1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
|
# frozen_string_literal: true
RSpec.shared_examples 'Debian packages GET request' do |status, body = nil|
and_body = body.nil? ? '' : ' and expected body'
it "returns #{status}#{and_body}" do
subject
expect(response).to have_gitlab_http_status(status)
unless body.nil?
expect(response.body).to match(body)
end
end
end
RSpec.shared_examples 'Debian packages upload request' do |status, body = nil|
and_body = body.nil? ? '' : ' and expected body'
if status == :created
it 'creates package files', :aggregate_failures do
expect(::Packages::Debian::CreatePackageFileService).to receive(:new).with(package: be_a(Packages::Package), current_user: be_an(User), params: be_an(Hash)).and_call_original
if extra_params[:distribution] || file_name.end_with?('.changes')
expect(::Packages::Debian::FindOrCreateIncomingService).not_to receive(:new)
expect(::Packages::Debian::ProcessPackageFileWorker).to receive(:perform_async).with(be_a(Integer), extra_params[:distribution], extra_params[:component])
expect { subject }
.to change { container.packages.debian.count }.by(1)
.and not_change { container.packages.debian.where(name: 'incoming').count }
.and change { container.package_files.count }.by(1)
else
expect(::Packages::Debian::FindOrCreateIncomingService).to receive(:new).with(container, user).and_call_original
expect(::Packages::Debian::ProcessPackageFileWorker).not_to receive(:perform_async)
expect { subject }
.to change { container.packages.debian.count }.by(1)
.and change { container.packages.debian.where(name: 'incoming').count }.by(1)
.and change { container.package_files.count }.by(1)
end
expect(response).to have_gitlab_http_status(status)
expect(response.media_type).to eq('text/plain')
unless body.nil?
expect(response.body).to match(body)
end
end
else
it "returns #{status}#{and_body}", :aggregate_failures do
subject
expect(response).to have_gitlab_http_status(status)
unless body.nil?
expect(response.body).to match(body)
end
end
end
end
RSpec.shared_examples 'Debian packages upload authorize request' do |status, body = nil|
and_body = body.nil? ? '' : ' and expected body'
if status == :created
it 'authorizes package file upload', :aggregate_failures do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(response.media_type).to eq(Gitlab::Workhorse::INTERNAL_API_CONTENT_TYPE)
expect(json_response['TempPath']).to eq(Packages::PackageFileUploader.workhorse_local_upload_path)
expect(json_response['RemoteObject']).to be_nil
expect(json_response['MaximumSize']).to be_nil
end
context 'without a valid token' do
let(:workhorse_token) { 'invalid' }
it 'rejects request' do
subject
expect(response).to have_gitlab_http_status(:forbidden)
end
end
context 'bypassing gitlab-workhorse' do
let(:workhorse_headers) { {} }
it 'rejects request' do
subject
expect(response).to have_gitlab_http_status(:forbidden)
end
end
else
it "returns #{status}#{and_body}", :aggregate_failures do
subject
expect(response).to have_gitlab_http_status(status)
unless body.nil?
expect(response.body).to match(body)
end
end
end
end
RSpec.shared_examples 'Debian packages read endpoint' do |desired_behavior, success_status, success_body|
context 'with valid container' do
using RSpec::Parameterized::TableSyntax
where(:visibility_level, :user_type, :auth_method, :expected_status, :expected_body) do
:public | :guest | :basic | success_status | success_body
:public | :not_a_member | :basic | success_status | success_body
:public | :anonymous | :basic | success_status | success_body
:public | :invalid_token | :basic | :unauthorized | nil
:private | :developer | :basic | success_status | success_body
:private | :developer | :private_token | :unauthorized | nil
:private | :guest | :basic | :forbidden | nil
:private | :not_a_member | :basic | :not_found | nil
:private | :anonymous | :basic | :unauthorized | nil
:private | :invalid_token | :basic | :unauthorized | nil
end
with_them do
include_context 'Debian repository access', params[:visibility_level], params[:user_type], params[:auth_method] do
it_behaves_like "Debian packages #{desired_behavior} request", params[:expected_status], params[:expected_body]
end
end
end
it_behaves_like 'rejects Debian access with unknown container id', :unauthorized, :basic
end
RSpec.shared_examples 'Debian packages write endpoint' do |desired_behavior, success_status, success_body|
context 'with valid container' do
using RSpec::Parameterized::TableSyntax
where(:visibility_level, :user_type, :auth_method, :expected_status, :expected_body) do
:public | :developer | :basic | success_status | success_body
:public | :developer | :private_token | :unauthorized | nil
:public | :guest | :basic | :forbidden | nil
:public | :not_a_member | :basic | :forbidden | nil
:public | :anonymous | :basic | :unauthorized | nil
:public | :invalid_token | :basic | :unauthorized | nil
:private | :developer | :basic | success_status | success_body
:private | :guest | :basic | :forbidden | nil
:private | :not_a_member | :basic | :not_found | nil
:private | :anonymous | :basic | :unauthorized | nil
:private | :invalid_token | :basic | :unauthorized | nil
end
with_them do
include_context 'Debian repository access', params[:visibility_level], params[:user_type], params[:auth_method] do
it_behaves_like "Debian packages #{desired_behavior} request", params[:expected_status], params[:expected_body]
end
end
end
it_behaves_like 'rejects Debian access with unknown container id', :unauthorized, :basic
end
RSpec.shared_examples 'Debian packages endpoint catching ObjectStorage::RemoteStoreError' do
include_context 'Debian repository access', :public, :developer, :basic do
it "returns forbidden" do
expect(::Packages::Debian::CreatePackageFileService).to receive(:new).and_raise ObjectStorage::RemoteStoreError
subject
expect(response).to have_gitlab_http_status(:forbidden)
end
end
end
RSpec.shared_examples 'Debian packages index endpoint' do |success_body|
it_behaves_like 'Debian packages read endpoint', 'GET', :success, success_body
context 'when no ComponentFile is found' do
let(:target_component_name) { component.name + FFaker::Lorem.word }
it_behaves_like 'Debian packages read endpoint', 'GET', :no_content, /^$/
end
end
RSpec.shared_examples 'Debian packages index sha256 endpoint' do |success_body|
it_behaves_like 'Debian packages read endpoint', 'GET', :success, success_body
context 'with empty checksum' do
let(:target_sha256) { 'e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855' }
it_behaves_like 'Debian packages read endpoint', 'GET', :no_content, /^$/
end
context 'when ComponentFile is not found' do
let(:target_component_name) { component.name + FFaker::Lorem.word }
it_behaves_like 'Debian packages read endpoint', 'GET', :not_found, /^{"message":"404 Not Found"}$/
end
end
|
