1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010
|
# frozen_string_literal: true
RSpec.shared_examples 'web-hook API endpoints test hook' do |prefix|
describe "POST #{prefix}/:hook_id", :aggregate_failures do
it 'tests the hook' do
expect(WebHookService)
.to receive(:new).with(hook, anything, String, force: false)
.and_return(instance_double(WebHookService, execute: nil))
post api(hook_uri, user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:created)
end
end
end
RSpec.shared_examples 'POST webhook API endpoints with a branch filter' do |prefix|
before do
post api(collection_uri, user, admin_mode: user.admin?), params: params.merge(url: "http://example.com")
end
describe "POST #{prefix}/hooks" do
context "when setting push_events_branch_filter" do
let(:params) { { push_events_branch_filter: 'some-wildcard' } }
it "returns created response" do
expect(response).to have_gitlab_http_status(:created)
expect(json_response).to a_hash_including('push_events_branch_filter' => 'some-wildcard',
'branch_filter_strategy' => 'wildcard')
end
end
context "when setting push_events_branch_filter with branch_filter_strategy regex" do
let(:params) { { push_events_branch_filter: 'some-regex', 'branch_filter_strategy' => 'regex' } }
it "returns created response" do
expect(response).to have_gitlab_http_status(:created)
expect(json_response).to a_hash_including('push_events_branch_filter' => 'some-regex',
'branch_filter_strategy' => 'regex')
end
end
context "when setting push_events_branch_filter to ^regex with branch_filter_strategy regex" do
let(:params) { { push_events_branch_filter: '^regex', 'branch_filter_strategy' => 'regex' } }
it "returns created response" do
expect(response).to have_gitlab_http_status(:created)
expect(json_response).to a_hash_including('push_events_branch_filter' => '^regex',
'branch_filter_strategy' => 'regex')
end
end
it_behaves_like 'POST/PUT webhook API endpoints with a branch filter'
end
end
RSpec.shared_examples 'PUT webhook API endpoints with a branch filter' do |prefix|
before do
put api(hook_uri, user, admin_mode: user.admin?), params: params.merge(url: "http://example.com")
end
describe "PUT #{prefix}/hooks" do
context "when setting push_events_branch_filter with branch_filter_strategy regex" do
let(:params) { { push_events_branch_filter: 'some-regex', 'branch_filter_strategy' => 'regex' } }
it "returns ok" do
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to a_hash_including('push_events_branch_filter' => 'some-regex',
'branch_filter_strategy' => 'regex')
end
end
context "when setting push_events_branch_filter without branch_filter_strategy regex" do
let(:params) { { push_events_branch_filter: '^regex', branch_filter_strategy: 'regex' } }
it "returns ok" do
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to a_hash_including('push_events_branch_filter' => '^regex',
'branch_filter_strategy' => 'regex')
end
end
it_behaves_like 'POST/PUT webhook API endpoints with a branch filter'
end
end
RSpec.shared_examples 'POST/PUT webhook API endpoints with a branch filter' do
describe "POST/PUT hooks" do
context "when branch_filter_strategy is not valid" do
let(:params) { { push_events_branch_filter: '~badbranchname/', 'branch_filter_strategy' => 'bla' } }
it "returns a 400 error" do
expect(response).to have_gitlab_http_status(:bad_request)
end
end
context "when push_events_branch_filter is not valid" do
let(:params) { { push_events_branch_filter: '~badbranchname/' } }
it "returns a 422 error" do
expect(response).to have_gitlab_http_status(:unprocessable_entity)
end
end
end
end
RSpec.shared_examples 'web-hook API endpoints' do |prefix|
def hooks_count
scope.count
end
def hook_param_overrides
if defined?(super)
super
else
{ push_events_branch_filter: 'some-feature-branch' }
end
end
let(:hook_params) do
event_names.to_h { [_1, true] }.merge(hook_param_overrides).merge(
url: "http://example.com",
url_variables: [
{ key: 'token', value: 'very-secret' },
{ key: 'abc', value: 'other value' }
],
custom_headers: [
{ key: 'X-Custom-Header', value: 'custom value' },
{ key: 'abc', value: 'other value' }
]
)
end
let(:update_params) do
{
name: 'Updated name',
description: 'Updated description',
push_events: false,
job_events: true,
push_events_branch_filter: 'updated-branch-filter'
}
end
let(:default_values) { {} }
describe "GET #{prefix}/hooks", :aggregate_failures do
context "authorized user" do
it "returns all hooks" do
get api(collection_uri, user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:ok)
expect(response).to match_collection_schema
end
end
context "when user is forbidden" do
it "prevents access to hooks" do
get api(collection_uri, unauthorized_user, admin_mode: true)
expect(response).to have_gitlab_http_status(:forbidden)
end
end
context "when user is unauthorized" do
it "prevents access to hooks" do
get api(collection_uri, nil)
expect(response).to have_gitlab_http_status(:unauthorized)
end
end
context 'the hook has URL variables', if: prefix != '/projects/:id' do
before do
hook.update!(url_variables: { 'token' => 'supers3cret' })
end
it 'returns the names of the url variables' do
get api(collection_uri, user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to contain_exactly(
a_hash_including(
'url_variables' => [{ 'key' => 'token' }]
)
)
end
end
context 'the hook has custom headers', if: prefix != '/projects/:id' do
before do
hook.update!(custom_headers: { 'Custom-Header' => 'supers3cret' })
end
it 'returns the names of the custom headers' do
get api(collection_uri, user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to contain_exactly(
a_hash_including(
'custom_headers' => [{ 'key' => 'Custom-Header' }]
)
)
end
end
end
describe "GET #{prefix}/hooks/:hook_id", :aggregate_failures do
context "authorized user" do
it "returns a project hook" do
get api(hook_uri, user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:ok)
expect(response).to match_hook_schema
expect(json_response['url']).to eq(hook.url)
end
it "returns a 404 error if hook id is not available" do
get api(hook_uri(non_existing_record_id), user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:not_found)
end
context 'the hook is disabled' do
before do
hook.update!(recent_failures: hook.class::EXCEEDED_FAILURE_THRESHOLD)
end
it "has the correct alert status", :aggregate_failures do
get api(hook_uri, user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to include('alert_status' => 'disabled') unless hook.executable?
end
end
context 'the hook is backed-off' do
before do
WebHooks::AutoDisabling::FAILURE_THRESHOLD.times { hook.backoff! }
hook.backoff!
end
it "has the correct alert status", :aggregate_failures do
get api(hook_uri, user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:ok)
unless hook.executable?
expect(json_response).to include(
'alert_status' => 'temporarily_disabled',
'disabled_until' => hook.disabled_until.iso8601(3)
)
end
end
end
end
context "when user is forbidden" do
it "does not access an existing hook" do
get api(hook_uri, unauthorized_user, admin_mode: true)
expect(response).to have_gitlab_http_status(:forbidden)
end
end
context "when user is unauthorized" do
it "does not access an existing hook" do
get api(hook_uri, nil)
expect(response).to have_gitlab_http_status(:unauthorized)
end
end
end
describe "POST #{prefix}/hooks", :aggregate_failures do
let(:hook_creation_params) { hook_params }
it "adds hook", :aggregate_failures do
expect do
post api(collection_uri, user, admin_mode: user.admin?), params: hook_creation_params
end.to change { hooks_count }.by(1)
expect(response).to have_gitlab_http_status(:created)
expect(response).to match_hook_schema
expect(json_response['url']).to eq(hook_creation_params[:url])
hook_param_overrides.each do |k, v|
expect(json_response[k.to_s]).to eq(v)
end
event_names.each do |name|
expect(json_response[name.to_s]).to eq(true), name.to_s
end
expect(json_response['url_variables']).to match_array [
{ 'key' => 'token' },
{ 'key' => 'abc' }
]
expect(json_response['custom_headers']).to match_array [
{ 'key' => 'X-Custom-Header' },
{ 'key' => 'abc' }
]
expect(json_response).not_to include('token')
end
it "adds the token without including it in the response" do
token = "secret token"
expect do
post api(collection_uri, user, admin_mode: user.admin?), params: { url: "http://example.com", token: token }
end.to change { hooks_count }.by(1)
expect(response).to have_gitlab_http_status(:created)
expect(json_response["url"]).to eq("http://example.com")
expect(json_response).not_to include("token")
hook = scope.find(json_response["id"])
expect(hook.url).to eq("http://example.com")
expect(hook.token).to eq(token)
end
it "returns a 400 error if url not given" do
post api(collection_uri, user, admin_mode: user.admin?), params: { event_names.first => true }
expect(response).to have_gitlab_http_status(:bad_request)
end
it "returns a 400 error if no parameters are provided" do
post api(collection_uri, user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:bad_request)
end
it 'sets default values for events', :aggregate_failures do
post api(collection_uri, user, admin_mode: user.admin?), params: { url: 'http://mep.mep' }
expect(response).to have_gitlab_http_status(:created)
expect(response).to match_hook_schema
expect(json_response['enable_ssl_verification']).to be true
event_names.each do |name|
expect(json_response[name.to_s]).to eq(default_values.fetch(name, false)), name.to_s
end
end
it "returns a 422 error if token not valid" do
post api(collection_uri, user, admin_mode: user.admin?),
params: { url: "http://example.com", token: "foo\nbar" }
expect(response).to have_gitlab_http_status(:unprocessable_entity)
end
it "returns a 422 error if url not valid" do
post api(collection_uri, user, admin_mode: user.admin?), params: { url: "ftp://example.com" }
expect(response).to have_gitlab_http_status(:unprocessable_entity)
end
end
describe "PUT #{prefix}/hooks/:hook_id", :aggregate_failures do
it "updates an existing hook" do
put api(hook_uri, user, admin_mode: user.admin?), params: update_params
expect(response).to have_gitlab_http_status(:ok)
expect(response).to match_hook_schema
update_params.each do |k, v|
expect(json_response[k.to_s]).to eq(v)
end
end
it 'updates the URL variables' do
hook.update!(url_variables: { 'abc' => 'some value' })
put api(hook_uri, user, admin_mode: user.admin?),
params: { url_variables: [{ key: 'def', value: 'other value' }] }
expect(response).to have_gitlab_http_status(:ok)
expect(json_response['url_variables']).to match_array [
{ 'key' => 'abc' },
{ 'key' => 'def' }
]
end
it 'updates the custom headers' do
hook.update!(custom_headers: { 'abc' => 'some value' })
put api(hook_uri, user, admin_mode: user.admin?),
params: { custom_headers: [{ key: 'def', value: 'other value' }] }
expect(response).to have_gitlab_http_status(:ok)
expect(json_response['custom_headers']).to match_array [
{ 'key' => 'abc' },
{ 'key' => 'def' }
]
end
it "adds the token without including it in the response" do
token = "secret token"
put api(hook_uri, user, admin_mode: user.admin?), params: { url: "http://example.org", token: token }
expect(response).to have_gitlab_http_status(:ok)
expect(json_response["url"]).to eq("http://example.org")
expect(json_response).not_to include("token")
expect(hook.reload.url).to eq("http://example.org")
expect(hook.reload.token).to eq(token)
end
it "returns 404 error if hook id not found" do
put api(hook_uri(non_existing_record_id), user, admin_mode: user.admin?), params: { url: 'http://example.org' }
expect(response).to have_gitlab_http_status(:not_found)
end
it "returns 400 error if no parameters are provided" do
put api(hook_uri, user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:bad_request)
end
it "returns a 422 error if url is not valid" do
put api(hook_uri, user, admin_mode: user.admin?), params: { url: 'ftp://example.com' }
expect(response).to have_gitlab_http_status(:unprocessable_entity)
end
it "returns a 422 error if token is not valid" do
put api(hook_uri, user, admin_mode: user.admin?), params: { token: %w[foo bar].join("\n") }
expect(response).to have_gitlab_http_status(:unprocessable_entity)
end
end
describe "DELETE #{prefix}/hooks/:hook_id", :aggregate_failures do
it "deletes hook from project" do
expect do
delete api(hook_uri, user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:no_content)
end.to change { hooks_count }.by(-1)
end
it "returns a 404 error when deleting non existent hook" do
delete api(hook_uri(non_existing_record_id), user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:not_found)
end
it "returns a 404 error if hook id not given" do
delete api(collection_uri, user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:not_found)
end
it "returns forbidden if a user attempts to delete hooks they do not own" do
delete api(hook_uri, unauthorized_user, admin_mode: true)
expect(response).to have_gitlab_http_status(:forbidden)
expect(WebHook.exists?(hook.id)).to be_truthy
end
it_behaves_like '412 response' do
let(:request) { api(hook_uri, user, admin_mode: user.admin?) }
end
end
describe "PUT #{prefix}/hooks/:hook_id/url_variables/:key", :aggregate_failures do
it 'sets the variable' do
expect do
put api("#{hook_uri}/url_variables/abc", user, admin_mode: user.admin?),
params: { value: 'some secret value' }
end.to change { hook.reload.url_variables }.to(eq('abc' => 'some secret value'))
expect(response).to have_gitlab_http_status(:no_content)
end
it 'overwrites existing values' do
hook.update!(url_variables: { 'abc' => 'xyz', 'def' => 'other value' })
put api("#{hook_uri}/url_variables/abc", user, admin_mode: user.admin?),
params: { value: 'some secret value' }
expect(response).to have_gitlab_http_status(:no_content)
expect(hook.reload.url_variables).to eq('abc' => 'some secret value', 'def' => 'other value')
end
it "returns a 404 error when editing non existent hook" do
put api("#{hook_uri(non_existing_record_id)}/url_variables/abc", user, admin_mode: user.admin?),
params: { value: 'xyz' }
expect(response).to have_gitlab_http_status(:not_found)
end
it "returns a 422 error when the key is illegal" do
put api("#{hook_uri}/url_variables/abc%20def", user, admin_mode: user.admin?),
params: { value: 'xyz' }
expect(response).to have_gitlab_http_status(:unprocessable_entity)
end
it "returns a 422 error when the value is illegal" do
put api("#{hook_uri}/url_variables/abc", user, admin_mode: user.admin?),
params: { value: '' }
expect(response).to have_gitlab_http_status(:unprocessable_entity)
end
end
describe "DELETE #{prefix}/hooks/:hook_id/url_variables/:key", :aggregate_failures do
before do
hook.update!(url_variables: { 'abc' => 'prior value', 'def' => 'other value' })
end
it 'unsets the variable' do
expect do
delete api("#{hook_uri}/url_variables/abc", user, admin_mode: user.admin?)
end.to change { hook.reload.url_variables }.to(eq({ 'def' => 'other value' }))
expect(response).to have_gitlab_http_status(:no_content)
end
it 'returns 404 for keys that do not exist' do
hook.update!(url_variables: { 'def' => 'other value' })
delete api("#{hook_uri}/url_variables/abc", user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:not_found)
end
it "returns a 404 error when deleting a variable from a non existent hook" do
delete api(hook_uri(non_existing_record_id) + "/url_variables/abc", user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:not_found)
end
end
describe "PUT #{prefix}/hooks/:hook_id/custom_headers/:key", :aggregate_failures do
it 'sets the custom header' do
expect do
put api("#{hook_uri}/custom_headers/abc", user, admin_mode: user.admin?),
params: { value: 'some secret value' }
end.to change { hook.reload.custom_headers }.to(eq('abc' => 'some secret value'))
expect(response).to have_gitlab_http_status(:no_content)
end
it 'overwrites existing values' do
hook.update!(custom_headers: { 'abc' => 'xyz', 'def' => 'other value' })
put api("#{hook_uri}/custom_headers/abc", user, admin_mode: user.admin?),
params: { value: 'some secret value' }
expect(response).to have_gitlab_http_status(:no_content)
expect(hook.reload.custom_headers).to eq('abc' => 'some secret value', 'def' => 'other value')
end
it "returns a 404 error when editing non existent hook" do
put api("#{hook_uri(non_existing_record_id)}/custom_headers/abc", user, admin_mode: user.admin?),
params: { value: 'xyz' }
expect(response).to have_gitlab_http_status(:not_found)
end
it "returns a 422 error when the key is illegal" do
put api("#{hook_uri}/custom_headers/abc%20def", user, admin_mode: user.admin?),
params: { value: 'xyz' }
expect(response).to have_gitlab_http_status(:unprocessable_entity)
end
it "returns a 422 error when the value is illegal" do
put api("#{hook_uri}/custom_headers/abc", user, admin_mode: user.admin?),
params: { value: '' }
expect(response).to have_gitlab_http_status(:unprocessable_entity)
end
end
describe "DELETE #{prefix}/hooks/:hook_id/custom_headers/:key", :aggregate_failures do
before do
hook.update!(custom_headers: { 'abc' => 'prior value', 'def' => 'other value' })
end
it 'unsets the custom header' do
expect do
delete api("#{hook_uri}/custom_headers/abc", user, admin_mode: user.admin?)
end.to change { hook.reload.custom_headers }.to(eq({ 'def' => 'other value' }))
expect(response).to have_gitlab_http_status(:no_content)
end
it 'returns 404 for keys that do not exist' do
hook.update!(custom_headers: { 'def' => 'other value' })
delete api("#{hook_uri}/custom_headers/abc", user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:not_found)
end
it "returns a 404 error when deleting a custom header from a non existent hook" do
delete api(hook_uri(non_existing_record_id) + "/custom_headers/abc", user, admin_mode: user.admin?)
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
RSpec.shared_examples 'test web-hook endpoint' do
include StubRequests
context "when trigger webhook test", :aggregate_failures, :clean_gitlab_redis_rate_limiting do
before do
stub_full_request(hook.url, method: :post).to_return(status: 200)
end
it_behaves_like 'rate limited endpoint', rate_limit_key: :web_hook_test do
let(:current_user) { user }
def request
post api("#{hook_uri}/test/push_events", user), params: {}
end
context 'when ops flag is disabled' do
before do
stub_feature_flags(web_hook_test_api_endpoint_rate_limit: false)
end
it 'does not block the request' do
request
expect(response).to have_gitlab_http_status(:created)
end
end
end
context 'when testing is not available for trigger' do
where(:trigger_name) do
%w[confidential_note_events deployment_events feature_flag_events]
end
with_them do
it 'returns error message that testing is not available' do
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response['message']).to eq('Testing not available for this hook')
end
end
end
context 'when push_events' do
where(:trigger_name) do
[
["push_events"],
["tag_push_events"]
]
end
with_them do
it 'executes hook' do
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:created)
end
end
end
context 'when issue_events' do
where(:trigger_name) do
%w[issues_events confidential_issues_events]
end
with_them do
it 'executes hook' do
create(:issue, project: project)
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:created)
end
it 'returns error message if not enough data' do
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response['message']).to eq('Ensure the project has issues.')
end
end
end
context 'when note_events' do
where(:trigger_name) do
[
["note_events"],
["emoji_events"]
]
end
with_them do
it 'executes hook' do
create(:note, :on_issue, project: project)
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:created)
end
it 'returns error message if not enough data' do
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response['message']).to eq('Ensure the project has notes.')
end
end
end
context 'when merge_request_events' do
let(:trigger_name) { 'merge_requests_events' }
it 'executes hook' do
create(:merge_request, source_project: project, target_project: project)
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:created)
end
it 'returns error message if not enough data' do
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response['message']).to eq('Ensure the project has merge requests.')
end
end
context 'when job_events' do
let(:trigger_name) { 'job_events' }
it 'executes hook' do
create(:ci_build, project: project, name: 'build')
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:created)
end
it 'returns error message if not enough data' do
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response['message']).to eq('Ensure the project has CI jobs.')
end
end
context 'when pipeline_events' do
let(:trigger_name) { 'pipeline_events' }
it 'executes hook' do
create(:ci_pipeline, project: project, user: user)
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:created)
end
it 'returns error message if not enough data' do
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response['message']).to eq('Ensure the project has CI pipelines.')
end
end
context 'when wiki_page_events' do
let(:trigger_name) { 'wiki_page_events' }
it 'executes hook' do
create(:wiki_page, wiki: project.wiki)
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:created)
end
it 'returns error message if wiki is not enabled' do
project.project_feature.update!(wiki_access_level: ProjectFeature::DISABLED)
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response['message']).to eq('Ensure the wiki is enabled and has pages.')
end
end
context 'when release_events' do
let(:trigger_name) { 'releases_events' }
it 'executes hook' do
create(:release, project: project)
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:created)
end
it 'returns error message if not enough data' do
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response['message']).to eq('Ensure the project has releases.')
end
end
context 'when resource_access_token_events' do
let(:trigger_name) { 'resource_access_token_events' }
it 'executes hook' do
post api("#{hook_uri}/test/#{trigger_name}", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:created)
end
end
it "returns a 400 error when trigger is invalid" do
post api("#{hook_uri}/test/xyz", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:bad_request)
expect(json_response['error']).to eq('trigger does not have a valid value')
end
it "returns a 422 error when request trigger test is not successful" do
stub_full_request(hook.url, method: :post).to_return(status: 400, body: 'Error response')
post api("#{hook_uri}/test/push_events", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response['message']).to eq('Error response')
end
end
end
RSpec.shared_examples 'resend web-hook event endpoint' do
include StubRequests
before do
stub_full_request(hook.url, method: :post).to_return(status: 200)
end
let_it_be(:log) { create(:web_hook_log, web_hook: hook, response_status: '404') }
it_behaves_like 'rate limited endpoint', rate_limit_key: :web_hook_event_resend do
let(:current_user) { user }
def request
post api("#{hook_uri}/events/#{log.id}/resend", current_user, admin_mode: current_user.admin?), params: {}
end
context 'when ops flag is disabled' do
before do
stub_feature_flags(web_hook_event_resend_api_endpoint_rate_limit: false)
end
it 'does not block the request' do
request
expect(response).to have_gitlab_http_status(:created)
end
end
end
it 'successfully posts a hook' do
post api("#{hook_uri}/events/#{log.id}/resend", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:created)
expect(json_response['response_status']).to eq(200)
end
it "returns a 404 error when web hook log not found" do
post api("#{hook_uri}/events/#{non_existing_record_id}/resend", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:not_found)
end
it "return 403 when current user is not authorized" do
post api("#{hook_uri}/events/#{log.id}/resend", unauthorized_user, admin_mode: false), params: {}
expect(response).to have_gitlab_http_status(:forbidden)
end
context 'when hook URL has changed' do
let_it_be(:log) { create(:web_hook_log, web_hook: hook, response_status: '404', url_hash: 'new_hash') }
it "returns 422" do
post api("#{hook_uri}/events/#{log.id}/resend", user, admin_mode: user.admin?), params: {}
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response['message']).to eq('The hook URL has changed, and this log entry cannot be retried')
end
end
end
RSpec.shared_examples 'get web-hook event endpoint' do
describe 'hooks events' do
let_it_be(:log_200) { create(:web_hook_log, web_hook: hook) }
let_it_be(:log_400) { create(:web_hook_log, web_hook: hook, response_status: '400') }
let_it_be(:log_404) { create(:web_hook_log, web_hook: hook, response_status: '404') }
let_it_be(:log_500) { create(:web_hook_log, web_hook: hook, response_status: '500') }
let_it_be(:log_502) { create(:web_hook_log, web_hook: hook, response_status: '502') }
let_it_be(:log_internal_error) { create(:web_hook_log, web_hook: hook, response_status: 'internal error') }
let(:path) { "#{hook_uri}/events" }
let(:recent_logs) { [log_200, log_400, log_404, log_500, log_502, log_internal_error] }
describe "authorize user" do
it 'returns an array of web hook logs for the past 7 days' do
create(:web_hook_log, web_hook: hook, created_at: 8.days.ago)
get api(path, user)
expect(response).to have_gitlab_http_status(:ok)
expect(response).to include_pagination_headers
expect(json_response).to be_an Array
expect(json_response.pluck('id')).to contain_exactly(*recent_logs.map(&:id))
end
it 'returns 404 when web hook not found' do
get api("/projects/#{project.id}/hooks/#{non_existing_record_id}", user)
expect(response).to have_gitlab_http_status(:not_found)
expect(json_response['message']).to eq('404 Not found')
end
describe 'pagination' do
it 'returns the correct page' do
page = 2
get api(path, user), params: { page: page, per_page: 2 }
expect(response.headers['X-Page']).to eq(page.to_s)
end
it 'returns the correct page size' do
get api(path, user), params: { page: 1, per_page: 2 }
expect(json_response.length).to eq 2
end
it 'returns invalid value if per_page exceed 20' do
get api(path, user), params: { page: 2, per_page: 21 }
expect(response).to have_gitlab_http_status(:bad_request)
expect(json_response['error']).to eq('per_page does not have a valid value')
end
end
describe 'filter by status' do
it 'can filter by response_status number' do
get api("#{path}?status=400", user)
expect(response).to have_gitlab_http_status(:ok)
expect(response).to include_pagination_headers
expect(json_response).to be_an Array
expect(json_response.pluck('id')).to contain_exactly(log_400.id)
end
describe 'filter by status string' do
it 'can filter by status client_failure' do
get api("#{path}?status=client_failure", user)
expect(json_response.pluck('id')).to contain_exactly(*[log_400, log_404].map(&:id))
end
it 'can filter by status server_failure' do
get api("#{path}?status=server_failure", user)
expect(json_response.pluck('id')).to contain_exactly(*[log_500, log_502, log_internal_error].map(&:id))
end
it 'can filter by status successful' do
get api("#{path}?status=successful", user)
expect(json_response.pluck('id')).to contain_exactly(*[log_200].map(&:id))
end
it 'can filter by multiple status' do
get api("#{path}?status=successful,server_failure", user)
expect(json_response.pluck('id')).to contain_exactly(*[log_200, log_500, log_502,
log_internal_error].map(&:id))
end
it 'return 400 when invalid status' do
get api("#{path}?status=invalid", user)
expect(response).to have_gitlab_http_status(:bad_request)
expect(json_response['error']).to eq('status does not have a valid value')
end
end
end
end
describe "unauthorized user" do
it 'returns 403' do
get api(path, unauthorized_user, admin_mode: false)
expect(response).to have_gitlab_http_status(:forbidden)
end
end
describe "when user is not authenticated" do
it 'returns 401' do
get api(path)
expect(response).to have_gitlab_http_status(:unauthorized)
end
end
end
end
|