1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Database::DuplicateIndexes, feature_category: :database do
index_class = ActiveRecord::ConnectionAdapters::IndexDefinition
let(:default_index_options) do
options = { using: :btree, orders: {}, unique: false, opclasses: {}, where: nil }
options[:include] = [] if ::Gitlab.next_rails?
options
end
let(:table_name) { 'foobar' }
let(:index1) { instance_double(index_class, default_index_options.merge(name: 'index1', columns: %w[user_id])) }
let(:index1_copy) { instance_double(index_class, default_index_options.merge(name: 'index1b', columns: %w[user_id])) }
let(:index2) { instance_double(index_class, default_index_options.merge(name: 'index2', columns: %w[project_id])) }
let(:index3) do
instance_double(index_class, default_index_options.merge(name: 'index3', columns: %w[user_id project_id]))
end
let(:index3_inverse) do
instance_double(index_class, default_index_options.merge(name: 'index3_inverse', columns: %w[project_id user_id]))
end
let(:index1_unique) do
instance_double(index_class, default_index_options.merge(name: 'index1_unique', columns: %w[user_id], unique: true))
end
let(:index1_desc) do
instance_double(
index_class,
default_index_options.merge(name: 'index1', columns: %w[user_id], orders: { user_id: 'desc' })
)
end
let(:index3_with_where) do
instance_double(
index_class,
default_index_options.merge(name: 'index3_with_where', columns: %w[user_id project_id], where: "id > 100")
)
end
subject(:duplicate_indexes) do
described_class.new(table_name, indexes).duplicate_indexes
end
context 'when there are no duplicate indexes' do
let(:indexes) { [index1, index2] }
it { expect(duplicate_indexes).to be_empty }
end
context 'when overlapping indexes' do
let(:indexes) { [index1, index3] }
it 'detects a duplicate index between index1 and index3' do
expected_duplicate_indexes = { index_struct(index3) => [index_struct(index1)] }
expect(duplicate_indexes).to eq(expected_duplicate_indexes)
end
end
context 'when the indexes have the inverse order of columns' do
let(:indexes) { [index3, index3_inverse] }
it 'does not detect duplicate indexes between index3 and index3_inverse' do
expect(duplicate_indexes).to eq({})
end
end
# For now we ignore other indexes that are UNIQUE and have a matching columns subset of
# the btree_index columns, as UNIQUE indexes are still needed to enforce uniqueness
# constraints on subset of the columns.
context 'when the index with matching sub-columns is unique' do
let(:indexes) { [index3, index1_unique] }
it 'does not detect duplicate indexes between index3 and index1_unique' do
expect(duplicate_indexes).to eq({})
end
end
context 'when the one of the indexes is a conditional index' do
let(:indexes) { [index3, index3_with_where] }
it 'does not detect duplicate indexes between index3 and index3_with_where' do
expect(duplicate_indexes).to eq({})
end
end
context 'when identical indexes' do
let(:indexes) { [index1, index1_copy] }
it 'detects a duplicate index between index1 and index3' do
expected_duplicate_indexes = {
index_struct(index1) => [index_struct(index1_copy)],
index_struct(index1_copy) => [index_struct(index1)]
}
expect(duplicate_indexes).to eq(expected_duplicate_indexes)
end
end
context 'when indexes have the same columns but with different order' do
let(:indexes) { [index1, index1_desc] }
it { expect(duplicate_indexes).to be_empty }
end
def index_struct(index)
Database::DuplicateIndexes.btree_index_struct(index)
end
end
|
