1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
|
# frozen_string_literal: true
require 'fast_spec_helper'
require 'rspec-parameterized'
require 'gitlab/dangerfiles/spec_helper'
require_relative '../../../tooling/danger/datateam'
RSpec.describe Tooling::Danger::Datateam do
include_context "with dangerfile"
let(:fake_danger) { DangerSpecHelper.fake_danger.include(described_class) }
let(:datateam) { fake_danger.new(helper: fake_helper) }
describe 'data team danger' do
using RSpec::Parameterized::TableSyntax
where do
{
'with structure.sql subtraction changes and no Data Warehouse::Impact Check label' => {
modified_files: %w[db/structure.sql app/models/user.rb],
changed_lines: ['-group_id bigint NOT NULL'],
mr_labels: [],
impacted: true,
impacted_files: %w[db/structure.sql]
},
'with structure.sql subtraction changes and Data Warehouse::Impact Check label' => {
modified_files: %w[db/structure.sql],
changed_lines: ['-group_id bigint NOT NULL)'],
mr_labels: ['Data Warehouse::Impact Check'],
impacted: false,
impacted_files: %w[db/structure.sql]
},
'with structure.sql addition changes and no Data Warehouse::Impact Check label' => {
modified_files: %w[db/structure.sql app/models/user.rb],
changed_lines: ['+group_id bigint NOT NULL'],
mr_labels: [],
impacted: false,
impacted_files: %w[db/structure.sql]
},
'with user model changes' => {
modified_files: %w[app/models/users.rb],
changed_lines: ['+has_one :namespace'],
mr_labels: [],
impacted: false,
impacted_files: []
},
'with perfomance indicator changes and no Data Warehouse::Impact Check label' => {
modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb],
changed_lines: ['+-gmau'],
mr_labels: [],
impacted: true,
impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml]
},
'with perfomance indicator changes and Data Warehouse::Impact Check label' => {
modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml],
changed_lines: ['+-gmau'],
mr_labels: ['Data Warehouse::Impact Check'],
impacted: false,
impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml]
},
'with metric file changes and no performance indicator changes' => {
modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml],
changed_lines: ['-product_group: activation'],
mr_labels: [],
impacted: false,
impacted_files: []
},
'with metric file changes and no performance indicator changes and other label' => {
modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml],
changed_lines: ['-product_group: activation'],
mr_labels: ['type::maintenance'],
impacted: false,
impacted_files: []
},
'with performance indicator changes and other label' => {
modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb],
changed_lines: ['+-gmau'],
mr_labels: ['type::maintenance'],
impacted: true,
impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml]
},
'with performance indicator changes, Data Warehouse::Impact Check and other label' => {
modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb],
changed_lines: ['+-gmau'],
mr_labels: ['type::maintenance', 'Data Warehouse::Impact Check'],
impacted: false,
impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml]
},
'with performance indicator changes and other labels' => {
modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb],
changed_lines: ['+-gmau'],
mr_labels: ['type::maintenance', 'Data Warehouse::Impacted'],
impacted: false,
impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml]
},
'with metric status removed' => {
modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb],
changed_lines: ['+status: removed'],
mr_labels: ['type::maintenance'],
impacted: true,
impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml]
},
'with metric status active' => {
modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb],
changed_lines: ['+status: active'],
mr_labels: ['type::maintenance'],
impacted: false,
impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml]
},
'with database metric files added' => {
added_files: %w[config/metrics/20210216182127_users_all.yml],
changed_lines: ['+data_source: database'],
mr_labels: ['type::maintenance'],
impacted: true,
impacted_files: %w[config/metrics/20210216182127_users_all.yml]
},
'with non-database metric files added' => {
added_files: %w[config/metrics/20210216182127_users_all.yml],
changed_lines: ['+data_source: internal_events'],
mr_labels: ['type::maintenance'],
impacted: false,
impacted_files: %w[config/metrics/20210216182127_users_all.yml]
}
}
end
with_them do
before do
allow(fake_helper).to receive(:modified_files).and_return(modified_files || [])
allow(fake_helper).to receive(:added_files).and_return(added_files || [])
allow(fake_helper).to receive(:changed_lines).and_return(changed_lines)
allow(fake_helper).to receive(:mr_labels).and_return(mr_labels)
allow(fake_helper).to receive(:markdown_list).with(impacted_files).and_return(impacted_files.map { |item| "* `#{item}`" }.join("\n"))
end
it :aggregate_failures do
expect(datateam.impacted?).to be(impacted)
expect(datateam.build_message).to match_expected_message
end
end
end
def match_expected_message
return be_nil unless impacted
start_with(described_class::CHANGED_SCHEMA_MESSAGE).and(include(*impacted_files))
end
end
|
