1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe PostReceive, :clean_gitlab_redis_shared_state, feature_category: :source_code_management do
include AfterNextHelpers
let(:changes) do
<<~EOF
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/tags/tag
EOF
end
let(:wrongly_encoded_changes) { changes.encode("ISO-8859-1").force_encoding("UTF-8") }
let(:base64_changes) { Base64.encode64(wrongly_encoded_changes) }
let(:gl_repository) { "project-#{project.id}" }
let(:key) { create(:key, user: project.first_owner) }
let!(:key_id) { key.shell_id }
let(:project) do
create(:project, :repository, auto_cancel_pending_pipelines: 'disabled')
end
let(:job_args) { [gl_repository, key_id, base64_changes] }
let(:worker) { described_class.new }
def perform(changes: base64_changes)
worker.perform(gl_repository, key_id, changes)
end
context 'as a sidekiq worker' do
it 'responds to #perform' do
expect(described_class.new).to respond_to(:perform)
end
end
context 'with a non-existing project' do
let(:gl_repository) { "project-123456789" }
let(:error_message) do
"Triggered hook for non-existing gl_repository \"#{gl_repository}\""
end
it 'returns false and logs an error' do
expect(Gitlab::GitLogger).to receive(:error).with("POST-RECEIVE: #{error_message}")
expect(perform).to be(false)
end
context 'with PersonalSnippet' do
let(:gl_repository) { "snippet-#{snippet.id}" }
let(:snippet) { create(:personal_snippet, author: project.first_owner) }
it 'does not log an error' do
expect(Gitlab::GitLogger).not_to receive(:error)
expect(Gitlab::GitPostReceive).to receive(:new).and_call_original
expect_next(described_class).to receive(:process_snippet_changes)
perform
end
end
end
describe '#process_project_changes' do
context 'with an empty project' do
let(:empty_project) { create(:project, :empty_repo) }
before do
allow_next(Gitlab::GitPostReceive).to receive(:identify).and_return(empty_project.first_owner)
# Need to mock here so we can expect calls on project
allow(Gitlab::GlRepository).to receive(:parse).and_return([empty_project, empty_project, Gitlab::GlRepository::PROJECT])
end
it 'expire the status cache' do
expect(empty_project.repository).to receive(:expire_status_cache)
perform
end
it 'schedules a cache update for commit count and size' do
expect(ProjectCacheWorker).to receive(:perform_async)
.with(empty_project.id, [], [:repository_size, :commit_count], true)
perform
end
end
shared_examples 'not updating remote mirrors' do
it 'does not schedule an update' do
expect(project).not_to receive(:has_remote_mirror?)
expect(project).not_to receive(:mark_stuck_remote_mirrors_as_failed!)
expect(project).not_to receive(:update_remote_mirrors)
perform
end
end
context 'empty changes' do
it 'does not call any PushService but runs after project hooks' do
expect(Git::ProcessRefChangesService).not_to receive(:new)
expect_next(SystemHooksService).to receive(:execute_hooks)
perform(changes: "")
end
it_behaves_like 'not updating remote mirrors'
end
context 'unidentified user' do
let!(:key_id) { "" }
it 'returns false' do
expect(Git::ProcessRefChangesService).not_to receive(:new)
expect(perform).to be false
end
end
context 'when identifier is for a deploy key' do
let(:deploy_key) { create(:deploy_key, user: project.first_owner) }
let!(:key_id) { deploy_key.shell_id }
it 'calls Git::ProcessRefChangesService' do
expect(Git::ProcessRefChangesService).to receive(:new).with(project, project.first_owner, kind_of(Hash)).and_call_original
perform
end
end
context 'with changes' do
let(:push_service) { double(execute: true) }
before do
allow_next(Gitlab::GitPostReceive).to receive(:identify).and_return(project.first_owner)
allow(Gitlab::GlRepository).to receive(:parse).and_return([project, project, Gitlab::GlRepository::PROJECT])
end
shared_examples 'updating remote mirrors' do
it 'schedules an update if the project had mirrors' do
expect(project).to receive(:has_remote_mirror?).and_return(true)
expect(project).to receive(:mark_stuck_remote_mirrors_as_failed!)
expect(project).to receive(:update_remote_mirrors)
perform
end
end
context 'branches' do
let(:changes) do
<<~EOF
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést1
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést2
EOF
end
it 'expires the branches cache' do
expect(project.repository).to receive(:expire_branches_cache).once
perform
end
it 'expires the status cache' do
expect(project.repository).to receive(:empty?).at_least(:once).and_return(true)
expect(project.repository).to receive(:expire_status_cache)
perform
end
it 'calls Git::ProcessRefChangesService' do
expect_next(Git::ProcessRefChangesService).to receive(:execute).and_return(true)
perform
end
it 'schedules a cache update for repository size only' do
expect(ProjectCacheWorker).to receive(:perform_async)
.with(project.id, [], [:repository_size], true)
perform
end
it_behaves_like 'updating remote mirrors'
context 'with a default branch' do
let(:changes) do
<<~EOF
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést1
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést2
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/#{project.default_branch}
EOF
end
it 'schedules a cache update for commit count and size' do
expect(ProjectCacheWorker).to receive(:perform_async)
.with(project.id, [], [:repository_size, :commit_count], true)
perform
end
end
end
context 'tags' do
let(:changes) do
<<~EOF
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/tags/tag1
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/tags/tag2
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/tags/tag3
EOF
end
before do
expect(Gitlab::GlRepository).to receive(:parse).and_return([project, project, Gitlab::GlRepository::PROJECT])
end
it 'does not expire branches cache' do
expect(project.repository).not_to receive(:expire_branches_cache)
perform
end
it 'only invalidates tags once' do
expect(project.repository).to receive(:repository_event).exactly(3).times.with(:push_tag).and_call_original
expect(project.repository).to receive(:expire_caches_for_tags).once.and_call_original
expect(project.repository).to receive(:expire_tags_cache).once.and_call_original
perform
end
it 'calls Git::ProcessRefChangesService' do
expect(Git::ProcessRefChangesService).to get_executed
perform
end
it 'schedules a single ProjectCacheWorker update' do
expect(ProjectCacheWorker).to receive(:perform_async)
.with(project.id, [], [:repository_size], true)
perform
end
it_behaves_like 'updating remote mirrors'
end
context 'merge-requests' do
let(:changes) { "#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/merge-requests/123" }
it "does not call any of the services" do
expect(Git::ProcessRefChangesService).not_to receive(:new)
perform
end
it_behaves_like 'not updating remote mirrors'
end
context 'after project changes hooks' do
let(:fake_hook_data) { { event_name: 'repository_update' } }
before do
allow(Gitlab::DataBuilder::Repository).to receive(:update).and_return(fake_hook_data)
# silence hooks so we can isolate
allow_next(Key).to receive(:post_create_hook).and_return(true)
expect(Git::ProcessRefChangesService).to get_executed
end
it 'calls SystemHooksService' do
expect_next(SystemHooksService)
.to receive(:execute_hooks).with(fake_hook_data, :repository_update_hooks)
.and_return(true)
perform
end
it_behaves_like 'internal event tracking' do
let(:event) { 'source_code_pushed' }
let(:user) { project.first_owner }
subject(:perform_action) { perform }
end
end
end
it_behaves_like 'an idempotent worker'
end
describe '#process_wiki_changes' do
let(:gl_repository) { "wiki-#{project.id}" }
before do
# Need to mock here so we can expect calls on project
allow(Gitlab::GlRepository).to receive(:parse).and_return([project.wiki, project, Gitlab::GlRepository::WIKI])
end
it 'updates project activity' do
# Force Project#set_timestamps_for_create to initialize timestamps
project
# MySQL drops milliseconds in the timestamps, so advance at least
# a second to ensure we see changes.
travel_to(1.second.from_now) do
expect do
perform
project.reload
end.to change { project.last_activity_at }
.and change { project.last_repository_updated_at }
end
end
context 'master' do
let(:default_branch) { 'master' }
let(:oldrev) { SeedRepo::Commit::PARENT_ID }
let(:newrev) { SeedRepo::Commit::ID }
let(:changes) do
<<~EOF
#{oldrev} #{newrev} refs/heads/#{default_branch}
#{oldrev} #{newrev} refs/heads/tést2
EOF
end
let(:raw_repo) { double('RawRepo') }
it 'processes the changes on the master branch' do
expect_next(Git::WikiPushService).to receive(:execute)
perform
end
end
context 'branches' do
let(:changes) do
<<~EOF
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést1
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést2
EOF
end
before do
allow_next(Git::WikiPushService).to receive(:execute)
end
it 'expires the branches cache' do
expect(project.wiki.repository).to receive(:expire_branches_cache).once
perform
end
it 'expires the status cache' do
expect(project.wiki.repository).to receive(:empty?).and_return(true)
expect(project.wiki.repository).to receive(:expire_status_cache)
perform
end
end
it_behaves_like 'an idempotent worker'
end
context 'webhook' do
it 'fetches the correct project' do
expect(Project).to receive(:find_by).with({ id: project.id })
perform
end
it "does not run if the author is not in the project" do
allow_next(Gitlab::GitPostReceive).to receive(:identify_using_ssh_key).and_return(nil)
expect(project).not_to receive(:execute_hooks)
expect(perform).to be_falsey
end
it 'asks the project to trigger all hooks' do
create(:project_hook, push_events: true, tag_push_events: true, project: project)
create(:custom_issue_tracker_integration, push_events: true, merge_requests_events: false, project: project)
allow(Project).to receive(:find_by).and_return(project)
expect(project).to receive(:execute_hooks).twice
expect(project).to receive(:execute_integrations).twice
perform
end
it 'enqueues a UpdateMergeRequestsWorker job' do
allow(Project).to receive(:find_by).and_return(project)
expect_next(MergeRequests::PushedBranchesService).to receive(:execute).and_return(%w[tést])
expect(UpdateMergeRequestsWorker).to receive(:perform_async).with(project.id, project.first_owner.id, any_args)
perform
end
end
describe '#process_snippet_changes' do
let(:gl_repository) { "snippet-#{snippet.id}" }
before do
# Need to mock here so we can expect calls on project
allow(Gitlab::GlRepository).to receive(:parse).and_return([snippet, snippet.project, Gitlab::GlRepository::SNIPPET])
end
shared_examples 'snippet changes actions' do
context 'unidentified user' do
let!(:key_id) { '' }
it 'returns false' do
expect(perform).to be false
end
end
context 'with changes' do
context 'branches' do
let(:changes) do
<<~EOF
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést1
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést2
EOF
end
it 'expires the branches cache' do
expect(snippet.repository).to receive(:expire_branches_cache).once
perform
end
it 'expires the status cache' do
expect(snippet.repository).to receive(:empty?).at_least(:once).and_return(true)
expect(snippet.repository).to receive(:expire_status_cache)
perform
end
it 'updates the snippet model updated_at' do
expect(snippet).to receive(:touch)
perform
end
it 'updates snippet statistics' do
expect(Snippets::UpdateStatisticsService).to receive(:new).with(snippet).and_call_original
perform
end
context 'with post_receive_sync_refresh_cache feature flag enabled' do
it 'refreshes branch names cache in a lock' do
expect(worker).to receive(:in_lock).with("post_receive:#{gl_repository}:branch", ttl: 20, retries: 50, sleep_sec: 0.4).and_wrap_original do |method, *args, **_kwargs, &block|
expect(snippet.repository).to receive(:expire_branches_cache).and_call_original
expect(snippet.repository).to receive(:branch_names).and_call_original
method.call(*args, &block)
end
perform
end
context 'when exclusive lease fails' do
it 'logs a message' do
expect(worker).to receive(:in_lock).and_raise(Gitlab::ExclusiveLeaseHelpers::FailedToObtainLockError)
expect(snippet.repository).to receive(:expire_branches_cache).and_call_original
expect(Gitlab::GitLogger).to receive(:error).with("POST-RECEIVE: Failed to obtain lease for expiring branch name cache")
perform
end
end
end
context 'with post_receive_sync_refresh_cache feature flag disabled' do
before do
stub_feature_flags(post_receive_sync_refresh_cache: false)
end
it 'does not expire in a lock' do
expect(worker).not_to receive(:in_lock)
expect(snippet.repository).not_to receive(:tag_names)
perform
end
end
end
context 'tags' do
let(:changes) do
<<~EOF
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/tags/tag1
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/tags/tag2
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/tags/tag3
EOF
end
it 'does not expire branches cache' do
expect(snippet.repository).not_to receive(:expire_branches_cache)
perform
end
it 'only invalidates tags once' do
expect(snippet.repository).to receive(:expire_caches_for_tags).once.and_call_original
expect(snippet.repository).to receive(:expire_tags_cache).once.and_call_original
perform
end
context 'with post_receive_sync_refresh_cache feature flag enabled' do
it 'refreshes the tag names cache' do
expect(worker).to receive(:in_lock).with("post_receive:#{gl_repository}:tag", ttl: 20, retries: 50, sleep_sec: 0.4).and_wrap_original do |method, *args, **_kwargs, &block|
expect(snippet.repository).to receive(:expire_tags_cache).and_call_original
expect(snippet.repository).to receive(:tag_names).and_call_original
method.call(*args, &block)
end
perform
end
context 'when exclusive lease fails' do
it 'logs a message' do
expect(worker).to receive(:in_lock).and_raise(Gitlab::ExclusiveLeaseHelpers::FailedToObtainLockError)
expect(snippet.repository).to receive(:expire_tags_cache).and_call_original
expect(Gitlab::GitLogger).to receive(:error).with("POST-RECEIVE: Failed to obtain lease for expiring tag name cache")
perform
end
end
end
end
context 'with post_receive_sync_refresh_cache feature flag disabled' do
before do
stub_feature_flags(post_receive_sync_refresh_cache: false)
end
it 'does not expire tags cache in a lock' do
expect(worker).not_to receive(:in_lock)
expect(snippet.repository).not_to receive(:tag_names)
perform
end
end
end
it_behaves_like 'an idempotent worker'
end
context 'with PersonalSnippet' do
let!(:snippet) { create(:personal_snippet, :repository, author: project.first_owner) }
it_behaves_like 'snippet changes actions'
end
context 'with ProjectSnippet' do
let!(:snippet) { create(:project_snippet, :repository, project: project, author: project.first_owner) }
it_behaves_like 'snippet changes actions'
end
end
describe '#process_design_management_repository_changes' do
let(:gl_repository) { "design-#{project.design_management_repository.id}" }
before do
project.create_design_management_repository
project.design_management_repository.repository.create_if_not_exists
end
it 'does not log an error' do
expect(Gitlab::GitLogger).not_to receive(:error)
expect(Gitlab::GitPostReceive).to receive(:new).and_call_original
expect_next(described_class).to receive(:process_design_management_repository_changes)
perform
end
it 'expires cache' do
expect_next(described_class).to receive(:expire_caches).with(anything, project.design_management_repository.repository)
perform
end
it_behaves_like 'an idempotent worker'
end
end
|