1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
|
package git
import (
"context"
"errors"
"fmt"
"io"
"net"
"net/http/httptest"
"os"
"path/filepath"
"testing"
"time"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"google.golang.org/grpc"
"gitlab.com/gitlab-org/gitaly/v16/client"
"gitlab.com/gitlab-org/gitaly/v16/proto/go/gitalypb"
"gitlab.com/gitlab-org/gitlab/workhorse/internal/api"
"gitlab.com/gitlab-org/gitlab/workhorse/internal/testhelper"
)
var (
originalUploadPackTimeout = uploadPackTimeout
)
type waitReader struct {
t time.Duration
}
func (f *waitReader) Read(_ []byte) (int, error) {
time.Sleep(f.t)
return 0, io.EOF
}
type smartHTTPServiceServer struct {
gitalypb.UnimplementedSmartHTTPServiceServer
handler func(context.Context, *gitalypb.PostUploadPackWithSidechannelRequest) (*gitalypb.PostUploadPackWithSidechannelResponse, error)
}
func (srv *smartHTTPServiceServer) PostUploadPackWithSidechannel(ctx context.Context, req *gitalypb.PostUploadPackWithSidechannelRequest) (*gitalypb.PostUploadPackWithSidechannelResponse, error) {
return srv.handler(ctx, req)
}
func TestUploadPackTimesOut(t *testing.T) {
uploadPackTimeout = time.Millisecond
defer func() { uploadPackTimeout = originalUploadPackTimeout }()
addr := startSmartHTTPServer(t, &smartHTTPServiceServer{
handler: func(ctx context.Context, _ *gitalypb.PostUploadPackWithSidechannelRequest) (*gitalypb.PostUploadPackWithSidechannelResponse, error) {
conn, err := client.OpenServerSidechannel(ctx)
if err != nil {
return nil, err
}
defer conn.Close()
_, _ = io.Copy(io.Discard, conn)
return &gitalypb.PostUploadPackWithSidechannelResponse{}, nil
},
})
body := &waitReader{t: 10 * time.Millisecond}
w := httptest.NewRecorder()
r := httptest.NewRequest("GET", "/", body)
a := &api.Response{GitalyServer: api.GitalyServer{Address: addr}}
_, err := handleUploadPack(NewHTTPResponseWriter(w), r, a)
require.True(t, errors.Is(err, context.DeadlineExceeded))
}
func startSmartHTTPServer(t testing.TB, s gitalypb.SmartHTTPServiceServer) string {
t.Helper()
// Ideally, we'd just use t.TempDir(), which would then use either the value of
// `$TMPDIR` or alternatively "/tmp". But given that macOS sets `$TMPDIR` to a user specific
// temporary directory, resulting paths would be too long and thus cause issues galore. We
// thus support our own specific variable instead which allows users to override it, with
// our default being "/tmp".
// This fixes errors like this on macOS:
//
// listen unix /var/folders/xx/xx/T/xx/001/gitaly.sock: bind: invalid argument
tempDirLocation := os.Getenv("TEST_TMP_DIR")
if tempDirLocation == "" {
tempDirLocation = "/tmp"
}
tmp, err := os.MkdirTemp(tempDirLocation, "workhorse-")
require.NoError(t, err)
t.Cleanup(func() {
assert.NoError(t, os.RemoveAll(tmp))
})
socket := filepath.Join(tmp, "gitaly.sock")
ln, err := net.Listen("unix", socket)
require.NoError(t, err)
srv := grpc.NewServer(testhelper.WithSidechannel())
gitalypb.RegisterSmartHTTPServiceServer(srv, s)
go func() {
assert.NoError(t, srv.Serve(ln))
}()
t.Cleanup(func() {
srv.GracefulStop()
})
return fmt.Sprintf("%s://%s", ln.Addr().Network(), ln.Addr().String())
}
|
