1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370
|
/* -*- Mode: C; tab-width: 8; indent-tabs-mode: t; c-basic-offset: 8 -*-
* vi:set noexpandtab tabstop=8 shiftwidth=8:
*
* Copyright (C) 2021 Red Hat <www.redhat.com>
*
* SPDX-License-Identifier: GPL-2.0-or-later
*/
#include "config.h"
#include <glib/gi18n-lib.h>
#include "gs-packagekit-task.h"
/**
* SECTION:gs-packagekit-task
* @short_description: PkTask subclass which implements vfuncs for user interaction during a task
*
* #GsPackagekitTask is a subclass of #PkTask which represents a single
* operation on PackageKit.
*
* By subclassing #PkTask, it can implement vfuncs which allow decisions
* to be made about the task while it’s running. For example, to decide
* what to do if an untrusted package needs to be installed.
*
* Since: 42
*/
typedef struct {
GWeakRef plugin_weakref; /* GsPlugin * */
GsPackagekitTaskQuestionType question_type;
GsPackagekitHelper *helper;
} GsPackagekitTaskPrivate;
G_DEFINE_TYPE_WITH_PRIVATE (GsPackagekitTask, gs_packagekit_task, PK_TYPE_TASK)
static gboolean
gs_packagekit_task_user_accepted (PkTask *task,
const gchar *title,
const gchar *msg,
const gchar *details,
const gchar *accept_label)
{
GsPackagekitTask *gs_task = GS_PACKAGEKIT_TASK (task);
GsPackagekitTaskPrivate *priv = gs_packagekit_task_get_instance_private (gs_task);
g_autoptr(GsPlugin) plugin = NULL;
gboolean accepts = FALSE;
plugin = g_weak_ref_get (&priv->plugin_weakref);
if (plugin)
accepts = gs_plugin_ask_untrusted (plugin, title, msg, details, accept_label);
return accepts;
}
typedef struct {
GWeakRef task_weakref;
guint request;
gchar *title;
gchar *msg;
gchar *details;
gchar *accept_label;
} QuestionData;
static QuestionData *
question_data_new (GsPackagekitTask *task,
guint request,
const gchar *title,
const gchar *msg,
const gchar *details,
const gchar *accept_label)
{
QuestionData *qd;
qd = g_slice_new0 (QuestionData);
g_weak_ref_init (&qd->task_weakref, task);
qd->request = request;
qd->title = g_strdup (title);
qd->msg = g_strdup (msg);
qd->details = g_strdup (details);
qd->accept_label = g_strdup (accept_label);
return qd;
}
static void
question_data_free (gpointer ptr)
{
QuestionData *qd = ptr;
g_weak_ref_clear (&qd->task_weakref);
g_free (qd->title);
g_free (qd->msg);
g_free (qd->details);
g_free (qd->accept_label);
g_slice_free (QuestionData, qd);
}
G_DEFINE_AUTOPTR_CLEANUP_FUNC (QuestionData, question_data_free)
static gboolean
gs_packagekit_task_question_idle_cb (gpointer user_data)
{
QuestionData *qd = user_data;
g_autoptr(PkTask) task = NULL;
task = g_weak_ref_get (&qd->task_weakref);
if (task) {
if (gs_packagekit_task_user_accepted (task, qd->title, qd->msg, qd->details, qd->accept_label))
pk_task_user_accepted (task, qd->request);
else
pk_task_user_declined (task, qd->request);
}
return G_SOURCE_REMOVE;
}
static void
gs_packagekit_task_schedule_question (GsPackagekitTask *task,
guint request,
const gchar *title,
const gchar *msg,
const gchar *details,
const gchar *accept_label)
{
g_autoptr(QuestionData) qd = NULL;
qd = question_data_new (task, request, title, msg, details, accept_label);
g_idle_add_full (G_PRIORITY_HIGH_IDLE, gs_packagekit_task_question_idle_cb, g_steal_pointer (&qd), question_data_free);
}
/* This may be called in a PackageKit worker thread. */
static void
gs_packagekit_task_untrusted_question (PkTask *task,
guint request,
PkResults *results)
{
GsPackagekitTask *gs_task = GS_PACKAGEKIT_TASK (task);
GsPackagekitTaskPrivate *priv = gs_packagekit_task_get_instance_private (gs_task);
g_autoptr(PkError) error = NULL;
const gchar *title;
const gchar *msg;
const gchar *details;
const gchar *accept_label;
switch (priv->question_type) {
case GS_PACKAGEKIT_TASK_QUESTION_TYPE_INSTALL:
title = _("Install Unsigned Software?");
msg = _("Software that is to be installed is not signed. It will not be possible to verify the origin of updates to this software, or whether updates have been tampered with.");
accept_label = _("_Install");
break;
case GS_PACKAGEKIT_TASK_QUESTION_TYPE_DOWNLOAD:
title = _("Download Unsigned Software?");
msg = _("Unsigned updates are available. Without a signature, it is not possible to verify the origin of the update, or whether it has been tampered with.");
accept_label = _("_Download");
break;
case GS_PACKAGEKIT_TASK_QUESTION_TYPE_UPDATE:
title = _("Update Unsigned Software?");
msg = _("Unsigned updates are available. Without a signature, it is not possible to verify the origin of the update, or whether it has been tampered with. Software updates will be disabled until unsigned updates are either removed or updated.");
accept_label = _("_Update");
break;
default:
pk_task_user_declined (task, request);
return;
}
error = pk_results_get_error_code (results);
if (error)
details = pk_error_get_details (error);
else
details = NULL;
gs_packagekit_task_schedule_question (gs_task, request, title, msg, details, accept_label);
}
/* disable for now, but keep it in the code in case it would be reconsidered in the future (also due to translatable strings)
* See https://gitlab.gnome.org/GNOME/gnome-software/-/issues/2874 */
/* #define WITH_KEY_QUESTION 1 */
#ifdef WITH_KEY_QUESTION
/* This may be called in a PackageKit worker thread. */
static void
gs_packagekit_task_key_question (PkTask *task,
guint request,
PkResults *results)
{
GsPackagekitTask *self = GS_PACKAGEKIT_TASK (task);
g_autoptr(GPtrArray) array = NULL;
g_autoptr(GString) details = NULL;
g_autofree gchar *msg = NULL;
array = pk_results_get_repo_signature_required_array (results);
if (array == NULL) {
pk_task_user_declined (task, request);
return;
}
details = g_string_new ("");
for (guint i = 0; i < array->len; i++) {
PkRepoSignatureRequired *item = g_ptr_array_index (array, i);
g_autofree gchar *key_id = NULL;
g_autofree gchar *key_userid = NULL;
g_autofree gchar *key_url = NULL;
g_autofree gchar *key_fingerprint = NULL;
g_autofree gchar *key_filename = NULL;
const gchar *from;
g_object_get (item,
"key-id", &key_id,
"key-url", &key_url,
"key-userid", &key_userid,
"key-fingerprint", &key_fingerprint,
NULL);
if (key_url != NULL && g_ascii_strncasecmp (key_url, "file:", 5) == 0)
key_filename = g_filename_from_uri (key_url, NULL, NULL);
if (array->len == 1) {
/* to mute static analyzers, which may produce a false positive about
overwriting the `msg` content in the second go of the cycle */
g_clear_pointer (&msg, g_free);
/* Translators: the '%s' is replaced with the key ID, usually a few hex digits */
msg = g_strdup_printf (_("Do you want to import key %s?"), key_id);
} else {
/* add empty line between the keys, if there are more to be imported */
if (details->len > 0)
g_string_append (details, "\n\n");
/* Translators: the '%s' is replaced with the key ID, usually a few hex digits */
g_string_append_printf (details, _("Key %s"), key_id);
g_string_append_c (details, '\n');
}
from = key_filename != NULL ? key_filename : key_url;
#define add_nonempty_line(_format, _value) G_STMT_START { \
if ((_value) != NULL && *(_value) != '\0') { \
g_string_append_printf (details, _format, _value); \
g_string_append_c (details, '\n'); \
} \
} G_STMT_END
/* Translators: the '%s' is replaced with the key user name */
add_nonempty_line (_("Key user: %s"), key_userid);
/* Translators: the '%s' is replaced with the key fingerprint, a few hex digits */
add_nonempty_line (_("Fingerprint: %s"), key_fingerprint);
/* Translators: the '%s' is replaced with the local path or a URI to the key */
add_nonempty_line (_("From: %s"), from);
#undef add_nonempty_line
}
gs_packagekit_task_schedule_question (self, request,
_("Import Key"),
msg == NULL ? _("Do you want to import keys?") : msg,
details->str,
_("_Import Key"));
}
#endif
static void
gs_packagekit_task_finalize (GObject *object)
{
GsPackagekitTask *task = GS_PACKAGEKIT_TASK (object);
GsPackagekitTaskPrivate *priv = gs_packagekit_task_get_instance_private (task);
g_weak_ref_clear (&priv->plugin_weakref);
g_clear_object (&priv->helper);
G_OBJECT_CLASS (gs_packagekit_task_parent_class)->finalize (object);
}
static void
gs_packagekit_task_class_init (GsPackagekitTaskClass *klass)
{
GObjectClass *object_class;
PkTaskClass *task_class;
task_class = PK_TASK_CLASS (klass);
task_class->untrusted_question = gs_packagekit_task_untrusted_question;
#ifdef WITH_KEY_QUESTION
task_class->key_question = gs_packagekit_task_key_question;
#endif
object_class = G_OBJECT_CLASS (klass);
object_class->finalize = gs_packagekit_task_finalize;
}
static void
gs_packagekit_task_init (GsPackagekitTask *task)
{
GsPackagekitTaskPrivate *priv = gs_packagekit_task_get_instance_private (task);
g_weak_ref_init (&priv->plugin_weakref, NULL);
}
PkTask *
gs_packagekit_task_new (GsPlugin *plugin)
{
GsPackagekitTask *task;
GsPackagekitTaskPrivate *priv;
g_return_val_if_fail (GS_IS_PLUGIN (plugin), NULL);
task = g_object_new (GS_TYPE_PACKAGEKIT_TASK, NULL);
priv = gs_packagekit_task_get_instance_private (task);
g_weak_ref_set (&priv->plugin_weakref, plugin);
return PK_TASK (task);
}
void
gs_packagekit_task_setup (GsPackagekitTask *task,
GsPackagekitTaskQuestionType question_type,
gboolean interactive)
{
GsPackagekitTaskPrivate *priv = gs_packagekit_task_get_instance_private (task);
g_return_if_fail (GS_IS_PACKAGEKIT_TASK (task));
priv->question_type = question_type;
/* The :interactive and :background properties have slightly different
* purposes:
* - :interactive controls whether the task can create interactive
* authentication (polkit) prompts
* - :background controls the scheduling of the task relative to other
* PackageKit tasks from this client and other clients
* However, we always want to set them both based on the same
* conditions. */
pk_client_set_interactive (PK_CLIENT (task), interactive);
pk_client_set_background (PK_CLIENT (task), !interactive);
}
GsPackagekitTaskQuestionType
gs_packagekit_task_get_question_type (GsPackagekitTask *task)
{
GsPackagekitTaskPrivate *priv = gs_packagekit_task_get_instance_private (task);
g_return_val_if_fail (GS_IS_PACKAGEKIT_TASK (task), GS_PACKAGEKIT_TASK_QUESTION_TYPE_NONE);
return priv->question_type;
}
void
gs_packagekit_task_take_helper (GsPackagekitTask *task,
GsPackagekitHelper *helper)
{
GsPackagekitTaskPrivate *priv = gs_packagekit_task_get_instance_private (task);
g_return_if_fail (GS_IS_PACKAGEKIT_TASK (task));
if (priv->helper != helper) {
g_clear_object (&priv->helper);
priv->helper = helper;
}
}
GsPackagekitHelper *
gs_packagekit_task_get_helper (GsPackagekitTask *task)
{
GsPackagekitTaskPrivate *priv = gs_packagekit_task_get_instance_private (task);
g_return_val_if_fail (GS_IS_PACKAGEKIT_TASK (task), NULL);
return priv->helper;
}
|