File: 12_fix_exit.patch

package info (click to toggle)
gnome-system-tools 3.0.0-11.1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid
  • size: 17,840 kB
  • sloc: ansic: 16,544; xml: 14,114; sh: 10,794; makefile: 402
file content (42 lines) | stat: -rw-r--r-- 1,398 bytes parent folder | download | duplicates (6)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
Description: Drop unneeded g_object_unref call to fix a segmentation fault on exit after a new user has been created. Adjust gst_users_tool_finalize to fix some warnings/error messages.
Author: Thaddäus Tintenfisch <thad.fisch@gmail.com>
Bug-Ubuntu: https://launchpad.net/bugs/1185396
Bug-Debian: https://bugs.debian.org/729477

=== modified file 'src/users/users-tool.c'
--- a/src/users/users-tool.c	2011-12-16 17:08:20 +0000
+++ b/src/users/users-tool.c	2014-03-07 19:55:37 +0000
@@ -114,17 +114,18 @@
 {
 	GstUsersTool *tool = GST_USERS_TOOL (object);
 
+	/* Clear models to unreference OobsUsers and OobsGroups
+	 * to be sure they are finalized properly (passwords...) */
+	users_table_clear ();
+	groups_table_clear ();
+
 	g_object_unref (tool->users_config);
+	g_object_unref (tool->groups_config);
 	g_object_unref (tool->self_config);
-	g_object_unref (tool->groups_config);
+
 	g_object_unref (tool->profiles);
 	g_object_unref (tool->settings);
 
-	/* Clear models to unreference OobsUsers and OobsGroups
-	 * to be sure they are finalized properly (passwords...) */
-	users_table_clear ();
-	groups_table_clear ();
-
 	(* G_OBJECT_CLASS (gst_users_tool_parent_class)->finalize) (object);
 }
 
@@ -182,7 +183,6 @@
 		/* update privileges table too */
 		privileges_table_add_group (OOBS_GROUP (group));
 
-		g_object_unref (group);
 		valid = oobs_list_iter_next (list, &iter);
 	}