File: 67_lib-x509-x509_ext.c-Add-gnutls_free-to-avoid-memory-.patch

package info (click to toggle)
gnutls28 3.7.9-2%2Bdeb12u5
  • links: PTS, VCS
  • area: main
  • in suites: bookworm, bookworm-proposed-updates
  • size: 78,064 kB
  • sloc: ansic: 378,337; asm: 113,340; sh: 17,300; makefile: 6,698; yacc: 1,851; lisp: 1,593; python: 1,370; cpp: 1,362; perl: 995; sed: 16
file content (40 lines) | stat: -rw-r--r-- 1,192 bytes parent folder | download 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
 
From 9d567481dad33c4044baa4e659862ee096d014ae Mon Sep 17 00:00:00 2001
From: Jiasheng Jiang <jian1000@purdue.edu>
Date: Sat, 5 Jul 2025 00:55:17 +0000
Subject: [PATCH] lib/x509/x509_ext.c: Add gnutls_free() to avoid memory leak

Add gnutls_free() to free ooc if subject_alt_names_set() fails to avoid memory leak.

Fixes: 2bd323f72 ("Added new API to handle X.509 extensions.")
Signed-off-by: JiashengJiang <jiasheng@purdue.edu>
---
 lib/x509/x509_ext.c | 3 +++
 1 file changed, 3 insertions(+)

--- a/lib/x509/x509_ext.c
+++ b/lib/x509/x509_ext.c
@@ -187,10 +187,11 @@ int gnutls_subject_alt_names_set(gnutls_
 	else
 		ooc = NULL;
 	ret = subject_alt_names_set(&sans->names, &sans->size,
 				    san_type, &copy, ooc, 0);
 	if (ret < 0) {
+		gnutls_free(ooc);
 		gnutls_free(copy.data);
 		return gnutls_assert_val(ret);
 	}
 
 	return 0;
@@ -806,10 +807,12 @@ int gnutls_x509_aki_set_cert_issuer(gnut
 	ret =
 	    subject_alt_names_set(&aki->cert_issuer.names,
 				  &aki->cert_issuer.size, san_type, &t_san,
 				  (char *)t_othername_oid.data, 0);
 	if (ret < 0) {
+		gnutls_free(t_othername_oid.data);
+		gnutls_free(t_san.data);
 		gnutls_assert();
 		return ret;
 	}
 
 	return 0;