1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
|
// Copyright 2021-present The Atlas Authors. All rights reserved.
// This source code is licensed under the Apache 2.0 license found
// in the LICENSE file in the root directory of this source tree.
package myparse_test
import (
"strconv"
"testing"
"ariga.io/atlas/cmd/atlas/internal/sqlparse/myparse"
"ariga.io/atlas/sql/migrate"
"ariga.io/atlas/sql/schema"
"github.com/stretchr/testify/require"
)
func TestFixChange_RenameColumns(t *testing.T) {
var p myparse.Parser
_, err := p.FixChange(
nil,
"ALTER TABLE t RENAME COLUMN c1 TO c2",
schema.Changes{&schema.AddTable{}},
)
require.Error(t, err)
changes, err := p.FixChange(
nil,
"ALTER TABLE t RENAME COLUMN c1 TO c2",
schema.Changes{
&schema.ModifyTable{
Changes: schema.Changes{
&schema.DropColumn{C: schema.NewColumn("c1")},
&schema.AddColumn{C: schema.NewColumn("c2")},
},
},
},
)
require.NoError(t, err)
require.Equal(
t,
schema.Changes{
&schema.ModifyTable{
Changes: schema.Changes{
&schema.RenameColumn{From: schema.NewColumn("c1"), To: schema.NewColumn("c2")},
},
},
},
changes,
)
changes, err = p.FixChange(
nil,
"ALTER TABLE t ADD INDEX i(id), RENAME COLUMN c1 TO c2, ADD COLUMN c3 int, DROP COLUMN c4",
schema.Changes{
&schema.ModifyTable{
Changes: schema.Changes{
&schema.AddIndex{I: schema.NewIndex("i").AddColumns(schema.NewColumn("id"))},
&schema.DropColumn{C: schema.NewColumn("c1")},
&schema.AddColumn{C: schema.NewColumn("c2")},
&schema.AddColumn{C: schema.NewColumn("c3")},
&schema.AddColumn{C: schema.NewColumn("c4")},
},
},
},
)
require.NoError(t, err)
require.Equal(
t,
schema.Changes{
&schema.ModifyTable{
Changes: schema.Changes{
&schema.AddIndex{I: schema.NewIndex("i").AddColumns(schema.NewColumn("id"))},
&schema.RenameColumn{From: schema.NewColumn("c1"), To: schema.NewColumn("c2")},
&schema.AddColumn{C: schema.NewColumn("c3")},
&schema.AddColumn{C: schema.NewColumn("c4")},
},
},
},
changes,
)
}
func TestFixChange_RenameIndexes(t *testing.T) {
var p myparse.Parser
changes, err := p.FixChange(
nil,
"ALTER TABLE t RENAME Index i1 TO i2",
schema.Changes{
&schema.ModifyTable{
Changes: schema.Changes{
&schema.DropIndex{I: schema.NewIndex("i1")},
&schema.AddIndex{I: schema.NewIndex("i2")},
},
},
},
)
require.NoError(t, err)
require.Equal(
t,
schema.Changes{
&schema.ModifyTable{
Changes: schema.Changes{
&schema.RenameIndex{From: schema.NewIndex("i1"), To: schema.NewIndex("i2")},
},
},
},
changes,
)
}
func TestFixChange_RenameTable(t *testing.T) {
var p myparse.Parser
changes, err := p.FixChange(
nil,
"RENAME TABLE t1 TO t2",
schema.Changes{
&schema.DropTable{T: schema.NewTable("t1")},
&schema.AddTable{T: schema.NewTable("t2")},
},
)
require.NoError(t, err)
require.Equal(
t,
schema.Changes{
&schema.RenameTable{From: schema.NewTable("t1"), To: schema.NewTable("t2")},
},
changes,
)
changes, err = p.FixChange(
nil,
"RENAME TABLE t1 TO t2, t3 TO t4",
schema.Changes{
&schema.DropTable{T: schema.NewTable("t1")},
&schema.AddTable{T: schema.NewTable("t2")},
&schema.DropTable{T: schema.NewTable("t3")},
&schema.AddTable{T: schema.NewTable("t4")},
},
)
require.NoError(t, err)
require.Equal(
t,
schema.Changes{
&schema.RenameTable{From: schema.NewTable("t1"), To: schema.NewTable("t2")},
&schema.RenameTable{From: schema.NewTable("t3"), To: schema.NewTable("t4")},
},
changes,
)
}
func TestFixChange_AlterAndRename(t *testing.T) {
var (
p myparse.Parser
drv = &mockDriver{}
)
drv.changes = append(drv.changes, &schema.AddColumn{C: schema.NewIntColumn("c2", "int")})
changes, err := p.FixChange(
drv,
"ALTER TABLE t1 RENAME TO t2, ADD COLUMN c2 int",
schema.Changes{
&schema.DropTable{T: schema.NewTable("t1").AddColumns(schema.NewIntColumn("c1", "int"))},
&schema.AddTable{T: schema.NewTable("t2").AddColumns(schema.NewIntColumn("c1", "int"), schema.NewIntColumn("c2", "int"))},
},
)
require.NoError(t, err)
require.Equal(
t,
schema.Changes{
&schema.ModifyTable{
T: schema.NewTable("t1").AddColumns(schema.NewIntColumn("c1", "int"), schema.NewIntColumn("c2", "int")),
Changes: schema.Changes{
&schema.AddColumn{C: schema.NewIntColumn("c2", "int")},
},
},
&schema.RenameTable{
From: schema.NewTable("t1").AddColumns(schema.NewIntColumn("c1", "int"), schema.NewIntColumn("c2", "int")),
To: schema.NewTable("t2").AddColumns(schema.NewIntColumn("c1", "int"), schema.NewIntColumn("c2", "int")),
},
},
changes,
)
}
func TestColumnFilledBefore(t *testing.T) {
for i, tt := range []struct {
file string
pos int
wantFilled bool
wantErr bool
}{
{
file: `UPDATE t SET c = NULL;`,
pos: 100,
},
{
file: `UPDATE t SET c = 2;`,
pos: 100,
wantFilled: true,
},
{
file: `UPDATE t SET c = 2 WHERE c IS NULL;`,
pos: 100,
wantFilled: true,
},
{
file: `UPDATE t SET c = 2 WHERE c IS NOT NULL;`,
pos: 100,
wantFilled: false,
},
{
file: `UPDATE t SET c = 2 WHERE c <> NULL`,
pos: 100,
wantFilled: false,
},
{
file: `
ALTER TABLE t MODIFY COLUMN c INT NOT NULL;
UPDATE t SET c = 2 WHERE c IS NULL;
`,
pos: 2,
wantFilled: false,
},
{
file: `
UPDATE t SET c = 2 WHERE c IS NULL;
ALTER TABLE t MODIFY COLUMN c INT NOT NULL;
`,
pos: 30,
wantFilled: true,
},
} {
t.Run(strconv.Itoa(i), func(t *testing.T) {
var (
p myparse.Parser
f = migrate.NewLocalFile("file", []byte(tt.file))
)
filled, err := p.ColumnFilledBefore(f, schema.NewTable("t"), schema.NewColumn("c"), tt.pos)
require.Equal(t, err != nil, tt.wantErr, err)
require.Equal(t, filled, tt.wantFilled)
})
}
}
type mockDriver struct {
migrate.Driver
changes schema.Changes
}
func (d mockDriver) TableDiff(_, _ *schema.Table) ([]schema.Change, error) {
return d.changes, nil
}
|
