1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
|
// Copyright 2021-2023 The Connect Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package connect_test
import (
"context"
"fmt"
"net/http"
"testing"
connect "connectrpc.com/connect"
"connectrpc.com/connect/internal/assert"
pingv1 "connectrpc.com/connect/internal/gen/connect/ping/v1"
"connectrpc.com/connect/internal/gen/connect/ping/v1/pingv1connect"
"connectrpc.com/connect/internal/memhttp/memhttptest"
)
type panicPingServer struct {
pingv1connect.UnimplementedPingServiceHandler
panicWith any
}
func (s *panicPingServer) Ping(
context.Context,
*connect.Request[pingv1.PingRequest],
) (*connect.Response[pingv1.PingResponse], error) {
panic(s.panicWith) //nolint:forbidigo
}
func (s *panicPingServer) CountUp(
_ context.Context,
_ *connect.Request[pingv1.CountUpRequest],
stream *connect.ServerStream[pingv1.CountUpResponse],
) error {
if err := stream.Send(&pingv1.CountUpResponse{}); err != nil {
return err
}
panic(s.panicWith) //nolint:forbidigo
}
func TestWithRecover(t *testing.T) {
t.Parallel()
handle := func(_ context.Context, _ connect.Spec, _ http.Header, r any) error {
return connect.NewError(connect.CodeFailedPrecondition, fmt.Errorf("panic: %v", r))
}
assertHandled := func(err error) {
t.Helper()
assert.NotNil(t, err)
assert.Equal(t, connect.CodeOf(err), connect.CodeFailedPrecondition)
}
assertNotHandled := func(err error) {
t.Helper()
// When HTTP/2 handlers panic, net/http sends an RST_STREAM frame with code
// INTERNAL_ERROR. We should be mapping this back to CodeInternal.
assert.Equal(t, connect.CodeOf(err), connect.CodeInternal)
}
drainStream := func(stream *connect.ServerStreamForClient[pingv1.CountUpResponse]) error {
t.Helper()
defer stream.Close()
assert.True(t, stream.Receive()) // expect one response msg
assert.False(t, stream.Receive()) // expect panic before second response msg
return stream.Err()
}
pinger := &panicPingServer{}
mux := http.NewServeMux()
mux.Handle(pingv1connect.NewPingServiceHandler(pinger, connect.WithRecover(handle)))
server := memhttptest.NewServer(t, mux)
client := pingv1connect.NewPingServiceClient(
server.Client(),
server.URL(),
)
for _, panicWith := range []any{42, nil} {
pinger.panicWith = panicWith
_, err := client.Ping(context.Background(), connect.NewRequest(&pingv1.PingRequest{}))
assertHandled(err)
stream, err := client.CountUp(context.Background(), connect.NewRequest(&pingv1.CountUpRequest{}))
assert.Nil(t, err)
assertHandled(drainStream(stream))
}
pinger.panicWith = http.ErrAbortHandler
_, err := client.Ping(context.Background(), connect.NewRequest(&pingv1.PingRequest{}))
assertNotHandled(err)
stream, err := client.CountUp(context.Background(), connect.NewRequest(&pingv1.CountUpRequest{}))
assert.Nil(t, err)
assertNotHandled(drainStream(stream))
}
|
