1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
|
package internal
import (
"errors"
"os"
"testing"
"github.com/go-quicktest/qt"
)
func TestVerifierErrorWhitespace(t *testing.T) {
b := []byte("unreachable insn 28")
b = append(b,
0xa, // \n
0xd, // \r
0x9, // \t
0x20, // space
0, 0, // trailing NUL bytes
)
err := ErrorWithLog("frob", errors.New("test"), b)
qt.Assert(t, qt.Equals(err.Error(), "frob: test: unreachable insn 28"))
for _, log := range [][]byte{
nil,
[]byte("\x00"),
[]byte(" "),
} {
err = ErrorWithLog("frob", errors.New("test"), log)
qt.Assert(t, qt.Equals(err.Error(), "frob: test"), qt.Commentf("empty log %q has incorrect format", log))
}
}
func TestVerifierErrorWrapping(t *testing.T) {
sentinel := errors.New("bad")
ve := ErrorWithLog("frob", sentinel, nil)
qt.Assert(t, qt.ErrorIs(ve, sentinel), qt.Commentf("should wrap provided error"))
ve = ErrorWithLog("frob", sentinel, []byte("foo"))
qt.Assert(t, qt.ErrorIs(ve, sentinel), qt.Commentf("should wrap provided error"))
qt.Assert(t, qt.StringContains(ve.Error(), "foo"), qt.Commentf("verifier log should appear in error string"))
}
func TestVerifierErrorSummary(t *testing.T) {
// Suppress the last line containing 'processed ... insns'.
errno524 := readErrorFromFile(t, "testdata/errno524.log")
qt.Assert(t, qt.StringContains(errno524.Error(), "JIT doesn't support bpf-to-bpf calls"))
qt.Assert(t, qt.Not(qt.StringContains(errno524.Error(), "processed 39 insns")))
// Include the previous line if the current one starts with a tab.
invalidMember := readErrorFromFile(t, "testdata/invalid-member.log")
qt.Assert(t, qt.StringContains(invalidMember.Error(), "STRUCT task_struct size=7744 vlen=218: cpus_mask type_id=109 bitfield_size=0 bits_offset=7744 Invalid member"))
// Only include the last line.
issue43 := readErrorFromFile(t, "testdata/issue-43.log")
qt.Assert(t, qt.StringContains(issue43.Error(), "[11] FUNC helper_func2 type_id=10 vlen != 0"))
qt.Assert(t, qt.Not(qt.StringContains(issue43.Error(), "[10] FUNC_PROTO (anon) return=3 args=(3 arg)")))
// Include instruction that caused invalid register access.
invalidR0 := readErrorFromFile(t, "testdata/invalid-R0.log")
qt.Assert(t, qt.StringContains(invalidR0.Error(), "0: (95) exit: R0 !read_ok"))
// Include symbol that doesn't match context type.
invalidCtx := readErrorFromFile(t, "testdata/invalid-ctx-access.log")
qt.Assert(t, qt.StringContains(invalidCtx.Error(), "func '__x64_sys_recvfrom' arg0 type FWD is not a struct: invalid bpf_context access off=0 size=8"))
}
func readErrorFromFile(tb testing.TB, file string) *VerifierError {
tb.Helper()
contents, err := os.ReadFile(file)
if err != nil {
tb.Fatal("Read file:", err)
}
return ErrorWithLog("file", errors.New("error"), contents)
}
|
