1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
|
package ocsp
import (
"os"
"testing"
"time"
"github.com/cloudflare/cfssl/helpers"
"golang.org/x/crypto/ocsp"
)
const (
serverCertFile = "testdata/ca.pem"
serverKeyFile = "testdata/ca-key.pem"
otherCertFile = "testdata/cert.pem"
brokenServerCert = "testdata/server_broken.crt"
brokenServerKey = "testdata/server_broken.key"
wrongServerCertFile = "testdata/server.crt"
wrongServerKeyFile = "testdata/server.key"
)
func TestNewSignerFromFile(t *testing.T) {
// arbitrary duration
dur, _ := time.ParseDuration("1ms")
// nonexistent files
_, err := NewSignerFromFile("", "", "", dur)
if err == nil {
t.Fatal("Failed to issue error on improper file")
}
_, err = NewSignerFromFile(serverCertFile, "", "", dur)
if err == nil {
t.Fatal("Failed to issue error on improper file")
}
_, err = NewSignerFromFile(serverCertFile, otherCertFile, "", dur)
if err == nil {
t.Fatal("Failed to issue error on improper file")
}
// malformed certs
_, err = NewSignerFromFile(brokenServerCert, otherCertFile, serverKeyFile, dur)
if err == nil {
t.Fatal("Didn't fail on malformed file")
}
_, err = NewSignerFromFile(serverCertFile, brokenServerCert, serverKeyFile, dur)
if err == nil {
t.Fatal("Didn't fail on malformed file")
}
_, err = NewSignerFromFile(serverCertFile, otherCertFile, brokenServerKey, dur)
if err == nil {
t.Fatal("Didn't fail on malformed file")
}
// expected case
_, err = NewSignerFromFile(serverCertFile, otherCertFile, serverKeyFile, dur)
if err != nil {
t.Fatalf("Signer creation failed %v", err)
}
}
func setup(t *testing.T) (SignRequest, time.Duration) {
dur, _ := time.ParseDuration("1ms")
certPEM, err := os.ReadFile(otherCertFile)
if err != nil {
t.Fatal(err)
}
leafCert, err := helpers.ParseCertificatePEM(certPEM)
if err != nil {
t.Fatal(err)
}
req := SignRequest{
Certificate: leafCert,
Status: "good",
}
return req, dur
}
func TestSignNoResponder(t *testing.T) {
req, dur := setup(t)
s, err := NewSignerFromFile(serverCertFile, serverCertFile, serverKeyFile, dur)
if err != nil {
t.Fatalf("Signer creation failed: %v", err)
}
respBytes, err := s.Sign(req)
if err != nil {
t.Fatal("Failed to sign with no responder cert")
}
resp, err := ocsp.ParseResponse(respBytes, nil)
if err != nil {
t.Fatal("Failed to fail on improper status code")
}
if resp.Certificate != nil {
t.Fatal("Response contain responder cert even though it was identical to issuer")
}
}
func TestSign(t *testing.T) {
req, dur := setup(t)
// expected case
s, err := NewSignerFromFile(serverCertFile, otherCertFile, serverKeyFile, dur)
if err != nil {
t.Fatalf("Signer creation failed: %v", err)
}
_, err = s.Sign(SignRequest{})
if err == nil {
t.Fatal("Signed request with nil certificate")
}
_, err = s.Sign(req)
if err != nil {
t.Fatal("Sign failed")
}
sMismatch, err := NewSignerFromFile(wrongServerCertFile, otherCertFile, wrongServerKeyFile, dur)
if err != nil {
t.Fatal("NewSigner failed:", err)
}
_, err = sMismatch.Sign(req)
if err == nil {
t.Fatal("Signed a certificate from the wrong issuer")
}
// incorrect status code
req.Status = "aalkjsfdlkafdslkjahds"
_, err = s.Sign(req)
if err == nil {
t.Fatal("Failed to fail on improper status code")
}
// revoked
req.Status = "revoked"
_, err = s.Sign(req)
if err != nil {
t.Fatal("Error on revoked certificate")
}
}
func TestSignCustomInterval(t *testing.T) {
req, _ := setup(t)
dur := time.Hour
s, err := NewSignerFromFile(serverCertFile, serverCertFile, serverKeyFile, dur)
if err != nil {
t.Fatalf("Signer creation failed: %v", err)
}
// default case
n := time.Now().UTC().Truncate(time.Hour)
respBytes, err := s.Sign(req)
if err != nil {
t.Fatalf("Error signing default request: %s", err)
}
resp, err := ocsp.ParseResponse(respBytes, nil)
if err != nil {
t.Fatalf("Error parsing response: %s", err)
}
if !resp.ThisUpdate.Equal(n) {
t.Fatalf("Unexpected ThisUpdate: wanted %s, got %s", n, resp.ThisUpdate)
}
if !resp.NextUpdate.Equal(n.Add(dur)) {
t.Fatalf("Unexpected NextUpdate: wanted %s, got %s", n.Add(dur), resp.NextUpdate)
}
// custom case, ThisUpdate only
this := time.Now().UTC().Add(-time.Hour * 5).Truncate(time.Hour)
req.ThisUpdate = &this
respBytes, err = s.Sign(req)
if err != nil {
t.Fatalf("Error signing default request: %s", err)
}
resp, err = ocsp.ParseResponse(respBytes, nil)
if err != nil {
t.Fatalf("Error parsing response: %s", err)
}
if !resp.ThisUpdate.Equal(this) {
t.Fatalf("Unexpected ThisUpdate: wanted %s, got %s", this, resp.ThisUpdate)
}
if !resp.NextUpdate.Equal(this.Add(dur)) {
t.Fatalf("Unexpected NextUpdate: wanted %s, got %s", this.Add(dur), resp.NextUpdate)
}
// custom case, ThisUpdate and NextUpdate
next := this.Add(time.Hour * 2)
req.NextUpdate = &next
respBytes, err = s.Sign(req)
if err != nil {
t.Fatalf("Error signing default request: %s", err)
}
resp, err = ocsp.ParseResponse(respBytes, nil)
if err != nil {
t.Fatalf("Error parsing response: %s", err)
}
if !resp.ThisUpdate.Equal(this) {
t.Fatalf("Unexpected ThisUpdate: wanted %s, got %s", this, resp.ThisUpdate)
}
if !resp.NextUpdate.Equal(next) {
t.Fatalf("Unexpected NextUpdate: wanted %s, got %s", next, resp.NextUpdate)
}
}
|
