1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
|
package resolvconf
import (
"os"
"path/filepath"
"testing"
"github.com/opencontainers/runtime-spec/specs-go"
"github.com/stretchr/testify/assert"
)
const resolv1 = `nameserver 1.1.1.1
`
const resolv2 = `search example.com
nameserver 1.1.1.1
options edns0
`
func TestNew(t *testing.T) {
tests := []struct {
name string
baseContent string
nameservers []string
options []string
searches []string
ipv6 bool
hostns bool
keepHostServers bool
keepHostSearches bool
keepHostOptions bool
want string
}{
{
name: "simple resolv.conf",
baseContent: resolv1,
want: resolv1,
},
{
name: "simple resolv.conf with search and options",
baseContent: resolv2,
want: resolv2,
},
{
name: "simple resolv.conf with comments",
baseContent: "#some comment\n" + resolv2,
want: resolv2,
},
{
name: "overwrite default nameservers",
baseContent: resolv2,
nameservers: []string{"1.2.3.4", "5.6.7.8"},
want: "search example.com\nnameserver 1.2.3.4\nnameserver 5.6.7.8\noptions edns0\n",
},
{
name: "overwrite default options",
baseContent: resolv2,
options: []string{"ndots:2"},
want: "search example.com\nnameserver 1.1.1.1\noptions ndots:2\n",
},
{
name: "overwrite default searches",
baseContent: resolv2,
searches: []string{"test.com"},
want: "search test.com\nnameserver 1.1.1.1\noptions edns0\n",
},
{
name: "dot in searches should unset all search domains",
baseContent: resolv2,
searches: []string{"."},
want: "nameserver 1.1.1.1\noptions edns0\n",
},
{
name: "dot in searches should unset all search domains even with keepHostServers",
baseContent: resolv2,
searches: []string{"."},
keepHostServers: true,
want: "nameserver 1.1.1.1\noptions edns0\n",
},
{
name: "overwrite all",
baseContent: resolv2,
nameservers: []string{"1.2.3.4", "5.6.7.8"},
options: []string{"ndots:2"},
searches: []string{"test.com"},
want: "search test.com\nnameserver 1.2.3.4\nnameserver 5.6.7.8\noptions ndots:2\n",
},
{
name: "overwrite all and unset search",
baseContent: resolv2,
nameservers: []string{"1.2.3.4", "5.6.7.8"},
options: []string{"ndots:2"},
searches: []string{"."},
want: "nameserver 1.2.3.4\nnameserver 5.6.7.8\noptions ndots:2\n",
},
{
name: "set all and keep host server",
baseContent: resolv2,
nameservers: []string{"1.2.3.4", "5.6.7.8"},
options: []string{"ndots:2"},
searches: []string{"test.com"},
keepHostServers: true,
want: "search test.com\nnameserver 1.2.3.4\nnameserver 5.6.7.8\nnameserver 1.1.1.1\noptions ndots:2\n",
},
{
name: "set all and keep host searches",
baseContent: resolv2,
nameservers: []string{"1.2.3.4", "5.6.7.8"},
options: []string{"ndots:2"},
searches: []string{"test.com"},
keepHostSearches: true,
want: "search test.com example.com\nnameserver 1.2.3.4\nnameserver 5.6.7.8\noptions ndots:2\n",
},
{
name: "set all and keep host options",
baseContent: resolv2,
nameservers: []string{"1.2.3.4", "5.6.7.8"},
options: []string{"ndots:2"},
searches: []string{"test.com"},
keepHostOptions: true,
want: "search test.com\nnameserver 1.2.3.4\nnameserver 5.6.7.8\noptions ndots:2 edns0\n",
},
{
name: "set all and keep all options",
baseContent: resolv2,
nameservers: []string{"1.2.3.4", "5.6.7.8"},
options: []string{"ndots:2"},
searches: []string{"test.com"},
keepHostServers: true,
keepHostSearches: true,
keepHostOptions: true,
want: "search test.com example.com\nnameserver 1.2.3.4\nnameserver 5.6.7.8\nnameserver 1.1.1.1\noptions ndots:2 edns0\n",
},
{
name: "localhost nameservers should be filtered and use defaults instead",
baseContent: "nameserver 127.0.0.1\nnameserver ::1\n",
want: "nameserver 8.8.8.8\nnameserver 8.8.4.4\n",
},
{
name: "localhost nameservers should not be filtered with hostns",
baseContent: "nameserver 127.0.0.1\nnameserver ::1\n",
hostns: true,
want: "nameserver 127.0.0.1\nnameserver ::1\n",
},
{
name: "ipv6 nameservers should be filtered when ipv6 is not set",
baseContent: "nameserver 1.1.1.1\nnameserver fd::1\n",
want: "nameserver 1.1.1.1\n",
},
{
name: "ipv6 nameservers should not be filtered when ipv6 is set",
baseContent: "nameserver 1.1.1.1\nnameserver fd::1\n",
ipv6: true,
want: "nameserver 1.1.1.1\nnameserver fd::1\n",
},
{
name: "ipv6 link local must always be filtered when netns is private",
baseContent: "nameserver 1.1.1.1\nnameserver fe80::1%eth1\nnameserver fd::1\n",
ipv6: true,
want: "nameserver 1.1.1.1\nnameserver fd::1\n",
},
{
name: "ipv6 link local must not be filtered when netns is host",
baseContent: "nameserver 1.1.1.1\nnameserver fe80::1%eth1\nnameserver fd::1\n",
hostns: true,
want: "nameserver 1.1.1.1\nnameserver fe80::1%eth1\nnameserver fd::1\n",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
base := filepath.Join(t.TempDir(), "resolv.conf")
target := filepath.Join(t.TempDir(), "new-resolv.conf")
err := os.WriteFile(base, []byte(tt.baseContent), 0o644)
assert.NoError(t, err, "write tmp resolv.conf")
var namespaces []specs.LinuxNamespace
if !tt.hostns {
namespaces = []specs.LinuxNamespace{
{Type: specs.NetworkNamespace},
}
}
err = New(&Params{
Path: target,
Nameservers: tt.nameservers,
Searches: tt.searches,
Options: tt.options,
IPv6Enabled: tt.ipv6,
KeepHostServers: tt.keepHostServers,
KeepHostSearches: tt.keepHostSearches,
KeepHostOptions: tt.keepHostOptions,
Namespaces: namespaces,
resolvConfPath: base,
})
assert.NoError(t, err, "New()")
content, err := os.ReadFile(target)
assert.NoError(t, err, "read tmp resolv.conf)")
assert.Equal(t, tt.want, string(content), "expected resolv.conf does not match")
})
}
}
func TestAdd(t *testing.T) {
tests := []struct {
name string
content string
nameservers []string
want string
}{
{
name: "add single nameserver",
content: resolv1,
nameservers: []string{"1.2.3.4"},
want: "nameserver 1.2.3.4\n" + resolv1,
},
{
name: "add single nameserver with search and options",
content: resolv2,
nameservers: []string{"1.2.3.4"},
want: `search example.com
nameserver 1.2.3.4
nameserver 1.1.1.1
options edns0
`,
},
{
name: "add three nameservers",
content: resolv1,
nameservers: []string{"1.2.3.4", "2.3.4.5", "3.4.5.6"},
want: "nameserver 1.2.3.4\nnameserver 2.3.4.5\nnameserver 3.4.5.6\n" + resolv1,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
resolvPath := filepath.Join(t.TempDir(), "resolv.conf")
err := os.WriteFile(resolvPath, []byte(tt.content), 0o644)
assert.NoError(t, err, "write tmp resolv.conf")
err = Add(resolvPath, tt.nameservers)
assert.NoError(t, err, "Add()")
content, err := os.ReadFile(resolvPath)
assert.NoError(t, err, "read tmp resolv.conf)")
assert.Equal(t, tt.want, string(content), "expected resolv.conf does not match")
})
}
}
func TestRemove(t *testing.T) {
tests := []struct {
name string
content string
nameservers []string
want string
}{
{
name: "remove single nameserver",
content: resolv1,
nameservers: []string{"1.1.1.1"},
want: "",
},
{
name: "remove single nameserver with search and options",
content: resolv2,
nameservers: []string{"1.1.1.1"},
want: `search example.com
options edns0
`,
},
{
name: "remove three nameservers",
content: "nameserver 1.2.3.4\nnameserver 2.3.4.5\nnameserver 3.4.5.6\n" + resolv1,
nameservers: []string{"1.2.3.4", "2.3.4.5", "3.4.5.6"},
want: resolv1,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
resolvPath := filepath.Join(t.TempDir(), "resolv.conf")
err := os.WriteFile(resolvPath, []byte(tt.content), 0o644)
assert.NoError(t, err, "write tmp resolv.conf")
err = Remove(resolvPath, tt.nameservers)
assert.NoError(t, err, "Remove()")
content, err := os.ReadFile(resolvPath)
assert.NoError(t, err, "read tmp resolv.conf)")
assert.Equal(t, tt.want, string(content), "expected resolv.conf does not match")
})
}
}
|
