1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
|
package shelldriver
import (
"fmt"
"testing"
"github.com/containers/common/pkg/secrets/define"
"github.com/stretchr/testify/require"
)
func setupDriver(t *testing.T) *Driver {
base := t.TempDir()
driver, err := NewDriver(map[string]string{
"delete": fmt.Sprintf("rm %s/${SECRET_ID}", base),
"list": fmt.Sprintf("ls %s", base),
"lookup": fmt.Sprintf("cat %s/${SECRET_ID} ", base),
"store": fmt.Sprintf("cat - > %s/${SECRET_ID}", base),
})
require.NoError(t, err)
return driver
}
func TestStoreAndLookup(t *testing.T) {
cases := []struct {
name string
key string
value []byte
expStoreErr error
expLookupErr error
}{
{
name: "store and lookup work for a simple key",
key: "simple",
value: []byte("abc"),
},
{
name: "store and lookup work for a multiline string",
key: "long",
value: []byte("abc\n123\ndef\n"),
},
{
name: "store and lookup work for non-utf8 data",
key: "long",
value: []byte{0, 1, 2, 3, 0, 1, 2, 3},
},
{
name: "storing into a sneaky key fails",
key: "../../../sneaky",
value: []byte("abc"),
expStoreErr: define.ErrInvalidKey,
},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
driver := setupDriver(t)
err := driver.Store(tc.key, tc.value)
if tc.expStoreErr != nil {
require.Error(t, err)
require.Equal(t, tc.expStoreErr.Error(), err.Error())
} else {
require.NoError(t, err)
val, err := driver.Lookup(tc.key)
if tc.expLookupErr != nil {
require.Error(t, err)
require.Equal(t, tc.expLookupErr.Error(), err.Error())
} else {
require.NoError(t, err)
require.Equal(t, tc.value, val)
}
}
})
}
}
func TestLookup(t *testing.T) {
driver := setupDriver(t)
// prepare a valid lookup target
err := driver.Store("valid", []byte("abc"))
require.NoError(t, err)
cases := []struct {
name string
key string
expValue []byte
expErr error
}{
{
name: "lookup of an existing key works",
key: "valid",
expValue: []byte("abc"),
},
{
name: "lookup of a non-existing key fails",
key: "invalid",
expErr: fmt.Errorf("invalid: %w", define.ErrNoSuchSecret),
},
{
name: "lookup of a sneaky key fails",
key: "../../../etc/shadow",
expErr: define.ErrInvalidKey,
},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
val, err := driver.Lookup(tc.key)
if tc.expErr == nil {
require.Equal(t, tc.expValue, val)
} else {
require.EqualError(t, err, tc.expErr.Error())
}
})
}
}
func TestList(t *testing.T) {
driver := setupDriver(t)
require.NoError(t, driver.Store("a", []byte("abc")))
require.NoError(t, driver.Store("b", []byte("abc")))
require.NoError(t, driver.Store("c", []byte("abc")))
list, err := driver.List()
require.NoError(t, err)
require.Equal(t, []string{"a", "b", "c"}, list)
}
func TestDelete(t *testing.T) {
driver := setupDriver(t)
require.NoError(t, driver.Store("a", []byte("abc")))
cases := []struct {
name string
key string
expErr error
}{
{
name: "deleting an existing item works",
key: "a",
},
{
name: "deleting an non-existing item fails",
key: "wrong",
expErr: fmt.Errorf("wrong: %w", define.ErrNoSuchSecret),
},
{
name: "using a sneaky path fails",
key: "../../../etc/shadow",
expErr: define.ErrInvalidKey,
},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
err := driver.Delete(tc.key)
if tc.expErr != nil {
require.EqualError(t, err, tc.expErr.Error())
} else {
require.NoError(t, err)
}
})
}
}
|
