1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
|
package archive
import (
"context"
"fmt"
"os"
"path/filepath"
"testing"
"github.com/containers/image/v5/docker/reference"
"github.com/containers/image/v5/types"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
const (
sha256digestHex = "0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef"
sha256digest = "@sha256:" + sha256digestHex
tarFixture = "fixtures/almostempty.tar"
)
func TestTransportName(t *testing.T) {
assert.Equal(t, "docker-archive", Transport.Name())
}
func TestTransportParseReference(t *testing.T) {
testParseReference(t, Transport.ParseReference)
}
func TestTransportValidatePolicyConfigurationScope(t *testing.T) {
for _, scope := range []string{ // A semi-representative assortment of values; everything is rejected.
"docker.io/library/busybox:notlatest",
"docker.io/library/busybox",
"docker.io/library",
"docker.io",
"",
} {
err := Transport.ValidatePolicyConfigurationScope(scope)
assert.Error(t, err, scope)
}
}
func TestParseReference(t *testing.T) {
testParseReference(t, ParseReference)
}
// testParseReference is a test shared for Transport.ParseReference and ParseReference.
func testParseReference(t *testing.T, fn func(string) (types.ImageReference, error)) {
for _, c := range []struct {
input, expectedPath, expectedRef string
expectedSourceIndex int
}{
{"", "", "", -1}, // Empty input is explicitly rejected
{"/path", "/path", "", -1},
{"/path:busybox:notlatest", "/path", "docker.io/library/busybox:notlatest", -1}, // Explicit tag
{"/path:busybox" + sha256digest, "", "", -1}, // Digest references are forbidden
{"/path:busybox", "/path", "docker.io/library/busybox:latest", -1}, // Default tag
// A github.com/distribution/reference value can have a tag and a digest at the same time!
{"/path:busybox:latest" + sha256digest, "", "", -1}, // Both tag and digest is rejected
{"/path:docker.io/library/busybox:latest", "/path", "docker.io/library/busybox:latest", -1}, // All implied reference parts explicitly specified
{"/path:UPPERCASEISINVALID", "", "", -1}, // Invalid reference format
{"/path:@", "", "", -1}, // Missing source index
{"/path:@0", "/path", "", 0}, // Valid source index
{"/path:@999999", "/path", "", 999999}, // Valid source index
{"/path:@-2", "", "", -1}, // Negative source index
{"/path:@-1", "", "", -1}, // Negative source index, using the placeholder value
{"/path:busybox@0", "", "", -1}, // References and source indices can’t be combined.
{"/path:@0:busybox", "", "", -1}, // References and source indices can’t be combined.
} {
ref, err := fn(c.input)
if c.expectedPath == "" {
assert.Error(t, err, c.input)
} else {
require.NoError(t, err, c.input)
archiveRef, ok := ref.(archiveReference)
require.True(t, ok, c.input)
assert.Equal(t, c.expectedPath, archiveRef.path, c.input)
if c.expectedRef == "" {
assert.Nil(t, archiveRef.ref, c.input)
} else {
require.NotNil(t, archiveRef.ref, c.input)
assert.Equal(t, c.expectedRef, archiveRef.ref.String(), c.input)
}
assert.Equal(t, c.expectedSourceIndex, archiveRef.sourceIndex, c.input)
}
}
}
// namedTaggedRef returns a reference.NamedTagged for input
func namedTaggedRef(t *testing.T, input string) reference.NamedTagged {
named, err := reference.ParseNormalizedNamed(input)
require.NoError(t, err, input)
nt, ok := named.(reference.NamedTagged)
require.True(t, ok, input)
return nt
}
func TestNewReference(t *testing.T) {
for _, path := range []string{"relative", "/absolute"} {
for _, c := range []struct {
ref string
ok bool
}{
{"busybox:notlatest", true},
{"busybox:notlatest" + sha256digest, false},
{"", true},
} {
var ntRef reference.NamedTagged = nil
if c.ref != "" {
ntRef = namedTaggedRef(t, c.ref)
}
res, err := NewReference(path, ntRef)
if !c.ok {
assert.Error(t, err, c.ref)
} else {
require.NoError(t, err, c.ref)
archiveRef, ok := res.(archiveReference)
require.True(t, ok, c.ref)
assert.Equal(t, path, archiveRef.path)
if c.ref == "" {
assert.Nil(t, archiveRef.ref, c.ref)
} else {
require.NotNil(t, archiveRef.ref, c.ref)
assert.Equal(t, ntRef.String(), archiveRef.ref.String(), c.ref)
}
assert.Equal(t, -1, archiveRef.sourceIndex, c.ref)
}
}
}
_, err := NewReference("with:colon", nil)
assert.Error(t, err)
// Complete coverage testing of the private newReference here as well
ntRef := namedTaggedRef(t, "busybox:latest")
_, err = newReference("path", ntRef, 0, nil, nil)
assert.Error(t, err)
}
func TestNewIndexReference(t *testing.T) {
for _, path := range []string{"relative", "/absolute"} {
for _, c := range []struct {
index int
ok bool
}{
{0, true},
{9999990, true},
{-1, true},
{-2, false},
} {
res, err := NewIndexReference(path, c.index)
if !c.ok {
assert.Error(t, err, c.index)
} else {
require.NoError(t, err, c.index)
archiveRef, ok := res.(archiveReference)
require.True(t, ok, c.index)
assert.Equal(t, path, archiveRef.path)
assert.Nil(t, archiveRef.ref, c.index)
assert.Equal(t, c.index, archiveRef.sourceIndex)
}
}
}
_, err := NewReference("with:colon", nil)
assert.Error(t, err)
}
// A common list of reference formats to test for the various ImageReference methods.
var validReferenceTestCases = []struct {
input, dockerRef string
sourceIndex int
stringWithinTransport string
}{
{"/pathonly", "", -1, "/pathonly"},
{"/path:busybox:notlatest", "docker.io/library/busybox:notlatest", -1, "/path:docker.io/library/busybox:notlatest"}, // Explicit tag
{"/path:docker.io/library/busybox:latest", "docker.io/library/busybox:latest", -1, "/path:docker.io/library/busybox:latest"}, // All implied reference part explicitly specified
{"/path:example.com/ns/foo:bar", "example.com/ns/foo:bar", -1, "/path:example.com/ns/foo:bar"}, // All values explicitly specified
{"/path:@0", "", 0, "/path:@0"},
{"/path:@999999", "", 999999, "/path:@999999"},
}
func TestReferenceTransport(t *testing.T) {
ref, err := ParseReference("/tmp/archive.tar")
require.NoError(t, err)
assert.Equal(t, Transport, ref.Transport())
}
func TestReferenceStringWithinTransport(t *testing.T) {
for _, c := range validReferenceTestCases {
ref, err := ParseReference(c.input)
require.NoError(t, err, c.input)
stringRef := ref.StringWithinTransport()
assert.Equal(t, c.stringWithinTransport, stringRef, c.input)
// Do one more round to verify that the output can be parsed, to an equal value.
ref2, err := Transport.ParseReference(stringRef)
require.NoError(t, err, c.input)
stringRef2 := ref2.StringWithinTransport()
assert.Equal(t, stringRef, stringRef2, c.input)
}
}
func TestReferenceDockerReference(t *testing.T) {
for _, c := range validReferenceTestCases {
ref, err := ParseReference(c.input)
require.NoError(t, err, c.input)
dockerRef := ref.DockerReference()
if c.dockerRef != "" {
require.NotNil(t, dockerRef, c.input)
assert.Equal(t, c.dockerRef, dockerRef.String(), c.input)
} else {
require.Nil(t, dockerRef, c.input)
}
}
}
func TestReferencePolicyConfigurationIdentity(t *testing.T) {
for _, c := range validReferenceTestCases {
ref, err := ParseReference(c.input)
require.NoError(t, err, c.input)
assert.Equal(t, "", ref.PolicyConfigurationIdentity(), c.input)
}
}
func TestReferencePolicyConfigurationNamespaces(t *testing.T) {
for _, c := range validReferenceTestCases {
ref, err := ParseReference(c.input)
require.NoError(t, err, c.input)
assert.Empty(t, "", ref.PolicyConfigurationNamespaces(), c.input)
}
}
func TestReferenceNewImage(t *testing.T) {
for _, suffix := range []string{"", ":emptyimage:latest", ":@0"} {
ref, err := ParseReference(tarFixture + suffix)
require.NoError(t, err, suffix)
img, err := ref.NewImage(context.Background(), nil)
require.NoError(t, err, suffix)
defer img.Close()
}
}
func TestReferenceNewImageSource(t *testing.T) {
for _, suffix := range []string{"", ":emptyimage:latest", ":@0"} {
ref, err := ParseReference(tarFixture + suffix)
require.NoError(t, err, suffix)
src, err := ref.NewImageSource(context.Background(), nil)
require.NoError(t, err, suffix)
defer src.Close()
}
}
func TestReferenceNewImageDestination(t *testing.T) {
tmpDir := t.TempDir()
ref, err := ParseReference(filepath.Join(tmpDir, "no-reference"))
require.NoError(t, err)
dest, err := ref.NewImageDestination(context.Background(), nil)
assert.NoError(t, err)
dest.Close()
ref, err = ParseReference(filepath.Join(tmpDir, "with-reference") + "busybox:latest")
require.NoError(t, err)
dest, err = ref.NewImageDestination(context.Background(), nil)
assert.NoError(t, err)
defer dest.Close()
}
func TestReferenceDeleteImage(t *testing.T) {
tmpDir := t.TempDir()
for i, suffix := range []string{"", ":some-reference", ":@0"} {
testFile := filepath.Join(tmpDir, fmt.Sprintf("file%d.tar", i))
err := os.WriteFile(testFile, []byte("nonempty"), 0644)
require.NoError(t, err, suffix)
ref, err := ParseReference(testFile + suffix)
require.NoError(t, err, suffix)
err = ref.DeleteImage(context.Background(), nil)
assert.Error(t, err, suffix)
_, err = os.Lstat(testFile)
assert.NoError(t, err, suffix)
}
}
|
