1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
|
package docker
import (
"bufio"
"bytes"
"errors"
"net/http"
"testing"
"github.com/docker/distribution/registry/api/errcode"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
// NOTE: This test records expected text strings, but NEITHER the returned error types
// NOR the error texts are an API commitment subject to API stability expectations;
// they can change at any time for any reason.
func TestRegistryHTTPResponseToError(t *testing.T) {
for _, c := range []struct {
name string
response string
errorString string
errorType interface{} // A value of the same type as the expected error, or nil
unwrappedErrorPtr interface{} // A pointer to a value expected to be reachable using errors.As, or nil
}{
{
name: "HTTP status out of registry error range",
response: "HTTP/1.1 333 HTTP status out of range\r\n" +
"Header1: Value1\r\n" +
"\r\n" +
"Body of the request\r\n",
errorString: "received unexpected HTTP status: 333 HTTP status out of range",
errorType: &unexpectedHTTPStatusError{},
},
{
name: "HTTP body not in expected format",
response: "HTTP/1.1 400 I don't like this request\r\n" +
"Header1: Value1\r\n" +
"\r\n" +
"<html><body>JSON? What JSON?</body></html>\r\n",
errorString: "StatusCode: 400, <html><body>JSON? What JSON?</body></html>\r\n",
errorType: nil,
unwrappedErrorPtr: nil,
},
{
name: "401 body not in expected format",
response: "HTTP/1.1 401 I don't like this request\r\n" +
"Header1: Value1\r\n" +
"\r\n" +
"<html><body>JSON? What JSON?</body></html>\r\n",
errorString: "unauthorized: authentication required",
errorType: errcode.Error{},
unwrappedErrorPtr: nil,
},
{ // docker.io when an image is not found
name: "GET https://registry-1.docker.io/v2/library/this-does-not-exist/manifests/latest",
response: "HTTP/1.1 401 Unauthorized\r\n" +
"Connection: close\r\n" +
"Content-Length: 170\r\n" +
"Content-Type: application/json\r\n" +
"Date: Thu, 12 Aug 2021 20:11:01 GMT\r\n" +
"Docker-Distribution-Api-Version: registry/2.0\r\n" +
"Strict-Transport-Security: max-age=31536000\r\n" +
"Www-Authenticate: Bearer realm=\"https://auth.docker.io/token\",service=\"registry.docker.io\",scope=\"repository:library/this-does-not-exist:pull\",error=\"insufficient_scope\"\r\n" +
"\r\n" +
"{\"errors\":[{\"code\":\"UNAUTHORIZED\",\"message\":\"authentication required\",\"detail\":[{\"Type\":\"repository\",\"Class\":\"\",\"Name\":\"library/this-does-not-exist\",\"Action\":\"pull\"}]}]}\n",
errorString: "errors:\ndenied: requested access to the resource is denied\nunauthorized: authentication required\n",
errorType: errcode.Errors{},
unwrappedErrorPtr: nil,
},
{ // docker.io when a tag is not found
name: "GET https://registry-1.docker.io/v2/library/busybox/manifests/this-does-not-exist",
response: "HTTP/1.1 404 Not Found\r\n" +
"Connection: close\r\n" +
"Content-Length: 109\r\n" +
"Content-Type: application/json\r\n" +
"Date: Thu, 12 Aug 2021 20:51:32 GMT\r\n" +
"Docker-Distribution-Api-Version: registry/2.0\r\n" +
"Ratelimit-Limit: 100;w=21600\r\n" +
"Ratelimit-Remaining: 100;w=21600\r\n" +
"Strict-Transport-Security: max-age=31536000\r\n" +
"\r\n" +
"{\"errors\":[{\"code\":\"MANIFEST_UNKNOWN\",\"message\":\"manifest unknown\",\"detail\":{\"Tag\":\"this-does-not-exist\"}}]}\n",
errorString: "manifest unknown: manifest unknown",
errorType: errcode.Errors{},
unwrappedErrorPtr: nil,
},
{ // public.ecr.aws does not implement tag list
name: "GET https://public.ecr.aws/v2/nginx/nginx/tags/list",
response: "HTTP/1.1 404 Not Found\r\n" +
"Connection: close\r\n" +
"Content-Length: 19\r\n" +
"Content-Type: text/plain; charset=utf-8\r\n" +
"Date: Thu, 12 Aug 2021 19:54:58 GMT\r\n" +
"Docker-Distribution-Api-Version: registry/2.0\r\n" +
"X-Content-Type-Options: nosniff\r\n" +
"\r\n" +
"404 page not found\n",
errorString: "StatusCode: 404, 404 page not found\n",
errorType: nil,
unwrappedErrorPtr: nil,
},
} {
res, err := http.ReadResponse(bufio.NewReader(bytes.NewReader([]byte(c.response))), nil)
require.NoError(t, err, c.name)
err = registryHTTPResponseToError(res)
assert.Equal(t, c.errorString, err.Error(), c.name)
if c.errorType != nil {
assert.IsType(t, c.errorType, err, c.name)
}
if c.unwrappedErrorPtr != nil {
found := errors.As(err, c.unwrappedErrorPtr)
assert.True(t, found, c.name)
}
}
}
|
