1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733
|
package image
import (
"bytes"
"context"
"encoding/json"
"errors"
"io"
"os"
"path/filepath"
"testing"
"time"
"github.com/containers/image/v5/docker/reference"
"github.com/containers/image/v5/internal/testing/mocks"
"github.com/containers/image/v5/manifest"
"github.com/containers/image/v5/types"
"github.com/opencontainers/go-digest"
imgspecv1 "github.com/opencontainers/image-spec/specs-go/v1"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"golang.org/x/exp/slices"
)
func manifestOCI1FromFixture(t *testing.T, src types.ImageSource, fixture string) genericManifest {
manifest, err := os.ReadFile(filepath.Join("fixtures", fixture))
require.NoError(t, err)
m, err := manifestOCI1FromManifest(src, manifest)
require.NoError(t, err)
return m
}
var layerDescriptorsLikeFixture = []imgspecv1.Descriptor{
{
MediaType: imgspecv1.MediaTypeImageLayerGzip,
Digest: "sha256:6a5a5368e0c2d3e5909184fa28ddfd56072e7ff3ee9a945876f7eee5896ef5bb",
Size: 51354364,
},
{
MediaType: imgspecv1.MediaTypeImageLayerGzip,
Digest: "sha256:1bbf5d58d24c47512e234a5623474acf65ae00d4d1414272a893204f44cc680c",
Size: 150,
},
{
MediaType: imgspecv1.MediaTypeImageLayerGzip,
Digest: "sha256:8f5dc8a4b12c307ac84de90cdd9a7f3915d1be04c9388868ca118831099c67a9",
Size: 11739507,
URLs: []string{
"https://layer.url",
},
},
{
MediaType: imgspecv1.MediaTypeImageLayerGzip,
Digest: "sha256:bbd6b22eb11afce63cc76f6bc41042d99f10d6024c96b655dafba930b8d25909",
Size: 8841833,
Annotations: map[string]string{
"test-annotation-2": "two",
},
},
{
MediaType: imgspecv1.MediaTypeImageLayerGzip,
Digest: "sha256:960e52ecf8200cbd84e70eb2ad8678f4367e50d14357021872c10fa3fc5935fa",
Size: 291,
},
}
func manifestOCI1FromComponentsLikeFixture(configBlob []byte) genericManifest {
return manifestOCI1FromComponents(imgspecv1.Descriptor{
MediaType: imgspecv1.MediaTypeImageConfig,
Size: 5940,
Digest: commonFixtureConfigDigest,
Annotations: map[string]string{
"test-annotation-1": "one",
},
}, nil, configBlob, layerDescriptorsLikeFixture)
}
func manifestOCI1FromComponentsWithExtraConfigFields(t *testing.T, src types.ImageSource) genericManifest {
configJSON, err := os.ReadFile("fixtures/oci1-config-extra-fields.json")
require.NoError(t, err)
return manifestOCI1FromComponents(imgspecv1.Descriptor{
MediaType: imgspecv1.MediaTypeImageConfig,
Size: 7693,
Digest: "sha256:7f2a783ee2f07826b1856e68a40c930cd0430d6e7d4a88c29c2c8b7718706e74",
Annotations: map[string]string{
"test-annotation-1": "one",
},
}, src, configJSON, layerDescriptorsLikeFixture)
}
func TestManifestOCI1FromManifest(t *testing.T) {
// This just tests that the JSON can be loaded; we test that the parsed
// values are correctly returned in tests for the individual getter methods.
_ = manifestOCI1FromFixture(t, mocks.ForbiddenImageSource{}, "oci1.json")
_, err := manifestOCI1FromManifest(nil, []byte{})
assert.Error(t, err)
}
func TestManifestOCI1FromComponents(t *testing.T) {
// This just smoke-tests that the manifest can be created; we test that the parsed
// values are correctly returned in tests for the individual getter methods.
_ = manifestOCI1FromComponentsLikeFixture(nil)
}
func TestManifestOCI1Serialize(t *testing.T) {
for _, m := range []genericManifest{
manifestOCI1FromFixture(t, mocks.ForbiddenImageSource{}, "oci1.json"),
manifestOCI1FromComponentsLikeFixture(nil),
} {
serialized, err := m.serialize()
require.NoError(t, err)
// We would ideally like to compare “serialized” with some transformation of
// the original fixture, but the ordering of fields in JSON maps is undefined, so this is
// easier.
assertJSONEqualsFixture(t, serialized, "oci1.json")
}
}
func TestManifestOCI1ManifestMIMEType(t *testing.T) {
for _, m := range []genericManifest{
manifestOCI1FromFixture(t, mocks.ForbiddenImageSource{}, "oci1.json"),
manifestOCI1FromComponentsLikeFixture(nil),
} {
assert.Equal(t, imgspecv1.MediaTypeImageManifest, m.manifestMIMEType())
}
}
func TestManifestOCI1ConfigInfo(t *testing.T) {
for _, m := range []genericManifest{
manifestOCI1FromFixture(t, mocks.ForbiddenImageSource{}, "oci1.json"),
manifestOCI1FromComponentsLikeFixture(nil),
} {
assert.Equal(t, types.BlobInfo{
Size: 5940,
Digest: commonFixtureConfigDigest,
Annotations: map[string]string{
"test-annotation-1": "one",
},
MediaType: "application/vnd.oci.image.config.v1+json",
}, m.ConfigInfo())
}
}
func TestManifestOCI1ConfigBlob(t *testing.T) {
realConfigJSON, err := os.ReadFile("fixtures/oci1-config.json")
require.NoError(t, err)
for _, c := range []struct {
cbISfn func() (io.ReadCloser, int64, error)
blob []byte
}{
// Success
{func() (io.ReadCloser, int64, error) {
return io.NopCloser(bytes.NewReader(realConfigJSON)), int64(len(realConfigJSON)), nil
}, realConfigJSON},
// Various kinds of failures
{nil, nil},
{func() (io.ReadCloser, int64, error) {
return nil, -1, errors.New("Error returned from GetBlob")
}, nil},
{func() (io.ReadCloser, int64, error) {
reader, writer := io.Pipe()
err = writer.CloseWithError(errors.New("Expected error reading input in ConfigBlob"))
require.NoError(t, err)
return reader, 1, nil
}, nil},
{func() (io.ReadCloser, int64, error) {
nonmatchingJSON := []byte("This does not match ConfigDescriptor.Digest")
return io.NopCloser(bytes.NewReader(nonmatchingJSON)), int64(len(nonmatchingJSON)), nil
}, nil},
} {
var src types.ImageSource
if c.cbISfn != nil {
src = configBlobImageSource{
expectedDigest: commonFixtureConfigDigest,
f: c.cbISfn,
}
} else {
src = nil
}
m := manifestOCI1FromFixture(t, src, "oci1.json")
blob, err := m.ConfigBlob(context.Background())
if c.blob != nil {
assert.NoError(t, err)
assert.Equal(t, c.blob, blob)
} else {
assert.Error(t, err)
}
}
// Generally configBlob should match ConfigInfo; we don’t quite need it to, and this will
// guarantee that the returned object is returning the original contents instead
// of reading an object from elsewhere.
configBlob := []byte("config blob which does not match ConfigInfo")
// This just tests that the manifest can be created; we test that the parsed
// values are correctly returned in tests for the individual getter methods.
m := manifestOCI1FromComponentsLikeFixture(configBlob)
cb, err := m.ConfigBlob(context.Background())
require.NoError(t, err)
assert.Equal(t, configBlob, cb)
}
func TestManifestOCI1OCIConfig(t *testing.T) {
// Just a smoke-test that the code can read the data…
configJSON, err := os.ReadFile("fixtures/oci1-config.json")
require.NoError(t, err)
expectedConfig := imgspecv1.Image{}
err = json.Unmarshal(configJSON, &expectedConfig)
require.NoError(t, err)
originalSrc := newOCI1ImageSource(t, "oci1-config.json", "httpd:latest")
for _, m := range []genericManifest{
manifestOCI1FromFixture(t, originalSrc, "oci1.json"),
manifestOCI1FromComponentsLikeFixture(configJSON),
} {
config, err := m.OCIConfig(context.Background())
require.NoError(t, err)
assert.Equal(t, &expectedConfig, config)
}
// “Any extra fields in the Image JSON struct are considered implementation specific
// and MUST NOT generate an error by any implementations which are unable to interpret them.”
// oci1-config-extra-fields.json is the same as oci1-config.json, apart from a few added fields.
srcWithExtraFields := newOCI1ImageSource(t, "oci1-config-extra-fields.json", "httpd:latest")
for _, m := range []genericManifest{
manifestOCI1FromFixture(t, srcWithExtraFields, "oci1-extra-config-fields.json"),
manifestOCI1FromComponentsWithExtraConfigFields(t, srcWithExtraFields),
} {
config, err := m.OCIConfig(context.Background())
require.NoError(t, err)
assert.Equal(t, &expectedConfig, config)
}
// This can share originalSrc because the config digest is the same between oci1-artifact.json and oci1.json
artifact := manifestOCI1FromFixture(t, originalSrc, "oci1-artifact.json")
_, err = artifact.OCIConfig(context.Background())
var expected manifest.NonImageArtifactError
assert.ErrorAs(t, err, &expected)
}
func TestManifestOCI1LayerInfo(t *testing.T) {
for _, m := range []genericManifest{
manifestOCI1FromFixture(t, mocks.ForbiddenImageSource{}, "oci1.json"),
manifestOCI1FromComponentsLikeFixture(nil),
} {
assert.Equal(t, []types.BlobInfo{
{
Digest: "sha256:6a5a5368e0c2d3e5909184fa28ddfd56072e7ff3ee9a945876f7eee5896ef5bb",
Size: 51354364,
MediaType: imgspecv1.MediaTypeImageLayerGzip,
},
{
Digest: "sha256:1bbf5d58d24c47512e234a5623474acf65ae00d4d1414272a893204f44cc680c",
Size: 150,
MediaType: imgspecv1.MediaTypeImageLayerGzip,
},
{
Digest: "sha256:8f5dc8a4b12c307ac84de90cdd9a7f3915d1be04c9388868ca118831099c67a9",
Size: 11739507,
URLs: []string{
"https://layer.url",
},
MediaType: imgspecv1.MediaTypeImageLayerGzip,
},
{
Digest: "sha256:bbd6b22eb11afce63cc76f6bc41042d99f10d6024c96b655dafba930b8d25909",
Size: 8841833,
Annotations: map[string]string{
"test-annotation-2": "two",
},
MediaType: imgspecv1.MediaTypeImageLayerGzip,
},
{
Digest: "sha256:960e52ecf8200cbd84e70eb2ad8678f4367e50d14357021872c10fa3fc5935fa",
Size: 291,
MediaType: imgspecv1.MediaTypeImageLayerGzip,
},
}, m.LayerInfos())
}
}
func TestManifestOCI1EmbeddedDockerReferenceConflicts(t *testing.T) {
for _, m := range []genericManifest{
manifestOCI1FromFixture(t, mocks.ForbiddenImageSource{}, "oci1.json"),
manifestOCI1FromComponentsLikeFixture(nil),
} {
for _, name := range []string{"busybox", "example.com:5555/ns/repo:tag"} {
ref, err := reference.ParseNormalizedNamed(name)
require.NoError(t, err)
conflicts := m.EmbeddedDockerReferenceConflicts(ref)
assert.False(t, conflicts)
}
}
}
func TestManifestOCI1Inspect(t *testing.T) {
var emptyAnnotations map[string]string
created := time.Date(2016, 9, 23, 23, 20, 45, 789764590, time.UTC)
configJSON, err := os.ReadFile("fixtures/oci1-config.json")
require.NoError(t, err)
for _, m := range []genericManifest{
manifestOCI1FromComponentsLikeFixture(configJSON),
// “Any extra fields in the Image JSON struct are considered implementation specific
// and MUST NOT generate an error by any implementations which are unable to interpret them.”
// oci1-config-extra-fields.json is the same as oci1-config.json, apart from a few added fields.
manifestOCI1FromComponentsWithExtraConfigFields(t, nil),
} {
ii, err := m.Inspect(context.Background())
require.NoError(t, err)
assert.Equal(t, types.ImageInspectInfo{
Tag: "",
Created: &created,
DockerVersion: "1.12.1",
Labels: map[string]string{},
Architecture: "amd64",
Os: "linux",
Layers: []string{
"sha256:6a5a5368e0c2d3e5909184fa28ddfd56072e7ff3ee9a945876f7eee5896ef5bb",
"sha256:1bbf5d58d24c47512e234a5623474acf65ae00d4d1414272a893204f44cc680c",
"sha256:8f5dc8a4b12c307ac84de90cdd9a7f3915d1be04c9388868ca118831099c67a9",
"sha256:bbd6b22eb11afce63cc76f6bc41042d99f10d6024c96b655dafba930b8d25909",
"sha256:960e52ecf8200cbd84e70eb2ad8678f4367e50d14357021872c10fa3fc5935fa",
},
LayersData: []types.ImageInspectLayer{{
MIMEType: "application/vnd.oci.image.layer.v1.tar+gzip",
Digest: "sha256:6a5a5368e0c2d3e5909184fa28ddfd56072e7ff3ee9a945876f7eee5896ef5bb",
Size: 51354364,
Annotations: emptyAnnotations,
}, {
MIMEType: "application/vnd.oci.image.layer.v1.tar+gzip",
Digest: "sha256:1bbf5d58d24c47512e234a5623474acf65ae00d4d1414272a893204f44cc680c",
Size: 150,
Annotations: emptyAnnotations,
}, {
MIMEType: "application/vnd.oci.image.layer.v1.tar+gzip",
Digest: "sha256:8f5dc8a4b12c307ac84de90cdd9a7f3915d1be04c9388868ca118831099c67a9",
Size: 11739507,
Annotations: emptyAnnotations,
}, {
MIMEType: "application/vnd.oci.image.layer.v1.tar+gzip",
Digest: "sha256:bbd6b22eb11afce63cc76f6bc41042d99f10d6024c96b655dafba930b8d25909",
Size: 8841833,
Annotations: map[string]string{"test-annotation-2": "two"},
}, {
MIMEType: "application/vnd.oci.image.layer.v1.tar+gzip",
Digest: "sha256:960e52ecf8200cbd84e70eb2ad8678f4367e50d14357021872c10fa3fc5935fa",
Size: 291,
Annotations: emptyAnnotations,
},
},
Author: "",
Env: []string{
"PATH=/usr/local/apache2/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
"HTTPD_PREFIX=/usr/local/apache2",
"HTTPD_VERSION=2.4.23",
"HTTPD_SHA1=5101be34ac4a509b245adb70a56690a84fcc4e7f",
"HTTPD_BZ2_URL=https://www.apache.org/dyn/closer.cgi?action=download&filename=httpd/httpd-2.4.23.tar.bz2",
"HTTPD_ASC_URL=https://www.apache.org/dist/httpd/httpd-2.4.23.tar.bz2.asc",
},
}, *ii)
}
// nil configBlob will trigger an error in m.ConfigBlob()
m := manifestOCI1FromComponentsLikeFixture(nil)
_, err = m.Inspect(context.Background())
assert.Error(t, err)
m = manifestOCI1FromComponentsLikeFixture([]byte("invalid JSON"))
_, err = m.Inspect(context.Background())
assert.Error(t, err)
}
func TestManifestOCI1UpdatedImageNeedsLayerDiffIDs(t *testing.T) {
for _, m := range []genericManifest{
manifestOCI1FromFixture(t, mocks.ForbiddenImageSource{}, "oci1.json"),
manifestOCI1FromComponentsLikeFixture(nil),
} {
assert.False(t, m.UpdatedImageNeedsLayerDiffIDs(types.ManifestUpdateOptions{
ManifestMIMEType: manifest.DockerV2Schema2MediaType,
}))
}
}
// oci1ImageSource is plausible enough for schema conversions in manifestOCI1.UpdatedImage() to work.
type oci1ImageSource struct {
configBlobImageSource
ref reference.Named
}
func (OCIis *oci1ImageSource) Reference() types.ImageReference {
return refImageReferenceMock{ref: OCIis.ref}
}
func newOCI1ImageSource(t *testing.T, configFixture string, dockerRef string) *oci1ImageSource {
realConfigJSON, err := os.ReadFile(filepath.Join("fixtures", configFixture))
require.NoError(t, err)
ref, err := reference.ParseNormalizedNamed(dockerRef)
require.NoError(t, err)
return &oci1ImageSource{
configBlobImageSource: configBlobImageSource{
expectedDigest: digest.FromBytes(realConfigJSON),
f: func() (io.ReadCloser, int64, error) {
return io.NopCloser(bytes.NewReader(realConfigJSON)), int64(len(realConfigJSON)), nil
},
},
ref: ref,
}
}
func TestManifestOCI1UpdatedImage(t *testing.T) {
originalSrc := newOCI1ImageSource(t, "oci1-config.json", "httpd:latest")
original := manifestOCI1FromFixture(t, originalSrc, "oci1.json")
// LayerInfos:
layerInfos := append(original.LayerInfos()[1:], original.LayerInfos()[0])
res, err := original.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
LayerInfos: layerInfos,
})
require.NoError(t, err)
assert.Equal(t, layerInfos, res.LayerInfos())
_, err = original.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
LayerInfos: append(layerInfos, layerInfos[0]),
})
assert.Error(t, err)
// EmbeddedDockerReference:
// … is ignored
embeddedRef, err := reference.ParseNormalizedNamed("busybox")
require.NoError(t, err)
res, err = original.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
EmbeddedDockerReference: embeddedRef,
})
require.NoError(t, err)
nonEmbeddedRef, err := reference.ParseNormalizedNamed("notbusybox:notlatest")
require.NoError(t, err)
conflicts := res.EmbeddedDockerReferenceConflicts(nonEmbeddedRef)
assert.False(t, conflicts)
// ManifestMIMEType:
// Only smoke-test the valid conversions, detailed tests are below. (This also verifies that “original” is not affected.)
for _, mime := range []string{
manifest.DockerV2Schema2MediaType,
} {
_, err = original.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
ManifestMIMEType: mime,
InformationOnly: types.ManifestUpdateInformation{
Destination: &memoryImageDest{ref: originalSrc.ref},
},
})
assert.NoError(t, err, mime)
}
for _, mime := range []string{
imgspecv1.MediaTypeImageManifest, // This indicates a confused caller, not a no-op.
"this is invalid",
} {
_, err = original.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
ManifestMIMEType: mime,
})
assert.Error(t, err, mime)
}
// m hasn’t been changed:
m2 := manifestOCI1FromFixture(t, originalSrc, "oci1.json")
typedOriginal, ok := original.(*manifestOCI1)
require.True(t, ok)
typedM2, ok := m2.(*manifestOCI1)
require.True(t, ok)
assert.Equal(t, *typedM2, *typedOriginal)
}
func TestManifestOCI1ConvertToManifestSchema1(t *testing.T) {
originalSrc := newOCI1ImageSource(t, "oci1-config.json", "httpd-copy:latest")
original := manifestOCI1FromFixture(t, originalSrc, "oci1.json")
memoryDest := &memoryImageDest{ref: originalSrc.ref}
res, err := original.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
ManifestMIMEType: manifest.DockerV2Schema1SignedMediaType,
InformationOnly: types.ManifestUpdateInformation{
Destination: memoryDest,
},
})
require.NoError(t, err)
convertedJSON, mt, err := res.Manifest(context.Background())
require.NoError(t, err)
assert.Equal(t, manifest.DockerV2Schema1SignedMediaType, mt)
assertJSONEqualsFixture(t, convertedJSON, "oci1-to-schema1.json", "signatures")
assert.Equal(t, GzippedEmptyLayer, memoryDest.storedBlobs[GzippedEmptyLayerDigest])
// Conversion to schema1 together with changing LayerInfos works as expected (which requires
// handling schema1 empty layers):
updatedLayers, updatedLayersCopy := modifiedLayerInfos(t, original.LayerInfos())
res, err = original.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
LayerInfos: updatedLayers,
ManifestMIMEType: manifest.DockerV2Schema1SignedMediaType,
InformationOnly: types.ManifestUpdateInformation{
Destination: memoryDest,
},
})
require.NoError(t, err)
assert.Equal(t, updatedLayersCopy, updatedLayers) // updatedLayers have not been modified in place
convertedJSON, mt, err = res.Manifest(context.Background())
require.NoError(t, err)
assert.Equal(t, manifest.DockerV2Schema1SignedMediaType, mt)
// Layers have been updated as expected
s1Manifest, err := manifestSchema1FromManifest(convertedJSON)
require.NoError(t, err)
assert.Equal(t, []types.BlobInfo{
{Digest: "sha256:6a5a5368e0c2d3e5909184fa28ddfd56072e7ff3ee9a945876f7eee5896ef5ba", Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: "sha256:1bbf5d58d24c47512e234a5623474acf65ae00d4d1414272a893204f44cc680d", Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: "sha256:8f5dc8a4b12c307ac84de90cdd9a7f3915d1be04c9388868ca118831099c67a8", Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: "sha256:bbd6b22eb11afce63cc76f6bc41042d99f10d6024c96b655dafba930b8d25908", Size: -1},
{Digest: "sha256:960e52ecf8200cbd84e70eb2ad8678f4367e50d14357021872c10fa3fc5935fb", Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
}, s1Manifest.LayerInfos())
// This can share originalSrc because the config digest is the same between oci1-artifact.json and oci1.json
artifact := manifestOCI1FromFixture(t, originalSrc, "oci1-artifact.json")
_, err = artifact.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
ManifestMIMEType: manifest.DockerV2Schema1SignedMediaType,
InformationOnly: types.ManifestUpdateInformation{
Destination: memoryDest,
},
})
var expected manifest.NonImageArtifactError
assert.ErrorAs(t, err, &expected)
// Conversion of an encrypted image fails
encrypted := manifestOCI1FromFixture(t, originalSrc, "oci1.encrypted.json")
_, err = encrypted.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
ManifestMIMEType: manifest.DockerV2Schema1SignedMediaType,
InformationOnly: types.ManifestUpdateInformation{
Destination: memoryDest,
},
})
assert.Error(t, err)
// Conversion to schema1 with encryption fails
_, err = original.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
LayerInfos: layerInfosWithCryptoOperation(original.LayerInfos(), types.Encrypt),
ManifestMIMEType: manifest.DockerV2Schema1SignedMediaType,
InformationOnly: types.ManifestUpdateInformation{
Destination: memoryDest,
},
})
assert.Error(t, err)
// Conversion to schema1 with simultaneous decryption is possible
updatedLayers = layerInfosWithCryptoOperation(encrypted.LayerInfos(), types.Decrypt)
updatedLayersCopy = slices.Clone(updatedLayers)
res, err = encrypted.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
LayerInfos: updatedLayers,
ManifestMIMEType: manifest.DockerV2Schema1SignedMediaType,
InformationOnly: types.ManifestUpdateInformation{
Destination: memoryDest,
},
})
require.NoError(t, err)
assert.Equal(t, updatedLayersCopy, updatedLayers) // updatedLayers have not been modified in place
convertedJSON, mt, err = res.Manifest(context.Background())
require.NoError(t, err)
assert.Equal(t, manifest.DockerV2Schema1SignedMediaType, mt)
// Layers have been updated as expected
s1Manifest, err = manifestSchema1FromManifest(convertedJSON)
require.NoError(t, err)
assert.Equal(t, []types.BlobInfo{
{Digest: "sha256:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: "sha256:bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb", Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: "sha256:cccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc", Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: "sha256:dddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd", Size: -1},
{Digest: "sha256:eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee", Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
{Digest: GzippedEmptyLayerDigest, Size: -1},
}, s1Manifest.LayerInfos())
// encrypted = the source Image implementation hasn’t been changed by the edits involved in the decrypt+convert+update
encrypted2 := manifestOCI1FromFixture(t, originalSrc, "oci1.encrypted.json")
typedEncrypted, ok := encrypted.(*manifestOCI1)
require.True(t, ok)
typedEncrypted2, ok := encrypted2.(*manifestOCI1)
require.True(t, ok)
assert.Equal(t, *typedEncrypted2, *typedEncrypted)
// FIXME? Test also the other failure cases, if only to see that we don't crash?
}
func TestConvertToManifestSchema2(t *testing.T) {
originalSrc := newOCI1ImageSource(t, "oci1-config.json", "httpd-copy:latest")
original := manifestOCI1FromFixture(t, originalSrc, "oci1.json")
res, err := original.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
ManifestMIMEType: manifest.DockerV2Schema2MediaType,
})
require.NoError(t, err)
convertedJSON, mt, err := res.Manifest(context.Background())
require.NoError(t, err)
assert.Equal(t, manifest.DockerV2Schema2MediaType, mt)
assertJSONEqualsFixture(t, convertedJSON, "oci1-to-schema2.json")
convertedConfig, err := res.ConfigBlob(context.Background())
require.NoError(t, err)
assertJSONEqualsFixture(t, convertedConfig, "oci1-to-schema2-config.json")
// This can share originalSrc because the config digest is the same between oci1-artifact.json and oci1.json
artifact := manifestOCI1FromFixture(t, originalSrc, "oci1-artifact.json")
_, err = artifact.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
ManifestMIMEType: manifest.DockerV2Schema2MediaType,
})
var expected manifest.NonImageArtifactError
assert.ErrorAs(t, err, &expected)
// Conversion of an encrypted image fails
encrypted := manifestOCI1FromFixture(t, originalSrc, "oci1.encrypted.json")
_, err = encrypted.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
ManifestMIMEType: manifest.DockerV2Schema2MediaType,
})
assert.Error(t, err)
// Conversion to schema2 with encryption fails
_, err = original.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
LayerInfos: layerInfosWithCryptoOperation(original.LayerInfos(), types.Encrypt),
ManifestMIMEType: manifest.DockerV2Schema2MediaType,
})
assert.Error(t, err)
// Conversion to schema2 with simultaneous decryption is possible
updatedLayers := layerInfosWithCryptoOperation(encrypted.LayerInfos(), types.Decrypt)
updatedLayersCopy := slices.Clone(updatedLayers)
res, err = encrypted.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
LayerInfos: updatedLayers,
ManifestMIMEType: manifest.DockerV2Schema2MediaType,
})
require.NoError(t, err)
assert.Equal(t, updatedLayersCopy, updatedLayers) // updatedLayers have not been modified in place
convertedJSON, mt, err = res.Manifest(context.Background())
require.NoError(t, err)
assert.Equal(t, manifest.DockerV2Schema2MediaType, mt)
s2Manifest, err := manifestSchema2FromManifest(originalSrc, convertedJSON)
require.NoError(t, err)
assert.Equal(t, []types.BlobInfo{
{
Digest: "sha256:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
Size: 51354364,
MediaType: "application/vnd.docker.image.rootfs.diff.tar.gzip",
},
{
Digest: "sha256:bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb",
Size: 150,
MediaType: "application/vnd.docker.image.rootfs.diff.tar.gzip",
},
{
Digest: "sha256:cccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc",
Size: 11739507,
MediaType: "application/vnd.docker.image.rootfs.diff.tar.gzip",
URLs: []string{"https://layer.url"},
},
{
Digest: "sha256:dddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd",
Size: 8841833,
MediaType: "application/vnd.docker.image.rootfs.diff.tar.gzip",
},
{
Digest: "sha256:eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee",
Size: 291,
MediaType: "application/vnd.docker.image.rootfs.diff.tar.gzip",
},
}, s2Manifest.LayerInfos())
convertedConfig, err = res.ConfigBlob(context.Background())
require.NoError(t, err)
assertJSONEqualsFixture(t, convertedConfig, "oci1-to-schema2-config.json")
// encrypted = the source Image implementation hasn’t been changed by the edits involved in the decrypt+convert+update
encrypted2 := manifestOCI1FromFixture(t, originalSrc, "oci1.encrypted.json")
typedEncrypted, ok := encrypted.(*manifestOCI1)
require.True(t, ok)
typedEncrypted2, ok := encrypted2.(*manifestOCI1)
require.True(t, ok)
assert.Equal(t, *typedEncrypted2, *typedEncrypted)
// FIXME? Test also the other failure cases, if only to see that we don't crash?
}
func TestConvertToManifestSchema2AllMediaTypes(t *testing.T) {
originalSrc := newOCI1ImageSource(t, "oci1-config.json", "httpd-copy:latest")
original := manifestOCI1FromFixture(t, originalSrc, "oci1-all-media-types.json")
_, err := original.UpdatedImage(context.Background(), types.ManifestUpdateOptions{
ManifestMIMEType: manifest.DockerV2Schema2MediaType,
})
require.Error(t, err) // zstd compression is not supported for docker images
}
func TestConvertToV2S2WithInvalidMIMEType(t *testing.T) {
originalSrc := newOCI1ImageSource(t, "oci1-config.json", "httpd-copy:latest")
manifest, err := os.ReadFile(filepath.Join("fixtures", "oci1-invalid-media-type.json"))
require.NoError(t, err)
_, err = manifestOCI1FromManifest(originalSrc, manifest)
require.NoError(t, err)
}
func TestManifestOCI1CanChangeLayerCompression(t *testing.T) {
for _, m := range []genericManifest{
manifestOCI1FromFixture(t, mocks.ForbiddenImageSource{}, "oci1.json"),
manifestOCI1FromComponentsLikeFixture(nil),
} {
assert.True(t, m.CanChangeLayerCompression(imgspecv1.MediaTypeImageLayerGzip))
// Some projects like to use squashfs and other unspecified formats for layers; don’t touch those.
assert.False(t, m.CanChangeLayerCompression("a completely unknown and quite possibly invalid MIME type"))
}
artifact := manifestOCI1FromFixture(t, mocks.ForbiddenImageSource{}, "oci1-artifact.json")
assert.False(t, artifact.CanChangeLayerCompression(imgspecv1.MediaTypeImageLayerGzip))
}
|