1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
|
package manifest
import (
"fmt"
"os"
"path/filepath"
"testing"
"github.com/containers/image/v5/types"
"github.com/opencontainers/go-digest"
imgspecv1 "github.com/opencontainers/image-spec/specs-go/v1"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func pare(m List) {
if impl, ok := m.(*OCI1Index); ok {
impl.Annotations = nil
}
if impl, ok := m.(*Schema2List); ok {
for i := range impl.Manifests {
impl.Manifests[i].Platform.Features = nil
}
}
}
func TestParseLists(t *testing.T) {
cases := []struct {
path string
mimeType string
}{
{"ociv1.image.index.json", imgspecv1.MediaTypeImageIndex},
{"v2list.manifest.json", DockerV2ListMediaType},
}
for _, c := range cases {
manifest, err := os.ReadFile(filepath.Join("testdata", c.path))
require.NoError(t, err, "error reading file %q", filepath.Join("testdata", c.path))
assert.Equal(t, GuessMIMEType(manifest), c.mimeType)
// c/image/manifest.TestParseLists verifies that FromBlob refuses to parse the manifest list
m, err := ListFromBlob(manifest, c.mimeType)
require.NoError(t, err, "manifest list %q should parse as list types", c.path)
assert.Equal(t, m.MIMEType(), c.mimeType, "manifest %q is not of the expected MIME type", c.path)
clone := m.Clone()
assert.Equal(t, clone, m, "manifest %q is missing some fields after being cloned", c.path)
pare(m)
index, err := m.ConvertToMIMEType(imgspecv1.MediaTypeImageIndex)
require.NoError(t, err, "error converting %q to an OCI1Index", c.path)
list, err := m.ConvertToMIMEType(DockerV2ListMediaType)
require.NoError(t, err, "error converting %q to an Schema2List", c.path)
index2, err := list.ConvertToMIMEType(imgspecv1.MediaTypeImageIndex)
require.NoError(t, err)
assert.Equal(t, index, index2, "index %q lost data in conversion", c.path)
list2, err := index.ConvertToMIMEType(DockerV2ListMediaType)
require.NoError(t, err)
assert.Equal(t, list, list2, "list %q lost data in conversion", c.path)
}
}
func TestChooseInstance(t *testing.T) {
type expectedMatch struct {
arch, variant string
instanceDigest digest.Digest
}
chooseInstanceCalls := []func(sys *types.SystemContext, rawManifest []byte) (digest.Digest, error){
func(sys *types.SystemContext, rawManifest []byte) (digest.Digest, error) {
list, err := ListPublicFromBlob(rawManifest, GuessMIMEType(rawManifest))
require.NoError(t, err)
return list.ChooseInstance(sys)
},
// Gzip preference true.
func(sys *types.SystemContext, rawManifest []byte) (digest.Digest, error) {
list, err := ListFromBlob(rawManifest, GuessMIMEType(rawManifest))
require.NoError(t, err)
return list.ChooseInstanceByCompression(sys, types.OptionalBoolTrue)
},
// Gzip preference false.
func(sys *types.SystemContext, rawManifest []byte) (digest.Digest, error) {
list, err := ListFromBlob(rawManifest, GuessMIMEType(rawManifest))
require.NoError(t, err)
return list.ChooseInstanceByCompression(sys, types.OptionalBoolFalse)
},
func(sys *types.SystemContext, rawManifest []byte) (digest.Digest, error) {
list, err := ListFromBlob(rawManifest, GuessMIMEType(rawManifest))
require.NoError(t, err)
return list.ChooseInstanceByCompression(sys, types.OptionalBoolUndefined)
},
}
for _, manifestList := range []struct {
listFile string
matchedInstances []expectedMatch
unmatchedInstances []string
}{
{
listFile: "schema2list.json",
matchedInstances: []expectedMatch{
{"amd64", "", "sha256:030fcb92e1487b18c974784dcc110a93147c9fc402188370fbfd17efabffc6af"},
{"s390x", "", "sha256:e5aa1b0a24620228b75382997a0977f609b3ca3a95533dafdef84c74cc8df642"},
{"arm", "v7", "sha256:b5dbad4bdb4444d919294afe49a095c23e86782f98cdf0aa286198ddb814b50b"},
{"arm64", "", "sha256:dc472a59fb006797aa2a6bfb54cc9c57959bb0a6d11fadaa608df8c16dea39cf"},
},
unmatchedInstances: []string{
"unmatched",
},
},
{ // Focus on ARM variant field testing
listFile: "schema2list-variants.json",
matchedInstances: []expectedMatch{
{"amd64", "", "sha256:59eec8837a4d942cc19a52b8c09ea75121acc38114a2c68b98983ce9356b8610"},
{"arm", "v7", "sha256:f365626a556e58189fc21d099fc64603db0f440bff07f77c740989515c544a39"},
{"arm", "v6", "sha256:f365626a556e58189fc21d099fc64603db0f440bff07f77c740989515c544a39"},
{"arm", "v5", "sha256:c84b0a3a07b628bc4d62e5047d0f8dff80f7c00979e1e28a821a033ecda8fe53"},
{"arm", "", "sha256:c84b0a3a07b628bc4d62e5047d0f8dff80f7c00979e1e28a821a033ecda8fe53"},
{"arm", "unrecognized-present", "sha256:bcf9771c0b505e68c65440474179592ffdfa98790eb54ffbf129969c5e429990"},
{"arm", "unrecognized-not-present", "sha256:c84b0a3a07b628bc4d62e5047d0f8dff80f7c00979e1e28a821a033ecda8fe53"},
},
unmatchedInstances: []string{
"unmatched",
},
},
{
listFile: "oci1index.json",
matchedInstances: []expectedMatch{
{"amd64", "", "sha256:5b0bcabd1ed22e9fb1310cf6c2dec7cdef19f0ad69efa1f392e94a4333501270"},
{"ppc64le", "", "sha256:e692418e4cbaf90ca69d05a66403747baa33ee08806650b51fab815ad7fc331f"},
},
unmatchedInstances: []string{
"unmatched",
},
},
} {
rawManifest, err := os.ReadFile(filepath.Join("testdata", manifestList.listFile))
require.NoError(t, err)
for _, chooseInstance := range chooseInstanceCalls {
for _, match := range manifestList.matchedInstances {
testName := fmt.Sprintf("%s %q+%q", manifestList.listFile, match.arch, match.variant)
digest, err := chooseInstance(&types.SystemContext{
ArchitectureChoice: match.arch,
VariantChoice: match.variant,
OSChoice: "linux",
}, rawManifest)
require.NoError(t, err, testName)
assert.Equal(t, match.instanceDigest, digest, testName)
}
for _, arch := range manifestList.unmatchedInstances {
_, err := chooseInstance(&types.SystemContext{
ArchitectureChoice: arch,
OSChoice: "linux",
}, rawManifest)
assert.Error(t, err)
}
}
}
}
|
