1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
|
package layout
import (
"bytes"
"context"
"errors"
"io/fs"
"os"
"path/filepath"
"testing"
"github.com/containers/image/v5/internal/private"
"github.com/containers/image/v5/pkg/blobinfocache/memory"
"github.com/containers/image/v5/types"
digest "github.com/opencontainers/go-digest"
imgspecv1 "github.com/opencontainers/image-spec/specs-go/v1"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
var _ private.ImageDestination = (*ociImageDestination)(nil)
// readerFromFunc allows implementing Reader by any function, e.g. a closure.
type readerFromFunc func([]byte) (int, error)
func (fn readerFromFunc) Read(p []byte) (int, error) {
return fn(p)
}
// TestPutBlobDigestFailure simulates behavior on digest verification failure.
func TestPutBlobDigestFailure(t *testing.T) {
const digestErrorString = "Simulated digest error"
const blobDigest = "sha256:e692418e4cbaf90ca69d05a66403747baa33ee08806650b51fab815ad7fc331f"
ref, _ := refToTempOCI(t)
dirRef, ok := ref.(ociReference)
require.True(t, ok)
blobPath, err := dirRef.blobPath(blobDigest, "")
assert.NoError(t, err)
cache := memory.New()
firstRead := true
reader := readerFromFunc(func(p []byte) (int, error) {
_, err := os.Lstat(blobPath)
require.Error(t, err)
require.True(t, os.IsNotExist(err))
if firstRead {
if len(p) > 0 {
firstRead = false
}
for i := 0; i < len(p); i++ {
p[i] = 0xAA
}
return len(p), nil
}
return 0, errors.New(digestErrorString)
})
dest, err := ref.NewImageDestination(context.Background(), nil)
require.NoError(t, err)
defer dest.Close()
_, err = dest.PutBlob(context.Background(), reader, types.BlobInfo{Digest: blobDigest, Size: -1}, cache, false)
assert.ErrorContains(t, err, digestErrorString)
err = dest.Commit(context.Background(), nil) // nil unparsedToplevel is invalid, we don’t currently use the value
assert.NoError(t, err)
_, err = os.Lstat(blobPath)
require.Error(t, err)
require.True(t, os.IsNotExist(err))
}
// TestPutManifestAppendsToExistingManifest tests that new manifests are getting added to existing index.
func TestPutManifestAppendsToExistingManifest(t *testing.T) {
ref, tmpDir := refToTempOCI(t)
ociRef, ok := ref.(ociReference)
require.True(t, ok)
// initially we have one manifest
index, err := ociRef.getIndex()
assert.NoError(t, err)
assert.Equal(t, 1, len(index.Manifests), "Unexpected number of manifests")
// create a new test reference
ociRef2, err := NewReference(tmpDir, "new-image")
assert.NoError(t, err)
putTestManifest(t, ociRef2.(ociReference), tmpDir)
index, err = ociRef.getIndex()
assert.NoError(t, err)
assert.Equal(t, 2, len(index.Manifests), "Unexpected number of manifests")
}
// TestPutManifestTwice tests that existing manifest gets updated and not appended.
func TestPutManifestTwice(t *testing.T) {
ref, tmpDir := refToTempOCI(t)
ociRef, ok := ref.(ociReference)
require.True(t, ok)
putTestConfig(t, ociRef, tmpDir)
putTestManifest(t, ociRef, tmpDir)
putTestManifest(t, ociRef, tmpDir)
index, err := ociRef.getIndex()
assert.NoError(t, err)
assert.Len(t, index.Manifests, 2, "Unexpected number of manifests")
}
func TestPutTwoDifferentTags(t *testing.T) {
ref, tmpDir := refToTempOCI(t)
ociRef, ok := ref.(ociReference)
require.True(t, ok)
putTestConfig(t, ociRef, tmpDir)
putTestManifest(t, ociRef, tmpDir)
// add the same manifest with a different tag; it shouldn't get overwritten
ref, err := NewReference(tmpDir, "zomg")
assert.NoError(t, err)
ociRef, ok = ref.(ociReference)
require.True(t, ok)
putTestManifest(t, ociRef, tmpDir)
index, err := ociRef.getIndex()
assert.NoError(t, err)
assert.Len(t, index.Manifests, 3, "Unexpected number of manifests")
assert.Equal(t, "imageValue", index.Manifests[1].Annotations[imgspecv1.AnnotationRefName])
assert.Equal(t, "zomg", index.Manifests[2].Annotations[imgspecv1.AnnotationRefName])
}
func putTestConfig(t *testing.T, ociRef ociReference, tmpDir string) {
data, err := os.ReadFile("../../internal/image/fixtures/oci1-config.json")
assert.NoError(t, err)
imageDest, err := newImageDestination(nil, ociRef)
assert.NoError(t, err)
cache := memory.New()
_, err = imageDest.PutBlob(context.Background(), bytes.NewReader(data), types.BlobInfo{Size: int64(len(data)), Digest: digest.FromBytes(data)}, cache, true)
assert.NoError(t, err)
err = imageDest.Commit(context.Background(), nil) // nil unparsedToplevel is invalid, we don’t currently use the value
assert.NoError(t, err)
paths := []string{}
err = filepath.WalkDir(tmpDir, func(path string, _ fs.DirEntry, err error) error {
paths = append(paths, path)
return nil
})
assert.NoError(t, err)
digest := digest.FromBytes(data).Encoded()
assert.Contains(t, paths, filepath.Join(tmpDir, "blobs", "sha256", digest), "The OCI directory does not contain the new config data")
}
func putTestManifest(t *testing.T, ociRef ociReference, tmpDir string) {
data, err := os.ReadFile("../../internal/image/fixtures/oci1.json")
assert.NoError(t, err)
imageDest, err := newImageDestination(nil, ociRef)
assert.NoError(t, err)
err = imageDest.PutManifest(context.Background(), data, nil)
assert.NoError(t, err)
err = imageDest.Commit(context.Background(), nil) // nil unparsedToplevel is invalid, we don’t currently use the value
assert.NoError(t, err)
paths := []string{}
err = filepath.WalkDir(tmpDir, func(path string, _ fs.DirEntry, err error) error {
paths = append(paths, path)
return nil
})
assert.NoError(t, err)
digest := digest.FromBytes(data).Encoded()
assert.Contains(t, paths, filepath.Join(tmpDir, "blobs", "sha256", digest), "The OCI directory does not contain the new manifest data")
}
|
