1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
|
package prioritize
import (
"fmt"
"testing"
"time"
"github.com/containers/image/v5/internal/blobinfocache"
compressiontypes "github.com/containers/image/v5/pkg/compression/types"
"github.com/containers/image/v5/types"
"github.com/opencontainers/go-digest"
"github.com/stretchr/testify/assert"
"golang.org/x/exp/slices"
)
const (
digestUncompressed = digest.Digest("sha256:2222222222222222222222222222222222222222222222222222222222222222")
digestCompressedA = digest.Digest("sha256:3333333333333333333333333333333333333333333333333333333333333333")
digestCompressedB = digest.Digest("sha256:4444444444444444444444444444444444444444444444444444444444444444")
digestCompressedPrimary = digest.Digest("sha256:6666666666666666666666666666666666666666666666666666666666666666")
)
var (
// cssLiteral contains a non-trivial candidateSortState shared among several tests below.
cssLiteral = candidateSortState{
cs: []CandidateWithTime{
{blobinfocache.BICReplacementCandidate2{Digest: digestCompressedA, Location: types.BICLocationReference{Opaque: "A1"}, CompressorName: compressiontypes.XzAlgorithmName}, time.Unix(1, 0)},
{blobinfocache.BICReplacementCandidate2{Digest: digestUncompressed, Location: types.BICLocationReference{Opaque: "U2"}, CompressorName: compressiontypes.GzipAlgorithmName}, time.Unix(1, 1)},
{blobinfocache.BICReplacementCandidate2{Digest: digestCompressedA, Location: types.BICLocationReference{Opaque: "A2"}, CompressorName: blobinfocache.Uncompressed}, time.Unix(1, 1)},
{blobinfocache.BICReplacementCandidate2{Digest: digestCompressedPrimary, Location: types.BICLocationReference{Opaque: "P1"}, CompressorName: blobinfocache.UnknownCompression}, time.Unix(1, 0)},
{blobinfocache.BICReplacementCandidate2{Digest: digestCompressedB, Location: types.BICLocationReference{Opaque: "B1"}, CompressorName: compressiontypes.Bzip2AlgorithmName}, time.Unix(1, 1)},
{blobinfocache.BICReplacementCandidate2{Digest: digestCompressedPrimary, Location: types.BICLocationReference{Opaque: "P2"}, CompressorName: compressiontypes.GzipAlgorithmName}, time.Unix(1, 1)},
{blobinfocache.BICReplacementCandidate2{Digest: digestCompressedB, Location: types.BICLocationReference{Opaque: "B2"}, CompressorName: blobinfocache.Uncompressed}, time.Unix(2, 0)},
{blobinfocache.BICReplacementCandidate2{Digest: digestUncompressed, Location: types.BICLocationReference{Opaque: "U1"}, CompressorName: blobinfocache.UnknownCompression}, time.Unix(1, 0)},
},
primaryDigest: digestCompressedPrimary,
uncompressedDigest: digestUncompressed,
}
// cssExpectedReplacementCandidates is the fully-sorted, unlimited, result of prioritizing cssLiteral.
cssExpectedReplacementCandidates = []blobinfocache.BICReplacementCandidate2{
{Digest: digestCompressedPrimary, Location: types.BICLocationReference{Opaque: "P2"}, CompressorName: compressiontypes.GzipAlgorithmName},
{Digest: digestCompressedPrimary, Location: types.BICLocationReference{Opaque: "P1"}, CompressorName: blobinfocache.UnknownCompression},
{Digest: digestCompressedB, Location: types.BICLocationReference{Opaque: "B2"}, CompressorName: blobinfocache.Uncompressed},
{Digest: digestCompressedA, Location: types.BICLocationReference{Opaque: "A2"}, CompressorName: blobinfocache.Uncompressed},
{Digest: digestCompressedB, Location: types.BICLocationReference{Opaque: "B1"}, CompressorName: compressiontypes.Bzip2AlgorithmName},
{Digest: digestCompressedA, Location: types.BICLocationReference{Opaque: "A1"}, CompressorName: compressiontypes.XzAlgorithmName},
{Digest: digestUncompressed, Location: types.BICLocationReference{Opaque: "U2"}, CompressorName: compressiontypes.GzipAlgorithmName},
{Digest: digestUncompressed, Location: types.BICLocationReference{Opaque: "U1"}, CompressorName: blobinfocache.UnknownCompression},
}
)
func TestCandidateSortStateLen(t *testing.T) {
css := cssLiteral
assert.Equal(t, 8, css.Len())
css.cs = []CandidateWithTime{}
assert.Equal(t, 0, css.Len())
}
func TestCandidateSortStateLess(t *testing.T) {
type p struct {
d digest.Digest
t int64
}
// Primary criteria: Also ensure that time does not matter
for _, c := range []struct {
name string
res int
d0, d1 digest.Digest
}{
{"primary < any", -1, digestCompressedPrimary, digestCompressedA},
{"any < uncompressed", -1, digestCompressedA, digestUncompressed},
{"primary < uncompressed", -1, digestCompressedPrimary, digestUncompressed},
} {
for _, tms := range [][2]int64{{1, 2}, {2, 1}, {1, 1}} {
caseName := fmt.Sprintf("%s %v", c.name, tms)
css := candidateSortState{
cs: []CandidateWithTime{
{blobinfocache.BICReplacementCandidate2{Digest: c.d0, Location: types.BICLocationReference{Opaque: "L0"}, CompressorName: compressiontypes.GzipAlgorithmName}, time.Unix(tms[0], 0)},
{blobinfocache.BICReplacementCandidate2{Digest: c.d1, Location: types.BICLocationReference{Opaque: "L1"}, CompressorName: compressiontypes.ZstdAlgorithmName}, time.Unix(tms[1], 0)},
},
primaryDigest: digestCompressedPrimary,
uncompressedDigest: digestUncompressed,
}
assert.Equal(t, c.res < 0, css.Less(0, 1), caseName)
assert.Equal(t, c.res > 0, css.Less(1, 0), caseName)
if c.d0 != digestUncompressed && c.d1 != digestUncompressed {
css.uncompressedDigest = ""
assert.Equal(t, c.res < 0, css.Less(0, 1), caseName)
assert.Equal(t, c.res > 0, css.Less(1, 0), caseName)
css.uncompressedDigest = css.primaryDigest
assert.Equal(t, c.res < 0, css.Less(0, 1), caseName)
assert.Equal(t, c.res > 0, css.Less(1, 0), caseName)
}
}
}
// Ordering within the three primary groups
for _, c := range []struct {
name string
res int
p0, p1 p
}{
{"primary: t=2 < t=1", -1, p{digestCompressedPrimary, 2}, p{digestCompressedPrimary, 1}},
{"primary: t=1 == t=1", 0, p{digestCompressedPrimary, 1}, p{digestCompressedPrimary, 1}},
{"uncompressed: t=2 < t=1", -1, p{digestUncompressed, 2}, p{digestUncompressed, 1}},
{"uncompressed: t=1 == t=1", 0, p{digestUncompressed, 1}, p{digestUncompressed, 1}},
{"any: t=2 < t=1, [d=A vs. d=B lower-priority]", -1, p{digestCompressedA, 2}, p{digestCompressedB, 1}},
{"any: t=2 < t=1, [d=B vs. d=A lower-priority]", -1, p{digestCompressedB, 2}, p{digestCompressedA, 1}},
{"any: t=2 < t=1, [d=A vs. d=A lower-priority]", -1, p{digestCompressedA, 2}, p{digestCompressedA, 1}},
{"any: t=1 == t=1, d=A < d=B", -1, p{digestCompressedA, 1}, p{digestCompressedB, 1}},
{"any: t=1 == t=1, d=A == d=A", 0, p{digestCompressedA, 1}, p{digestCompressedA, 1}},
} {
css := candidateSortState{
cs: []CandidateWithTime{
{blobinfocache.BICReplacementCandidate2{Digest: c.p0.d, Location: types.BICLocationReference{Opaque: "L0"}, CompressorName: compressiontypes.GzipAlgorithmName}, time.Unix(c.p0.t, 0)},
{blobinfocache.BICReplacementCandidate2{Digest: c.p1.d, Location: types.BICLocationReference{Opaque: "L1"}, CompressorName: compressiontypes.ZstdAlgorithmName}, time.Unix(c.p1.t, 0)},
},
primaryDigest: digestCompressedPrimary,
uncompressedDigest: digestUncompressed,
}
assert.Equal(t, c.res < 0, css.Less(0, 1), c.name)
assert.Equal(t, c.res > 0, css.Less(1, 0), c.name)
if c.p0.d != digestUncompressed && c.p1.d != digestUncompressed {
css.uncompressedDigest = ""
assert.Equal(t, c.res < 0, css.Less(0, 1), c.name)
assert.Equal(t, c.res > 0, css.Less(1, 0), c.name)
css.uncompressedDigest = css.primaryDigest
assert.Equal(t, c.res < 0, css.Less(0, 1), c.name)
assert.Equal(t, c.res > 0, css.Less(1, 0), c.name)
}
}
}
func TestCandidateSortStateSwap(t *testing.T) {
freshCSS := func() candidateSortState { // Return a deep copy of cssLiteral which is safe to modify.
res := cssLiteral
res.cs = slices.Clone(cssLiteral.cs)
return res
}
css := freshCSS()
css.Swap(0, 1)
assert.Equal(t, cssLiteral.cs[1], css.cs[0])
assert.Equal(t, cssLiteral.cs[0], css.cs[1])
assert.Equal(t, cssLiteral.cs[2], css.cs[2])
css = freshCSS()
css.Swap(1, 1)
assert.Equal(t, cssLiteral, css)
}
func TestDestructivelyPrioritizeReplacementCandidatesWithMax(t *testing.T) {
for _, max := range []int{0, 1, replacementAttempts, 100} {
// Just a smoke test; we mostly rely on test coverage in TestCandidateSortStateLess
res := destructivelyPrioritizeReplacementCandidatesWithMax(slices.Clone(cssLiteral.cs), digestCompressedPrimary, digestUncompressed, max)
if max > len(cssExpectedReplacementCandidates) {
max = len(cssExpectedReplacementCandidates)
}
assert.Equal(t, cssExpectedReplacementCandidates[:max], res)
}
}
func TestDestructivelyPrioritizeReplacementCandidates(t *testing.T) {
// Just a smoke test; we mostly rely on test coverage in TestCandidateSortStateLess
res := DestructivelyPrioritizeReplacementCandidates(slices.Clone(cssLiteral.cs), digestCompressedPrimary, digestUncompressed)
assert.Equal(t, cssExpectedReplacementCandidates[:replacementAttempts], res)
}
|
