1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
|
package tlsclientconfig
import (
"crypto/tls"
"crypto/x509"
"crypto/x509/pkix"
"encoding/asn1"
"os"
"testing"
"github.com/containers/image/v5/internal/set"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestSetupCertificates(t *testing.T) {
// Success
tlsc := tls.Config{}
err := SetupCertificates("testdata/full", &tlsc)
require.NoError(t, err)
require.NotNil(t, tlsc.RootCAs)
// SystemCertPool is implemented natively, and .Subjects() does not
// return raw certificates, on some systems (as of Go 1.18,
// Windows, macOS, iOS); so, .Subjects() is deprecated.
// We still use .Subjects() in these tests, because they work
// acceptably even in the native case, and they work fine on Linux,
// which we care about the most.
// For an unknown reason, with Go 1.18, as of Mar 15 2022,
// (golangci-lint) reports staticcheck SA1019 about using
// the deprecated .Subjects() function, but the //lint:ignore
// directives are ineffective (and cause extra warnings about
// pointless lint:ignore directives). So, use the big hammer
// of silencing staticcheck entirely; that should be removed
// as soon as practical.
// On systems where SystemCertPool is not special-cased, RootCAs include SystemCertPool;
// On systems where SystemCertPool is special cased, this compares two empty sets
// and succeeds.
// There isn’t a plausible alternative to calling .Subjects() here.
loadedSubjectBytes := set.New[string]()
// lint:ignore SA1019 Receiving no data for system roots is acceptable.
for _, s := range tlsc.RootCAs.Subjects() { //nolint staticcheck: the lint:ignore directive is somehow not recognized (and causes an extra warning!)
loadedSubjectBytes.Add(string(s))
}
systemCertPool, err := x509.SystemCertPool()
require.NoError(t, err)
// lint:ignore SA1019 Receiving no data for system roots is acceptable.
for _, s := range systemCertPool.Subjects() { //nolint staticcheck: the lint:ignore directive is somehow not recognized (and causes an extra warning!)
ok := loadedSubjectBytes.Contains(string(s))
assert.True(t, ok)
}
// RootCAs include our certificates.
// We could possibly test without .Subjects() this by validating certificates
// signed by our test CAs.
loadedSubjectCNs := set.New[string]()
// lint:ignore SA1019 We only care about non-system roots here.
for _, s := range tlsc.RootCAs.Subjects() { //nolint staticcheck: the lint:ignore directive is somehow not recognized (and causes an extra warning!)
subjectRDN := pkix.RDNSequence{}
rest, err := asn1.Unmarshal(s, &subjectRDN)
require.NoError(t, err)
require.Empty(t, rest)
subject := pkix.Name{}
subject.FillFromRDNSequence(&subjectRDN)
loadedSubjectCNs.Add(subject.CommonName)
}
ok := loadedSubjectCNs.Contains("containers/image test CA certificate 1")
assert.True(t, ok)
ok = loadedSubjectCNs.Contains("containers/image test CA certificate 2")
assert.True(t, ok)
// Certificates include our certificates
require.Len(t, tlsc.Certificates, 2)
names := []string{}
for _, c := range tlsc.Certificates {
require.Len(t, c.Certificate, 1)
parsed, err := x509.ParseCertificate(c.Certificate[0])
require.NoError(t, err)
names = append(names, parsed.Subject.CommonName)
}
assert.ElementsMatch(t, []string{
"containers/image test client certificate 1",
"containers/image test client certificate 2",
}, names)
// Directory does not exist
tlsc = tls.Config{}
err = SetupCertificates("/this/does/not/exist", &tlsc)
require.NoError(t, err)
assert.Equal(t, &tls.Config{}, &tlsc)
// Directory not accessible
unreadableDir := t.TempDir()
defer func() {
_ = os.Chmod(unreadableDir, 0700)
}()
err = os.Chmod(unreadableDir, 000)
require.NoError(t, err)
tlsc = tls.Config{}
err = SetupCertificates(unreadableDir, &tlsc)
assert.NoError(t, err)
assert.Equal(t, &tls.Config{}, &tlsc)
// Other error reading the directory
tlsc = tls.Config{}
err = SetupCertificates("/dev/null/is/not/a/directory", &tlsc)
assert.Error(t, err)
// Unreadable system cert pool untested
// Unreadable CA certificate
tlsc = tls.Config{}
err = SetupCertificates("testdata/unreadable-ca", &tlsc)
assert.NoError(t, err)
assert.Nil(t, tlsc.RootCAs)
// Missing key file
tlsc = tls.Config{}
err = SetupCertificates("testdata/missing-key", &tlsc)
assert.Error(t, err)
// Missing certificate file
tlsc = tls.Config{}
err = SetupCertificates("testdata/missing-cert", &tlsc)
assert.Error(t, err)
// Unreadable key file
tlsc = tls.Config{}
err = SetupCertificates("testdata/unreadable-key", &tlsc)
assert.Error(t, err)
// Unreadable certificate file
tlsc = tls.Config{}
err = SetupCertificates("testdata/unreadable-cert", &tlsc)
assert.Error(t, err)
}
|
