1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
|
package layout
import (
"context"
"fmt"
"io"
"io/fs"
"os"
"path/filepath"
"slices"
"testing"
"github.com/containers/image/v5/types"
digest "github.com/opencontainers/go-digest"
imgspecv1 "github.com/opencontainers/image-spec/specs-go/v1"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestReferenceDeleteImage_onlyOneImage(t *testing.T) {
tmpDir := loadFixture(t, "delete_image_only_one_image")
ref, err := NewReference(tmpDir, "latest")
require.NoError(t, err)
err = ref.DeleteImage(context.Background(), nil)
require.NoError(t, err)
// Check that all blobs were deleted
blobsDir := filepath.Join(tmpDir, "blobs")
files, err := os.ReadDir(filepath.Join(blobsDir, "sha256"))
require.NoError(t, err)
require.Empty(t, files)
// Check that the index is empty as there is only one image in the fixture
ociRef, ok := ref.(ociReference)
require.True(t, ok)
index, err := ociRef.getIndex()
require.NoError(t, err)
require.Equal(t, 0, len(index.Manifests))
}
func TestReferenceDeleteImage_onlyOneImage_emptyImageName(t *testing.T) {
tmpDir := loadFixture(t, "delete_image_only_one_image")
ref, err := NewReference(tmpDir, "")
require.NoError(t, err)
err = ref.DeleteImage(context.Background(), nil)
require.NoError(t, err)
// Check that all blobs were deleted
blobsDir := filepath.Join(tmpDir, "blobs")
files, err := os.ReadDir(filepath.Join(blobsDir, "sha256"))
require.NoError(t, err)
require.Empty(t, files)
// Check that the index is empty as there is only one image in the fixture
ociRef, ok := ref.(ociReference)
require.True(t, ok)
index, err := ociRef.getIndex()
require.NoError(t, err)
require.Equal(t, 0, len(index.Manifests))
}
func TestReferenceDeleteImage_sharedBlobDir(t *testing.T) {
tmpDir := loadFixture(t, "delete_image_shared_blobs_dir")
ref, err := NewReference(tmpDir, "latest")
require.NoError(t, err)
sys := &types.SystemContext{OCISharedBlobDirPath: filepath.Join(tmpDir, "shared_blobs")}
err = ref.DeleteImage(context.Background(), sys)
require.NoError(t, err)
// Check that the only blob in the local directory was deleted
blobsDir := filepath.Join(tmpDir, "blobs")
files, err := os.ReadDir(filepath.Join(blobsDir, "sha256"))
require.NoError(t, err)
require.Empty(t, files)
// Check that the blobs in the shared blob directory are still present
sharedBlobsDir := filepath.Join(tmpDir, "shared_blobs")
files, err = os.ReadDir(filepath.Join(sharedBlobsDir, "sha256"))
require.NoError(t, err)
require.Equal(t, 2, len(files))
// Check that the index is empty as there is only one image in the fixture
ociRef, ok := ref.(ociReference)
require.True(t, ok)
index, err := ociRef.getIndex()
require.NoError(t, err)
require.Equal(t, 0, len(index.Manifests))
}
func assertRefNameIsMissing(t *testing.T, index *imgspecv1.Index, refName string) {
if slices.ContainsFunc(index.Manifests, func(desc imgspecv1.Descriptor) bool {
return desc.Annotations[imgspecv1.AnnotationRefName] == refName
}) {
assert.Failf(t, "index still contains refName %q after deletion", refName)
}
}
func TestReferenceDeleteImage_multipleImages(t *testing.T) {
tmpDir := loadFixture(t, "delete_image_multiple_images")
ref, err := NewReference(tmpDir, "3.17.5")
require.NoError(t, err)
err = ref.DeleteImage(context.Background(), nil)
require.NoError(t, err)
// Check that the relevant blobs were deleted/preserved
blobsDir := filepath.Join(tmpDir, "blobs")
files, err := os.ReadDir(filepath.Join(blobsDir, "sha256"))
require.NoError(t, err)
require.Equal(t, 16, len(files))
assertBlobDoesNotExist(t, blobsDir, "sha256:5b2aba4d3c27bc6493633d0ec446b25c8d0a5c9cfe99894bcdff0aee80813805")
assertBlobDoesNotExist(t, blobsDir, "sha256:df11bc189adeb50dadb3291a3a7f2c34b36e0efdba0df70f2c8a2d761b215cde")
assertBlobDoesNotExist(t, blobsDir, "sha256:986315a0e599fac2b80eb31db2124dab8d3de04d7ca98b254999bd913c1f73fe")
// Check the index
ociRef, ok := ref.(ociReference)
require.True(t, ok)
// .. Check that the index has been reduced to the correct size
index, err := ociRef.getIndex()
require.NoError(t, err)
require.Equal(t, 6, len(index.Manifests))
// .. Check that the image is not in the index anymore
assertRefNameIsMissing(t, index, "3.17.5")
}
func TestReferenceDeleteImage_multipleImages_blobsUsedByOtherImages(t *testing.T) {
tmpDir := loadFixture(t, "delete_image_multiple_images")
ref, err := NewReference(tmpDir, "1.0.0")
require.NoError(t, err)
err = ref.DeleteImage(context.Background(), nil)
require.NoError(t, err)
// Check that the relevant blobs were deleted/preserved
blobsDir := filepath.Join(tmpDir, "blobs")
files, err := os.ReadDir(filepath.Join(blobsDir, "sha256"))
require.NoError(t, err)
require.Equal(t, 17, len(files))
assertBlobExists(t, blobsDir, "sha256:df11bc189adeb50dadb3291a3a7f2c34b36e0efdba0df70f2c8a2d761b215cde")
assertBlobDoesNotExist(t, blobsDir, "sha256:0dc27f36a618c110ae851662c13283e9fbc1b5a5de003befc4bcefa5a05d2eef")
assertBlobDoesNotExist(t, blobsDir, "sha256:a6f737ac2b84bc463f2ff721af39588c69646c82f79f3808236178e02e35b922")
// Check the index
ociRef, ok := ref.(ociReference)
require.True(t, ok)
// .. Check that the index has been reduced to the correct size
index, err := ociRef.getIndex()
require.NoError(t, err)
require.Equal(t, 6, len(index.Manifests))
// .. Check that the image is not in the index anymore
assertRefNameIsMissing(t, index, "1.0.0")
}
func TestReferenceDeleteImage_multipleImages_imageDoesNotExist(t *testing.T) {
tmpDir := loadFixture(t, "delete_image_multiple_images")
ref, err := NewReference(tmpDir, "does-not-exist")
assert.NoError(t, err)
err = ref.DeleteImage(context.Background(), nil)
assert.Error(t, err)
}
func TestReferenceDeleteImage_multipleImages_emptyImageName(t *testing.T) {
tmpDir := loadFixture(t, "delete_image_multiple_images")
ref, err := NewReference(tmpDir, "")
require.NoError(t, err)
err = ref.DeleteImage(context.Background(), nil)
require.Error(t, err)
}
func TestReferenceDeleteImage_multipleImages_nestedIndexImage(t *testing.T) {
tmpDir := loadFixture(t, "delete_image_multiple_images")
ref, err := NewReference(tmpDir, "3.16.7")
require.NoError(t, err)
err = ref.DeleteImage(context.Background(), nil)
require.NoError(t, err)
// Check that the relevant blobs were deleted/preserved
blobsDir := filepath.Join(tmpDir, "blobs")
files, err := os.ReadDir(filepath.Join(blobsDir, "sha256"))
require.NoError(t, err)
require.Equal(t, 12, len(files))
assertBlobDoesNotExist(t, blobsDir, "sha256:861d3c014b0e3edcf80e6221247d6b2921a4f892feb9bafe9515b9975b78c44f")
assertBlobDoesNotExist(t, blobsDir, "sha256:39c524417bb4228f9fcb0aef43a680b5fd6b9f3a1df2fd50509d047e47dad8be")
assertBlobDoesNotExist(t, blobsDir, "sha256:f732172ad8d2a666550fa3ec37a5153d59acc95744562ae64cf62ded46de101a")
assertBlobDoesNotExist(t, blobsDir, "sha256:02ea786cb1ff44d997661886a4186cbd8a1dc466938712bf7281379209476022")
assertBlobDoesNotExist(t, blobsDir, "sha256:be6036f9b6a4e120a04868c47f1b8674f58b2fe5e410cba9f585a13ca8946cf0")
assertBlobDoesNotExist(t, blobsDir, "sha256:7ffdfe7d276286b39a203dcc247949cf47c91d2d5e10a53a675c0962ed9e4402")
assertBlobDoesNotExist(t, blobsDir, "sha256:e2f7e0374fd6a03d9c373f4d9a0c7802045cc3ddcc1433e89d83b81fa7007242")
// Check the index
ociRef, ok := ref.(ociReference)
require.True(t, ok)
// .. Check that the index has been reduced to the correct size
index, err := ociRef.getIndex()
require.NoError(t, err)
require.Equal(t, 6, len(index.Manifests))
// .. Check that the image is not in the index anymore
assertRefNameIsMissing(t, index, "3.16.7")
}
func TestReferenceDeleteImage_multipleImages_nestedIndexImage_refWithSameContent(t *testing.T) {
tmpDir := loadFixture(t, "delete_image_multiple_images")
ref, err := NewReference(tmpDir, "3.18.3")
require.NoError(t, err)
err = ref.DeleteImage(context.Background(), nil)
require.NoError(t, err)
// Check that the relevant blobs were deleted/preserved
blobsDir := filepath.Join(tmpDir, "blobs")
files, err := os.ReadDir(filepath.Join(blobsDir, "sha256"))
require.NoError(t, err)
require.Equal(t, 19, len(files))
// Check the index
ociRef, ok := ref.(ociReference)
require.True(t, ok)
// .. Check that the index has been reduced to the correct size
index, err := ociRef.getIndex()
require.NoError(t, err)
require.Equal(t, 6, len(index.Manifests))
}
func TestReferenceDeleteImage_multipleImages_twoIdenticalReferences(t *testing.T) {
tmpDir := loadFixture(t, "delete_image_two_identical_references")
ref, err := NewReference(tmpDir, "1.0.0")
require.NoError(t, err)
err = ref.DeleteImage(context.Background(), nil)
require.NoError(t, err)
// Check that the relevant blobs were deleted/preserved - in this case only the first reference should be deleted
blobsDir := filepath.Join(tmpDir, "blobs")
files, err := os.ReadDir(filepath.Join(blobsDir, "sha256"))
require.NoError(t, err)
require.Equal(t, 3, len(files))
assertBlobExists(t, blobsDir, "sha256:ecfa463536cb5472e238aadc4df81d4785d5d6373027c488a2db8a6e76fe88ed")
assertBlobExists(t, blobsDir, "sha256:ce229a4eb5797ecd3a3a1846613b6b49811f79e38b5b0ce666268ba4b6c68e41")
assertBlobExists(t, blobsDir, "sha256:fa00bb4e2adbc73a5da1fd54d2a840020592530a8d4e8de9888b9e9a533419d8")
// Check the index
ociRef, ok := ref.(ociReference)
require.True(t, ok)
// .. Check that the index has been reduced to the correct size
index, err := ociRef.getIndex()
require.NoError(t, err)
require.Equal(t, 1, len(index.Manifests))
}
func loadFixture(t *testing.T, fixtureName string) string {
destDir := t.TempDir()
srcDir := filepath.Join("fixtures", fixtureName)
err := filepath.WalkDir(srcDir, func(path string, d fs.DirEntry, err error) (retErr error) {
if err != nil {
return err
}
relPath, err := filepath.Rel(srcDir, path)
if err != nil {
return err
}
destPath := filepath.Join(destDir, relPath)
switch d.Type() {
case fs.ModeDir:
return os.MkdirAll(destPath, 0o700)
case 0: // regular file
src, err := os.Open(path)
if err != nil {
return err
}
defer src.Close()
dest, err := os.OpenFile(destPath, os.O_WRONLY|os.O_CREATE|os.O_EXCL, 0o600)
if err != nil {
return err
}
defer func() {
if err := dest.Close(); err != nil && retErr == nil {
retErr = err
}
}()
_, err = io.Copy(dest, src)
return err
default:
return fmt.Errorf("unexpected file type %#v", d.Type())
}
})
require.NoError(t, err)
return destDir
}
func assertBlobExists(t *testing.T, blobsDir string, blobDigest string) {
digest, err := digest.Parse(blobDigest)
require.NoError(t, err)
blobPath := filepath.Join(blobsDir, digest.Algorithm().String(), digest.Encoded())
_, err = os.Stat(blobPath)
require.NoError(t, err)
}
func assertBlobDoesNotExist(t *testing.T, blobsDir string, blobDigest string) {
digest, err := digest.Parse(blobDigest)
require.NoError(t, err)
blobPath := filepath.Join(blobsDir, digest.Algorithm().String(), digest.Encoded())
_, err = os.Stat(blobPath)
require.True(t, os.IsNotExist(err))
}
|
