1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
|
package config
import (
"fmt"
"path/filepath"
"testing"
"github.com/crc-org/crc/v2/pkg/crc/constants"
crcpreset "github.com/crc-org/crc/v2/pkg/crc/preset"
"github.com/crc-org/crc/v2/pkg/crc/version"
"github.com/spf13/cast"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
// override for ValidateMemory in validations.go to disable the physical memory check
func validateMemoryNoPhysicalCheck(value interface{}, preset crcpreset.Preset) (bool, string) {
v, err := cast.ToIntE(value)
if err != nil {
return false, fmt.Sprintf("requires integer value in MiB >= %d", constants.GetDefaultMemory(preset))
}
if v < constants.GetDefaultMemory(preset) {
return false, fmt.Sprintf("requires memory in MiB >= %d", constants.GetDefaultMemory(preset))
}
return true, ""
}
func newInMemoryConfig() (*Config, error) {
validateMemory = validateMemoryNoPhysicalCheck
cfg := New(NewEmptyInMemoryStorage(), NewEmptyInMemorySecretStorage())
RegisterSettings(cfg)
return cfg, nil
}
// Check that with the default preset, we cannot set less CPUs than the defaultCPUs
// but that it is allowed with a different preset with less requirements (podman)
func TestCPUsValidate(t *testing.T) {
cfg, err := newInMemoryConfig()
require.NoError(t, err)
assert.Equal(t, SettingValue{
Value: version.GetDefaultPreset().String(),
Invalid: false,
IsDefault: true,
IsSecret: false,
}, cfg.Get(Preset))
defaultCPUs := constants.GetDefaultCPUs(version.GetDefaultPreset())
_, err = cfg.Set(CPUs, defaultCPUs-1)
require.Error(t, err)
assert.Equal(t, SettingValue{
Value: defaultCPUs,
Invalid: false,
IsDefault: true,
IsSecret: false,
}, cfg.Get(CPUs))
_, err = cfg.Set(Preset, crcpreset.Podman)
require.NoError(t, err)
_, err = cfg.Set(CPUs, defaultCPUs-1)
require.NoError(t, err)
assert.Equal(t, SettingValue{
Value: defaultCPUs - 1,
Invalid: false,
IsDefault: false,
IsSecret: false,
}, cfg.Get(CPUs))
}
// Check that when changing preset, invalid memory values are reset to their
// default value
func TestSetPreset(t *testing.T) {
cfg, err := newInMemoryConfig()
require.NoError(t, err)
_, err = cfg.Set(Preset, crcpreset.Podman)
require.NoError(t, err)
_, err = cfg.Set(Memory, 10000)
require.NoError(t, err)
assert.Equal(t, SettingValue{
Value: 10000,
Invalid: false,
IsDefault: false,
IsSecret: false,
}, cfg.Get(Memory))
_, err = cfg.Set(CPUs, 3)
require.NoError(t, err)
assert.Equal(t, SettingValue{
Value: 3,
Invalid: false,
IsDefault: false,
IsSecret: false,
}, cfg.Get(CPUs))
// Changing the preset to 'openshift' should reset the CPUs config value
_, err = cfg.Set(Preset, crcpreset.OpenShift)
require.NoError(t, err)
assert.Equal(t, SettingValue{
Value: 10000,
Invalid: false,
IsDefault: false,
IsSecret: false,
}, cfg.Get(Memory))
assert.Equal(t, SettingValue{
Value: 4,
Invalid: false,
IsDefault: true,
IsSecret: false,
}, cfg.Get(CPUs))
}
// Check that when unsetting preset, invalid memory values are reset to their
// default value
func TestUnsetPreset(t *testing.T) {
cfg, err := newInMemoryConfig()
require.NoError(t, err)
_, err = cfg.Set(Preset, crcpreset.Podman)
require.NoError(t, err)
_, err = cfg.Set(Memory, 10000)
require.NoError(t, err)
assert.Equal(t, SettingValue{
Value: 10000,
Invalid: false,
IsDefault: false,
IsSecret: false,
}, cfg.Get(Memory))
_, err = cfg.Set(CPUs, 3)
require.NoError(t, err)
assert.Equal(t, SettingValue{
Value: 3,
Invalid: false,
IsDefault: false,
IsSecret: false,
}, cfg.Get(CPUs))
// Unsetting the preset should reset the CPUs config value
_, err = cfg.Unset(Preset)
require.NoError(t, err)
assert.Equal(t, SettingValue{
Value: crcpreset.OpenShift.String(),
Invalid: false,
IsDefault: true,
IsSecret: false,
}, cfg.Get(Preset))
assert.Equal(t, SettingValue{
Value: 10000,
Invalid: false,
IsDefault: false,
IsSecret: false,
}, cfg.Get(Memory))
assert.Equal(t, SettingValue{
Value: 4,
Invalid: false,
IsDefault: true,
IsSecret: false,
}, cfg.Get(CPUs))
}
func TestPath(t *testing.T) {
cfg, err := newInMemoryConfig()
require.NoError(t, err)
assert.Equal(t, SettingValue{
Value: Path(""),
Invalid: false,
IsDefault: true,
IsSecret: false,
}, cfg.Get(ProxyCAFile))
_, err = cfg.Set(ProxyCAFile, "testdata/foo.crt")
require.NoError(t, err)
expectedPath, err := filepath.Abs("testdata/foo.crt")
require.NoError(t, err)
assert.Equal(t, SettingValue{
Value: Path(expectedPath),
Invalid: false,
IsDefault: false,
IsSecret: false,
}, cfg.Get(ProxyCAFile))
}
|
