1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
|
//go:build linux
// Copyright (C) 2024 SUSE LLC. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package securejoin
import (
"os"
"path/filepath"
"runtime"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"golang.org/x/sys/unix"
)
type openInRootFunc func(root, unsafePath string) (*os.File, error)
type openResult struct {
handlePath string
err error
fileType uint32
}
// O_LARGEFILE is automatically added by the kernel when opening files on
// 64-bit machines. Unfortunately, it is architecture-dependent and
// unix.O_LARGEFILE is 0 (presumably to avoid users setting it). So we need to
// initialise it at init.
var O_LARGEFILE = 0x8000
func init() {
switch runtime.GOARCH {
case "arm", "arm64":
O_LARGEFILE = 0x20000
case "mips", "mips64", "mips64le", "mips64p32", "mips64p32le":
O_LARGEFILE = 0x2000
case "ppc", "ppc64", "ppc64le":
O_LARGEFILE = 0x10000
case "sparc", "sparc64":
O_LARGEFILE = 0x40000
default:
// 0x8000 is the default flag in asm-generic.
}
}
func checkReopen(t *testing.T, handle *os.File, flags int, expectedErr error) {
newHandle, err := Reopen(handle, flags)
if newHandle != nil {
defer newHandle.Close()
}
if expectedErr != nil {
if assert.Error(t, err) {
assert.ErrorIs(t, err, expectedErr)
} else {
t.Errorf("unexpected handle %q", handle.Name())
}
return
}
assert.NoError(t, err)
// Get the original handle path.
handlePath, err := procSelfFdReadlink(handle)
require.NoError(t, err, "get real path of original handle")
// Make sure the handle matches the readlink path.
assert.Equal(t, handlePath, handle.Name(), "handle.Name() matching real original handle path")
// Check that the new and old handle have the same path.
newHandlePath, err := procSelfFdReadlink(newHandle)
require.NoError(t, err, "get real path of reopened handle")
assert.Equal(t, handlePath, newHandlePath, "old and reopen handle paths")
assert.Equal(t, handle.Name(), newHandle.Name(), "old and reopen handle.Name()")
// Check the fd flags.
newHandleFdFlags, err := unix.FcntlInt(newHandle.Fd(), unix.F_GETFD, 0)
require.NoError(t, err, "fcntl(F_GETFD)")
assert.Equal(t, unix.FD_CLOEXEC, newHandleFdFlags&unix.FD_CLOEXEC, "FD_CLOEXEC flag must be set")
// Check the file handle flags.
newHandleStatusFlags, err := unix.FcntlInt(newHandle.Fd(), unix.F_GETFL, 0)
require.NoError(t, err, "fcntl(F_GETFL)")
flags &^= unix.O_CLOEXEC // O_CLOEXEC is checked by F_GETFD
newHandleStatusFlags &^= O_LARGEFILE // ignore the O_LARGEFILE flag
assert.Equal(t, flags, newHandleStatusFlags, "re-opened handle status flags must match re-open flags (%+x)")
}
func checkOpenInRoot(t *testing.T, openInRootFn openInRootFunc, root, unsafePath string, expected openResult) {
handle, err := openInRootFn(root, unsafePath)
if handle != nil {
defer handle.Close()
}
if expected.err != nil {
if assert.Error(t, err) {
assert.ErrorIs(t, err, expected.err)
} else {
t.Errorf("unexpected handle %q", handle.Name())
}
return
}
assert.NoError(t, err)
// Check the handle path.
gotPath, err := procSelfFdReadlink(handle)
require.NoError(t, err, "get real path of returned handle")
assert.Equal(t, expected.handlePath, gotPath, "real handle path")
// Make sure the handle matches the readlink path.
assert.Equal(t, gotPath, handle.Name(), "handle.Name() matching real handle path")
// Check the handle type.
unixStat, err := fstat(handle)
require.NoError(t, err, "fstat handle")
assert.Equal(t, expected.fileType, unixStat.Mode&unix.S_IFMT, "handle S_IFMT type")
// Check that re-opening produces a handle with the same path.
switch expected.fileType {
case unix.S_IFDIR:
checkReopen(t, handle, unix.O_RDONLY, nil)
checkReopen(t, handle, unix.O_DIRECTORY, nil)
case unix.S_IFREG:
checkReopen(t, handle, unix.O_RDWR, nil)
checkReopen(t, handle, unix.O_DIRECTORY, unix.ENOTDIR)
// Only files and directories are safe to open this way. Use O_PATH for
// everything else.
default:
checkReopen(t, handle, unix.O_PATH, nil)
checkReopen(t, handle, unix.O_PATH|unix.O_DIRECTORY, unix.ENOTDIR)
}
}
func testOpenInRoot(t *testing.T, openInRootFn openInRootFunc) {
tree := []string{
"dir a",
"dir b/c/d/e/f",
"file b/c/file",
"symlink e /b/c/d/e",
"symlink b-file b/c/file",
// Dangling symlinks.
"symlink a-fake1 a/fake",
"symlink a-fake2 a/fake/foo/bar/..",
"symlink a-fake3 a/fake/../../b",
"dir c",
"symlink c/a-fake1 a/fake",
"symlink c/a-fake2 a/fake/foo/bar/..",
"symlink c/a-fake3 a/fake/../../b",
// Test non-lexical symlinks.
"dir target",
"dir link1",
"symlink link1/target_abs /target",
"symlink link1/target_rel ../target",
"dir link2",
"symlink link2/link1_abs /link1",
"symlink link2/link1_rel ../link1",
"dir link3",
"symlink link3/target_abs /link2/link1_rel/target_rel",
"symlink link3/target_rel ../link2/link1_rel/target_rel",
"symlink link3/deep_dangling1 ../link2/link1_rel/target_rel/nonexist",
"symlink link3/deep_dangling2 ../link2/link1_rel/target_rel/nonexist",
// Deep dangling symlinks (with single components).
"dir dangling",
"symlink dangling/a b/c",
"dir dangling/b",
"symlink dangling/b/c ../c",
"symlink dangling/c d/e",
"dir dangling/d",
"symlink dangling/d/e ../e",
"symlink dangling/e f/../g",
"dir dangling/f",
"symlink dangling/g h/i/j/nonexistent",
"dir dangling/h/i/j",
// Deep dangling symlink using a non-dir component.
"dir dangling-file",
"symlink dangling-file/a b/c",
"dir dangling-file/b",
"symlink dangling-file/b/c ../c",
"symlink dangling-file/c d/e",
"dir dangling-file/d",
"symlink dangling-file/d/e ../e",
"symlink dangling-file/e f/../g",
"dir dangling-file/f",
"symlink dangling-file/g h/i/j/file/foo",
"dir dangling-file/h/i/j",
"file dangling-file/h/i/j/file",
// Some "bad" inodes that a regular user can create.
"fifo b/fifo",
"sock b/sock",
// Symlink loops.
"dir loop",
"symlink loop/basic-loop1 basic-loop1",
"symlink loop/basic-loop2 /loop/basic-loop2",
"symlink loop/basic-loop3 ../loop/basic-loop3",
"dir loop/a",
"symlink loop/a/link ../b/link",
"dir loop/b",
"symlink loop/b/link /loop/c/link",
"dir loop/c",
"symlink loop/c/link /loop/d/link",
"symlink loop/d e",
"dir loop/e",
"symlink loop/e/link ../a/link",
"symlink loop/link a/link",
}
root := createTree(t, tree...)
for name, test := range map[string]struct {
unsafePath string
expected openResult
}{
// Complete lookups.
"complete-dir1": {"a", openResult{handlePath: "/a", fileType: unix.S_IFDIR}},
"complete-dir2": {"b/c/d/e/f", openResult{handlePath: "/b/c/d/e/f", fileType: unix.S_IFDIR}},
"complete-dir3": {"b///././c////.//d/./././///e////.//./f//././././", openResult{handlePath: "/b/c/d/e/f", fileType: unix.S_IFDIR}},
"complete-file": {"b/c/file", openResult{handlePath: "/b/c/file", fileType: unix.S_IFREG}},
"complete-file-link": {"b-file", openResult{handlePath: "/b/c/file", fileType: unix.S_IFREG}},
"complete-fifo": {"b/fifo", openResult{handlePath: "/b/fifo", fileType: unix.S_IFIFO}},
"complete-sock": {"b/sock", openResult{handlePath: "/b/sock", fileType: unix.S_IFSOCK}},
// Partial lookups.
"partial-dir-basic": {"a/b/c/d/e/f/g/h", openResult{err: unix.ENOENT}},
"partial-dir-dotdot": {"a/foo/../bar/baz", openResult{err: unix.ENOENT}},
// Complete lookups of non-lexical symlinks.
"nonlexical-basic-complete1": {"target", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-basic-complete2": {"target/", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-basic-complete3": {"target//", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-basic-partial": {"target/foo", openResult{err: unix.ENOENT}},
"nonlexical-basic-partial-dotdot": {"target/../target/foo/bar/../baz", openResult{err: unix.ENOENT}},
"nonlexical-level1-abs-complete1": {"link1/target_abs", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level1-abs-complete2": {"link1/target_abs/", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level1-abs-complete3": {"link1/target_abs//", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level1-abs-partial": {"link1/target_abs/foo", openResult{err: unix.ENOENT}},
"nonlexical-level1-abs-partial-dotdot": {"link1/target_abs/../target/foo/bar/../baz", openResult{err: unix.ENOENT}},
"nonlexical-level1-rel-complete1": {"link1/target_rel", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level1-rel-complete2": {"link1/target_rel/", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level1-rel-complete3": {"link1/target_rel//", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level1-rel-partial": {"link1/target_rel/foo", openResult{err: unix.ENOENT}},
"nonlexical-level1-rel-partial-dotdot": {"link1/target_rel/../target/foo/bar/../baz", openResult{err: unix.ENOENT}},
"nonlexical-level2-abs-abs-complete1": {"link2/link1_abs/target_abs", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-abs-abs-complete2": {"link2/link1_abs/target_abs/", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-abs-abs-complete3": {"link2/link1_abs/target_abs//", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-abs-abs-partial": {"link2/link1_abs/target_abs/foo", openResult{err: unix.ENOENT}},
"nonlexical-level2-abs-abs-partial-dotdot": {"link2/link1_abs/target_abs/../target/foo/bar/../baz", openResult{err: unix.ENOENT}},
"nonlexical-level2-abs-rel-complete1": {"link2/link1_abs/target_rel", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-abs-rel-complete2": {"link2/link1_abs/target_rel/", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-abs-rel-complete3": {"link2/link1_abs/target_rel//", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-abs-rel-partial": {"link2/link1_abs/target_rel/foo", openResult{err: unix.ENOENT}},
"nonlexical-level2-abs-rel-partial-dotdot": {"link2/link1_abs/target_rel/../target/foo/bar/../baz", openResult{err: unix.ENOENT}},
"nonlexical-level2-abs-open-complete1": {"link2/link1_abs/../target", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-abs-open-complete2": {"link2/link1_abs/../target/", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-abs-open-complete3": {"link2/link1_abs/../target//", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-abs-open-partial": {"link2/link1_abs/../target/foo", openResult{err: unix.ENOENT}},
"nonlexical-level2-abs-open-partial-dotdot": {"link2/link1_abs/../target/../target/foo/bar/../baz", openResult{err: unix.ENOENT}},
"nonlexical-level2-rel-abs-complete1": {"link2/link1_rel/target_abs", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-rel-abs-complete2": {"link2/link1_rel/target_abs/", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-rel-abs-complete3": {"link2/link1_rel/target_abs//", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-rel-abs-partial": {"link2/link1_rel/target_abs/foo", openResult{err: unix.ENOENT}},
"nonlexical-level2-rel-abs-partial-dotdot": {"link2/link1_rel/target_abs/../target/foo/bar/../baz", openResult{err: unix.ENOENT}},
"nonlexical-level2-rel-rel-complete1": {"link2/link1_rel/target_rel", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-rel-rel-complete2": {"link2/link1_rel/target_rel/", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-rel-rel-complete3": {"link2/link1_rel/target_rel//", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-rel-rel-partial": {"link2/link1_rel/target_rel/foo", openResult{err: unix.ENOENT}},
"nonlexical-level2-rel-rel-partial-dotdot": {"link2/link1_rel/target_rel/../target/foo/bar/../baz", openResult{err: unix.ENOENT}},
"nonlexical-level2-rel-open-complete1": {"link2/link1_rel/../target", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-rel-open-complete2": {"link2/link1_rel/../target/", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-rel-open-complete3": {"link2/link1_rel/../target//", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level2-rel-open-partial": {"link2/link1_rel/../target/foo", openResult{err: unix.ENOENT}},
"nonlexical-level2-rel-open-partial-dotdot": {"link2/link1_rel/../target/../target/foo/bar/../baz", openResult{err: unix.ENOENT}},
"nonlexical-level3-abs-complete1": {"link3/target_abs", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level3-abs-complete2": {"link3/target_abs/", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level3-abs-complete3": {"link3/target_abs//", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level3-abs-partial": {"link3/target_abs/foo", openResult{err: unix.ENOENT}},
"nonlexical-level3-abs-partial-dotdot": {"link3/target_abs/../target/foo/bar/../baz", openResult{err: unix.ENOENT}},
"nonlexical-level3-rel-complete1": {"link3/target_rel", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level3-rel-complete2": {"link3/target_rel/", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level3-rel-complete3": {"link3/target_rel//", openResult{handlePath: "/target", fileType: unix.S_IFDIR}},
"nonlexical-level3-rel-partial": {"link3/target_rel/foo", openResult{err: unix.ENOENT}},
"nonlexical-level3-rel-partial-dotdot": {"link3/target_rel/../target/foo/bar/../baz", openResult{err: unix.ENOENT}},
// Partial lookups due to hitting a non-directory.
"partial-nondir-slash1": {"b/c/file/", openResult{err: unix.ENOTDIR}},
"partial-nondir-slash2": {"b/c/file//", openResult{err: unix.ENOTDIR}},
"partial-nondir-dot": {"b/c/file/.", openResult{err: unix.ENOTDIR}},
"partial-nondir-dotdot1": {"b/c/file/..", openResult{err: unix.ENOTDIR}},
"partial-nondir-dotdot2": {"b/c/file/../foo/bar", openResult{err: unix.ENOTDIR}},
"partial-nondir-symlink-slash1": {"b-file/", openResult{err: unix.ENOTDIR}},
"partial-nondir-symlink-slash2": {"b-file//", openResult{err: unix.ENOTDIR}},
"partial-nondir-symlink-dot": {"b-file/.", openResult{err: unix.ENOTDIR}},
"partial-nondir-symlink-dotdot1": {"b-file/..", openResult{err: unix.ENOTDIR}},
"partial-nondir-symlink-dotdot2": {"b-file/../foo/bar", openResult{err: unix.ENOTDIR}},
"partial-fifo-slash1": {"b/fifo/", openResult{err: unix.ENOTDIR}},
"partial-fifo-slash2": {"b/fifo//", openResult{err: unix.ENOTDIR}},
"partial-fifo-dot": {"b/fifo/.", openResult{err: unix.ENOTDIR}},
"partial-fifo-dotdot1": {"b/fifo/..", openResult{err: unix.ENOTDIR}},
"partial-fifo-dotdot2": {"b/fifo/../foo/bar", openResult{err: unix.ENOTDIR}},
"partial-sock-slash1": {"b/sock/", openResult{err: unix.ENOTDIR}},
"partial-sock-slash2": {"b/sock//", openResult{err: unix.ENOTDIR}},
"partial-sock-dot": {"b/sock/.", openResult{err: unix.ENOTDIR}},
"partial-sock-dotdot1": {"b/sock/..", openResult{err: unix.ENOTDIR}},
"partial-sock-dotdot2": {"b/sock/../foo/bar", openResult{err: unix.ENOTDIR}},
// Dangling symlinks are treated as though they are non-existent.
"dangling1-inroot-trailing": {"a-fake1", openResult{err: unix.ENOENT}},
"dangling1-inroot-partial": {"a-fake1/foo", openResult{err: unix.ENOENT}},
"dangling1-inroot-partial-dotdot": {"a-fake1/../bar/baz", openResult{err: unix.ENOENT}},
"dangling1-sub-trailing": {"c/a-fake1", openResult{err: unix.ENOENT}},
"dangling1-sub-partial": {"c/a-fake1/foo", openResult{err: unix.ENOENT}},
"dangling1-sub-partial-dotdot": {"c/a-fake1/../bar/baz", openResult{err: unix.ENOENT}},
"dangling2-inroot-trailing": {"a-fake2", openResult{err: unix.ENOENT}},
"dangling2-inroot-partial": {"a-fake2/foo", openResult{err: unix.ENOENT}},
"dangling2-inroot-partial-dotdot": {"a-fake2/../bar/baz", openResult{err: unix.ENOENT}},
"dangling2-sub-trailing": {"c/a-fake2", openResult{err: unix.ENOENT}},
"dangling2-sub-partial": {"c/a-fake2/foo", openResult{err: unix.ENOENT}},
"dangling2-sub-partial-dotdot": {"c/a-fake2/../bar/baz", openResult{err: unix.ENOENT}},
"dangling3-inroot-trailing": {"a-fake3", openResult{err: unix.ENOENT}},
"dangling3-inroot-partial": {"a-fake3/foo", openResult{err: unix.ENOENT}},
"dangling3-inroot-partial-dotdot": {"a-fake3/../bar/baz", openResult{err: unix.ENOENT}},
"dangling3-sub-trailing": {"c/a-fake3", openResult{err: unix.ENOENT}},
"dangling3-sub-partial": {"c/a-fake3/foo", openResult{err: unix.ENOENT}},
"dangling3-sub-partial-dotdot": {"c/a-fake3/../bar/baz", openResult{err: unix.ENOENT}},
// Tricky dangling symlinks.
"dangling-tricky1-trailing": {"link3/deep_dangling1", openResult{err: unix.ENOENT}},
"dangling-tricky1-partial": {"link3/deep_dangling1/foo", openResult{err: unix.ENOENT}},
"dangling-tricky1-partial-dotdot": {"link3/deep_dangling1/..", openResult{err: unix.ENOENT}},
"dangling-tricky2-trailing": {"link3/deep_dangling2", openResult{err: unix.ENOENT}},
"dangling-tricky2-partial": {"link3/deep_dangling2/foo", openResult{err: unix.ENOENT}},
"dangling-tricky2-partial-dotdot": {"link3/deep_dangling2/..", openResult{err: unix.ENOENT}},
// Really deep dangling links.
"deep-dangling1": {"dangling/a", openResult{err: unix.ENOENT}},
"deep-dangling2": {"dangling/b/c", openResult{err: unix.ENOENT}},
"deep-dangling3": {"dangling/c", openResult{err: unix.ENOENT}},
"deep-dangling4": {"dangling/d/e", openResult{err: unix.ENOENT}},
"deep-dangling5": {"dangling/e", openResult{err: unix.ENOENT}},
"deep-dangling6": {"dangling/g", openResult{err: unix.ENOENT}},
"deep-dangling-fileasdir1": {"dangling-file/a", openResult{err: unix.ENOTDIR}},
"deep-dangling-fileasdir2": {"dangling-file/b/c", openResult{err: unix.ENOTDIR}},
"deep-dangling-fileasdir3": {"dangling-file/c", openResult{err: unix.ENOTDIR}},
"deep-dangling-fileasdir4": {"dangling-file/d/e", openResult{err: unix.ENOTDIR}},
"deep-dangling-fileasdir5": {"dangling-file/e", openResult{err: unix.ENOTDIR}},
"deep-dangling-fileasdir6": {"dangling-file/g", openResult{err: unix.ENOTDIR}},
// Symlink loops.
"loop": {"loop/link", openResult{err: unix.ELOOP}},
"loop-basic1": {"loop/basic-loop1", openResult{err: unix.ELOOP}},
"loop-basic2": {"loop/basic-loop2", openResult{err: unix.ELOOP}},
"loop-basic3": {"loop/basic-loop3", openResult{err: unix.ELOOP}},
} {
test := test // copy iterator
// Update the handlePath to be inside our root.
if test.expected.handlePath != "" {
test.expected.handlePath = filepath.Join(root, test.expected.handlePath)
}
t.Run(name, func(t *testing.T) {
checkOpenInRoot(t, openInRootFn, root, test.unsafePath, test.expected)
})
}
}
func TestOpenInRoot(t *testing.T) {
withWithoutOpenat2(t, true, func(t *testing.T) {
testOpenInRoot(t, OpenInRoot)
})
}
func TestOpenInRootHandle(t *testing.T) {
withWithoutOpenat2(t, true, func(t *testing.T) {
testOpenInRoot(t, func(root, unsafePath string) (*os.File, error) {
rootDir, err := os.OpenFile(root, unix.O_PATH|unix.O_DIRECTORY|unix.O_CLOEXEC, 0)
if err != nil {
return nil, err
}
defer rootDir.Close()
return OpenatInRoot(rootDir, unsafePath)
})
})
}
func TestOpenInRoot_BadInode(t *testing.T) {
requireRoot(t) // mknod
withWithoutOpenat2(t, true, func(t *testing.T) {
tree := []string{
// Make sure we don't open "bad" inodes.
"dir foo",
"char foo/whiteout 0 0",
"block foo/whiteout-blk 0 0",
}
root := createTree(t, tree...)
rootDir, err := os.OpenFile(root, unix.O_PATH|unix.O_DIRECTORY|unix.O_CLOEXEC, 0)
require.NoError(t, err)
defer rootDir.Close()
for name, test := range map[string]struct {
unsafePath string
expected openResult
}{
// Complete lookups.
"char-trailing": {"foo/whiteout", openResult{handlePath: "/foo/whiteout", fileType: unix.S_IFCHR}},
"blk-trailing": {"foo/whiteout-blk", openResult{handlePath: "/foo/whiteout-blk", fileType: unix.S_IFBLK}},
// Partial lookups due to hitting a non-directory.
"char-dot": {"foo/whiteout/.", openResult{err: unix.ENOTDIR}},
"char-dotdot1": {"foo/whiteout/..", openResult{err: unix.ENOTDIR}},
"char-dotdot2": {"foo/whiteout/../foo/bar", openResult{err: unix.ENOTDIR}},
"blk-dot": {"foo/whiteout-blk/.", openResult{err: unix.ENOTDIR}},
"blk-dotdot1": {"foo/whiteout-blk/..", openResult{err: unix.ENOTDIR}},
"blk-dotdot2": {"foo/whiteout-blk/../foo/bar", openResult{err: unix.ENOTDIR}},
} {
test := test // copy iterator
// Update the handlePath to be inside our root.
if test.expected.handlePath != "" {
test.expected.handlePath = filepath.Join(root, test.expected.handlePath)
}
t.Run(name, func(t *testing.T) {
checkOpenInRoot(t, OpenInRoot, root, test.unsafePath, test.expected)
})
}
})
}
|
