1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650
|
// Copyright 2015 go-swagger maintainers
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package runtime
import (
"bytes"
"encoding/csv"
"errors"
"io"
"net/http/httptest"
"strings"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
const (
csvFixture = `name,country,age
John,US,19
Mike,US,20
`
badCSVFixture = `name,country,age
John,US,19
Mike,US
`
commentedCSVFixture = `# heading line
name,country,age
#John's record
John,US,19
#Mike's record
Mike,US,20
`
)
var testCSVRecords = [][]string{
{"name", "country", "age"},
{"John", "US", "19"},
{"Mike", "US", "20"},
}
func TestCSVConsumer(t *testing.T) {
consumer := CSVConsumer()
t.Run("can consume as a *csv.Writer", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
var buf bytes.Buffer
dest := csv.NewWriter(&buf)
err := consumer.Consume(reader, dest)
require.NoError(t, err)
assert.Equal(t, csvFixture, buf.String())
})
t.Run("can consume as a CSVReader", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
var dest csvRecordsWriter
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assertCSVRecords(t, dest.records)
})
t.Run("can consume as a Writer", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
var dest closingWriter
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assert.Equal(t, csvFixture, dest.b.String())
})
t.Run("can consume as a ReaderFrom", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
var dest readerFromDummy
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assert.Equal(t, csvFixture, dest.b.String())
})
t.Run("can consume as a BinaryUnmarshaler", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
var dest binaryUnmarshalDummy
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assert.Equal(t, csvFixture, dest.str)
})
t.Run("can consume as a *[][]string", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
dest := [][]string{}
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assertCSVRecords(t, dest)
})
t.Run("can consume as an alias to *[][]string", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
type records [][]string
var dest records
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assertCSVRecords(t, dest)
})
t.Run("can consume as a *[]byte", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
var dest []byte
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assert.Equal(t, csvFixture, string(dest))
})
t.Run("can consume as an alias to *[]byte", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
type buffer []byte
var dest buffer
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assert.Equal(t, csvFixture, string(dest))
})
t.Run("can consume as a *string", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
var dest string
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assert.Equal(t, csvFixture, dest)
})
t.Run("can consume as an alias to *string", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
type buffer string
var dest buffer
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assert.Equal(t, csvFixture, string(dest))
})
t.Run("can consume from an empty reader", func(t *testing.T) {
reader := &csvEmptyReader{}
var dest bytes.Buffer
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assert.Empty(t, dest.String())
})
t.Run("error cases", func(t *testing.T) {
t.Run("nil data is never accepted", func(t *testing.T) {
var rdr bytes.Buffer
require.Error(t, consumer.Consume(&rdr, nil))
})
t.Run("nil readers should also never be acccepted", func(t *testing.T) {
var buf bytes.Buffer
err := consumer.Consume(nil, &buf)
require.Error(t, err)
})
t.Run("data must be a pointer", func(t *testing.T) {
var rdr bytes.Buffer
var dest []byte
err := consumer.Consume(&rdr, dest)
require.Error(t, err)
})
t.Run("unsupported type", func(t *testing.T) {
var rdr bytes.Buffer
var dest struct{}
err := consumer.Consume(&rdr, &dest)
require.Error(t, err)
})
t.Run("should propagate CSV error (buffered)", func(t *testing.T) {
reader := bytes.NewBufferString(badCSVFixture)
var dest []byte
err := consumer.Consume(reader, &dest)
require.Error(t, err)
require.EqualError(t, err, "record on line 3: wrong number of fields")
})
t.Run("should propagate CSV error (buffered, string)", func(t *testing.T) {
reader := bytes.NewBufferString(badCSVFixture)
var dest string
err := consumer.Consume(reader, &dest)
require.Error(t, err)
require.EqualError(t, err, "record on line 3: wrong number of fields")
})
t.Run("should propagate CSV error (buffered, ReaderFrom)", func(t *testing.T) {
reader := bytes.NewBufferString(badCSVFixture)
var dest readerFromDummy
err := consumer.Consume(reader, &dest)
require.Error(t, err)
require.EqualError(t, err, "record on line 3: wrong number of fields")
})
t.Run("should propagate CSV error (buffered, BinaryUnmarshaler)", func(t *testing.T) {
reader := bytes.NewBufferString(badCSVFixture)
var dest binaryUnmarshalDummy
err := consumer.Consume(reader, &dest)
require.Error(t, err)
require.EqualError(t, err, "record on line 3: wrong number of fields")
})
t.Run("should propagate CSV error (streaming)", func(t *testing.T) {
reader := bytes.NewBufferString(badCSVFixture)
var dest bytes.Buffer
err := consumer.Consume(reader, &dest)
require.Error(t, err)
require.EqualError(t, err, "record on line 3: wrong number of fields")
})
t.Run("should propagate CSV error (streaming, write error)", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
var buf bytes.Buffer
dest := csvWriterDummy{err: errors.New("test error"), Writer: csv.NewWriter(&buf)}
err := consumer.Consume(reader, &dest)
require.Error(t, err)
require.EqualError(t, err, "test error")
})
t.Run("should propagate ReaderFrom error", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
dest := readerFromDummy{err: errors.New("test error")}
err := consumer.Consume(reader, &dest)
require.Error(t, err)
require.EqualError(t, err, "test error")
})
t.Run("should propagate BinaryUnmarshaler error", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
dest := binaryUnmarshalDummy{err: errors.New("test error")}
err := consumer.Consume(reader, &dest)
require.Error(t, err)
require.EqualError(t, err, "test error")
})
})
}
func TestCSVConsumerWithOptions(t *testing.T) {
semiColonFixture := strings.ReplaceAll(csvFixture, ",", ";")
t.Run("with CSV reader Comma", func(t *testing.T) {
consumer := CSVConsumer(WithCSVReaderOpts(csv.Reader{Comma: ';', FieldsPerRecord: 3}))
t.Run("should not read comma-separated input", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
var dest bytes.Buffer
err := consumer.Consume(reader, &dest)
require.Error(t, err)
require.EqualError(t, err, "record on line 1: wrong number of fields")
})
t.Run("should read semicolon-separated input and convert it to colon-separated", func(t *testing.T) {
reader := bytes.NewBufferString(semiColonFixture)
var dest bytes.Buffer
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assert.Equal(t, csvFixture, dest.String())
})
})
t.Run("with CSV reader Comment", func(t *testing.T) {
consumer := CSVConsumer(WithCSVReaderOpts(csv.Reader{Comment: '#'}))
t.Run("should read input and skip commented lines", func(t *testing.T) {
reader := bytes.NewBufferString(commentedCSVFixture)
var dest [][]string
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assertCSVRecords(t, dest)
})
})
t.Run("with CSV writer Comma", func(t *testing.T) {
consumer := CSVConsumer(WithCSVWriterOpts(csv.Writer{Comma: ';'}))
t.Run("should read comma-separated input and convert it to semicolon-separated", func(t *testing.T) {
reader := bytes.NewBufferString(csvFixture)
var dest bytes.Buffer
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assert.Equal(t, semiColonFixture, dest.String())
})
})
t.Run("with SkipLines (streaming)", func(t *testing.T) {
consumer := CSVConsumer(WithCSVSkipLines(1))
reader := bytes.NewBufferString(csvFixture)
var dest [][]string
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
expected := testCSVRecords[1:]
assert.Equalf(t, expected, dest, "expected output to skip header")
})
t.Run("with SkipLines (buffered)", func(t *testing.T) {
consumer := CSVConsumer(WithCSVSkipLines(1))
reader := bytes.NewBufferString(csvFixture)
var dest []byte
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
r := csv.NewReader(bytes.NewReader(dest))
consumed, err := r.ReadAll()
require.NoError(t, err)
expected := testCSVRecords[1:]
assert.Equalf(t, expected, consumed, "expected output to skip header")
})
t.Run("should detect errors on skipped lines (streaming)", func(t *testing.T) {
consumer := CSVConsumer(WithCSVSkipLines(1))
reader := bytes.NewBufferString(strings.ReplaceAll(csvFixture, ",age", `,"age`))
var dest [][]string
err := consumer.Consume(reader, &dest)
require.Error(t, err)
require.ErrorContains(t, err, "record on line 1; parse error")
})
t.Run("should detect errors on skipped lines (buffered)", func(t *testing.T) {
consumer := CSVConsumer(WithCSVSkipLines(1))
reader := bytes.NewBufferString(strings.ReplaceAll(csvFixture, ",age", `,"age`))
var dest []byte
err := consumer.Consume(reader, &dest)
require.Error(t, err)
require.ErrorContains(t, err, "record on line 1; parse error")
})
t.Run("with SkipLines greater than the total number of lines (streaming)", func(t *testing.T) {
consumer := CSVConsumer(WithCSVSkipLines(4))
reader := bytes.NewBufferString(csvFixture)
var dest [][]string
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assert.Empty(t, dest)
})
t.Run("with SkipLines greater than the total number of lines (buffered)", func(t *testing.T) {
consumer := CSVConsumer(WithCSVSkipLines(4))
reader := bytes.NewBufferString(csvFixture)
var dest []byte
err := consumer.Consume(reader, &dest)
require.NoError(t, err)
assert.Empty(t, dest)
})
t.Run("with CloseStream", func(t *testing.T) {
t.Run("wants to close stream", func(t *testing.T) {
closingConsumer := CSVConsumer(WithCSVClosesStream())
var dest bytes.Buffer
r := &closingReader{b: bytes.NewBufferString(csvFixture)}
require.NoError(t, closingConsumer.Consume(r, &dest))
assert.Equal(t, csvFixture, dest.String())
assert.EqualValues(t, 1, r.calledClose)
})
t.Run("don't want to close stream", func(t *testing.T) {
nonClosingConsumer := CSVConsumer()
var dest bytes.Buffer
r := &closingReader{b: bytes.NewBufferString(csvFixture)}
require.NoError(t, nonClosingConsumer.Consume(r, &dest))
assert.Equal(t, csvFixture, dest.String())
assert.EqualValues(t, 0, r.calledClose)
})
})
}
func TestCSVProducer(t *testing.T) {
producer := CSVProducer()
t.Run("can produce CSV from *csv.Reader", func(t *testing.T) {
writer := new(bytes.Buffer)
buf := bytes.NewBufferString(csvFixture)
data := csv.NewReader(buf)
err := producer.Produce(writer, data)
require.NoError(t, err)
assert.Equal(t, csvFixture, writer.String())
})
t.Run("can produce CSV from CSVReader", func(t *testing.T) {
writer := new(bytes.Buffer)
data := &csvRecordsWriter{
records: testCSVRecords,
}
err := producer.Produce(writer, data)
require.NoError(t, err)
assert.Equal(t, csvFixture, writer.String())
})
t.Run("can produce CSV from Reader", func(t *testing.T) {
writer := new(bytes.Buffer)
data := bytes.NewReader([]byte(csvFixture))
err := producer.Produce(writer, data)
require.NoError(t, err)
assert.Equal(t, csvFixture, writer.String())
})
t.Run("can produce CSV from WriterTo", func(t *testing.T) {
writer := new(bytes.Buffer)
buf := bytes.NewBufferString(csvFixture)
data := &writerToDummy{
b: *buf,
}
err := producer.Produce(writer, data)
require.NoError(t, err)
assert.Equal(t, csvFixture, writer.String())
})
t.Run("can produce CSV from BinaryMarshaler", func(t *testing.T) {
writer := new(bytes.Buffer)
data := &binaryMarshalDummy{str: csvFixture}
err := producer.Produce(writer, data)
require.NoError(t, err)
assert.Equal(t, csvFixture, writer.String())
})
t.Run("can produce CSV from [][]string", func(t *testing.T) {
writer := new(bytes.Buffer)
data := testCSVRecords
err := producer.Produce(writer, data)
require.NoError(t, err)
assert.Equal(t, csvFixture, writer.String())
})
t.Run("can produce CSV from alias to [][]string", func(t *testing.T) {
writer := new(bytes.Buffer)
type records [][]string
data := records(testCSVRecords)
err := producer.Produce(writer, data)
require.NoError(t, err)
assert.Equal(t, csvFixture, writer.String())
})
t.Run("can produce CSV from []byte", func(t *testing.T) {
writer := httptest.NewRecorder()
data := []byte(csvFixture)
err := producer.Produce(writer, data)
require.NoError(t, err)
assert.Equal(t, csvFixture, writer.Body.String())
})
t.Run("can produce CSV from alias to []byte", func(t *testing.T) {
writer := httptest.NewRecorder()
type buffer []byte
data := buffer(csvFixture)
err := producer.Produce(writer, data)
require.NoError(t, err)
assert.Equal(t, csvFixture, writer.Body.String())
})
t.Run("can produce CSV from string", func(t *testing.T) {
writer := httptest.NewRecorder()
data := csvFixture
err := producer.Produce(writer, data)
require.NoError(t, err)
assert.Equal(t, csvFixture, writer.Body.String())
})
t.Run("can produce CSV from alias to string", func(t *testing.T) {
writer := httptest.NewRecorder()
type buffer string
data := buffer(csvFixture)
err := producer.Produce(writer, data)
require.NoError(t, err)
assert.Equal(t, csvFixture, writer.Body.String())
})
t.Run("always close data reader whenever possible", func(t *testing.T) {
nonClosingProducer := CSVProducer()
r := &closingWriter{}
data := &closingReader{b: bytes.NewBufferString(csvFixture)}
require.NoError(t, nonClosingProducer.Produce(r, data))
assert.Equal(t, csvFixture, r.String())
assert.EqualValuesf(t, 0, r.calledClose, "expected the input reader NOT to be closed")
assert.EqualValuesf(t, 1, data.calledClose, "expected the data reader to be closed")
})
t.Run("error cases", func(t *testing.T) {
t.Run("unsupported type", func(t *testing.T) {
writer := httptest.NewRecorder()
var data struct{}
err := producer.Produce(writer, data)
require.Error(t, err)
})
t.Run("data cannot be nil", func(t *testing.T) {
writer := httptest.NewRecorder()
err := producer.Produce(writer, nil)
require.Error(t, err)
})
t.Run("writer cannot be nil", func(t *testing.T) {
data := []byte(csvFixture)
err := producer.Produce(nil, data)
require.Error(t, err)
})
t.Run("should propagate error from BinaryMarshaler", func(t *testing.T) {
var rdr bytes.Buffer
data := new(binaryMarshalDummy)
err := producer.Produce(&rdr, data)
require.Error(t, err)
require.ErrorContains(t, err, "no text set")
})
})
}
func TestCSVProducerWithOptions(t *testing.T) {
t.Run("with CloseStream", func(t *testing.T) {
t.Run("wants to close stream", func(t *testing.T) {
closingProducer := CSVProducer(WithCSVClosesStream())
r := &closingWriter{}
data := bytes.NewBufferString(csvFixture)
require.NoError(t, closingProducer.Produce(r, data))
assert.Equal(t, csvFixture, r.String())
assert.EqualValues(t, 1, r.calledClose)
})
t.Run("don't want to close stream", func(t *testing.T) {
nonClosingProducer := CSVProducer()
r := &closingWriter{}
data := bytes.NewBufferString(csvFixture)
require.NoError(t, nonClosingProducer.Produce(r, data))
assert.Equal(t, csvFixture, r.String())
assert.EqualValues(t, 0, r.calledClose)
})
})
}
func assertCSVRecords(t testing.TB, dest [][]string) {
assert.Len(t, dest, 3)
for i, record := range dest {
assert.Equal(t, testCSVRecords[i], record)
}
}
type csvEmptyReader struct{}
func (r *csvEmptyReader) Read(_ []byte) (int, error) {
return 0, io.EOF
}
type readerFromDummy struct {
err error
b bytes.Buffer
}
func (r *readerFromDummy) ReadFrom(rdr io.Reader) (int64, error) {
if r.err != nil {
return 0, r.err
}
return r.b.ReadFrom(rdr)
}
type writerToDummy struct {
b bytes.Buffer
}
func (w *writerToDummy) WriteTo(writer io.Writer) (int64, error) {
return w.b.WriteTo(writer)
}
type csvWriterDummy struct {
err error
*csv.Writer
}
func (w *csvWriterDummy) Write(record []string) error {
if w.err != nil {
return w.err
}
return w.Writer.Write(record)
}
func (w *csvWriterDummy) Error() error {
if w.err != nil {
return w.err
}
return w.Writer.Error()
}
|