1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405
|
// Copyright 2015 go-swagger maintainers
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package spec_test
import (
"path/filepath"
"strings"
"testing"
"github.com/go-openapi/spec"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
// Test unitary fixture for dev and bug fixing
func TestSpec_Issue2743(t *testing.T) {
t.Run("should expand but produce unresolvable $ref", func(t *testing.T) {
path := filepath.Join("fixtures", "bugs", "2743", "working", "spec.yaml")
sp := loadOrFail(t, path)
require.NoError(t,
spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: true, PathLoader: testLoader}),
)
t.Run("all $ref do not resolve when expanding again", func(t *testing.T) {
err := spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: false, PathLoader: testLoader})
require.Error(t, err)
require.ErrorContains(t, err, filepath.FromSlash("swagger/paths/swagger/user/index.yml"))
})
})
t.Run("should expand and produce resolvable $ref", func(t *testing.T) {
path := filepath.Join("fixtures", "bugs", "2743", "not-working", "spec.yaml")
sp := loadOrFail(t, path)
require.NoError(t,
spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: true, PathLoader: testLoader}),
)
t.Run("all $ref properly reolve when expanding again", func(t *testing.T) {
require.NoError(t,
spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: false, PathLoader: testLoader}),
)
require.NotContainsf(t, asJSON(t, sp), "$ref", "all $ref's should have been expanded properly")
})
})
}
func TestSpec_Issue1429(t *testing.T) {
path := filepath.Join("fixtures", "bugs", "1429", "swagger.yaml")
// load and full expand
sp := loadOrFail(t, path)
err := spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: false, PathLoader: testLoader})
require.NoError(t, err)
// assert well expanded
require.Truef(t, (sp.Paths != nil && sp.Paths.Paths != nil), "expected paths to be available in fixture")
assertPaths1429(t, sp)
for _, def := range sp.Definitions {
assert.Empty(t, def.Ref)
}
// reload and SkipSchemas: true
sp = loadOrFail(t, path)
err = spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: true, PathLoader: testLoader})
require.NoError(t, err)
// assert well resolved
require.Truef(t, (sp.Paths != nil && sp.Paths.Paths != nil), "expected paths to be available in fixture")
assertPaths1429SkipSchema(t, sp)
for _, def := range sp.Definitions {
assert.Contains(t, def.Ref.String(), "responses.yaml#/definitions/")
}
}
func assertPaths1429(t testing.TB, sp *spec.Swagger) {
for _, pi := range sp.Paths.Paths {
for _, param := range pi.Get.Parameters {
require.NotNilf(t, param.Schema, "expected param schema not to be nil")
// all param fixtures are body param with schema
// all $ref expanded
assert.Equal(t, "", param.Schema.Ref.String())
}
for code, response := range pi.Get.Responses.StatusCodeResponses {
// all response fixtures are with StatusCodeResponses, but 200
if code == 200 {
assert.Nilf(t, response.Schema, "expected response schema to be nil")
continue
}
require.NotNilf(t, response.Schema, "expected response schema not to be nil")
assert.Equal(t, "", response.Schema.Ref.String())
}
}
}
func assertPaths1429SkipSchema(t testing.TB, sp *spec.Swagger) {
for _, pi := range sp.Paths.Paths {
for _, param := range pi.Get.Parameters {
require.NotNilf(t, param.Schema, "expected param schema not to be nil")
// all param fixtures are body param with schema
switch param.Name {
case "plainRequest":
// this one is expanded
assert.Equal(t, "", param.Schema.Ref.String())
continue
case "nestedBody":
// this one is local
assert.Truef(t, strings.HasPrefix(param.Schema.Ref.String(), "#/definitions/"),
"expected rooted definitions $ref, got: %s", param.Schema.Ref.String())
continue
case "remoteRequest":
assert.Contains(t, param.Schema.Ref.String(), "remote/remote.yaml#/")
continue
}
assert.Contains(t, param.Schema.Ref.String(), "responses.yaml#/")
}
for code, response := range pi.Get.Responses.StatusCodeResponses {
// all response fixtures are with StatusCodeResponses, but 200
switch code {
case 200:
assert.Nilf(t, response.Schema, "expected response schema to be nil")
continue
case 204:
assert.Contains(t, response.Schema.Ref.String(), "remote/remote.yaml#/")
continue
case 404:
assert.Equal(t, "", response.Schema.Ref.String())
continue
}
assert.Containsf(t, response.Schema.Ref.String(), "responses.yaml#/", "expected remote ref at resp. %d", code)
}
}
}
func TestSpec_MoreLocalExpansion(t *testing.T) {
path := filepath.Join("fixtures", "local_expansion", "spec2.yaml")
// load and full expand
sp := loadOrFail(t, path)
require.NoError(t, spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: false, PathLoader: testLoader}))
// asserts all $ref are expanded
assert.NotContains(t, asJSON(t, sp), `"$ref"`)
}
func TestSpec_Issue69(t *testing.T) {
// this checks expansion for the dapperbox spec (circular ref issues)
path := filepath.Join("fixtures", "bugs", "69", "dapperbox.json")
// expand with relative path
// load and expand
sp := loadOrFail(t, path)
require.NoError(t, spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: false, PathLoader: testLoader}))
// asserts all $ref expanded
jazon := asJSON(t, sp)
// circular $ref are not expanded: however, they point to the expanded root document
// assert all $ref match "$ref": "#/definitions/something"
assertRefInJSON(t, jazon, "#/definitions")
// assert all $ref expand correctly against the spec
assertRefExpand(t, jazon, "", sp)
}
func TestSpec_Issue1621(t *testing.T) {
path := filepath.Join("fixtures", "bugs", "1621", "fixture-1621.yaml")
// expand with relative path
// load and expand
sp := loadOrFail(t, path)
err := spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: false, PathLoader: testLoader})
require.NoError(t, err)
// asserts all $ref expanded
jazon := asJSON(t, sp)
assertNoRef(t, jazon)
}
func TestSpec_Issue1614(t *testing.T) {
path := filepath.Join("fixtures", "bugs", "1614", "gitea.json")
// expand with relative path
// load and expand
sp := loadOrFail(t, path)
require.NoError(t, spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: false, PathLoader: testLoader}))
// asserts all $ref expanded
jazon := asJSON(t, sp)
// assert all $ref match "$ref": "#/definitions/something"
assertRefInJSON(t, jazon, "#/definitions")
// assert all $ref expand correctly against the spec
assertRefExpand(t, jazon, "", sp)
// now with option CircularRefAbsolute: circular $ref are not denormalized and are kept absolute.
// This option is essentially for debugging purpose.
sp = loadOrFail(t, path)
require.NoError(t, spec.ExpandSpec(sp, &spec.ExpandOptions{
RelativeBase: path,
SkipSchemas: false,
AbsoluteCircularRef: true,
PathLoader: testLoader,
}))
// asserts all $ref expanded
jazon = asJSON(t, sp)
// assert all $ref match "$ref": "file://{file}#/definitions/something"
assertRefInJSONRegexp(t, jazon, `file://.*/gitea.json#/definitions/`)
// assert all $ref expand correctly against the spec
assertRefExpand(t, jazon, "", sp, &spec.ExpandOptions{RelativeBase: path})
}
func TestSpec_Issue2113(t *testing.T) {
// this checks expansion with nested specs
path := filepath.Join("fixtures", "bugs", "2113", "base.yaml")
// load and expand
sp := loadOrFail(t, path)
err := spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: false, PathLoader: testLoader})
require.NoError(t, err)
// asserts all $ref expanded
jazon := asJSON(t, sp)
// assert all $ref match have been expanded
assertNoRef(t, jazon)
// now trying with SkipSchemas
sp = loadOrFail(t, path)
err = spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: true, PathLoader: testLoader})
require.NoError(t, err)
jazon = asJSON(t, sp)
// assert all $ref match
assertRefInJSONRegexp(t, jazon, `^(schemas/dummy/dummy.yaml)|(schemas/example/example.yaml)`)
// assert all $ref resolve correctly against the spec
assertRefResolve(t, jazon, "", sp, &spec.ExpandOptions{RelativeBase: path, PathLoader: testLoader})
// assert all $ref expand correctly against the spec
assertRefExpand(t, jazon, "", sp, &spec.ExpandOptions{RelativeBase: path, PathLoader: testLoader})
}
func TestSpec_Issue2113_External(t *testing.T) {
// Exercises the SkipSchema mode (used by spec flattening in go-openapi/analysis).
// Provides more ground for testing with schemas nested in $refs
// this checks expansion with nested specs
path := filepath.Join("fixtures", "skipschema", "external_definitions_valid.yml")
// load and expand, skipping schema expansion
sp := loadOrFail(t, path)
require.NoError(t, spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: true, PathLoader: testLoader}))
// asserts all $ref are expanded as expected
jazon := asJSON(t, sp)
assertRefInJSONRegexp(t, jazon, `^(external/definitions.yml#/definitions)|(external/errors.yml#/error)|(external/nestedParams.yml#/bodyParam)`)
// assert all $ref resolve correctly against the spec
assertRefResolve(t, jazon, "", sp, &spec.ExpandOptions{RelativeBase: path, PathLoader: testLoader})
// assert all $ref in jazon expand correctly against the spec
assertRefExpand(t, jazon, "", sp, &spec.ExpandOptions{RelativeBase: path, PathLoader: testLoader})
// expansion can be iterated again, including schemas
require.NoError(t, spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: false, PathLoader: testLoader}))
jazon = asJSON(t, sp)
assertNoRef(t, jazon)
// load and expand everything
sp = loadOrFail(t, path)
require.NoError(t, spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: false, PathLoader: testLoader}))
jazon = asJSON(t, sp)
assertNoRef(t, jazon)
}
func TestSpec_Issue2113_SkipSchema(t *testing.T) {
// Exercises the SkipSchema mode from spec flattening in go-openapi/analysis
// Provides more ground for testing with schemas nested in $refs
// this checks expansion with nested specs
path := filepath.Join("fixtures", "flatten", "flatten.yml")
// load and expand, skipping schema expansion
sp := loadOrFail(t, path)
require.NoError(t, spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: true, PathLoader: testLoader}))
jazon := asJSON(t, sp)
// asserts all $ref are expanded as expected
assertRefInJSONRegexp(t, jazon, `^(external/definitions.yml#/definitions)|(#/definitions/namedAgain)|(external/errors.yml#/error)`)
// assert all $ref resolve correctly against the spec
assertRefResolve(t, jazon, "", sp, &spec.ExpandOptions{RelativeBase: path, PathLoader: testLoader})
assertRefExpand(t, jazon, "", sp, &spec.ExpandOptions{RelativeBase: path, PathLoader: testLoader})
// load and expand, including schemas
sp = loadOrFail(t, path)
require.NoError(t, spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: false, PathLoader: testLoader}))
jazon = asJSON(t, sp)
assertNoRef(t, jazon)
}
func TestSpec_PointersLoop(t *testing.T) {
// this a spec that cannot be flattened (self-referencing pointer).
// however, it should be expanded without errors
// this checks expansion with nested specs
path := filepath.Join("fixtures", "more_circulars", "pointers", "fixture-pointers-loop.yaml")
// load and expand, skipping schema expansion
sp := loadOrFail(t, path)
require.NoError(t, spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: true, PathLoader: testLoader}))
jazon := asJSON(t, sp)
assertRefExpand(t, jazon, "", sp, &spec.ExpandOptions{RelativeBase: path, PathLoader: testLoader})
sp = loadOrFail(t, path)
require.NoError(t, spec.ExpandSpec(sp, &spec.ExpandOptions{RelativeBase: path, SkipSchemas: false, PathLoader: testLoader}))
// cannot guarantee which ref will be kept, but only one remains: expand reduces all $ref down
// to the last self-referencing one (the one picked changes from one run to another, depending
// on where during the walk the cycle is detected).
jazon = asJSON(t, sp)
m := rex.FindAllStringSubmatch(jazon, -1)
require.NotEmpty(t, m)
refs := make(map[string]struct{}, 5)
for _, matched := range m {
subMatch := matched[1]
refs[subMatch] = struct{}{}
}
require.Len(t, refs, 1)
assertRefExpand(t, jazon, "", sp, &spec.ExpandOptions{RelativeBase: path, PathLoader: testLoader})
}
func TestSpec_Issue102(t *testing.T) {
// go-openapi/validate/issues#102
path := filepath.Join("fixtures", "bugs", "102", "fixture-102.json")
sp := loadOrFail(t, path)
require.NoError(t, spec.ExpandSpec(sp, nil))
jazon := asJSON(t, sp)
assertRefInJSONRegexp(t, jazon, `^#/definitions/Error$`)
sp = loadOrFail(t, path)
sch := spec.RefSchema("#/definitions/Error")
require.NoError(t, spec.ExpandSchema(sch, sp, nil))
jazon = asJSON(t, sch)
assertRefInJSONRegexp(t, jazon, "^#/definitions/Error$")
sp = loadOrFail(t, path)
sch = spec.RefSchema("#/definitions/Error")
resp := spec.NewResponse().WithDescription("ok").WithSchema(sch)
require.NoError(t, spec.ExpandResponseWithRoot(resp, sp, nil))
jazon = asJSON(t, resp)
assertRefInJSONRegexp(t, jazon, "^#/definitions/Error$")
sp = loadOrFail(t, path)
sch = spec.RefSchema("#/definitions/Error")
param := spec.BodyParam("error", sch)
require.NoError(t, spec.ExpandParameterWithRoot(param, sp, nil))
jazon = asJSON(t, resp)
assertRefInJSONRegexp(t, jazon, "^#/definitions/Error$")
}
|