1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366
|
package zk
import (
"context"
"encoding/hex"
"errors"
"fmt"
"io"
"math/rand"
"net"
"os"
"path/filepath"
"reflect"
"regexp"
"sort"
"strconv"
"strings"
"sync"
"sync/atomic"
"testing"
"time"
)
func TestIntegration_StateChanges(t *testing.T) {
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
if err != nil {
t.Fatal(err)
}
defer ts.Stop()
callbackChan := make(chan Event)
f := func(event Event) {
callbackChan <- event
}
zk, eventChan, err := ts.ConnectWithOptions(15*time.Second, WithEventCallback(f))
if err != nil {
t.Fatalf("Connect returned error: %+v", err)
}
verifyEventOrder := func(c <-chan Event, expectedStates []State, source string) {
for _, state := range expectedStates {
for {
event, ok := <-c
if !ok {
t.Fatalf("unexpected channel close for %s", source)
}
if event.Type != EventSession {
continue
}
if event.State != state {
t.Fatalf("mismatched state order from %s, expected %v, received %v", source, state, event.State)
}
break
}
}
}
states := []State{StateConnecting, StateConnected, StateHasSession}
verifyEventOrder(callbackChan, states, "callback")
verifyEventOrder(eventChan, states, "event channel")
zk.Close()
verifyEventOrder(callbackChan, []State{StateDisconnected}, "callback")
verifyEventOrder(eventChan, []State{StateDisconnected}, "event channel")
}
func TestIntegration_Create(t *testing.T) {
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
requireNoErrorf(t, err)
defer ts.Stop()
zk, _, err := ts.ConnectAll()
requireNoErrorf(t, err, "ConnectAll()")
defer zk.Close()
tests := []struct {
name string
createFlags int32
specifiedPath string
wantErr string
}{
{
name: "valid create persistant",
createFlags: FlagPersistent,
},
{
name: "valid container from Create",
createFlags: FlagContainer,
// NOTE for v2: we dont need CreateContainer method.
},
{
name: "invalid path",
specifiedPath: "not/valid",
wantErr: "zk: invalid path",
},
{
name: "invalid create ttl",
createFlags: FlagTTL,
wantErr: "zk: invalid flags specified",
},
{
name: "invalid flag for create mode",
createFlags: 999,
wantErr: "invalid flag value: [999]",
},
}
const testPath = "/ttl_znode_tests"
// create sub node to create per test in avoiding using the root path.
_, err = zk.Create(testPath, nil /* data */, FlagPersistent, WorldACL(PermAll))
requireNoErrorf(t, err)
for idx, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
path := filepath.Join(testPath, fmt.Sprint(idx))
if tt.specifiedPath != "" {
path = tt.specifiedPath
}
_, err := zk.Create(path, []byte{12}, tt.createFlags, WorldACL(PermAll))
if tt.wantErr == "" {
requireNoErrorf(t, err, fmt.Sprintf("error not expected: path; %q; flags %v", path, tt.createFlags))
return
}
// want an error
if err == nil {
t.Fatalf("did not get expected error: %q", tt.wantErr)
}
if !strings.Contains(err.Error(), tt.wantErr) {
t.Fatalf("wanted error not found: %v; got: %v", tt.wantErr, err.Error())
}
})
}
}
func TestIntegration_CreateTTL(t *testing.T) {
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
requireNoErrorf(t, err)
defer ts.Stop()
zk, _, err := ts.ConnectAll()
requireNoErrorf(t, err, "ConnectAll()")
defer zk.Close()
tests := []struct {
name string
createFlags int32
specifiedPath string
giveDuration time.Duration
wantErr string
wantErrIs error
}{
{
name: "valid create ttl",
specifiedPath: "/test-valid-create-ttl",
createFlags: FlagTTL,
giveDuration: time.Minute,
},
{
name: "valid change detector",
specifiedPath: "/test-valid-change",
createFlags: 5,
giveDuration: time.Minute,
},
{
name: "invalid path",
createFlags: FlagTTL,
specifiedPath: "not/valid",
wantErr: "zk: invalid path",
wantErrIs: ErrInvalidPath,
},
{
name: "invalid container with ttl",
specifiedPath: "/test-invalid-flags",
createFlags: FlagContainer,
wantErr: "zk: invalid flags specified",
wantErrIs: ErrInvalidFlags,
},
{
name: "invalid flag for create mode",
specifiedPath: "/test-invalid-mode",
createFlags: 999,
giveDuration: time.Minute,
wantErr: "invalid flag value: [999]",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if tt.specifiedPath == "" {
t.Fatalf("path for test required: %v", tt.name)
}
_, err := zk.CreateTTL(tt.specifiedPath, []byte{12}, tt.createFlags, WorldACL(PermAll), tt.giveDuration)
if tt.wantErr == "" {
requireNoErrorf(t, err,
fmt.Sprintf("error not expected: path; %q; flags %v", tt.specifiedPath, tt.createFlags))
return
}
// want an error
if tt.wantErrIs != nil {
if !errors.Is(err, tt.wantErrIs) {
t.Errorf("error expected Is: %q", tt.wantErr)
}
}
if err == nil {
t.Errorf("did not get expected error: %q", tt.wantErr)
}
if !strings.Contains(err.Error(), tt.wantErr) {
t.Errorf("wanted error not found: %v; got: %v", tt.wantErr, err.Error())
}
})
}
}
// NOTE: Currently there is not a way to get the znode after creating and
// asserting it is once mode or another. This means these tests are only testing the
// path of creation, but is not asserting that the resulting znode is the
// mode we set with flags.
func TestIntegration_CreateContainer(t *testing.T) {
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
if err != nil {
t.Fatal(err)
}
defer ts.Stop()
zk, _, err := ts.ConnectAll()
if err != nil {
t.Fatalf("Connect returned error: %+v", err)
}
defer zk.Close()
tests := []struct {
name string
createFlags int32
specifiedPath string
wantErr string
}{
{
name: "valid create container",
createFlags: FlagContainer,
},
{
name: "valid create container hard coded flag int",
createFlags: 4,
// container flag, ensure matches ZK Create Mode (change detector test)
},
{
name: "invalid path",
createFlags: FlagContainer,
specifiedPath: "not/valid",
wantErr: "zk: invalid path",
},
{
name: "invalid create mode",
createFlags: 999,
wantErr: "invalid flag value: [999]",
},
{
name: "invalid containers cannot be persistant",
createFlags: FlagPersistent,
wantErr: ErrInvalidFlags.Error(),
},
{
name: "invalid containers cannot be ephemeral",
createFlags: FlagEphemeral,
wantErr: ErrInvalidFlags.Error(),
},
{
name: "invalid containers cannot be sequential",
createFlags: FlagSequence,
wantErr: ErrInvalidFlags.Error(),
},
{
name: "invalid container and sequential",
createFlags: FlagContainer | FlagSequence,
wantErr: ErrInvalidFlags.Error(),
},
{
name: "invliad TTLs cannot be used with Container znodes",
createFlags: FlagTTL,
wantErr: ErrInvalidFlags.Error(),
},
}
const testPath = "/container_test_znode"
// create sub node to create per test in avoiding using the root path.
_, err = zk.Create(testPath, nil /* data */, FlagPersistent, WorldACL(PermAll))
requireNoErrorf(t, err)
for idx, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
path := filepath.Join(testPath, fmt.Sprint(idx))
if tt.specifiedPath != "" {
path = tt.specifiedPath
}
_, err := zk.CreateContainer(path, []byte{12}, tt.createFlags, WorldACL(PermAll))
if tt.wantErr == "" {
requireNoErrorf(t, err, fmt.Sprintf("error not expected: path; %q; flags %v", path, tt.createFlags))
return
}
// want an error
if err == nil {
t.Fatalf("did not get expected error: %q", tt.wantErr)
}
if !strings.Contains(err.Error(), tt.wantErr) {
t.Fatalf("wanted error not found: %v; got: %v", tt.wantErr, err.Error())
}
})
}
}
func TestIntegration_IncrementalReconfig(t *testing.T) {
requireMinimumZkVersion(t, "3.5")
ts, err := StartTestCluster(t, 3, nil, logWriter{t: t, p: "[ZKERR] "})
requireNoErrorf(t, err, "failed to setup test cluster")
defer ts.Stop()
// start and add a new server.
tmpPath := t.TempDir()
startPort := int(rand.Int31n(6000) + 10000)
srvPath := filepath.Join(tmpPath, fmt.Sprintf("srv4"))
if err := os.Mkdir(srvPath, 0700); err != nil {
requireNoErrorf(t, err, "failed to make server path")
}
testSrvConfig := ServerConfigServer{
ID: 4,
Host: "127.0.0.1",
PeerPort: startPort + 1,
LeaderElectionPort: startPort + 2,
}
cfg := ServerConfig{
ClientPort: startPort,
DataDir: srvPath,
Servers: []ServerConfigServer{testSrvConfig},
}
// TODO: clean all this server creating up to a better helper method
cfgPath := filepath.Join(srvPath, _testConfigName)
fi, err := os.Create(cfgPath)
requireNoErrorf(t, err)
requireNoErrorf(t, cfg.Marshall(fi))
fi.Close()
fi, err = os.Create(filepath.Join(srvPath, _testMyIDFileName))
requireNoErrorf(t, err)
_, err = fmt.Fprintln(fi, "4")
fi.Close()
requireNoErrorf(t, err)
testServer, err := NewIntegrationTestServer(t, cfgPath, nil, nil)
requireNoErrorf(t, err)
requireNoErrorf(t, testServer.Start())
defer testServer.Stop()
zk, events, err := ts.ConnectAll()
requireNoErrorf(t, err, "failed to connect to cluster")
defer zk.Close()
err = zk.AddAuth("digest", []byte("super:test"))
requireNoErrorf(t, err, "failed to auth to cluster")
waitCtx, cancel := context.WithTimeout(context.Background(), time.Second)
defer cancel()
err = waitForSession(waitCtx, events)
requireNoErrorf(t, err, "failed to wail for session")
_, _, err = zk.Get("/zookeeper/config")
if err != nil {
t.Fatalf("get config returned error: %+v", err)
}
// initially should be 1<<32, which is 0x100000000. This is the zxid
// of the first NEWLEADER message, used as the inital version
// reflect.DeepEqual(bytes.Split(data, []byte("\n")), []byte("version=100000000"))
// remove node 3.
_, err = zk.IncrementalReconfig(nil, []string{"3"}, -1)
if err != nil && err == ErrConnectionClosed {
t.Log("conneciton closed is fine since the cluster re-elects and we dont reconnect")
} else {
requireNoErrorf(t, err, "failed to remove node from cluster")
}
// add node a new 4th node
server := fmt.Sprintf("server.%d=%s:%d:%d;%d", testSrvConfig.ID, testSrvConfig.Host, testSrvConfig.PeerPort, testSrvConfig.LeaderElectionPort, cfg.ClientPort)
_, err = zk.IncrementalReconfig([]string{server}, nil, -1)
if err != nil && err == ErrConnectionClosed {
t.Log("conneciton closed is fine since the cluster re-elects and we dont reconnect")
} else {
requireNoErrorf(t, err, "failed to add new server to cluster")
}
}
func TestIntegration_Reconfig(t *testing.T) {
requireMinimumZkVersion(t, "3.5")
// This test enures we can do an non-incremental reconfig
ts, err := StartTestCluster(t, 3, nil, logWriter{t: t, p: "[ZKERR] "})
requireNoErrorf(t, err, "failed to setup test cluster")
defer ts.Stop()
zk, events, err := ts.ConnectAll()
requireNoErrorf(t, err, "failed to connect to cluster")
defer zk.Close()
err = zk.AddAuth("digest", []byte("super:test"))
requireNoErrorf(t, err, "failed to auth to cluster")
waitCtx, cancel := context.WithTimeout(context.Background(), time.Second)
defer cancel()
err = waitForSession(waitCtx, events)
requireNoErrorf(t, err, "failed to wail for session")
_, _, err = zk.Get("/zookeeper/config")
if err != nil {
t.Fatalf("get config returned error: %+v", err)
}
// essentially remove the first node
var s []string
for _, host := range ts.Config.Servers[1:] {
s = append(s, fmt.Sprintf("server.%d=%s:%d:%d;%d\n", host.ID, host.Host, host.PeerPort, host.LeaderElectionPort, ts.Config.ClientPort))
}
_, err = zk.Reconfig(s, -1)
requireNoErrorf(t, err, "failed to reconfig cluster")
// reconfig to all the hosts again
s = []string{}
for _, host := range ts.Config.Servers {
s = append(s, fmt.Sprintf("server.%d=%s:%d:%d;%d\n", host.ID, host.Host, host.PeerPort, host.LeaderElectionPort, ts.Config.ClientPort))
}
_, err = zk.Reconfig(s, -1)
requireNoErrorf(t, err, "failed to reconfig cluster")
}
func TestIntegration_OpsAfterCloseDontDeadlock(t *testing.T) {
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
if err != nil {
t.Fatal(err)
}
defer ts.Stop()
zk, _, err := ts.ConnectAll()
if err != nil {
t.Fatalf("Connect returned error: %+v", err)
}
zk.Close()
path := "/gozk-test"
ch := make(chan struct{})
go func() {
defer close(ch)
for range make([]struct{}, 30) {
if _, err := zk.Create(path, []byte{1, 2, 3, 4}, 0, WorldACL(PermAll)); err == nil {
t.Fatal("Create did not return error")
}
}
}()
select {
case <-ch:
// expected
case <-time.After(10 * time.Second):
t.Fatal("ZK connection deadlocked when executing ops after a Close operation")
}
}
func TestIntegration_Multi(t *testing.T) {
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
if err != nil {
t.Fatal(err)
}
defer ts.Stop()
zk, _, err := ts.ConnectAll()
if err != nil {
t.Fatalf("Connect returned error: %+v", err)
}
defer zk.Close()
path := "/gozk-test"
if err := zk.Delete(path, -1); err != nil && err != ErrNoNode {
t.Fatalf("Delete returned error: %+v", err)
}
ops := []interface{}{
&CreateRequest{Path: path, Data: []byte{1, 2, 3, 4}, Acl: WorldACL(PermAll)},
&SetDataRequest{Path: path, Data: []byte{1, 2, 3, 4}, Version: -1},
}
if res, err := zk.Multi(ops...); err != nil {
t.Fatalf("Multi returned error: %+v", err)
} else if len(res) != 2 {
t.Fatalf("Expected 2 responses got %d", len(res))
} else {
t.Logf("%+v", res)
}
if data, stat, err := zk.Get(path); err != nil {
t.Fatalf("Get returned error: %+v", err)
} else if stat == nil {
t.Fatal("Get returned nil stat")
} else if len(data) < 4 {
t.Fatal("Get returned wrong size data")
}
}
func TestIntegration_IfAuthdataSurvivesReconnect(t *testing.T) {
// This test case ensures authentication data is being resubmited after
// reconnect.
testNode := "/auth-testnode"
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
if err != nil {
t.Fatal(err)
}
defer ts.Stop()
zk, _, err := ts.ConnectAll()
if err != nil {
t.Fatalf("Connect returned error: %+v", err)
}
defer zk.Close()
acl := DigestACL(PermAll, "userfoo", "passbar")
_, err = zk.Create(testNode, []byte("Some very secret content"), 0, acl)
if err != nil && err != ErrNodeExists {
t.Fatalf("Failed to create test node : %+v", err)
}
_, _, err = zk.Get(testNode)
if err == nil || err != ErrNoAuth {
var msg string
if err == nil {
msg = "Fetching data without auth should have resulted in an error"
} else {
msg = fmt.Sprintf("Expecting ErrNoAuth, got `%+v` instead", err)
}
t.Fatalf(msg)
}
zk.AddAuth("digest", []byte("userfoo:passbar"))
_, _, err = zk.Get(testNode)
if err != nil {
t.Fatalf("Fetching data with auth failed: %+v", err)
}
ts.StopAllServers()
ts.StartAllServers()
_, _, err = zk.Get(testNode)
if err != nil {
t.Fatalf("Fetching data after reconnect failed: %+v", err)
}
}
func TestIntegration_MultiFailures(t *testing.T) {
// This test case ensures that we return the errors associated with each
// opeThis in the event a call to Multi() fails.
const firstPath = "/gozk-test-first"
const secondPath = "/gozk-test-second"
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
if err != nil {
t.Fatal(err)
}
defer ts.Stop()
zk, _, err := ts.ConnectAll()
if err != nil {
t.Fatalf("Connect returned error: %+v", err)
}
defer zk.Close()
// Ensure firstPath doesn't exist and secondPath does. This will cause the
// 2nd operation in the Multi() to fail.
if err := zk.Delete(firstPath, -1); err != nil && err != ErrNoNode {
t.Fatalf("Delete returned error: %+v", err)
}
if _, err := zk.Create(secondPath, nil /* data */, 0, WorldACL(PermAll)); err != nil {
t.Fatalf("Create returned error: %+v", err)
}
ops := []interface{}{
&CreateRequest{Path: firstPath, Data: []byte{1, 2}, Acl: WorldACL(PermAll)},
&CreateRequest{Path: secondPath, Data: []byte{3, 4}, Acl: WorldACL(PermAll)},
}
res, err := zk.Multi(ops...)
if err != ErrNodeExists {
t.Fatalf("Multi() didn't return correct error: %+v", err)
}
if len(res) != 2 {
t.Fatalf("Expected 2 responses received %d", len(res))
}
if res[0].Error != nil {
t.Fatalf("First operation returned an unexpected error %+v", res[0].Error)
}
if res[1].Error != ErrNodeExists {
t.Fatalf("Second operation returned incorrect error %+v", res[1].Error)
}
if _, _, err := zk.Get(firstPath); err != ErrNoNode {
t.Fatalf("Node %s was incorrectly created: %+v", firstPath, err)
}
}
func TestIntegration_GetSetACL(t *testing.T) {
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
if err != nil {
t.Fatal(err)
}
defer ts.Stop()
zk, _, err := ts.ConnectAll()
if err != nil {
t.Fatalf("Connect returned error: %+v", err)
}
defer zk.Close()
if err := zk.AddAuth("digest", []byte("blah")); err != nil {
t.Fatalf("AddAuth returned error %+v", err)
}
path := "/gozk-test"
if err := zk.Delete(path, -1); err != nil && err != ErrNoNode {
t.Fatalf("Delete returned error: %+v", err)
}
if path, err := zk.Create(path, []byte{1, 2, 3, 4}, 0, WorldACL(PermAll)); err != nil {
t.Fatalf("Create returned error: %+v", err)
} else if path != "/gozk-test" {
t.Fatalf("Create returned different path '%s' != '/gozk-test'", path)
}
expected := WorldACL(PermAll)
if acl, stat, err := zk.GetACL(path); err != nil {
t.Fatalf("GetACL returned error %+v", err)
} else if stat == nil {
t.Fatalf("GetACL returned nil Stat")
} else if len(acl) != 1 || expected[0] != acl[0] {
t.Fatalf("GetACL mismatch expected %+v instead of %+v", expected, acl)
}
expected = []ACL{{PermAll, "ip", "127.0.0.1"}}
if stat, err := zk.SetACL(path, expected, -1); err != nil {
t.Fatalf("SetACL returned error %+v", err)
} else if stat == nil {
t.Fatalf("SetACL returned nil Stat")
}
if acl, stat, err := zk.GetACL(path); err != nil {
t.Fatalf("GetACL returned error %+v", err)
} else if stat == nil {
t.Fatalf("GetACL returned nil Stat")
} else if len(acl) != 1 || expected[0] != acl[0] {
t.Fatalf("GetACL mismatch expected %+v instead of %+v", expected, acl)
}
}
func TestIntegration_Auth(t *testing.T) {
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
if err != nil {
t.Fatal(err)
}
defer ts.Stop()
zk, _, err := ts.ConnectAll()
if err != nil {
t.Fatalf("Connect returned error: %+v", err)
}
defer zk.Close()
path := "/gozk-digest-test"
if err := zk.Delete(path, -1); err != nil && err != ErrNoNode {
t.Fatalf("Delete returned error: %+v", err)
}
acl := DigestACL(PermAll, "user", "password")
if p, err := zk.Create(path, []byte{1, 2, 3, 4}, 0, acl); err != nil {
t.Fatalf("Create returned error: %+v", err)
} else if p != path {
t.Fatalf("Create returned different path '%s' != '%s'", p, path)
}
if _, _, err := zk.Get(path); err != ErrNoAuth {
t.Fatalf("Get returned error %+v instead of ErrNoAuth", err)
}
if err := zk.AddAuth("digest", []byte("user:password")); err != nil {
t.Fatalf("AddAuth returned error %+v", err)
}
if a, stat, err := zk.GetACL(path); err != nil {
t.Fatalf("GetACL returned error %+v", err)
} else if stat == nil {
t.Fatalf("GetACL returned nil Stat")
} else if len(a) != 1 || acl[0] != a[0] {
t.Fatalf("GetACL mismatch expected %+v instead of %+v", acl, a)
}
if data, stat, err := zk.Get(path); err != nil {
t.Fatalf("Get returned error %+v", err)
} else if stat == nil {
t.Fatalf("Get returned nil Stat")
} else if len(data) != 4 {
t.Fatalf("Get returned wrong data length")
}
}
func TestIntegration_Children(t *testing.T) {
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
if err != nil {
t.Fatal(err)
}
defer ts.Stop()
zk, _, err := ts.ConnectAll()
if err != nil {
t.Fatalf("Connect returned error: %+v", err)
}
defer zk.Close()
deleteNode := func(node string) {
if err := zk.Delete(node, -1); err != nil && err != ErrNoNode {
t.Fatalf("Delete returned error: %+v", err)
}
}
deleteNode("/gozk-test-big")
if path, err := zk.Create("/gozk-test-big", []byte{1, 2, 3, 4}, 0, WorldACL(PermAll)); err != nil {
t.Fatalf("Create returned error: %+v", err)
} else if path != "/gozk-test-big" {
t.Fatalf("Create returned different path '%s' != '/gozk-test-big'", path)
}
rb := make([]byte, 1000)
hb := make([]byte, 2000)
prefix := []byte("/gozk-test-big/")
for i := 0; i < 10000; i++ {
_, err := rand.Read(rb)
if err != nil {
t.Fatal("Cannot create random znode name")
}
hex.Encode(hb, rb)
expect := string(append(prefix, hb...))
if path, err := zk.Create(expect, []byte{1, 2, 3, 4}, 0, WorldACL(PermAll)); err != nil {
t.Fatalf("Create returned error: %+v", err)
} else if path != expect {
t.Fatalf("Create returned different path '%s' != '%s'", path, expect)
}
defer deleteNode(string(expect))
}
children, _, err := zk.Children("/gozk-test-big")
if err != nil {
t.Fatalf("Children returned error: %+v", err)
} else if len(children) != 10000 {
t.Fatal("Children returned wrong number of nodes")
}
}
func TestIntegration_ChildWatch(t *testing.T) {
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
if err != nil {
t.Fatal(err)
}
defer ts.Stop()
zk, _, err := ts.ConnectAll()
if err != nil {
t.Fatalf("Connect returned error: %+v", err)
}
defer zk.Close()
if err := zk.Delete("/gozk-test", -1); err != nil && err != ErrNoNode {
t.Fatalf("Delete returned error: %+v", err)
}
children, stat, childCh, err := zk.ChildrenW("/")
if err != nil {
t.Fatalf("Children returned error: %+v", err)
} else if stat == nil {
t.Fatal("Children returned nil stat")
} else if len(children) < 1 {
t.Fatal("Children should return at least 1 child")
}
if path, err := zk.Create("/gozk-test", []byte{1, 2, 3, 4}, 0, WorldACL(PermAll)); err != nil {
t.Fatalf("Create returned error: %+v", err)
} else if path != "/gozk-test" {
t.Fatalf("Create returned different path '%s' != '/gozk-test'", path)
}
select {
case ev := <-childCh:
if ev.Err != nil {
t.Fatalf("Child watcher error %+v", ev.Err)
}
if ev.Path != "/" {
t.Fatalf("Child watcher wrong path %s instead of %s", ev.Path, "/")
}
case _ = <-time.After(time.Second * 2):
t.Fatal("Child watcher timed out")
}
// Delete of the watched node should trigger the watch
children, stat, childCh, err = zk.ChildrenW("/gozk-test")
if err != nil {
t.Fatalf("Children returned error: %+v", err)
} else if stat == nil {
t.Fatal("Children returned nil stat")
} else if len(children) != 0 {
t.Fatal("Children should return 0 children")
}
if err := zk.Delete("/gozk-test", -1); err != nil && err != ErrNoNode {
t.Fatalf("Delete returned error: %+v", err)
}
select {
case ev := <-childCh:
if ev.Err != nil {
t.Fatalf("Child watcher error %+v", ev.Err)
}
if ev.Path != "/gozk-test" {
t.Fatalf("Child watcher wrong path %s instead of %s", ev.Path, "/")
}
case _ = <-time.After(time.Second * 2):
t.Fatal("Child watcher timed out")
}
}
func TestIntegration_SetWatchers(t *testing.T) {
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
if err != nil {
t.Fatal(err)
}
defer ts.Stop()
zk, _, err := ts.ConnectAll()
if err != nil {
t.Fatalf("Connect returned error: %+v", err)
}
defer zk.Close()
zk.reconnectLatch = make(chan struct{})
zk.setWatchLimit = 1024 // break up set-watch step into 1k requests
var setWatchReqs atomic.Value
zk.setWatchCallback = func(reqs []*setWatchesRequest) {
setWatchReqs.Store(reqs)
}
zk2, _, err := ts.ConnectAll()
if err != nil {
t.Fatalf("Connect returned error: %+v", err)
}
defer zk2.Close()
if err := zk.Delete("/gozk-test", -1); err != nil && err != ErrNoNode {
t.Fatalf("Delete returned error: %+v", err)
}
testPaths := map[string]<-chan Event{}
defer func() {
// clean up all of the test paths we create
for p := range testPaths {
zk2.Delete(p, -1)
}
}()
// we create lots of paths to watch, to make sure a "set watches" request
// on re-create will be too big and be required to span multiple packets
for i := 0; i < 1000; i++ {
testPath, err := zk.Create(fmt.Sprintf("/gozk-test-%d", i), []byte{}, 0, WorldACL(PermAll))
if err != nil {
t.Fatalf("Create returned: %+v", err)
}
testPaths[testPath] = nil
_, _, testEvCh, err := zk.GetW(testPath)
if err != nil {
t.Fatalf("GetW returned: %+v", err)
}
testPaths[testPath] = testEvCh
}
children, stat, childCh, err := zk.ChildrenW("/")
if err != nil {
t.Fatalf("Children returned error: %+v", err)
} else if stat == nil {
t.Fatal("Children returned nil stat")
} else if len(children) < 1 {
t.Fatal("Children should return at least 1 child")
}
// Simulate network error by brutally closing the network connection.
zk.conn.Close()
for p := range testPaths {
if err := zk2.Delete(p, -1); err != nil && err != ErrNoNode {
t.Fatalf("Delete returned error: %+v", err)
}
}
if path, err := zk2.Create("/gozk-test", []byte{1, 2, 3, 4}, 0, WorldACL(PermAll)); err != nil {
t.Fatalf("Create returned error: %+v", err)
} else if path != "/gozk-test" {
t.Fatalf("Create returned different path '%s' != '/gozk-test'", path)
}
time.Sleep(100 * time.Millisecond)
// zk should still be waiting to reconnect, so none of the watches should have been triggered
for p, ch := range testPaths {
select {
case <-ch:
t.Fatalf("GetW watcher for %q should not have triggered yet", p)
default:
}
}
select {
case <-childCh:
t.Fatalf("ChildrenW watcher should not have triggered yet")
default:
}
// now we let the reconnect occur and make sure it resets watches
close(zk.reconnectLatch)
for p, ch := range testPaths {
select {
case ev := <-ch:
if ev.Err != nil {
t.Fatalf("GetW watcher error %+v", ev.Err)
}
if ev.Path != p {
t.Fatalf("GetW watcher wrong path %s instead of %s", ev.Path, p)
}
case <-time.After(2 * time.Second):
t.Fatal("GetW watcher timed out")
}
}
select {
case ev := <-childCh:
if ev.Err != nil {
t.Fatalf("Child watcher error %+v", ev.Err)
}
if ev.Path != "/" {
t.Fatalf("Child watcher wrong path %s instead of %s", ev.Path, "/")
}
case <-time.After(2 * time.Second):
t.Fatal("Child watcher timed out")
}
// Yay! All watches fired correctly. Now we also inspect the actual set-watch request objects
// to ensure they didn't exceed the expected packet set.
buf := make([]byte, bufferSize)
totalWatches := 0
actualReqs := setWatchReqs.Load().([]*setWatchesRequest)
if len(actualReqs) < 12 {
// sanity check: we should have generated *at least* 12 requests to reset watches
t.Fatalf("too few setWatchesRequest messages: %d", len(actualReqs))
}
for _, r := range actualReqs {
totalWatches += len(r.ChildWatches) + len(r.DataWatches) + len(r.ExistWatches)
n, err := encodePacket(buf, r)
if err != nil {
t.Fatalf("encodePacket failed: %v! request:\n%+v", err, r)
} else if n > 1024 {
t.Fatalf("setWatchesRequest exceeded allowed size (%d > 1024)! request:\n%+v", n, r)
}
}
if totalWatches != len(testPaths)+1 {
t.Fatalf("setWatchesRequests did not include all expected watches; expecting %d, got %d", len(testPaths)+1, totalWatches)
}
}
func TestIntegration_ExpiringWatch(t *testing.T) {
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
if err != nil {
t.Fatal(err)
}
defer ts.Stop()
zk, _, err := ts.ConnectAll()
if err != nil {
t.Fatalf("Connect returned error: %+v", err)
}
defer zk.Close()
if err := zk.Delete("/gozk-test", -1); err != nil && err != ErrNoNode {
t.Fatalf("Delete returned error: %+v", err)
}
children, stat, childCh, err := zk.ChildrenW("/")
if err != nil {
t.Fatalf("Children returned error: %+v", err)
} else if stat == nil {
t.Fatal("Children returned nil stat")
} else if len(children) < 1 {
t.Fatal("Children should return at least 1 child")
}
zk.sessionID = 99999
zk.conn.Close()
select {
case ev := <-childCh:
if ev.Err != ErrSessionExpired {
t.Fatalf("Child watcher error %+v instead of expected ErrSessionExpired", ev.Err)
}
if ev.Path != "/" {
t.Fatalf("Child watcher wrong path %s instead of %s", ev.Path, "/")
}
case <-time.After(2 * time.Second):
t.Fatal("Child watcher timed out")
}
}
func TestRequestFail(t *testing.T) {
// If connecting fails to all servers in the list then pending requests
// should be errored out so they don't hang forever.
zk, _, err := Connect([]string{"127.0.0.1:32444"}, time.Second*15)
if err != nil {
t.Fatal(err)
}
defer zk.Close()
ch := make(chan error)
go func() {
_, _, err := zk.Get("/blah")
ch <- err
}()
select {
case err := <-ch:
if err == nil {
t.Fatal("Expected non-nil error on failed request due to connection failure")
}
case <-time.After(time.Second * 2):
t.Fatal("Get hung when connection could not be made")
}
}
func TestIdempotentClose(t *testing.T) {
zk, _, err := Connect([]string{"127.0.0.1:32444"}, time.Second*15)
if err != nil {
t.Fatal(err)
}
// multiple calls to Close() should not panic
zk.Close()
zk.Close()
}
func TestIntegration_SlowServer(t *testing.T) {
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
if err != nil {
t.Fatal(err)
}
defer ts.Stop()
realAddr := fmt.Sprintf("127.0.0.1:%d", ts.Servers[0].Port)
proxyAddr, stopCh, err := startSlowProxy(t,
Rate{}, Rate{},
realAddr, func(ln *Listener) {
if ln.Up.Latency == 0 {
ln.Up.Latency = time.Millisecond * 2000
ln.Down.Latency = time.Millisecond * 2000
} else {
ln.Up.Latency = 0
ln.Down.Latency = 0
}
})
if err != nil {
t.Fatal(err)
}
defer close(stopCh)
zk, _, err := Connect([]string{proxyAddr}, time.Millisecond*500)
if err != nil {
t.Fatal(err)
}
defer zk.Close()
_, _, wch, err := zk.ChildrenW("/")
if err != nil {
t.Fatal(err)
}
// Force a reconnect to get a throttled connection
zk.conn.Close()
time.Sleep(time.Millisecond * 100)
if err := zk.Delete("/gozk-test", -1); err == nil {
t.Fatal("Delete should have failed")
}
// The previous request should have timed out causing the server to be disconnected and reconnected
if _, err := zk.Create("/gozk-test", []byte{1, 2, 3, 4}, 0, WorldACL(PermAll)); err != nil {
t.Fatal(err)
}
// Make sure event is still returned because the session should not have been affected
select {
case ev := <-wch:
t.Logf("Received event: %+v", ev)
case <-time.After(time.Second):
t.Fatal("Expected to receive a watch event")
}
}
func TestIntegration_MaxBufferSize(t *testing.T) {
ts, err := StartTestCluster(t, 1, nil, logWriter{t: t, p: "[ZKERR] "})
if err != nil {
t.Fatal(err)
}
defer ts.Stop()
// no buffer size
zk, _, err := ts.ConnectWithOptions(15 * time.Second)
var l testLogger
if err != nil {
t.Fatalf("Connect returned error: %+v", err)
}
defer zk.Close()
// 1k buffer size, logs to custom test logger
zkLimited, _, err := ts.ConnectWithOptions(15*time.Second, WithMaxBufferSize(1024), func(conn *Conn) {
conn.SetLogger(&l)
})
if err != nil {
t.Fatalf("Connect returned error: %+v", err)
}
defer zkLimited.Close()
// With small node with small number of children
data := []byte{101, 102, 103, 103}
_, err = zk.Create("/foo", data, 0, WorldACL(PermAll))
if err != nil {
t.Fatalf("Create returned error: %+v", err)
}
var children []string
for i := 0; i < 4; i++ {
childName, err := zk.Create("/foo/child", nil, FlagEphemeral|FlagSequence, WorldACL(PermAll))
if err != nil {
t.Fatalf("Create returned error: %+v", err)
}
children = append(children, childName[len("/foo/"):]) // strip parent prefix from name
}
sort.Strings(children)
// Limited client works fine
resultData, _, err := zkLimited.Get("/foo")
if err != nil {
t.Fatalf("Get returned error: %+v", err)
}
if !reflect.DeepEqual(resultData, data) {
t.Fatalf("Get returned unexpected data; expecting %+v, got %+v", data, resultData)
}
resultChildren, _, err := zkLimited.Children("/foo")
if err != nil {
t.Fatalf("Children returned error: %+v", err)
}
sort.Strings(resultChildren)
if !reflect.DeepEqual(resultChildren, children) {
t.Fatalf("Children returned unexpected names; expecting %+v, got %+v", children, resultChildren)
}
// With large node though...
data = make([]byte, 1024)
for i := 0; i < 1024; i++ {
data[i] = byte(i)
}
_, err = zk.Create("/bar", data, 0, WorldACL(PermAll))
if err != nil {
t.Fatalf("Create returned error: %+v", err)
}
_, _, err = zkLimited.Get("/bar")
// NB: Sadly, without actually de-serializing the too-large response packet, we can't send the
// right error to the corresponding outstanding request. So the request just sees ErrConnectionClosed
// while the log will see the actual reason the connection was closed.
expectErr(t, err, ErrConnectionClosed)
expectLogMessage(t, &l, "received packet from server with length .*, which exceeds max buffer size 1024")
// Or with large number of children...
totalLen := 0
children = nil
for totalLen < 1024 {
childName, err := zk.Create("/bar/child", nil, FlagEphemeral|FlagSequence, WorldACL(PermAll))
if err != nil {
t.Fatalf("Create returned error: %+v", err)
}
n := childName[len("/bar/"):] // strip parent prefix from name
children = append(children, n)
totalLen += len(n)
}
sort.Strings(children)
_, _, err = zkLimited.Children("/bar")
expectErr(t, err, ErrConnectionClosed)
expectLogMessage(t, &l, "received packet from server with length .*, which exceeds max buffer size 1024")
// Other client (without buffer size limit) can successfully query the node and its children, of course
resultData, _, err = zk.Get("/bar")
if err != nil {
t.Fatalf("Get returned error: %+v", err)
}
if !reflect.DeepEqual(resultData, data) {
t.Fatalf("Get returned unexpected data; expecting %+v, got %+v", data, resultData)
}
resultChildren, _, err = zk.Children("/bar")
if err != nil {
t.Fatalf("Children returned error: %+v", err)
}
sort.Strings(resultChildren)
if !reflect.DeepEqual(resultChildren, children) {
t.Fatalf("Children returned unexpected names; expecting %+v, got %+v", children, resultChildren)
}
}
func startSlowProxy(t *testing.T, up, down Rate, upstream string, adj func(ln *Listener)) (string, chan bool, error) {
ln, err := net.Listen("tcp", "127.0.0.1:0")
if err != nil {
return "", nil, err
}
tln := &Listener{
Listener: ln,
Up: up,
Down: down,
}
stopCh := make(chan bool)
go func() {
<-stopCh
tln.Close()
}()
go func() {
for {
cn, err := tln.Accept()
if err != nil {
if !strings.Contains(err.Error(), "use of closed network connection") {
t.Fatalf("Accept failed: %s", err.Error())
}
return
}
if adj != nil {
adj(tln)
}
go func(cn net.Conn) {
defer cn.Close()
upcn, err := net.Dial("tcp", upstream)
if err != nil {
t.Log(err)
return
}
// This will leave hanging goroutines util stopCh is closed
// but it doesn't matter in the context of running tests.
go func() {
<-stopCh
upcn.Close()
}()
go func() {
if _, err := io.Copy(upcn, cn); err != nil {
if !strings.Contains(err.Error(), "use of closed network connection") {
// log.Printf("Upstream write failed: %s", err.Error())
}
}
}()
if _, err := io.Copy(cn, upcn); err != nil {
if !strings.Contains(err.Error(), "use of closed network connection") {
// log.Printf("Upstream read failed: %s", err.Error())
}
}
}(cn)
}
}()
return ln.Addr().String(), stopCh, nil
}
func expectErr(t *testing.T, err error, expected error) {
if err == nil {
t.Fatalf("Get for node that is too large should have returned error!")
}
if err != expected {
t.Fatalf("Get returned wrong error; expecting ErrClosing, got %+v", err)
}
}
func expectLogMessage(t *testing.T, logger *testLogger, pattern string) {
re := regexp.MustCompile(pattern)
events := logger.Reset()
if len(events) == 0 {
t.Fatalf("Failed to log error; expecting message that matches pattern: %s", pattern)
}
var found []string
for _, e := range events {
if re.Match([]byte(e)) {
found = append(found, e)
}
}
if len(found) == 0 {
t.Fatalf("Failed to log error; expecting message that matches pattern: %s", pattern)
} else if len(found) > 1 {
t.Fatalf("Logged error redundantly %d times:\n%+v", len(found), found)
}
}
func requireMinimumZkVersion(t *testing.T, minimum string) {
t.Helper()
actualVersionStr, ok := os.LookupEnv("ZK_VERSION")
if !ok {
t.Skip("did not detect ZK_VERSION from env. skipping test")
}
parseFn := func(v string) (parts []int) {
for _, s := range strings.Split(v, ".") {
i, err := strconv.Atoi(s)
if err != nil {
t.Fatalf("invalid version segment: %q", s)
}
parts = append(parts, i)
}
return parts
}
minimumV, actualV := parseFn(minimum), parseFn(actualVersionStr)
for i, p := range minimumV {
if len(actualV) <= i {
break
}
if actualV[i] < p {
t.Skipf("zookeeper required min version not met; requires: %q, actual: %q", minimum, actualVersionStr)
}
}
}
type testLogger struct {
mu sync.Mutex
events []string
}
func (l *testLogger) Printf(msgFormat string, args ...interface{}) {
msg := fmt.Sprintf(msgFormat, args...)
fmt.Println(msg)
l.mu.Lock()
defer l.mu.Unlock()
l.events = append(l.events, msg)
}
func (l *testLogger) Reset() []string {
l.mu.Lock()
defer l.mu.Unlock()
ret := l.events
l.events = nil
return ret
}
|