1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553
|
#include "util/masterelection.h"
#include <gflags/gflags.h>
#include <glog/logging.h>
#include <climits>
#include <functional>
#include "monitoring/monitoring.h"
#include "util/periodic_closure.h"
namespace cert_trans {
using cert_trans::Gauge;
using std::bind;
using std::chrono::seconds;
using std::mutex;
using std::placeholders::_1;
using std::placeholders::_2;
using std::shared_ptr;
using std::string;
using std::unique_lock;
using std::unique_ptr;
using std::vector;
using util::Task;
DEFINE_int32(master_keepalive_interval_seconds, 60,
"Interval between refreshing mastership proposal.");
DEFINE_int32(masterelection_retry_delay_seconds, 5,
"Seconds to delay before retrying a failed attempt to create a "
"proposal file.");
namespace {
static Gauge<>* is_master_gauge(
Gauge<>::New("master", "Non-zero if this node is currently the master."));
static Gauge<>* participating_in_election_gauge(
Gauge<>::New("participating_in_election",
"Non-zero if this node is currently participating in the "
"masterelection."));
static Counter<>* proposal_creation_failures(
Counter<>::New("election_proposal_creation_failures",
"Total number of failures to create an election "
"proposal."));
// Special backing string which indicates that we're not backing any proposal.
const char kNoBacking[] = "";
// Returns |s| with a '/' appended if the last char is not already a '/'
string EnsureEndsWithSlash(const string& s) {
if (s.empty() || s.back() != '/') {
return s + '/';
} else {
return s;
}
}
} // namespace
std::ostream& operator<<(std::ostream& output,
MasterElection::ProposalState state) {
switch (state) {
case MasterElection::ProposalState::NONE:
output << "NONE";
break;
case MasterElection::ProposalState::AWAITING_CREATION:
output << "AWAITING_CREATION";
break;
case MasterElection::ProposalState::CREATING:
output << "CREATING";
break;
case MasterElection::ProposalState::UP_TO_DATE:
output << "UP_TO_DATE";
break;
case MasterElection::ProposalState::AWAITING_UPDATE:
output << "AWAITING_UPDATE";
break;
case MasterElection::ProposalState::UPDATING:
output << "UPDATING";
break;
case MasterElection::ProposalState::AWAITING_DELETE:
output << "AWAITING_DELETE";
break;
case MasterElection::ProposalState::DELETING:
output << "DELETING";
break;
}
return output;
}
MasterElection::MasterElection(const shared_ptr<libevent::Base>& base,
EtcdClient* client, const string& proposal_dir,
const string& node_id)
: base_(base),
client_(CHECK_NOTNULL(client)),
proposal_dir_(EnsureEndsWithSlash(proposal_dir)),
my_proposal_path_(proposal_dir_ + node_id),
proposal_state_(ProposalState::NONE),
running_(false),
backed_proposal_(kNoBacking),
is_master_(false) {
CHECK_NE(kNoBacking, node_id);
is_master_gauge->Set(0);
participating_in_election_gauge->Set(0);
}
// Testing only c'tor
MasterElection::MasterElection()
: client_(nullptr), proposal_state_(ProposalState::NONE) {
}
MasterElection::~MasterElection() {
VLOG(1) << my_proposal_path_ << ": Destroying election";
CHECK_EQ(proposal_state_, ProposalState::NONE);
VLOG(1) << "~" << my_proposal_path_;
}
void MasterElection::StartElection() {
{
unique_lock<mutex> lock(mutex_);
if (running_) {
return;
}
VLOG(1) << my_proposal_path_ << ": Joining election";
running_ = true;
participating_in_election_gauge->Set(1);
Transition(lock, ProposalState::AWAITING_CREATION);
}
base_->Add(bind(&MasterElection::CreateProposal, this));
}
void MasterElection::StopElection() {
unique_lock<mutex> lock(mutex_);
if (!running_) {
return;
}
VLOG(1) << my_proposal_path_ << ": Departing election.";
running_ = false;
participating_in_election_gauge->Set(0);
// Stop the updates from the watch. Do this without holding the lock
// because the watch callback takes that lock. This means that we'll
// stop updating our proposal, and maybe delay a master election,
// but that's okay, as we're about to delete our proposal
// altogether.
lock.unlock();
VLOG(1) << my_proposal_path_ << ": Cancelling watch...";
proposal_watch_->Cancel();
proposal_watch_->Wait();
proposal_watch_.reset();
lock.lock();
is_master_ = false;
is_master_cv_.notify_all();
// But wait for any in-flight updates to finish
VLOG(1) << my_proposal_path_ << ": waiting for in-flight proposal update "
<< "to complete.";
proposal_state_cv_.wait(lock, [this]() {
return proposal_state_ == ProposalState::UP_TO_DATE;
});
// No more refresh callbacks (this is not synchronous, the refresh
// callback might be running right now, trying to lock the mutex, so
// the callback has to be able to handle itself after we've
// stopped):
proposal_refresh_callback_.reset();
// Delete our proposal so we can't accidentally become master after we've
// left:
Transition(lock, ProposalState::AWAITING_DELETE);
base_->Add(bind(&MasterElection::DeleteProposal, this));
// Wait for the proposal to actually be deleted before we return.
VLOG(1) << my_proposal_path_ << ": Waiting for delete to complete.";
proposal_state_cv_.wait(lock, [this]() {
return proposal_state_ == ProposalState::NONE;
});
VLOG(1) << my_proposal_path_ << ": Departed election.";
}
bool MasterElection::WaitToBecomeMaster() const {
VLOG(1) << my_proposal_path_ << ": Waiting to become master";
unique_lock<mutex> lock(mutex_);
// We'll unblock if either we're master, or someone stopped the election.
is_master_cv_.wait(lock,
[this, &lock]() { return IsMaster(lock) || !running_; });
return IsMaster(lock);
}
bool MasterElection::IsMaster() const {
unique_lock<mutex> lock(mutex_);
return IsMaster(lock);
}
bool MasterElection::IsMaster(const unique_lock<mutex>& lock) const {
CHECK(lock.owns_lock());
return is_master_;
}
void MasterElection::Transition(const unique_lock<mutex>& lock,
const ProposalState to) {
CHECK(lock.owns_lock());
VLOG(1) << my_proposal_path_ << ": Transition " << proposal_state_ << " -> "
<< to;
switch (proposal_state_) {
case ProposalState::NONE:
CHECK_EQ(to, ProposalState::AWAITING_CREATION);
break;
case ProposalState::AWAITING_CREATION:
CHECK_EQ(to, ProposalState::CREATING);
break;
case ProposalState::CREATING:
CHECK(to == ProposalState::AWAITING_CREATION ||
to == ProposalState::UP_TO_DATE)
<< "proposal_state_: " << proposal_state_ << " to: " << to;
break;
case ProposalState::UP_TO_DATE:
CHECK(to == ProposalState::AWAITING_UPDATE ||
to == ProposalState::AWAITING_DELETE)
<< "proposal_state_: " << proposal_state_ << " to: " << to;
break;
case ProposalState::AWAITING_UPDATE:
CHECK_EQ(to, ProposalState::UPDATING);
break;
case ProposalState::UPDATING:
CHECK_EQ(to, ProposalState::UP_TO_DATE);
break;
case ProposalState::AWAITING_DELETE:
CHECK_EQ(to, ProposalState::DELETING);
break;
case ProposalState::DELETING:
CHECK_EQ(to, ProposalState::NONE);
break;
default:
CHECK(false) << "Unknown state: " << proposal_state_;
}
proposal_state_ = to;
proposal_state_cv_.notify_all();
}
void MasterElection::CreateProposal() {
unique_lock<mutex> lock(mutex_);
Transition(lock, ProposalState::CREATING);
// We'll create an empty file indicating we're not backing anyone, so as to
// avoid disrupting an existing settled election.
// Technically this could already exist if we had mastership before, crashed,
// and then restarted before the TTL expired.
EtcdClient::Response* const resp(new EtcdClient::Response);
client_->CreateWithTTL(
my_proposal_path_, kNoBacking,
seconds(FLAGS_master_keepalive_interval_seconds * 2), resp,
new Task(bind(&MasterElection::ProposalCreateDone, this, resp, _1),
base_.get()));
}
void MasterElection::ProposalCreateDone(EtcdClient::Response* resp,
Task* task) {
unique_ptr<EtcdClient::Response> resp_deleter(resp);
unique_ptr<Task> task_deleter(task);
unique_lock<mutex> lock(mutex_);
if (!task->status().ok()) {
proposal_creation_failures->Increment();
Transition(lock, ProposalState::AWAITING_CREATION);
LOG(WARNING) << "Problem creating proposal: " << task->status() << " "
<< "will retry.";
base_->Delay(seconds(FLAGS_masterelection_retry_delay_seconds),
new Task(bind(&MasterElection::CreateProposal, this),
base_.get()));
return;
}
Transition(lock, ProposalState::UP_TO_DATE);
VLOG(1) << my_proposal_path_ << ": Mastership proposal created at index "
<< resp->etcd_index;
my_proposal_modified_index_ = my_proposal_create_index_ = resp->etcd_index;
// Start a periodic callback to keep our proposal from being garbage
// collected
CHECK(!proposal_refresh_callback_);
VLOG(1) << my_proposal_path_ << ": Creating refresh Callback";
proposal_refresh_callback_.reset(new PeriodicClosure(
base_, seconds(FLAGS_master_keepalive_interval_seconds),
bind(&MasterElection::ProposalKeepAliveCallback, this)));
// Watch the proposal directory so we're aware of other proposals
// coming and going
VLOG(1) << my_proposal_path_ << ": Watching proposals";
CHECK(!proposal_watch_);
proposal_watch_.reset(new util::SyncTask(base_.get()));
client_->Watch(proposal_dir_,
bind(&MasterElection::OnProposalUpdate, this, _1),
proposal_watch_->task());
VLOG(1) << my_proposal_path_ << ": Joined election";
}
bool MasterElection::MaybeUpdateProposal(const unique_lock<mutex>& lock,
const string& backed) {
CHECK(lock.owns_lock());
if (proposal_state_ == ProposalState::UPDATING ||
proposal_state_ == ProposalState::AWAITING_UPDATE) {
// Don't want to have more than one proposal update happening at
// the same time so we'll just bail this one. It's ok, though,
// because the currently in-flight update will cause a call to
// ProposalUpdate() via the watch which should prompt another
// update attempt if it turns out to still be necessary.
VLOG(1) << my_proposal_path_ << ": Dropping proposal update backing "
<< backed << " because already have a proposal update in "
<< "flight.";
return false;
}
Transition(lock, ProposalState::AWAITING_UPDATE);
base_->Add(bind(&MasterElection::UpdateProposal, this, backed));
return true;
}
void MasterElection::UpdateProposal(const string& backed) {
unique_lock<mutex> lock(mutex_);
Transition(lock, ProposalState::UPDATING);
VLOG(1) << my_proposal_path_ << ": Updating proposal backing " << backed;
// TODO(alcutter): Set the HTTP timeout inside here to something sensible.
EtcdClient::Response* const resp(new EtcdClient::Response);
client_->UpdateWithTTL(my_proposal_path_, backed,
seconds(FLAGS_master_keepalive_interval_seconds * 2),
my_proposal_modified_index_, resp,
new Task(bind(&MasterElection::ProposalUpdateDone,
this, resp, _1),
base_.get()));
}
void MasterElection::ProposalUpdateDone(EtcdClient::Response* resp,
Task* task) {
unique_ptr<EtcdClient::Response> resp_deleter(resp);
unique_lock<mutex> lock(mutex_);
// TODO(alcutter): Handle this
CHECK(task->status().ok()) << my_proposal_path_ << ": " << task->status();
Transition(lock, ProposalState::UP_TO_DATE);
// Keep a note of the current modification index of our proposal since
// we'll need it in order to update or delete the proposal
my_proposal_modified_index_ = resp->etcd_index;
VLOG(1) << my_proposal_path_ << ": Proposal refreshed @ "
<< resp->etcd_index;
}
void MasterElection::DeleteProposal() {
unique_lock<mutex> lock(mutex_);
Transition(lock, ProposalState::DELETING);
VLOG(1) << my_proposal_path_ << ": Deleting proposal";
client_->Delete(my_proposal_path_, my_proposal_modified_index_,
new Task(bind(&MasterElection::ProposalDeleteDone, this, _1),
base_.get()));
}
void MasterElection::ProposalDeleteDone(Task* task) {
unique_lock<mutex> lock(mutex_);
if (!task->status().ok()) {
LOG(WARNING) << "error deleting proposal: " << task->status();
}
VLOG(1) << my_proposal_path_ << ": Delete done.";
// Now clean up
my_proposal_create_index_ = -1;
proposals_.clear();
Transition(lock, ProposalState::NONE);
}
void MasterElection::ProposalKeepAliveCallback() {
unique_lock<mutex> lock(mutex_);
VLOG(1) << my_proposal_path_ << ": Proposal Keep-Alive fired.";
if (!running_) {
VLOG(1) << my_proposal_path_
<< ": But we're not running so bailing on updates.";
return;
}
MaybeUpdateProposal(lock, backed_proposal_);
}
void MasterElection::UpdateProposalView(
const vector<EtcdClient::Node>& updates) {
for (const auto& update : updates) {
if (!update.deleted_) {
VLOG(1) << my_proposal_path_
<< ": Proposal updated: " << update.ToString();
proposals_[update.key_] = update;
} else {
VLOG(1) << my_proposal_path_
<< ": Proposal deleted: " << update.ToString();
CHECK_EQ(static_cast<size_t>(1), proposals_.erase(update.key_))
<< my_proposal_path_
<< ": Unknown proposal deleted: " << update.ToString();
}
}
}
bool MasterElection::DetermineApparentMaster(
EtcdClient::Node* apparent_master) const {
EtcdClient::Node tmp_master(INT_MAX, INT_MAX, "", false, "", {}, true);
bool found(false);
for (const auto& pair : proposals_) {
CHECK_EQ(pair.first, pair.second.key_);
if (pair.second.created_index_ < tmp_master.created_index_) {
found = true;
tmp_master = pair.second;
}
}
if (found) {
*apparent_master = tmp_master;
}
return found;
}
void MasterElection::OnProposalUpdate(
const vector<EtcdClient::Node>& updates) {
unique_lock<mutex> lock(mutex_);
CHECK_GE(updates.size(), static_cast<size_t>(1));
VLOG(1) << my_proposal_path_ << ": Got " << updates.size() << " update(s)";
if (!running_) {
VLOG(1) << my_proposal_path_
<< ": But we're not running so bailing on updates.";
return;
}
// First, update our view of the proposals:
UpdateProposalView(updates);
// Now figure out who we think the master should be based on proposal
// creation indicies:
EtcdClient::Node apparent_master;
if (!DetermineApparentMaster(&apparent_master)) {
// Doesn't look like there are any proposals, so nothing to do.
// Probably shouldn't really happen, but it could be that our proposal got
// cleaned up because we failed to refresh it before the TTL expired.
VLOG(1) << my_proposal_path_
<< ": No proposals to consider; no master currently";
// Since nobody is a master, that includes us:
is_master_ = false;
is_master_gauge->Set(0);
return;
}
// Do we have to update our public statement about who we're backing?
if (backed_proposal_ != apparent_master.key_) {
// Yep, looks like the situation has changed
VLOG(1) << my_proposal_path_ << ": Backed proposal (" << backed_proposal_
<< ") != apparent_master (" << apparent_master.key_ << "), "
<< is_master_;
// Try to update our proposal to show our support of the apparent master.
// If this fails it'll be because there's already an update in-flight, so
// we'll get notified of that shortly and end up here agin, at which point
// we can try again.
if (MaybeUpdateProposal(lock, apparent_master.key_)) {
// We managed to send the the update so store our backing here so we
// don't continually fire off 'updates' saying the same thing
backed_proposal_ = apparent_master.key_;
}
// Since we changed our mind about who to back, that means there's not
// currently consensus, so we can't be a master either.
// Strictly this might not be true - if everyone else already voted for us
// we could short circuit and set this true here, but there's no really
// anything to be gained from that other than more complex code.
is_master_ = false;
is_master_gauge->Set(0);
return;
}
// Check to see whether the apparent master from the previous stage is backed
// by all participating nodes:
CHECK(!proposals_.empty());
// Check if everyone is in agreement about who the master is:
for (const auto& pair : proposals_) {
// Discount any participant who has explicitly abstained from the vote.
// This is because participants who have just joined the election will not
// have had a chance to decide who to back, this would cause temporary
// blibs to No Master for the election each time a new participant joined,
// so we allow them to abstain from the vote, they should then analyze the
// situation and update their proposal with new backing info, at which
// point everybody will run OnProposalUpdate() and check for
// consensus again.
if (pair.second.value_ == kNoBacking) {
continue;
}
if (pair.second.value_ != apparent_master.key_) {
// Whoops, we don't have agreement: nobody is a master at the moment.
// In effect, we're now waiting for everybody to update their proposals
// an reach agreement for who the master is, or, possibly, for the
// dissenting participants (who have probably just crashed/wedged) to
// have their proposals expired by etcd.
VLOG(1) << my_proposal_path_ << ": No master currently, " << is_master_;
VLOG(1) << my_proposal_path_ << ": Apparent master is "
<< apparent_master.key_ << " but " << pair.first
<< " is backing: " << pair.second.value_;
// No master, so we can't be master
is_master_ = false;
is_master_gauge->Set(0);
return;
}
}
// There must be consensus about who the master is now.
VLOG(2) << my_proposal_path_ << ": Agreed that master is "
<< apparent_master.key_;
current_master_ = apparent_master;
// Finally, determine if we're the master, and wake up anyone blocked in
// WaitToBecomeMaster() if so:
is_master_ = running_ &&
(apparent_master.key_ == my_proposal_path_ &&
apparent_master.created_index_ == my_proposal_create_index_);
if (is_master_) {
LOG(INFO) << my_proposal_path_ << ": Became master";
is_master_gauge->Set(1);
is_master_cv_.notify_all();
}
}
} // namespace cert_trans
|