1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
|
package versionnegotiation
import (
"context"
"errors"
"fmt"
"net"
"testing"
"time"
"github.com/quic-go/quic-go"
"github.com/quic-go/quic-go/internal/protocol"
"github.com/quic-go/quic-go/logging"
"github.com/stretchr/testify/require"
)
type result struct {
loggedVersions bool
receivedVersionNegotiation bool
chosen logging.Version
clientVersions, serverVersions []logging.Version
}
func newVersionNegotiationTracer(t *testing.T) (*result, *logging.ConnectionTracer) {
r := &result{}
return r, &logging.ConnectionTracer{
NegotiatedVersion: func(chosen logging.Version, clientVersions, serverVersions []logging.Version) {
if r.loggedVersions {
t.Fatal("only expected one call to NegotiatedVersions")
}
r.loggedVersions = true
r.chosen = chosen
r.clientVersions = clientVersions
r.serverVersions = serverVersions
},
ReceivedVersionNegotiationPacket: func(dest, src logging.ArbitraryLenConnectionID, _ []logging.Version) {
r.receivedVersionNegotiation = true
},
}
}
func TestServerSupportsMoreVersionsThanClient(t *testing.T) {
supportedVersions := append([]quic.Version{}, protocol.SupportedVersions...)
protocol.SupportedVersions = append(protocol.SupportedVersions, []protocol.Version{7, 8, 9, 10}...)
defer func() { protocol.SupportedVersions = supportedVersions }()
expectedVersion := protocol.SupportedVersions[0]
serverConfig := &quic.Config{}
serverConfig.Versions = []protocol.Version{7, 8, protocol.SupportedVersions[0], 9}
serverResult, serverTracer := newVersionNegotiationTracer(t)
serverConfig.Tracer = func(context.Context, logging.Perspective, quic.ConnectionID) *logging.ConnectionTracer {
return serverTracer
}
server, err := quic.ListenAddr("localhost:0", getTLSConfig(), serverConfig)
require.NoError(t, err)
defer server.Close()
clientResult, clientTracer := newVersionNegotiationTracer(t)
conn, err := quic.DialAddr(
context.Background(),
fmt.Sprintf("localhost:%d", server.Addr().(*net.UDPAddr).Port),
getTLSClientConfig(),
maybeAddQLOGTracer(&quic.Config{Tracer: func(ctx context.Context, perspective logging.Perspective, id quic.ConnectionID) *logging.ConnectionTracer {
return clientTracer
}}),
)
require.NoError(t, err)
sconn, err := server.Accept(context.Background())
require.NoError(t, err)
require.Equal(t, expectedVersion, sconn.ConnectionState().Version)
require.Equal(t, expectedVersion, conn.ConnectionState().Version)
require.NoError(t, conn.CloseWithError(0, ""))
select {
case <-sconn.Context().Done():
// Expected behavior
case <-time.After(5 * time.Second):
t.Fatal("Timeout waiting for connection to close")
}
require.Equal(t, expectedVersion, clientResult.chosen)
require.False(t, clientResult.receivedVersionNegotiation)
require.Equal(t, protocol.SupportedVersions, clientResult.clientVersions)
require.Empty(t, clientResult.serverVersions)
require.Equal(t, expectedVersion, serverResult.chosen)
require.Equal(t, serverConfig.Versions, serverResult.serverVersions)
require.Empty(t, serverResult.clientVersions)
}
func TestClientSupportsMoreVersionsThanServer(t *testing.T) {
supportedVersions := append([]quic.Version{}, protocol.SupportedVersions...)
protocol.SupportedVersions = append(protocol.SupportedVersions, []protocol.Version{7, 8, 9, 10}...)
defer func() { protocol.SupportedVersions = supportedVersions }()
expectedVersion := protocol.SupportedVersions[0]
// The server doesn't support the highest supported version, which is the first one the client will try,
// but it supports a bunch of versions that the client doesn't speak
serverResult, serverTracer := newVersionNegotiationTracer(t)
serverConfig := &quic.Config{}
serverConfig.Versions = supportedVersions
serverConfig.Tracer = func(context.Context, logging.Perspective, quic.ConnectionID) *logging.ConnectionTracer {
return serverTracer
}
server, err := quic.ListenAddr("localhost:0", getTLSConfig(), serverConfig)
require.NoError(t, err)
defer server.Close()
clientVersions := []protocol.Version{7, 8, 9, protocol.SupportedVersions[0], 10}
clientResult, clientTracer := newVersionNegotiationTracer(t)
conn, err := quic.DialAddr(
context.Background(),
fmt.Sprintf("localhost:%d", server.Addr().(*net.UDPAddr).Port),
getTLSClientConfig(),
maybeAddQLOGTracer(&quic.Config{
Versions: clientVersions,
Tracer: func(context.Context, logging.Perspective, quic.ConnectionID) *logging.ConnectionTracer {
return clientTracer
},
}),
)
require.NoError(t, err)
sconn, err := server.Accept(context.Background())
require.NoError(t, err)
require.Equal(t, expectedVersion, sconn.ConnectionState().Version)
require.Equal(t, protocol.SupportedVersions[0], conn.ConnectionState().Version)
require.NoError(t, conn.CloseWithError(0, ""))
select {
case <-sconn.Context().Done():
// Expected behavior
case <-time.After(5 * time.Second):
t.Fatal("Timeout waiting for connection to close")
}
require.Equal(t, expectedVersion, clientResult.chosen)
require.True(t, clientResult.receivedVersionNegotiation)
require.Equal(t, clientVersions, clientResult.clientVersions)
require.Subset(t, clientResult.serverVersions, supportedVersions) // may contain greased versions
require.Equal(t, expectedVersion, serverResult.chosen)
require.Equal(t, serverConfig.Versions, serverResult.serverVersions)
require.Empty(t, serverResult.clientVersions)
}
func TestServerDisablesVersionNegotiation(t *testing.T) {
// The server doesn't support the highest supported version, which is the first one the client will try,
// but it supports a bunch of versions that the client doesn't speak
_, serverTracer := newVersionNegotiationTracer(t)
serverConfig := &quic.Config{Versions: []protocol.Version{quic.Version1}}
serverConfig.Tracer = func(context.Context, logging.Perspective, quic.ConnectionID) *logging.ConnectionTracer {
return serverTracer
}
conn, err := net.ListenUDP("udp", &net.UDPAddr{IP: net.IPv4(127, 0, 0, 1)})
require.NoError(t, err)
tr := &quic.Transport{
Conn: conn,
DisableVersionNegotiationPackets: true,
}
ln, err := tr.Listen(getTLSConfig(), serverConfig)
require.NoError(t, err)
defer ln.Close()
clientVersions := []protocol.Version{quic.Version2}
clientResult, clientTracer := newVersionNegotiationTracer(t)
_, err = quic.DialAddr(
context.Background(),
fmt.Sprintf("localhost:%d", conn.LocalAddr().(*net.UDPAddr).Port),
getTLSClientConfig(),
maybeAddQLOGTracer(&quic.Config{
Versions: clientVersions,
Tracer: func(context.Context, logging.Perspective, quic.ConnectionID) *logging.ConnectionTracer {
return clientTracer
},
HandshakeIdleTimeout: 100 * time.Millisecond,
}),
)
require.Error(t, err)
var nerr net.Error
require.True(t, errors.As(err, &nerr))
require.True(t, nerr.Timeout())
require.False(t, clientResult.receivedVersionNegotiation)
}
|
