File: validation.go

package info (click to toggle)
golang-github-minio-pkg 3.1.2-1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid, trixie
  • size: 1,500 kB
  • sloc: xml: 37; makefile: 35; asm: 22
file content (452 lines) | stat: -rw-r--r-- 15,485 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
// Copyright (c) 2015-2022 MinIO, Inc.
//
// This file is part of MinIO Object Storage stack
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program.  If not, see <http://www.gnu.org/licenses/>.

package ldap

import (
	"fmt"
	"regexp"
	"strings"

	"github.com/go-ldap/ldap/v3"
	"github.com/minio/minio-go/v7/pkg/set"
)

// Result - type for high-level names for the validation status of the config.
type Result string

// Constant values for Result type.
const (
	ConfigOk                       Result = "Config OK"
	ConnectivityError              Result = "LDAP Server Connection Error"
	ConnectionParamMisconfigured   Result = "LDAP Server Connection Parameters Misconfigured"
	LookupBindError                Result = "LDAP Lookup Bind Error"
	UserSearchParamsMisconfigured  Result = "User Search Parameters Misconfigured"
	GroupSearchParamsMisconfigured Result = "Group Search Parameters Misconfigured"
	UserDNLookupError              Result = "User DN Lookup Error"
	GroupMembershipsLookupError    Result = "Group Memberships Lookup Error"
)

// Validation returns feedback on the configuration. The `Suggestion` field
// needs to be "printed" for friendly display (it can contain escaped newlines
// `\n`).
type Validation struct {
	Result     Result
	Detail     string
	Suggestion string
	ErrCause   error
}

// Error instance for Validation.
func (v Validation) Error() string {
	if v.Result == ConfigOk {
		return ""
	}
	return fmt.Sprintf("%s: %s", string(v.Result), v.Detail)
}

// FormatError returns detailed validation error information.
func (v Validation) FormatError() string {
	if v.Result == ConfigOk {
		return ""
	}
	messages := []string{
		fmt.Sprintf("Result: %s", string(v.Result)),
		fmt.Sprintf("Detail: %s", v.Detail),
	}
	if v.Suggestion != "" {
		messages = append(messages, fmt.Sprintf("Suggestion: %s", v.Suggestion))
	}
	if v.ErrCause != nil {
		messages = append(messages, fmt.Sprintf("Due to: %s", v.ErrCause.Error()))
	}
	return strings.Join(messages, "\n")
}

// IsOk - returns if the validation succeeded.
func (v Validation) IsOk() bool {
	return v.Result == ConfigOk
}

// UserLookupResult returns the DN found for the test user and their group
// memberships.
type UserLookupResult struct {
	DN                 string
	DNAttributes       map[string][]string
	GroupDNMemberships []string
}

var validSRVRecordNames = set.CreateStringSet("ldap", "ldaps", "on")

// Validate validates the LDAP configuration. It can be called with any subset
// of configuration parameters provided by the user - it will return
// information on what needs to be done to fix the problem if any.
//
// This function updates the UserDNSearchBaseDistNames and
// GroupSearchBaseDistNames fields of the Config - however this an idempotent
// operation. This is done to support configuration validation in Console/mc and
// for tests.
func (l *Config) Validate() Validation {
	if !l.Enabled {
		return Validation{Result: ConfigOk, Detail: "Config is not enabled"}
	}

	if l.ServerAddr == "" {
		return Validation{
			Result:     ConnectionParamMisconfigured,
			Detail:     "Address is empty",
			Suggestion: "Set a server address.",
		}
	}

	if l.SRVRecordName != "" && !validSRVRecordNames.Contains(l.SRVRecordName) {
		return Validation{
			Result: ConnectionParamMisconfigured,
			Detail: "SRV Record Name is invalid",
			Suggestion: `If given, SRV Record Name must be one of "ldap", "ldaps" or "on".
    Please refer to documentation for more details`,
		}
	}

	conn, err := l.Connect()
	if err != nil {
		return Validation{
			Result:   ConnectivityError,
			Detail:   fmt.Sprintf("Could not connect to LDAP server: %v", err),
			ErrCause: err,
			Suggestion: `Check:
    (1) server address
    (2) TLS parameters,
    (3) LDAP server's TLS certificate is trusted by MinIO (when using TLS - highly recommended)
    (4) SRV Record lookup if given, and
    (5) LDAP service is up and reachable`,
		}
	}
	defer conn.Close()

	if l.LookupBindDN == "" {
		return Validation{
			Result:     LookupBindError,
			Detail:     "Lookup Bind UserDN not specified",
			Suggestion: "Specify LDAP service account credentials for performing lookups.",
		}
	}
	if err := l.LookupBind(conn); err != nil {
		return Validation{
			Result:     LookupBindError,
			ErrCause:   err,
			Detail:     fmt.Sprintf("Error connecting as LDAP Lookup Bind user: %v", err),
			Suggestion: "Check LDAP Lookup Bind user credentials and if user is allowed to login",
		}
	}

	// Validate User Lookup parameters
	userBaseDNList := splitAndTrim(l.UserDNSearchBaseDistName, dnDelimiter)
	l.userDNSearchBaseDistNames, err = validateAndParseBaseDNList(conn, userBaseDNList)
	if err != nil {
		return Validation{
			Result:     UserSearchParamsMisconfigured,
			Detail:     fmt.Sprintf("UserDN search base DN failed to validate/parse: %v", err),
			Suggestion: "Set the UserDN search base to a valid DN - e.g. as returned by an LDAP search",
		}
	}
	if len(l.userDNSearchBaseDistNames) == 0 {
		return Validation{
			Result:     UserSearchParamsMisconfigured,
			Detail:     "UserDN search base is empty",
			Suggestion: "Set the UserDN search base to the DN of the directory subtree where users are present",
		}
	}

	// Validate that BaseDNs represent non-overlapping subtrees.
	if ancestor, descendant := checkForDNOverlaps(l.userDNSearchBaseDistNames); ancestor != "" {
		return Validation{
			Result:     UserSearchParamsMisconfigured,
			Detail:     fmt.Sprintf("User Search Base DN `%s` is an ancestor of `%s`", ancestor, descendant),
			Suggestion: "No two base DNs may overlap - please remove one of them",
		}
	}

	userDNAttributes := splitAndTrim(l.UserDNAttributes, attrDelimiter)
	if len(userDNAttributes) > 0 {
		// Check that the attributes are valid.
		if err := validateAttributes(userDNAttributes); err != nil {
			return Validation{
				Result:     UserSearchParamsMisconfigured,
				Detail:     fmt.Sprintf("UserDN attributes `%s` are invalid: %v", l.UserDNAttributes, err),
				Suggestion: "Ensure that the attribute names are valid LDAP short names of attributes (not OIDs)",
			}
		}
	}
	l.userDNAttributesList = userDNAttributes

	if l.UserDNSearchFilter == "" {
		return Validation{
			Result: UserSearchParamsMisconfigured,
			Detail: "UserDN search filter is empty",
			Suggestion: `Set the UserDN search filter template:
    Use "%s" - it will be replaced by the login user name and sent to the LDAP server.
    For example: "(uid=%s)"`,
		}
	}
	if strings.Contains(l.UserDNSearchFilter, "%d") {
		return Validation{
			Result: UserSearchParamsMisconfigured,
			Detail: "User DN search filter contains `%d`",
			Suggestion: `User DN search filter is a template where "%s" is replaced by the login username.
    "%d" is not supported here.
    Please provide a search filter containing "%s"`,
		}
	}
	if !strings.Contains(l.UserDNSearchFilter, "%s") {
		return Validation{
			Result: UserSearchParamsMisconfigured,
			Detail: "User DN search filter does not contain `%s`",
			Suggestion: `During login, the user's DN is looked up using the search filter template:
    "%s" gets replaced by the given username - it must be used.
    Enter an LDAP search filter containing "%s"`,
		}
	}

	// Check that the LDAP filter compiles.
	if err := compileFilter(l.UserDNSearchFilter); err != nil {
		return Validation{
			Result:     UserSearchParamsMisconfigured,
			Detail:     fmt.Sprintf("User DN search filter `%s` failed to compile: %v", l.UserDNSearchFilter, err),
			Suggestion: `Ensure that the User DN search filter is valid`,
		}
	}

	// If group lookup is not configured, it's ok.
	if l.GroupSearchBaseDistName != "" || l.GroupSearchFilter != "" {

		// Validate Group Search parameters.
		groupBaseDNList := splitAndTrim(l.GroupSearchBaseDistName, dnDelimiter)
		l.groupSearchBaseDistNames, err = validateAndParseBaseDNList(conn, groupBaseDNList)
		if err != nil {
			return Validation{
				Result:     GroupSearchParamsMisconfigured,
				Detail:     fmt.Sprintf("Group Search Base DN failed to parse: %v", err),
				Suggestion: "Set the Group Search Base DN to a valid DN - e.g. as returned by an LDAP search",
			}
		}
		if len(l.groupSearchBaseDistNames) == 0 {
			return Validation{
				Result: GroupSearchParamsMisconfigured,
				Detail: "Group Search Base DN is required.",
				Suggestion: `Since you entered a value for the Group Search Filter - enter a value for the Group Search Base DN too:
    Enter this value as the DN of the subtree where groups will be found.`,
			}
		}

		// Validate that BaseDNs represent non-overlapping subtrees.
		if ancestor, descendant := checkForDNOverlaps(l.groupSearchBaseDistNames); ancestor != "" {
			return Validation{
				Result:     GroupSearchParamsMisconfigured,
				Detail:     fmt.Sprintf("Group Search Base DN `%s` is an ancestor of `%s`", ancestor, descendant),
				Suggestion: "No two base DNs may overlap - please remove one of them",
			}
		}

		if l.GroupSearchFilter == "" {
			return Validation{
				Result: GroupSearchParamsMisconfigured,
				Detail: "Group Search Filter is required.",
				Suggestion: `Since you entered a value for the Group Search Base DN - enter a value for the Group Search Filter too. This is a template where, before the query is sent to the server:
    "%s" is replaced with the login username;
    "%d" is replaced with the DN of the login user.
    For example: "(&(objectclass=groupOfNames)(memberUid=%s))"`,
			}
		}

		if !strings.Contains(l.GroupSearchFilter, "%d") && !strings.Contains(l.GroupSearchFilter, "%s") {
			return Validation{
				Result: GroupSearchParamsMisconfigured,
				Detail: `GroupSearchFilter must contain at least one of "%s" or "%d"`,
				Suggestion: `During group membership lookup the group search filter template is used:
    "%s" gets replaced by the given username, and
    "%d" gets replaced by the user's DN.
    Either one is needed to find only groups that the user is a member of.
    Enter an LDAP search filter template using at least one of these.`,
			}
		}

		// Check that the LDAP filter compiles.
		if err := compileFilter(l.GroupSearchFilter); err != nil {
			return Validation{
				Result:     GroupSearchParamsMisconfigured,
				Detail:     fmt.Sprintf("Group DN search filter `%s` failed to compile: %v", l.GroupSearchFilter, err),
				Suggestion: `Ensure that the Group DN search filter is valid`,
			}
		}

	}

	return Validation{
		Result: ConfigOk,
	}
}

// ValidateLookup takes a test username and performs user and group lookup (if
// configured) and returns the result. It is to validate the LDAP configuration.
// The lookup is performed without requiring the password for the test user -
// and so can be used to test any LDAP user intending to use MinIO.
func (l *Config) ValidateLookup(testUsername string) (*UserLookupResult, Validation) {
	if testUsername == "" {
		return nil, Validation{
			Result: UserDNLookupError,
			Detail: "Provided username is empty",
		}
	}

	if r := l.Validate(); !r.IsOk() {
		return nil, r
	}

	conn, err := l.Connect()
	if err != nil {
		return nil, Validation{
			Result:   ConnectivityError,
			Detail:   fmt.Sprintf("Could not connect to LDAP server: %v", err),
			ErrCause: err,
			Suggestion: `Check:
    (1) server address
    (2) TLS parameters, and
    (3) LDAP server's TLS certificate is trusted by MinIO (when using TLS - highly recommended)`,
		}
	}
	defer conn.Close()

	if err := l.LookupBind(conn); err != nil {
		return nil, Validation{
			Result:     LookupBindError,
			ErrCause:   err,
			Detail:     fmt.Sprintf("Error connecting as LDAP Lookup Bind user: %v", err),
			Suggestion: "Check LDAP Lookup Bind user credentials and if user is allowed to login",
		}
	}

	// Lookup the given username.
	dnResult, err := l.LookupUsername(conn, testUsername)
	if err != nil {
		return nil, Validation{
			Result:   UserDNLookupError,
			Detail:   fmt.Sprintf("Got an error when looking up user (%s) DN: %v", testUsername, err),
			ErrCause: err,
			Suggestion: `Check if this is a temporary error and try again.
    Perhaps there is an error in the user search filter or user search base DN.`,
		}
	}

	// Lookup groups.
	groups, err := l.SearchForUserGroups(conn, testUsername, dnResult.NormDN)
	if err != nil {
		return nil, Validation{
			Result: GroupMembershipsLookupError,
			Detail: fmt.Sprintf("Got an error when looking up groups for user(=>%s, dn=>%s): %v",
				testUsername, dnResult.NormDN, err),
			ErrCause: err,
			Suggestion: `Check if this is a temporary error and try again.
    Perhaps there is an error in the group search filter or group search base DN.`,
		}
	}

	return &UserLookupResult{
			DN:                 dnResult.NormDN,
			DNAttributes:       dnResult.Attributes,
			GroupDNMemberships: groups,
		}, Validation{
			Result: ConfigOk,
			Detail: "User lookup done.",
		}
}

// Splits on given delimiter, trims leading/trailing whitespace and removes
// empty values.
func splitAndTrim(s, sep string) (res []string) {
	parts := strings.Split(s, sep)
	for i := range parts {
		v := strings.TrimSpace(parts[i])
		if len(v) == 0 {
			continue
		}
		res = append(res, v)
	}
	return
}

// Validates that the given DNs are present in the LDAP server.
func validateAndParseBaseDNList(conn *ldap.Conn, baseDNList []string) ([]BaseDNInfo, error) {
	var res []BaseDNInfo
	for _, dn := range baseDNList {
		lookupResult, err := LookupDN(conn, dn, nil)
		if err != nil {
			return nil, fmt.Errorf("Base DN `%s` lookup failed: %w", dn, err)
		}
		if lookupResult == nil {
			return nil, fmt.Errorf("Base DN `%s` not found in the LDAP server", dn)
		}
		serverDN := lookupResult.NormDN
		parsed, err := ldap.ParseDN(serverDN)
		if err != nil {
			return nil, fmt.Errorf("Unexpectedly failed to parse DN `%s`: %w", serverDN, err)
		}
		res = append(res, BaseDNInfo{Original: dn, ServerDN: serverDN, Parsed: parsed})
	}
	return res, nil
}

var validAttributeRegex = regexp.MustCompile(`^[a-zA-Z][a-zA-Z0-9-]*$`)

// Validates that the given attributes are valid LDAP attribute names according
// to a regular expression.
func validateAttributes(attrs []string) error {
	for _, attr := range attrs {
		if !validAttributeRegex.MatchString(attr) {
			return fmt.Errorf("Attribute name `%s` is invalid", attr)
		}
	}
	return nil
}

// checks if given DNs overlap - returns the first pair of DNs having an overlap
// or empty strings.
func checkForDNOverlaps(s []BaseDNInfo) (string, string) {
	n := len(s)
	for i := 0; i < n; i++ {
		for j := i + 1; j < n; j++ {
			if s[i].Parsed.AncestorOf(s[j].Parsed) {
				return s[i].Original, s[j].Original
			} else if s[j].Parsed.AncestorOf(s[i].Parsed) {
				return s[j].Original, s[i].Original
			}
		}
	}
	return "", ""
}

const (
	dummyUser = "a"
	dummyDN   = "uid=a,dc=min,dc=io"
)

func compileFilter(s string) error {
	s1 := strings.ReplaceAll(s, "%s", dummyUser)
	s2 := strings.ReplaceAll(s1, "%d", dummyDN)
	_, err := ldap.CompileFilter(s2)
	return err
}