1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290
|
// Copyright (c) 2015-2024 MinIO, Inc.
//
// # This file is part of MinIO Object Storage stack
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>.
package cors
import (
"bytes"
"encoding/xml"
"os"
"reflect"
"strings"
"testing"
)
var defaultXMLName = xml.Name{Space: "http://s3.amazonaws.com/doc/2006-03-01/", Local: "CORSConfiguration"}
func TestCORSFilterHeaders(t *testing.T) {
tests := []struct {
name string
rule Rule
headers []string
wantOk bool
wantHeaders []string
}{
{
name: "plain single header",
rule: Rule{AllowedHeader: []string{"x-custom-header"}},
headers: []string{"x-custom-header"},
wantOk: true,
wantHeaders: []string{"x-custom-header"},
},
{
name: "single header case insensitive",
rule: Rule{AllowedHeader: []string{"x-CUSTOM-header"}},
headers: []string{"x-custom-HEADER"},
wantOk: true,
wantHeaders: []string{"x-custom-header"},
},
{
name: "plain multiple headers in order",
rule: Rule{AllowedHeader: []string{"x-custom-header-1", "x-custom-header-2"}},
headers: []string{"x-custom-header-1", "x-custom-header-2"},
wantOk: true,
wantHeaders: []string{"x-custom-header-1", "x-custom-header-2"},
},
{
name: "plain multiple headers out of order",
rule: Rule{AllowedHeader: []string{"x-custom-header-2", "x-custom-header-1"}},
headers: []string{"x-custom-header-1", "x-custom-header-2"},
wantOk: true,
wantHeaders: []string{"x-custom-header-1", "x-custom-header-2"},
},
{
name: "plain multiple headers with unknown header",
rule: Rule{AllowedHeader: []string{"x-custom-header-1", "x-custom-header-2"}},
headers: []string{"x-custom-header-1", "x-custom-header-2", "x-custom-header-3"},
wantOk: false,
wantHeaders: nil,
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
config := &Config{
CORSRules: []Rule{test.rule},
}
for _, rule := range config.CORSRules {
headers, ok := rule.FilterAllowedHeaders(test.headers)
if ok != test.wantOk {
t.Errorf("got: %v, want: %v", ok, test.wantOk)
}
if !reflect.DeepEqual(headers, test.wantHeaders) {
t.Errorf("got: %v, want: %v", headers, test.wantHeaders)
}
}
})
}
}
func TestCORSInvalid(t *testing.T) {
tests := []struct {
name string
config *Config
wantErrContains string
}{
{
name: "no CORS rules",
config: &Config{
CORSRules: []Rule{},
},
wantErrContains: "no CORS rules found",
},
{
name: "too many CORS rules",
config: &Config{
CORSRules: make([]Rule, 101),
},
wantErrContains: "too many CORS rules",
},
{
name: "no AllowedOrigin",
config: &Config{
CORSRules: []Rule{
{
ID: "1",
AllowedOrigin: []string{},
AllowedMethod: []string{"GET"},
},
},
},
wantErrContains: "no AllowedOrigin found in CORS rule, id: 1",
},
{
name: "invalid origin multiple wildcards",
config: &Config{
CORSRules: []Rule{
{
AllowedOrigin: []string{"https", "http://*.example.*"},
AllowedMethod: []string{"GET"},
},
},
},
wantErrContains: "can not have more than one wildcard",
},
{
name: "no AllowedMethod",
config: &Config{
CORSRules: []Rule{
{
AllowedOrigin: []string{"*"},
AllowedMethod: []string{},
},
},
},
wantErrContains: "no AllowedMethod found in CORS rule",
},
{
name: "invalid method",
config: &Config{
CORSRules: []Rule{
{
AllowedOrigin: []string{"*"},
AllowedMethod: []string{"GET", "POST", "PATCH"},
},
},
},
wantErrContains: "Unsupported method is PATCH",
},
{
name: "invalid method lowercase",
config: &Config{
CORSRules: []Rule{
{
AllowedOrigin: []string{"*"},
AllowedMethod: []string{"get"},
},
},
},
wantErrContains: "Unsupported method is get",
},
{
name: "invalid header multiple wildcards",
config: &Config{
CORSRules: []Rule{
{
AllowedOrigin: []string{"*"},
AllowedMethod: []string{"GET"},
AllowedHeader: []string{"X-*-Header-*"},
},
},
},
wantErrContains: "not have more than one wildcard",
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
err := test.config.Validate()
if err == nil {
t.Fatal("expected error")
}
if !strings.Contains(err.Error(), test.wantErrContains) {
t.Errorf("got: %v, want contains: %v", err, test.wantErrContains)
}
})
}
}
func TestCORSXMLValid(t *testing.T) {
tests := []struct {
name string
filename string
wantCORSConfig *Config
}{
{
name: "example1 cors config",
filename: "example1.xml",
wantCORSConfig: &Config{
XMLName: defaultXMLName,
XMLNS: defaultXMLNS,
CORSRules: []Rule{
{
AllowedOrigin: []string{"http://www.example1.com"},
AllowedMethod: []string{"PUT", "POST", "DELETE"},
AllowedHeader: []string{"*"},
},
{
AllowedOrigin: []string{"http://www.example2.com"},
AllowedMethod: []string{"PUT", "POST", "DELETE"},
AllowedHeader: []string{"*"},
},
{
AllowedOrigin: []string{"*"},
AllowedMethod: []string{"GET"},
},
},
},
},
{
name: "example2 cors config",
filename: "example2.xml",
wantCORSConfig: &Config{
XMLName: defaultXMLName,
XMLNS: defaultXMLNS,
CORSRules: []Rule{
{
AllowedOrigin: []string{"http://www.example.com"},
AllowedMethod: []string{"PUT", "POST", "DELETE"},
AllowedHeader: []string{"*"},
MaxAgeSeconds: 3000,
ExposeHeader: []string{"x-amz-server-side-encryption", "x-amz-request-id", "x-amz-id-2"},
},
},
},
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
fileContents, err := os.ReadFile("testdata/" + test.filename)
if err != nil {
t.Fatal(err)
}
c, err := ParseBucketCorsConfig(bytes.NewReader(fileContents))
if err != nil {
t.Fatal(err)
}
if !reflect.DeepEqual(c, test.wantCORSConfig) {
t.Errorf("got: %v, want: %v", c, test.wantCORSConfig)
}
err = c.Validate()
if err != nil {
t.Errorf("unexpected error: %v", err)
}
})
}
}
func TestCORSXMLMarshal(t *testing.T) {
fileContents, err := os.ReadFile("testdata/example3.xml")
if err != nil {
t.Fatal(err)
}
c, err := ParseBucketCorsConfig(bytes.NewReader(fileContents))
if err != nil {
t.Fatal(err)
}
remarshalled, err := c.ToXML()
if err != nil {
t.Fatal(err)
}
trimmedFileContents := bytes.TrimSpace(fileContents)
if !bytes.Equal(trimmedFileContents, remarshalled) {
t.Errorf("got: %s, want: %s", string(remarshalled), string(trimmedFileContents))
}
}
|