1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288
|
package redisc
import (
"net"
"strconv"
"sync/atomic"
"testing"
"time"
"github.com/gomodule/redigo/redis"
"github.com/mna/redisc/redistest"
"github.com/mna/redisc/redistest/resp"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestRetryConnAsk(t *testing.T) {
var s *redistest.MockServer
var asking int32
// test a RetryConn that receves an ASK error, but that redirects
// to the same address (only to validate that ASKING is properly
// sent first).
s = redistest.StartMockServer(t, func(cmd string, args ...string) interface{} {
switch cmd {
case "CLUSTER":
addr, port, _ := net.SplitHostPort(s.Addr)
nPort, _ := strconv.Atoi(port)
// reply that all slots are served by this server
return resp.Array{
0: resp.Array{0: int64(0), 1: int64(hashSlots - 1), 2: resp.Array{0: addr, 1: int64(nPort)}},
}
case "GET":
// if asking wasn't sent first, reply with ASK for slot 1234 to
// the same current address.
if atomic.LoadInt32(&asking) == 0 {
return resp.Error("ASK 1234 " + s.Addr)
}
// if asking was sent, reply with OK
return "ok"
case "ASKING":
// record that ASKING was sent
atomic.AddInt32(&asking, 1)
return nil
}
return resp.Error("unexpected command " + cmd)
})
defer s.Close()
c := &Cluster{
StartupNodes: []string{s.Addr},
}
defer c.Close()
require.NoError(t, c.Refresh(), "Refresh")
conn := c.Get()
defer conn.Close()
_, err := conn.Do("GET", "x")
if assert.Error(t, err, "GET without retry") {
re := ParseRedir(err)
if assert.NotNil(t, re, "ParseRedir") {
assert.Equal(t, "ASK", re.Type, "ASK")
}
}
rc, err := RetryConn(conn, 3, time.Second)
require.NoError(t, err, "RetryConn")
v, err := rc.Do("GET", "x")
if assert.NoError(t, err, "GET with retry") {
assert.Equal(t, []byte("ok"), v, "expected result")
}
}
func TestRetryConnAskDistinctServers(t *testing.T) {
var s1, s2 *redistest.MockServer
var asking int32
// all slots are served by server s1, but simulate a migration on a slot
// and reply with ASK to s2, and make sure that s2 received the ASKING
// and subsequent command.
s1 = redistest.StartMockServer(t, func(cmd string, args ...string) interface{} {
switch cmd {
case "CLUSTER":
addr, port, _ := net.SplitHostPort(s1.Addr)
nPort, _ := strconv.Atoi(port)
// reply that all slots are served by this server
return resp.Array{
0: resp.Array{0: int64(0), 1: int64(hashSlots - 1), 2: resp.Array{0: addr, 1: int64(nPort)}},
}
case "GET":
// reply with ASK redirection
return resp.Error("ASK 1234 " + s2.Addr)
}
return resp.Error("unexpected command " + cmd)
})
defer s1.Close()
s2 = redistest.StartMockServer(t, func(cmd string, args ...string) interface{} {
switch cmd {
case "GET":
return "ok"
case "ASKING":
// record that ASKING was sent
atomic.AddInt32(&asking, 1)
return nil
}
return resp.Error("unexpected command " + cmd)
})
defer s2.Close()
c := &Cluster{
StartupNodes: []string{s1.Addr},
}
defer c.Close()
require.NoError(t, c.Refresh(), "Refresh")
conn := c.Get()
defer conn.Close()
rc, err := RetryConn(conn, 3, time.Second)
require.NoError(t, err, "RetryConn")
v, err := rc.Do("GET", "x")
if assert.NoError(t, err, "GET with retry") {
assert.Equal(t, []byte("ok"), v, "expected result")
assert.Equal(t, int32(1), atomic.LoadInt32(&asking))
}
}
func TestRetryConnTryAgain(t *testing.T) {
var s *redistest.MockServer
var tryagain int32
s = redistest.StartMockServer(t, func(cmd string, args ...string) interface{} {
switch cmd {
case "CLUSTER":
addr, port, _ := net.SplitHostPort(s.Addr)
nPort, _ := strconv.Atoi(port)
return resp.Array{
0: resp.Array{0: int64(0), 1: int64(16383), 2: resp.Array{0: addr, 1: int64(nPort)}},
}
case "GET":
if atomic.LoadInt32(&tryagain) < 2 {
atomic.AddInt32(&tryagain, 1)
return resp.Error("TRYAGAIN")
}
return "ok"
}
return resp.Error("unexpected command " + cmd)
})
defer s.Close()
c := &Cluster{
StartupNodes: []string{s.Addr},
}
defer c.Close()
require.NoError(t, c.Refresh(), "Refresh")
conn := c.Get()
defer conn.Close()
_, err := conn.Do("GET", "x")
if assert.Error(t, err, "GET without retry") {
assert.True(t, IsTryAgain(err), "IsTryAgain")
}
rc, err := RetryConn(conn, 3, 1*time.Millisecond)
require.NoError(t, err, "RetryConn")
v, err := rc.Do("GET", "x")
if assert.NoError(t, err, "GET with retry") {
assert.Equal(t, []byte("ok"), v, "expected result")
}
}
func TestRetryConnErrs(t *testing.T) {
c := &Cluster{
StartupNodes: []string{":6379"},
}
conn := c.Get()
require.NoError(t, conn.Close(), "Close")
rc, err := RetryConn(conn, 3, time.Second)
require.NoError(t, err, "RetryConn")
_, err = rc.Do("A")
assert.Error(t, err, "Do after Close")
assert.Error(t, rc.Err(), "Err after Close")
assert.Error(t, rc.Flush(), "Flush")
_, err = rc.Receive()
assert.Error(t, err, "Receive")
assert.Error(t, rc.Send("A"), "Send")
assert.Error(t, rc.Close(), "Close after Close")
_, err = RetryConn(rc, 3, time.Second) // RetryConn, but conn is not a *Conn
assert.Error(t, err, "RetryConn with a non-*Conn")
}
func TestRetryConnTooManyAttempts(t *testing.T) {
fn, ports := redistest.StartCluster(t, nil)
defer fn()
for i, p := range ports {
ports[i] = ":" + p
}
c := &Cluster{
StartupNodes: ports,
DialOptions: []redis.DialOption{redis.DialConnectTimeout(2 * time.Second)},
}
require.NoError(t, c.Refresh(), "Refresh")
// create a connection and bind to key "a"
conn := c.Get()
defer conn.Close()
require.NoError(t, conn.(*Conn).Bind("a"), "Bind")
// wrap it in a RetryConn with a single attempt allowed
rc, err := RetryConn(conn, 1, 100*time.Millisecond)
require.NoError(t, err, "RetryConn")
_, err = rc.Do("SET", "b", "x")
if assert.Error(t, err, "SET b") {
assert.Contains(t, err.Error(), "too many attempts")
}
}
func TestRetryConnMoved(t *testing.T) {
fn, ports := redistest.StartCluster(t, nil)
defer fn()
for i, p := range ports {
ports[i] = ":" + p
}
c := &Cluster{
StartupNodes: ports,
DialOptions: []redis.DialOption{redis.DialConnectTimeout(2 * time.Second)},
}
require.NoError(t, c.Refresh(), "Refresh")
// create a connection and bind to key "a"
conn := c.Get()
defer conn.Close()
require.NoError(t, conn.(*Conn).Bind("a"), "Bind")
// cluster's mapping for "a" should be 15495, "b" is 3300, check that
// the MOVED did update the mapping of "b", and did not touch "a"
c.mu.Lock()
addrA := c.mapping[15495]
addrB := c.mapping[3300]
c.mapping[3300] = []string{"x"}
c.mu.Unlock()
// set key "b", which is on a different node (generates a MOVED) - this is NOT a RetryConn
_, err := conn.Do("SET", "b", "x")
if assert.Error(t, err, "SET b") {
re := ParseRedir(err)
if assert.NotNil(t, re, "ParseRedir") {
assert.Equal(t, "MOVED", re.Type, "Redir type")
}
}
// cluster updated its mapping even though it did not follow the redirection
c.mu.Lock()
assert.Equal(t, addrA, c.mapping[15495], "Addr A")
assert.Equal(t, addrB, c.mapping[3300], "Sentinel value B")
c.mapping[3300] = []string{"x"}
c.mu.Unlock()
// now wrap it in a RetryConn
rc, err := RetryConn(conn, 3, 100*time.Millisecond)
require.NoError(t, err, "RetryConn")
_, err = rc.Do("SET", "b", "x")
assert.NoError(t, err, "SET b")
// the cluster should've updated its mapping
c.mu.Lock()
assert.Equal(t, addrA, c.mapping[15495], "Addr A")
assert.Equal(t, addrB, c.mapping[3300], "Addr B")
c.mu.Unlock()
v, err := redis.String(rc.Do("GET", "b"))
if assert.NoError(t, err, "GET b") {
assert.Equal(t, "x", v, "GET value")
}
}
|