1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
|
package rtcp
import (
"errors"
"reflect"
"testing"
)
var _ Packet = (*Goodbye)(nil) // assert is a Packet
func TestGoodbyeUnmarshal(t *testing.T) {
for _, test := range []struct {
Name string
Data []byte
Want Goodbye
WantError error
}{
{
Name: "valid",
Data: []byte{
// v=2, p=0, count=1, BYE, len=12
0x81, 0xcb, 0x00, 0x0c,
// ssrc=0x902f9e2e
0x90, 0x2f, 0x9e, 0x2e,
// len=3, text=FOO
0x03, 0x46, 0x4f, 0x4f,
},
Want: Goodbye{
Sources: []uint32{0x902f9e2e},
Reason: "FOO",
},
},
{
Name: "invalid octet count",
Data: []byte{
// v=2, p=0, count=1, BYE, len=12
0x81, 0xcb, 0x00, 0x0c,
// ssrc=0x902f9e2e
0x90, 0x2f, 0x9e, 0x2e,
// len=4, text=FOO
0x04, 0x46, 0x4f, 0x4f,
},
WantError: errPacketTooShort,
},
{
Name: "wrong type",
Data: []byte{
// v=2, p=0, count=1, SDES, len=12
0x81, 0xca, 0x00, 0x0c,
// ssrc=0x902f9e2e
0x90, 0x2f, 0x9e, 0x2e,
// len=3, text=FOO
0x03, 0x46, 0x4f, 0x4f,
},
WantError: errWrongType,
},
{
Name: "short reason",
Data: []byte{
// v=2, p=0, count=1, BYE, len=12
0x81, 0xcb, 0x00, 0x0c,
// ssrc=0x902f9e2e
0x90, 0x2f, 0x9e, 0x2e,
// len=3, text=F + padding
0x01, 0x46, 0x00, 0x00,
},
Want: Goodbye{
Sources: []uint32{0x902f9e2e},
Reason: "F",
},
},
{
Name: "not byte aligned",
Data: []byte{
// v=2, p=0, count=1, BYE, len=10
0x81, 0xcb, 0x00, 0x0a,
// ssrc=0x902f9e2e
0x90, 0x2f, 0x9e, 0x2e,
// len=1, text=F
0x01, 0x46,
},
WantError: errPacketTooShort,
},
{
Name: "bad count in header",
Data: []byte{
// v=2, p=0, count=2, BYE, len=8
0x82, 0xcb, 0x00, 0x0c,
// ssrc=0x902f9e2e
0x90, 0x2f, 0x9e, 0x2e,
},
WantError: errPacketTooShort,
},
{
Name: "empty packet",
Data: []byte{
// v=2, p=0, count=0, BYE, len=4
0x80, 0xcb, 0x00, 0x04,
},
Want: Goodbye{
Sources: []uint32{},
Reason: "",
},
},
{
Name: "nil",
Data: nil,
WantError: errPacketTooShort,
},
} {
var bye Goodbye
err := bye.Unmarshal(test.Data)
if got, want := err, test.WantError; !errors.Is(got, want) {
t.Fatalf("Unmarshal %q bye: err = %v, want %v", test.Name, got, want)
}
if err != nil {
continue
}
if got, want := bye, test.Want; !reflect.DeepEqual(got, want) {
t.Fatalf("Unmarshal %q bye: got %v, want %v", test.Name, got, want)
}
}
}
func TestGoodbyeRoundTrip(t *testing.T) {
// a slice with enough sources to overflow an 5-bit int
var tooManySources []uint32
var tooLongText string
for i := 0; i < (1 << 5); i++ {
tooManySources = append(tooManySources, 0x00)
}
for i := 0; i < (1 << 8); i++ {
tooLongText += "x"
}
for _, test := range []struct {
Name string
Bye Goodbye
WantError error
}{
{
Name: "empty",
Bye: Goodbye{
Sources: []uint32{},
},
},
{
Name: "valid",
Bye: Goodbye{
Sources: []uint32{
0x01020304,
0x05060708,
},
Reason: "because",
},
},
{
Name: "empty reason",
Bye: Goodbye{
Sources: []uint32{0x01020304},
Reason: "",
},
},
{
Name: "reason no source",
Bye: Goodbye{
Sources: []uint32{},
Reason: "foo",
},
},
{
Name: "short reason",
Bye: Goodbye{
Sources: []uint32{},
Reason: "f",
},
},
{
Name: "count overflow",
Bye: Goodbye{
Sources: tooManySources,
},
WantError: errTooManySources,
},
{
Name: "reason too long",
Bye: Goodbye{
Sources: []uint32{},
Reason: tooLongText,
},
WantError: errReasonTooLong,
},
} {
data, err := test.Bye.Marshal()
if got, want := err, test.WantError; !errors.Is(got, want) {
t.Fatalf("Marshal %q: err = %v, want %v", test.Name, got, want)
}
if err != nil {
continue
}
var bye Goodbye
if err := bye.Unmarshal(data); err != nil {
t.Fatalf("Unmarshal %q: %v", test.Name, err)
}
if got, want := bye, test.Bye; !reflect.DeepEqual(got, want) {
t.Fatalf("%q sdes round trip: got %#v, want %#v", test.Name, got, want)
}
}
}
|
