1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457
|
package selfupdate
import (
"fmt"
"os"
"regexp"
"strings"
"testing"
"github.com/blang/semver"
"github.com/google/go-github/v60/github"
)
func TestDetectReleaseWithVersionPrefix(t *testing.T) {
r, ok, err := DetectLatest("rhysd/github-clone-all")
if err != nil {
t.Fatal("Fetch failed:", err)
}
if !ok {
t.Fatal("Failed to detect latest")
}
if r == nil {
t.Fatal("Release detected but nil returned for it")
}
if r.Version.LE(semver.MustParse("2.0.0")) {
t.Error("Incorrect version:", r.Version)
}
if !strings.HasSuffix(r.AssetURL, ".zip") && !strings.HasSuffix(r.AssetURL, ".tar.gz") {
t.Error("Incorrect URL for asset:", r.AssetURL)
}
if r.URL == "" {
t.Error("Document URL should not be empty")
}
if r.ReleaseNotes == "" {
t.Error("Description should not be empty for this repo")
}
if r.Name == "" {
t.Error("Release name is unexpectedly empty")
}
if r.AssetByteSize == 0 {
t.Error("Asset's size is unexpectedly zero")
}
if r.AssetID == 0 {
t.Error("Asset's ID is unexpectedly zero")
}
if r.PublishedAt.IsZero() {
t.Error("Release time is unexpectedly zero")
}
if r.RepoOwner != "rhysd" {
t.Error("Repo owner is not correct:", r.RepoOwner)
}
if r.RepoName != "github-clone-all" {
t.Error("Repo name was not properly detectd:", r.RepoName)
}
}
func TestDetectVersionExisting(t *testing.T) {
testVersion := "v2.2.0"
r, ok, err := DetectVersion("rhysd/github-clone-all", testVersion)
if err != nil {
t.Fatal("Fetch failed:", err)
}
if !ok {
t.Fatalf("Failed to detect %s", testVersion)
}
if r == nil {
t.Fatal("Release detected but nil returned for it")
}
}
func TestDetectVersionNotExisting(t *testing.T) {
r, ok, err := DetectVersion("rhysd/github-clone-all", "foobar")
if err != nil {
t.Fatal("Fetch failed:", err)
}
if ok {
t.Fatal("Failed to correctly detect foobar")
}
if r != nil {
t.Fatal("Release not detected but got a returned value for it")
}
}
func TestDetectReleasesForVariousArchives(t *testing.T) {
for _, tc := range []struct {
slug string
prefix string
}{
{"rhysd-test/test-release-zip", "v"},
{"rhysd-test/test-release-tar", "v"},
{"rhysd-test/test-release-gzip", "v"},
{"rhysd-test/test-release-xz", "release-v"},
{"rhysd-test/test-release-tar-xz", "release-"},
} {
t.Run(tc.slug, func(t *testing.T) {
r, ok, err := DetectLatest(tc.slug)
if err != nil {
t.Fatal("Fetch failed:", err)
}
if !ok {
t.Fatal(tc.slug, "not found")
}
if r == nil {
t.Fatal("Release not detected")
}
if !r.Version.Equals(semver.MustParse("1.2.3")) {
t.Error("")
}
url := fmt.Sprintf("https://github.com/%s/releases/tag/%s1.2.3", tc.slug, tc.prefix)
if r.URL != url {
t.Error("URL is not correct. Want", url, "but got", r.URL)
}
if r.ReleaseNotes == "" {
t.Error("Release note is unexpectedly empty")
}
if !strings.HasPrefix(r.AssetURL, fmt.Sprintf("https://github.com/%s/releases/download/%s1.2.3/", tc.slug, tc.prefix)) {
t.Error("Unexpected asset URL:", r.AssetURL)
}
if r.Name == "" {
t.Error("Release name is unexpectedly empty")
}
if r.AssetByteSize == 0 {
t.Error("Asset's size is unexpectedly zero")
}
if r.AssetID == 0 {
t.Error("Asset's ID is unexpectedly zero")
}
if r.PublishedAt.IsZero() {
t.Error("Release time is unexpectedly zero")
}
if r.RepoOwner != "rhysd-test" {
t.Error("Repo owner should be rhysd-test:", r.RepoOwner)
}
if !strings.HasPrefix(r.RepoName, "test-release-") {
t.Error("Repo name was not properly detectd:", r.RepoName)
}
})
}
}
func TestDetectReleaseButNoAsset(t *testing.T) {
_, ok, err := DetectLatest("rhysd/clever-f.vim")
if err != nil {
t.Fatal("Fetch failed:", err)
}
if ok {
t.Fatal("When no asset found, result should be marked as 'not found'")
}
}
func TestDetectNoRelease(t *testing.T) {
_, ok, err := DetectLatest("rhysd/clever-f.vim")
if err != nil {
t.Fatal("Fetch failed:", err)
}
if ok {
t.Fatal("When no release found, result should be marked as 'not found'")
}
}
func TestInvalidSlug(t *testing.T) {
up := DefaultUpdater()
for _, slug := range []string{
"foo",
"/",
"foo/",
"/bar",
"foo/bar/piyo",
} {
_, _, err := up.DetectLatest(slug)
if err == nil {
t.Error(slug, "should be invalid slug")
}
if !strings.Contains(err.Error(), "Invalid slug format") {
t.Error("Unexpected error for", slug, ":", err)
}
}
}
func TestNonExistingRepo(t *testing.T) {
v, ok, err := DetectLatest("rhysd/non-existing-repo")
if err != nil {
t.Fatal("Non-existing repo should not cause an error:", v)
}
if ok {
t.Fatal("Release for non-existing repo should not be found")
}
}
func TestNoReleaseFound(t *testing.T) {
_, ok, err := DetectLatest("rhysd/misc")
if err != nil {
t.Fatal("Repo having no release should not cause an error:", err)
}
if ok {
t.Fatal("Repo having no release should not be found")
}
}
func TestDetectFromBrokenGitHubEnterpriseURL(t *testing.T) {
up, err := NewUpdater(Config{APIToken: "hogehoge", EnterpriseBaseURL: "https://example.com"})
if err != nil {
t.Fatal(err)
}
_, ok, _ := up.DetectLatest("foo/bar")
if ok {
t.Fatal("Invalid GitHub Enterprise base URL should raise an error")
}
}
func TestDetectFromGitHubEnterpriseRepo(t *testing.T) {
token := os.Getenv("GITHUB_ENTERPRISE_TOKEN")
base := os.Getenv("GITHUB_ENTERPRISE_BASE_URL")
repo := os.Getenv("GITHUB_ENTERPRISE_REPO")
if token == "" {
t.Skip("because token for GHE is not found")
}
if base == "" {
t.Skip("because base URL for GHE is not found")
}
if repo == "" {
t.Skip("because repo slug for GHE is not found")
}
up, err := NewUpdater(Config{APIToken: token, EnterpriseBaseURL: base})
if err != nil {
t.Fatal(err)
}
r, ok, err := up.DetectLatest(repo)
if err != nil {
t.Fatal("Fetch failed:", err)
}
if !ok {
t.Fatal(repo, "not found")
}
if r == nil {
t.Fatal("Release not detected")
}
if !r.Version.Equals(semver.MustParse("1.2.3")) {
t.Error("")
}
}
func TestFindReleaseAndAsset(t *testing.T) {
EnableLog()
type findReleaseAndAssetFixture struct {
name string
rels *github.RepositoryRelease
targetVersion string
filters []*regexp.Regexp
expectedAsset string
expectedVersion string
expectedFound bool
}
rel1 := "rel1"
v1 := "1.0.0"
rel11 := "rel11"
v11 := "1.1.0"
asset1 := "asset1.gz"
asset2 := "asset2.gz"
wrongAsset1 := "asset1.yaml"
asset11 := "asset11.gz"
url1 := "https://asset1"
url2 := "https://asset2"
url11 := "https://asset11"
for _, fixture := range []findReleaseAndAssetFixture{
{
name: "empty fixture",
rels: nil,
targetVersion: "",
filters: nil,
expectedFound: false,
},
{
name: "find asset, no filters",
rels: &github.RepositoryRelease{
Name: &rel1,
TagName: &v1,
Assets: []*github.ReleaseAsset{
{
Name: &asset1,
URL: &url1,
},
},
},
targetVersion: "1.0.0",
expectedAsset: asset1,
expectedVersion: "1.0.0",
expectedFound: true,
},
{
name: "don't find asset with wrong extension, no filters",
rels: &github.RepositoryRelease{
Name: &rel11,
TagName: &v11,
Assets: []*github.ReleaseAsset{
{
Name: &wrongAsset1,
URL: &url11,
},
},
},
targetVersion: "1.1.0",
expectedFound: false,
},
{
name: "find asset with different name, no filters",
rels: &github.RepositoryRelease{
Name: &rel11,
TagName: &v11,
Assets: []*github.ReleaseAsset{
{
Name: &asset1,
URL: &url11,
},
},
},
targetVersion: "1.1.0",
expectedAsset: asset1,
expectedVersion: "1.1.0",
expectedFound: true,
},
{
name: "find asset, no filters (2)",
rels: &github.RepositoryRelease{
Name: &rel11,
TagName: &v11,
Assets: []*github.ReleaseAsset{
{
Name: &asset11,
URL: &url11,
},
},
},
targetVersion: "1.1.0",
expectedAsset: asset11,
expectedVersion: "1.1.0",
filters: nil,
expectedFound: true,
},
{
name: "find asset, match filter",
rels: &github.RepositoryRelease{
Name: &rel11,
TagName: &v11,
Assets: []*github.ReleaseAsset{
{
Name: &asset11,
URL: &url11,
},
{
Name: &asset1,
URL: &url1,
},
},
},
targetVersion: "1.1.0",
filters: []*regexp.Regexp{regexp.MustCompile("11")},
expectedAsset: asset11,
expectedVersion: "1.1.0",
expectedFound: true,
},
{
name: "find asset, match another filter",
rels: &github.RepositoryRelease{
Name: &rel11,
TagName: &v11,
Assets: []*github.ReleaseAsset{
{
Name: &asset11,
URL: &url11,
},
{
Name: &asset1,
URL: &url1,
},
},
},
targetVersion: "1.1.0",
filters: []*regexp.Regexp{regexp.MustCompile("([^1])1{1}([^1])")},
expectedAsset: asset1,
expectedVersion: "1.1.0",
expectedFound: true,
},
{
name: "find asset, match any filter",
rels: &github.RepositoryRelease{
Name: &rel11,
TagName: &v11,
Assets: []*github.ReleaseAsset{
{
Name: &asset11,
URL: &url11,
},
{
Name: &asset2,
URL: &url2,
},
},
},
targetVersion: "1.1.0",
filters: []*regexp.Regexp{
regexp.MustCompile("([^1])1{1}([^1])"),
regexp.MustCompile("([^1])2{1}([^1])"),
},
expectedAsset: asset2,
expectedVersion: "1.1.0",
expectedFound: true,
},
{
name: "find asset, match no filter",
rels: &github.RepositoryRelease{
Name: &rel11,
TagName: &v11,
Assets: []*github.ReleaseAsset{
{
Name: &asset11,
URL: &url11,
},
{
Name: &asset2,
URL: &url2,
},
},
},
targetVersion: "1.1.0",
filters: []*regexp.Regexp{
regexp.MustCompile("another"),
regexp.MustCompile("binary"),
},
expectedFound: false,
},
} {
asset, ver, found := findAssetFromRelease(fixture.rels, []string{".gz"}, fixture.targetVersion, fixture.filters)
if fixture.expectedFound {
if !found {
t.Errorf("expected to find an asset for this fixture: %q", fixture.name)
continue
}
if asset.Name == nil {
t.Errorf("invalid asset struct returned from fixture: %q, got: %v", fixture.name, asset)
continue
}
if *asset.Name != fixture.expectedAsset {
t.Errorf("expected asset %q in fixture: %q, got: %s", fixture.expectedAsset, fixture.name, *asset.Name)
continue
}
t.Logf("asset %v, %v", asset, ver)
} else if found {
t.Errorf("expected not to find an asset for this fixture: %q, but got: %v", fixture.name, asset)
}
}
}
|