1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
|
//
// Copyright 2021 The Sigstore Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package signature
import (
"bytes"
"context"
"crypto"
crand "crypto/rand"
"crypto/rsa"
"crypto/x509"
"strings"
"testing"
"github.com/sigstore/sigstore/pkg/signature/options"
)
func testingSigner(t *testing.T, s Signer, alg string, hashFunc crypto.Hash, message []byte) { // nolint: unparam
t.Helper()
isPreHashed := alg != "ed25519"
var digest []byte
if isPreHashed {
hasher := hashFunc.New()
_, _ = hasher.Write(message)
digest = hasher.Sum(nil)
}
if _, err := s.SignMessage(nil); err == nil {
t.Error("didn't error out for nil message")
}
// if nil is passed for rand, default (crypto/rand.Reader) should be used
if _, err := s.SignMessage(bytes.NewReader(message), options.WithRand(nil)); err != nil && isPreHashed {
t.Errorf("unexpected error passing nil Rand: %v", err)
}
if _, err := s.SignMessage(bytes.NewReader(message), options.WithRand(crand.Reader)); err != nil {
t.Errorf("unexpected error passing valid Rand: %v", err)
}
if _, err := s.SignMessage(bytes.NewReader(message), options.WithRand(crand.Reader), options.WithDigest(digest)); err != nil {
t.Errorf("unexpected error passing valid Rand and Digest: %v", err)
}
if _, err := s.SignMessage(bytes.NewReader(message), options.WithRand(crand.Reader), options.WithDigest(digest), options.WithCryptoSignerOpts(hashFunc)); err != nil {
t.Errorf("unexpected error passing valid Rand and Digest and Opts: %v", err)
}
if _, err := s.SignMessage(bytes.NewReader(message), options.WithDigest(digest)); err != nil {
t.Errorf("unexpected error passing valid Digest: %v", err)
}
if _, err := s.SignMessage(bytes.NewReader(message), options.WithDigest(digest), options.WithCryptoSignerOpts(crypto.Hash(0))); err == nil && isPreHashed {
t.Error("no error passing invalid opts")
}
if _, err := s.SignMessage(bytes.NewReader(message), options.WithDigest(digest), options.WithCryptoSignerOpts(crypto.SHA384)); err == nil && isPreHashed {
t.Error("no error passing mismatched Digest and opts")
}
if _, err := s.SignMessage(bytes.NewReader(message), options.WithCryptoSignerOpts(nil)); err != nil && alg != "ed25519ph" {
t.Errorf("unexpected error passing nil options: %v", err)
}
cs, ok := s.(crypto.Signer)
if !ok {
t.Fatalf("expected crypto.Signer")
}
if _, err := cs.Sign(nil, nil, nil); err == nil {
t.Errorf("no error passing nil for all args to Sign: %v", err)
}
if !isPreHashed {
if _, err := cs.Sign(nil, message, crypto.Hash(0)); err != nil {
t.Errorf("unexpected error passing nil Rand, message and crypto.Hash(0) to Sign: %v", err)
}
}
if _, err := cs.Sign(nil, digest, nil); err != nil && isPreHashed {
t.Errorf("unexpected error passing nil for Rand and Opts to Sign: %v", err)
}
if _, err := cs.Sign(nil, digest, &rsa.PSSOptions{Hash: hashFunc}); err != nil && isPreHashed {
t.Errorf("unexpected error passing nil for Rand and valid Opts to Sign: %v", err)
}
if _, err := cs.Sign(crand.Reader, digest, &rsa.PSSOptions{Hash: hashFunc}); err != nil && isPreHashed {
t.Errorf("unexpected error passing valid Rand and valid Opts to Sign: %v", err)
}
if _, err := cs.Sign(crand.Reader, digest, nil); err != nil && isPreHashed {
t.Errorf("unexpected error passing valid Rand and nil Opts to Sign: %v", err)
}
if k := cs.Public(); k == nil {
t.Error("Public() returned empty key")
}
if k, err := s.PublicKey(); k == nil || err != nil {
t.Errorf("PublicKey() returned empty key or err: %v", err)
}
if k, err := s.PublicKey(options.WithContext(context.Background())); k == nil || err != nil {
t.Errorf("PublicKey(context.Background()) returned empty key or err: %v", err)
}
}
func assertPublicKeyIsx509Marshalable(t *testing.T, pub crypto.PublicKey) {
t.Helper()
if _, err := x509.MarshalPKIXPublicKey(pub); err != nil {
t.Errorf("x509.MarshalPKIXPublicKey(%T) returned error: %v", pub, err)
}
}
func testingVerifier(t *testing.T, v Verifier, alg string, hashFunc crypto.Hash, signature, message []byte) { // nolint: unparam
t.Helper()
isPreHashed := alg != "ed25519"
var digest []byte
if isPreHashed {
hasher := hashFunc.New()
_, _ = hasher.Write(message)
digest = hasher.Sum(nil)
}
if err := v.VerifySignature(bytes.NewReader(signature), nil); err == nil {
t.Error("no error when passing nil as message")
}
if err := v.VerifySignature(nil, bytes.NewReader(message)); err == nil {
t.Error("no error when passing nil as signature")
}
if err := v.VerifySignature(strings.NewReader("not the sig"), bytes.NewReader(message)); err == nil {
t.Error("no error when passing incorrect signature")
}
if err := v.VerifySignature(bytes.NewReader(signature), bytes.NewReader(message)); err != nil {
t.Errorf("unexpected error when verifying valid bytes.NewReader(message): %v", err)
}
if err := v.VerifySignature(bytes.NewReader(signature), bytes.NewReader(message), options.WithDigest(digest)); err != nil {
t.Errorf("unexpected error when using valid bytes.NewReader(message) with digest: %v", err)
}
if err := v.VerifySignature(bytes.NewReader(signature), bytes.NewReader(message), options.WithDigest(digest), options.WithCryptoSignerOpts(hashFunc)); err != nil {
t.Errorf("unexpected error when using valid bytes.NewReader(message) with digest & opts: %v", err)
}
var alternativeHash crypto.Hash
if hashFunc == crypto.SHA512 {
alternativeHash = crypto.SHA256
} else {
alternativeHash = crypto.SHA512
}
if err := v.VerifySignature(bytes.NewReader(signature), bytes.NewReader(message), options.WithDigest(digest), options.WithCryptoSignerOpts(alternativeHash)); err == nil && isPreHashed {
t.Error("no error when using mismatched hashFunc with digest & opts")
}
}
|
