1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
|
// Copyright (c) 2023 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package tally_test
import (
"io"
"sync"
"testing"
"time"
"github.com/golang/mock/gomock"
"github.com/stretchr/testify/require"
"github.com/uber-go/tally/v4"
"github.com/uber-go/tally/v4/tallymock"
"go.uber.org/atomic"
)
func TestTestScopesNotPruned(t *testing.T) {
var (
root = tally.NewTestScope("", nil)
subscope = root.SubScope("foo")
counter = subscope.Counter("bar")
)
counter.Inc(123)
closer, ok := subscope.(io.Closer)
require.True(t, ok)
require.NoError(t, closer.Close())
subscope = root.SubScope("foo")
counter = subscope.Counter("bar")
counter.Inc(123)
var (
snapshot = root.Snapshot()
counters = snapshot.Counters()
)
require.Len(t, counters, 1)
require.Len(t, snapshot.Gauges(), 0)
require.Len(t, snapshot.Timers(), 0)
require.Len(t, snapshot.Histograms(), 0)
val, ok := counters["foo.bar+"]
require.True(t, ok)
require.Equal(t, "foo.bar", val.Name())
require.EqualValues(t, 246, val.Value())
}
func TestNoDefunctSubscopes(t *testing.T) {
ctrl := gomock.NewController(t)
defer ctrl.Finish()
var (
tags = map[string]string{
"hello": "world",
}
mockreporter = tallymock.NewMockStatsReporter(ctrl)
ready = make(chan struct{})
closed atomic.Bool
wg sync.WaitGroup
)
wg.Add(2)
mockreporter.EXPECT().
ReportCounter("a", gomock.Any(), int64(123)).
Do(func(_ string, _ map[string]string, _ int64) {
wg.Done()
}).
Times(1)
mockreporter.EXPECT().
ReportCounter("b", gomock.Any(), int64(456)).
Do(func(_ string, _ map[string]string, _ int64) {
wg.Done()
}).
Times(1)
// Use flushing as a signal to determine if/when a closed scope
// would be removed from the registry's cache.
mockreporter.EXPECT().
Flush().
Do(func() {
// Don't unblock the ready channel until we've explicitly
// closed the scope.
if !closed.Load() {
return
}
select {
case <-ready:
default:
close(ready)
}
}).
MinTimes(1)
root, _ := tally.NewRootScope(tally.ScopeOptions{
Reporter: mockreporter,
OmitCardinalityMetrics: true,
}, time.Millisecond)
subscope := root.Tagged(tags)
requireClose(t, subscope)
subscope = root.Tagged(tags)
// Signal and wait for the next flush to ensure that subscope can
// be a closed scope.
closed.Store(true)
<-ready
// Use the maybe-closed subscope for counter A.
subscope.Counter("a").Inc(123)
// Guarantee that counter B will not use a closed subscope.
subscope = root.Tagged(tags)
subscope.Counter("b").Inc(456)
requireClose(t, root)
wg.Wait()
}
func requireClose(t *testing.T, scope tally.Scope) {
x, ok := scope.(io.Closer)
require.True(t, ok)
require.NoError(t, x.Close())
}
|
