1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
|
package metricsql
import (
"strings"
"testing"
)
func TestPrettifyError(t *testing.T) {
f := func(s string) {
t.Helper()
result, err := Prettify(s)
if err == nil {
t.Fatalf("expecting non-nil error")
}
if result != "" {
t.Fatalf("expecting empty result; got %q", result)
}
}
f(`foo{`)
f(`invalid query`)
}
func TestPrettifyOkParseError(t *testing.T) {
f := func(s, wantErr string) {
t.Helper()
// check prettify ok
// it should not check query for semantic errors
result, err := Prettify(s)
if err != nil {
t.Fatalf("unexpected error when prettifying: %q: %s", s, err)
}
// Verify that the prettified result is failed to parse due to semantic error
_, err = Parse(result)
if err == nil {
t.Fatalf("expecting non-nil error")
}
errStr := err.Error()
if !strings.Contains(errStr, wantErr) {
t.Fatalf("unexpected error string:\ngot:\n%q\nwant:\n%q", err, wantErr)
}
}
// unknown duration
f(`sum(rate(m{a="b"}[BAZ]))`, `cannot find WITH template for "BAZ"`)
f(`sum(rate(m{a="b"}[5m:BAZ]))`, `cannot find WITH template for "BAZ"`)
f(`sum(rate(m{a="b"}[BAZ:5s]))`, `cannot find WITH template for "BAZ"`)
f(`sum(rate(m{a="b"}[5m] offset BAZ))`, `cannot find WITH template for "BAZ"`)
// unknown function
f(`WITH (ru(freev, maxv) = bad_func1(maxv - bad_func_2(freev, 0), 0) / clamp_min(maxv, 0) * 100) ru(1,2)`, `unsupported function "bad_func_2"`)
// composite strings
f(`with (f(x)=foo(m{a="z"+x})) f("abc")`, `unsupported function "foo"`)
f(`with (f(x) = "a" + x + "y" + "z") f(abc)`, `"x" must be string expression; got "abc"`)
}
func TestPrettifySuccess(t *testing.T) {
another := func(s, resultExpected string) {
t.Helper()
result, err := Prettify(s)
if err != nil {
t.Fatalf("unexpected error when parsing %q: %s", s, err)
}
if result != resultExpected {
t.Fatalf("unexpected query after prettifying;\ngot\n%s\nwant\n%s", result, resultExpected)
}
// Verify that prettifying of the result gives the same result
result2, err := Prettify(result)
if err != nil {
t.Fatalf("unexpected error when parsing prettified %q: %s", s, err)
}
if result2 != result {
t.Fatalf("unexpected result after prettifying already prettified result;\ngot\n%s\nwant\n%s", result2, result)
}
// Verify that the prettified result is successfully parsed into the same string as the original query
e, err := Parse(s)
if err != nil {
t.Fatalf("cannot parse original string: %s", err)
}
eResult, err := Parse(result)
if err != nil {
t.Fatalf("cannot parse prettified result: %s", err)
}
sExpected := e.AppendString(nil)
sGot := eResult.AppendString(nil)
if string(sExpected) != string(sGot) {
t.Fatalf("unexpected prettified string after parsing;\ngot\n%s\nwant\n%s", sGot, sExpected)
}
}
same := func(s string) {
t.Helper()
another(s, s)
}
// Verify that short queries remain single-line
same(`foo`)
another(`{"foo"}`, "foo")
another(`{"3foo"}`, `{"3foo"}`)
another(`{"foo", bar="baz"}`, `foo{bar="baz"}`)
another(`{"foo", "bar"="baz"}`, `foo{bar="baz"}`)
same(`foo{bar="baz"}`)
same(`foo{"3bar"="baz"}`)
another(`foo{"bar3"="baz"}`, `foo{bar3="baz"}`)
same(`"metr\"ic"`)
same(`'metr"ic'`)
same(`{"3foo", bar="baz"}`)
same(`foo{bar="baz",x="y" or q="w",r="t"}`)
same(`foo{bar="baz"} + rate(x{y="x"}[5m] offset 1h)`)
// Verify that empty label filters aren't added to long metric names
same(`foobar_baz:namespace_pod_name_container_name:container_cpu_usage_seconds_total:sum_rate`)
another(`foobar_baz:namespace_pod_name_container_name:container_cpu_usage_seconds_total:sum_rate{}`,
`foobar_baz:namespace_pod_name_container_name:container_cpu_usage_seconds_total:sum_rate`)
// Verify that long label filters are split into multiple lines
another(`process_cpu_seconds_total{foo="bar",xjljljlkjopiwererrewre="asdfdsfdsfsdfdsfjkljlk"}`,
`process_cpu_seconds_total{
foo="bar",xjljljlkjopiwererrewre="asdfdsfdsfsdfdsfjkljlk"
}`)
another(`process_cpu_seconds_total{"3foo"="bar",xjljljlkjopiwererrewre="asdfdsfdsfsdfdsfjkljlk"}`,
`process_cpu_seconds_total{
"3foo"="bar",xjljljlkjopiwererrewre="asdfdsfdsfsdfdsfjkljlk"
}`)
another(`{"process_cpu_seconds_total", "foo"="bar",xjljljlkjopiwererrewre="asdfdsfdsfsdfdsfjkljlk"}`,
`process_cpu_seconds_total{
foo="bar",xjljljlkjopiwererrewre="asdfdsfdsfsdfdsfjkljlk"
}`)
another(`{"3process_cpu_seconds_total", "foo"="bar",xjljljlkjopiwererrewre="asdfdsfdsfsdfdsfjkljlk"}`,
`{
"3process_cpu_seconds_total",
foo="bar",xjljljlkjopiwererrewre="asdfdsfdsfsdfdsfjkljlk"
}`)
another(`process_cpu_seconds_total{foo="bar",xjljljlkjopiwererrewre="asdfdsfdsfsdfdsfjkljlk",very_long_label_aaaaaaaaaaaaaaa="fdsfdsffdsfs"}`,
`process_cpu_seconds_total{
foo="bar",
xjljljlkjopiwererrewre="asdfdsfdsfsdfdsfjkljlk",
very_long_label_aaaaaaaaaaaaaaa="fdsfdsffdsfs"
}`)
another(`{foo="bar",xjljljlkjopiwererrewre="asdfdsfdsfsdfdsfjkljlk",very_long_label_aaaaaaaaaaaaaaa="fdsfdsffdsfs"}`,
`{
foo="bar",
xjljljlkjopiwererrewre="asdfdsfdsfsdfdsfjkljlk",
very_long_label_aaaaaaaaaaaaaaa="fdsfdsffdsfs"
}`)
another(`process_cpu_seconds_total{instance="foobar-baz",job="job1234567" or instance="lkjlkjlkjlkjlkjlkjlkjlkjlkjlk",job="lkjljlkjalkadsfdsffdsfdsfd",
some_very_long_label="very_very_very_long_value_12397787_dfdfdfsds_dsffdfsf"}`,
`process_cpu_seconds_total{
instance="foobar-baz",job="job1234567"
or
instance="lkjlkjlkjlkjlkjlkjlkjlkjlkjlk",
job="lkjljlkjalkadsfdsffdsfdsfd",
some_very_long_label="very_very_very_long_value_12397787_dfdfdfsds_dsffdfsf"
}`)
// Verify that long binary operations are split into multiple lines
another(`(sum(rate(process_cpu_seconds_total{instance="foo",job="bar"}[5m] offset 1h @ start())) by (x) / on(x) group_right(y) prefix "x" sum(rate(node_cpu_seconds_total{mode!="idle"}[5m]) keep_metric_names)) keep_metric_names`,
`(
sum(
rate(
process_cpu_seconds_total{instance="foo",job="bar"}[5m] offset 1h @ start()
)
) by(x)
/ on(x) group_right(y) prefix "x"
sum(rate(node_cpu_seconds_total{mode!="idle"}[5m]) keep_metric_names)
) keep_metric_names`)
another(`(sum(rate({"3process_cpu_seconds_total", instance="foo",job="bar"}[5m] offset 1h @ start())) by (x) / on(x) group_right(y) prefix "x" sum(rate(node_cpu_seconds_total{mode!="idle"}[5m]) keep_metric_names)) keep_metric_names`,
`(
sum(
rate(
{"3process_cpu_seconds_total", instance="foo",job="bar"}[5m] offset 1h @ start()
)
) by(x)
/ on(x) group_right(y) prefix "x"
sum(rate(node_cpu_seconds_total{mode!="idle"}[5m]) keep_metric_names)
) keep_metric_names`)
another(`process_cpu_seconds_total{aaaaaaaaaaaaaaaaaa="bbbbbb"} offset 5m + (rate(xxxxxxxxxxxxxxxx{yyyyyyyy="aaaaaaa"}) keep_metric_names)`,
`(process_cpu_seconds_total{aaaaaaaaaaaaaaaaaa="bbbbbb"} offset 5m)
+
(rate(xxxxxxxxxxxxxxxx{yyyyyyyy="aaaaaaa"}) keep_metric_names)`)
another(`process_cpu_seconds_total{aaaaaaaaaaaaaaaaaa="bbbbbb",cccccccccccccccccccccc!~"ddddddddddddddddddddddd"} offset 5m + (rate(xxxxxxxxxxxxxxxx{yyyyyyyy="aaaaaaa"}) keep_metric_names)`,
`(
process_cpu_seconds_total{
aaaaaaaaaaaaaaaaaa="bbbbbb",
cccccccccccccccccccccc!~"ddddddddddddddddddddddd"
} offset 5m
)
+
(rate(xxxxxxxxxxxxxxxx{yyyyyyyy="aaaaaaa"}) keep_metric_names)`)
// Verify that long rollup expression is properly split into multiple lines
another(`process_cpu_seconds_total{foo="bar",aaaaaaaaaaaaaaaaaaaaaaaa="bbbbbbbbbbbbbbbbbbbb",c="dddddddddddd"}[5m:3s] offset 5h3m @ 12345`,
`process_cpu_seconds_total{
foo="bar",aaaaaaaaaaaaaaaaaaaaaaaa="bbbbbbbbbbbbbbbbbbbb",c="dddddddddddd"
}[5m:3s] offset 5h3m @ 12345`)
another(`process_cpu_seconds_total{foo="bar",aaaaaaaaaaaaaaaaaaaaaaaa="bbbbbbbbbbbbbbbbbbbb",ccccccccccccccc="dddddddddddd"}[5m:3s] offset 5h3m @ 12345`,
`process_cpu_seconds_total{
foo="bar",
aaaaaaaaaaaaaaaaaaaaaaaa="bbbbbbbbbbbbbbbbbbbb",
ccccccccccccccc="dddddddddddd"
}[5m:3s] offset 5h3m @ 12345`)
// Verify that aggregate expression is properly split into multiple lines
another(`sum without(x,y) (process_cpu_seconds_total{foo="bar",aaaaaaaaaaaaaaaaaaaaaaaa="bbbbbbbbbbbbbbbbbbbb",c="dddddddddddd"}[5m:3s] offset 5h3m @ 12345)`,
`sum(
process_cpu_seconds_total{
foo="bar",aaaaaaaaaaaaaaaaaaaaaaaa="bbbbbbbbbbbbbbbbbbbb",c="dddddddddddd"
}[5m:3s] offset 5h3m @ 12345
) without(x,y)`)
// Verify that an ordinary function args are split into multiple lines
another(`clamp_min(process_cpu_seconds_total{aaaaaaaaaaaaaaaaaaaaaaaaa="bbbb",cccccc="dddd",ppppppppppppppppppppppppp=~"xxxxxxx"}, 123, "456")`,
`clamp_min(
process_cpu_seconds_total{
aaaaaaaaaaaaaaaaaaaaaaaaa="bbbb",
cccccc="dddd",
ppppppppppppppppppppppppp=~"xxxxxxx"
},
123,
"456"
)`)
// Verify how prettifier works with very long string
same(`"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"`)
// Verify short WITH expressions
same(`WITH (x = {a="b"}) x`)
same(`WITH (x = {a="b"}) {x,y="z"}`)
same(`WITH (x = {a="b"}) {y="z",x}`)
same(`WITH (x = {a="b"}) x{y="z"}`)
same(`WITH (f(s) = {x="foo"+s+"bar"}) f("x")`)
same(`WITH (x = sum(rate({a="b"}[1m]))) x`)
// Verify long WITH expressions
another(`with (f(a)=foo{a,qw="ert"}, x = process_cpu_seconds_total{aaaaaaaaaaaaaaaaaaaaaaaaa="bbbb",cccccc="dddd",ppppppppppppppppppppppppp=~"xxxxxxx"}, y=f({ab="cde"}) + efg{h="j"}) x + sum(y)`,
`WITH (
f(a) = foo{a,qw="ert"},
x = (
process_cpu_seconds_total{
aaaaaaaaaaaaaaaaaaaaaaaaa="bbbb",
cccccc="dddd",
ppppppppppppppppppppppppp=~"xxxxxxx"
}
),
y = f({ab="cde"}) + efg{h="j"},
)
x + sum(y)`)
// Embedded WITH expressions
another(`with ( x = (a{b="c"}) + (with (q=we{rt="z"}) q)) ((abc) / x) + (with(rt=234+234) 2*rt+ poasdfklkjlkjfdsfjklfdfdsfdsfddfsfd)`,
`WITH (
x = a{b="c"} + WITH (q = we{rt="z"}) q,
)
(abc / x) + WITH (rt = 234 + 234) (2 * rt) + poasdfklkjlkjfdsfjklfdfdsfdsfddfsfd`)
// duration replacement in WITH expression
another(`WITH(BAR=1m,x(BAZ)=sum(rate({a="b"}[BAR:BAZ])) offset BAR) x`, `WITH (BAR = 1m, x(BAZ) = sum(rate({a="b"}[BAR:BAZ])) offset BAR) x`)
// function replacement in WITH expression
same(`WITH (f(x) = abc{x}, z = f({foo="bar"})) z`)
}
|
