1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
|
package rfc
/*
* ZLint Copyright 2024 Regents of the University of Michigan
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy
* of the License at http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
* implied. See the License for the specific language governing
* permissions and limitations under the License.
*/
import (
"github.com/zmap/zcrypto/x509"
"github.com/zmap/zlint/v3/lint"
"github.com/zmap/zlint/v3/util"
)
type utcNoSecond struct{}
/************************************************************************
4.1.2.5.1. UTCTime
The universal time type, UTCTime, is a standard ASN.1 type intended
for representation of dates and time. UTCTime specifies the year
through the two low-order digits and time is specified to the
precision of one minute or one second. UTCTime includes either Z
(for Zulu, or Greenwich Mean Time) or a time differential.
For the purposes of this profile, UTCTime values MUST be expressed in
Greenwich Mean Time (Zulu) and MUST include seconds (i.e., times are
YYMMDDHHMMSSZ), even where the number of seconds is zero. Conforming
systems MUST interpret the year field (YY) as follows:
Where YY is greater than or equal to 50, the year SHALL be
interpreted as 19YY; and
Where YY is less than 50, the year SHALL be interpreted as 20YY.
************************************************************************/
func init() {
lint.RegisterCertificateLint(&lint.CertificateLint{
LintMetadata: lint.LintMetadata{
Name: "e_utc_time_does_not_include_seconds",
Description: "UTCTime values MUST include seconds",
Citation: "RFC 5280: 4.1.2.5.1",
Source: lint.RFC5280,
EffectiveDate: util.RFC2459Date,
},
Lint: NewUtcNoSecond,
})
}
func NewUtcNoSecond() lint.LintInterface {
return &utcNoSecond{}
}
func (l *utcNoSecond) CheckApplies(c *x509.Certificate) bool {
firstDate, secondDate := util.GetTimes(c)
beforeTag, afterTag := util.FindTimeType(firstDate, secondDate)
date1Utc := beforeTag == 23
date2Utc := afterTag == 23
return date1Utc || date2Utc
}
func (l *utcNoSecond) Execute(c *x509.Certificate) *lint.LintResult {
date1, date2 := util.GetTimes(c)
beforeTag, afterTag := util.FindTimeType(date1, date2)
date1Utc := beforeTag == 23
date2Utc := afterTag == 23
if date1Utc {
if len(date1.Bytes) != 13 && len(date1.Bytes) != 17 {
return &lint.LintResult{Status: lint.Error}
}
}
if date2Utc {
if len(date2.Bytes) != 13 && len(date2.Bytes) != 17 {
return &lint.LintResult{Status: lint.Error}
}
}
return &lint.LintResult{Status: lint.Pass}
}
|
