1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327
|
// Copyright 2022 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package checker_test
import (
"flag"
"fmt"
"go/token"
"log"
"os"
"os/exec"
"path"
"regexp"
"runtime"
"strings"
"testing"
"golang.org/x/tools/go/analysis"
"golang.org/x/tools/go/analysis/analysistest"
"golang.org/x/tools/go/analysis/multichecker"
"golang.org/x/tools/internal/testenv"
)
// These are the analyzers available to the multichecker.
// (Tests may add more in init functions as needed.)
var candidates = map[string]*analysis.Analyzer{
renameAnalyzer.Name: renameAnalyzer,
otherAnalyzer.Name: otherAnalyzer,
}
func TestMain(m *testing.M) {
// If the ANALYZERS=a,..,z environment is set, then this
// process should behave like a multichecker with the
// named analyzers.
if s, ok := os.LookupEnv("ANALYZERS"); ok {
var analyzers []*analysis.Analyzer
for _, name := range strings.Split(s, ",") {
a := candidates[name]
if a == nil {
log.Fatalf("no such analyzer: %q", name)
}
analyzers = append(analyzers, a)
}
multichecker.Main(analyzers...)
panic("unreachable")
}
// ordinary test
flag.Parse()
os.Exit(m.Run())
}
const (
exitCodeSuccess = 0 // success (no diagnostics)
exitCodeFailed = 1 // analysis failed to run
exitCodeDiagnostics = 3 // diagnostics were reported
)
// fix runs a multichecker subprocess with -fix in the specified
// directory, applying the comma-separated list of named analyzers to
// the packages matching the patterns. It returns the CombinedOutput.
func fix(t *testing.T, dir, analyzers string, wantExit int, patterns ...string) string {
testenv.NeedsExec(t)
testenv.NeedsTool(t, "go")
cmd := exec.Command(os.Args[0], "-fix")
cmd.Args = append(cmd.Args, patterns...)
cmd.Env = append(os.Environ(),
"ANALYZERS="+analyzers,
"GOPATH="+dir,
"GO111MODULE=off",
"GOPROXY=off")
clean := func(s string) string {
return strings.ReplaceAll(s, os.TempDir(), "os.TempDir/")
}
outBytes, err := cmd.CombinedOutput()
out := clean(string(outBytes))
t.Logf("$ %s\n%s", clean(fmt.Sprint(cmd)), out)
if err, ok := err.(*exec.ExitError); !ok {
t.Fatalf("failed to execute multichecker: %v", err)
} else if err.ExitCode() != wantExit {
// plan9 ExitCode() currently only returns 0 for success or 1 for failure
if !(runtime.GOOS == "plan9" && wantExit != exitCodeSuccess && err.ExitCode() != exitCodeSuccess) {
t.Errorf("exit code was %d, want %d", err.ExitCode(), wantExit)
}
}
return out
}
// TestFixes ensures that checker.Run applies fixes correctly.
// This test fork/execs the main function above.
func TestFixes(t *testing.T) {
files := map[string]string{
"rename/foo.go": `package rename
func Foo() {
bar := 12
_ = bar
}
// the end
`,
"rename/intestfile_test.go": `package rename
func InTestFile() {
bar := 13
_ = bar
}
// the end
`,
"rename/foo_test.go": `package rename_test
func Foo() {
bar := 14
_ = bar
}
// the end
`,
"duplicate/dup.go": `package duplicate
func Foo() {
bar := 14
_ = bar
}
// the end
`,
}
fixed := map[string]string{
"rename/foo.go": `package rename
func Foo() {
baz := 12
_ = baz
}
// the end
`,
"rename/intestfile_test.go": `package rename
func InTestFile() {
baz := 13
_ = baz
}
// the end
`,
"rename/foo_test.go": `package rename_test
func Foo() {
baz := 14
_ = baz
}
// the end
`,
"duplicate/dup.go": `package duplicate
func Foo() {
baz := 14
_ = baz
}
// the end
`,
}
dir, cleanup, err := analysistest.WriteFiles(files)
if err != nil {
t.Fatalf("Creating test files failed with %s", err)
}
defer cleanup()
fix(t, dir, "rename,other", exitCodeDiagnostics, "rename", "duplicate")
for name, want := range fixed {
path := path.Join(dir, "src", name)
contents, err := os.ReadFile(path)
if err != nil {
t.Errorf("error reading %s: %v", path, err)
}
if got := string(contents); got != want {
t.Errorf("contents of %s file did not match expectations. got=%s, want=%s", path, got, want)
}
}
}
// TestConflict ensures that checker.Run detects conflicts correctly.
// This test fork/execs the main function above.
func TestConflict(t *testing.T) {
files := map[string]string{
"conflict/foo.go": `package conflict
func Foo() {
bar := 12
_ = bar
}
// the end
`,
}
dir, cleanup, err := analysistest.WriteFiles(files)
if err != nil {
t.Fatalf("Creating test files failed with %s", err)
}
defer cleanup()
out := fix(t, dir, "rename,other", exitCodeFailed, "conflict")
pattern := `conflicting edits from rename and rename on .*foo.go`
matched, err := regexp.MatchString(pattern, out)
if err != nil {
t.Errorf("error matching pattern %s: %v", pattern, err)
} else if !matched {
t.Errorf("output did not match pattern: %s", pattern)
}
// No files updated
for name, want := range files {
path := path.Join(dir, "src", name)
contents, err := os.ReadFile(path)
if err != nil {
t.Errorf("error reading %s: %v", path, err)
}
if got := string(contents); got != want {
t.Errorf("contents of %s file updated. got=%s, want=%s", path, got, want)
}
}
}
// TestOther ensures that checker.Run reports conflicts from
// distinct actions correctly.
// This test fork/execs the main function above.
func TestOther(t *testing.T) {
files := map[string]string{
"other/foo.go": `package other
func Foo() {
bar := 12
_ = bar
}
// the end
`,
}
dir, cleanup, err := analysistest.WriteFiles(files)
if err != nil {
t.Fatalf("Creating test files failed with %s", err)
}
defer cleanup()
out := fix(t, dir, "rename,other", exitCodeFailed, "other")
pattern := `.*conflicting edits from other and rename on .*foo.go`
matched, err := regexp.MatchString(pattern, out)
if err != nil {
t.Errorf("error matching pattern %s: %v", pattern, err)
} else if !matched {
t.Errorf("output did not match pattern: %s", pattern)
}
// No files updated
for name, want := range files {
path := path.Join(dir, "src", name)
contents, err := os.ReadFile(path)
if err != nil {
t.Errorf("error reading %s: %v", path, err)
}
if got := string(contents); got != want {
t.Errorf("contents of %s file updated. got=%s, want=%s", path, got, want)
}
}
}
// TestNoEnd tests that a missing SuggestedFix.End position is
// correctly interpreted as if equal to SuggestedFix.Pos (see issue #64199).
func TestNoEnd(t *testing.T) {
files := map[string]string{
"a/a.go": "package a\n\nfunc F() {}",
}
dir, cleanup, err := analysistest.WriteFiles(files)
if err != nil {
t.Fatalf("Creating test files failed with %s", err)
}
defer cleanup()
fix(t, dir, "noend", exitCodeDiagnostics, "a")
got, err := os.ReadFile(path.Join(dir, "src/a/a.go"))
if err != nil {
t.Fatal(err)
}
const want = "package a\n\n/*hello*/\nfunc F() {}\n"
if string(got) != want {
t.Errorf("new file contents were <<%s>>, want <<%s>>", got, want)
}
}
func init() {
candidates["noend"] = &analysis.Analyzer{
Name: "noend",
Doc: "inserts /*hello*/ before first decl",
Run: func(pass *analysis.Pass) (any, error) {
decl := pass.Files[0].Decls[0]
pass.Report(analysis.Diagnostic{
Pos: decl.Pos(),
End: token.NoPos,
Message: "say hello",
SuggestedFixes: []analysis.SuggestedFix{{
Message: "say hello",
TextEdits: []analysis.TextEdit{
{
Pos: decl.Pos(),
End: token.NoPos,
NewText: []byte("/*hello*/"),
},
},
}},
})
return nil, nil
},
}
}
|