1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
|
// Copyright 2018 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package unitchecker_test
import (
"flag"
"os"
"os/exec"
"regexp"
"runtime"
"strings"
"testing"
"golang.org/x/tools/go/analysis/passes/assign"
"golang.org/x/tools/go/analysis/passes/findcall"
"golang.org/x/tools/go/analysis/passes/printf"
"golang.org/x/tools/go/analysis/unitchecker"
"golang.org/x/tools/go/packages/packagestest"
)
func TestMain(m *testing.M) {
// child process?
switch os.Getenv("ENTRYPOINT") {
case "vet":
vet()
panic("unreachable")
case "minivet":
minivet()
panic("unreachable")
case "worker":
worker() // see ExampleSeparateAnalysis
panic("unreachable")
}
// test process
flag.Parse()
os.Exit(m.Run())
}
// minivet is a vet-like tool with a few analyzers, for testing.
func minivet() {
unitchecker.Main(
findcall.Analyzer,
printf.Analyzer,
assign.Analyzer,
)
}
// This is a very basic integration test of modular
// analysis with facts using unitchecker under "go vet".
// It fork/execs the main function above.
func TestIntegration(t *testing.T) { packagestest.TestAll(t, testIntegration) }
func testIntegration(t *testing.T, exporter packagestest.Exporter) {
if runtime.GOOS != "linux" && runtime.GOOS != "darwin" {
t.Skipf("skipping fork/exec test on this platform")
}
exported := packagestest.Export(t, exporter, []packagestest.Module{{
Name: "golang.org/fake",
Files: map[string]interface{}{
"a/a.go": `package a
func _() {
MyFunc123()
}
func MyFunc123() {}
`,
"b/b.go": `package b
import "golang.org/fake/a"
func _() {
a.MyFunc123()
MyFunc123()
}
func MyFunc123() {}
`,
"c/c.go": `package c
func _() {
i := 5
i = i
}
`,
}}})
defer exported.Cleanup()
const wantA = `# golang.org/fake/a
([/._\-a-zA-Z0-9]+[\\/]fake[\\/])?a/a.go:4:11: call of MyFunc123\(...\)
`
const wantB = `# golang.org/fake/b
([/._\-a-zA-Z0-9]+[\\/]fake[\\/])?b/b.go:6:13: call of MyFunc123\(...\)
([/._\-a-zA-Z0-9]+[\\/]fake[\\/])?b/b.go:7:11: call of MyFunc123\(...\)
`
const wantC = `# golang.org/fake/c
([/._\-a-zA-Z0-9]+[\\/]fake[\\/])?c/c.go:5:5: self-assignment of i to i
`
const wantAJSON = `# golang.org/fake/a
\{
"golang.org/fake/a": \{
"findcall": \[
\{
"posn": "([/._\-a-zA-Z0-9]+[\\/]fake[\\/])?a/a.go:4:11",
"message": "call of MyFunc123\(...\)",
"suggested_fixes": \[
\{
"message": "Add '_TEST_'",
"edits": \[
\{
"filename": "([/._\-a-zA-Z0-9]+[\\/]fake[\\/])?a/a.go",
"start": 32,
"end": 32,
"new": "_TEST_"
\}
\]
\}
\]
\}
\]
\}
\}
`
const wantCJSON = `# golang.org/fake/c
\{
"golang.org/fake/c": \{
"assign": \[
\{
"posn": "([/._\-a-zA-Z0-9]+[\\/]fake[\\/])?c/c.go:5:5",
"message": "self-assignment of i to i",
"suggested_fixes": \[
\{
"message": "Remove",
"edits": \[
\{
"filename": "([/._\-a-zA-Z0-9]+[\\/]fake[\\/])?c/c.go",
"start": 37,
"end": 42,
"new": ""
\}
\]
\}
\]
\}
\]
\}
\}
`
for _, test := range []struct {
args string
wantOut string
wantExitError bool
}{
{args: "golang.org/fake/a", wantOut: wantA, wantExitError: true},
{args: "golang.org/fake/b", wantOut: wantB, wantExitError: true},
{args: "golang.org/fake/c", wantOut: wantC, wantExitError: true},
{args: "golang.org/fake/a golang.org/fake/b", wantOut: wantA + wantB, wantExitError: true},
{args: "-json golang.org/fake/a", wantOut: wantAJSON, wantExitError: false},
{args: "-json golang.org/fake/c", wantOut: wantCJSON, wantExitError: false},
{args: "-c=0 golang.org/fake/a", wantOut: wantA + "4 MyFunc123\\(\\)\n", wantExitError: true},
} {
cmd := exec.Command("go", "vet", "-vettool="+os.Args[0], "-findcall.name=MyFunc123")
cmd.Args = append(cmd.Args, strings.Fields(test.args)...)
cmd.Env = append(exported.Config.Env, "ENTRYPOINT=minivet")
cmd.Dir = exported.Config.Dir
// TODO(golang/go#65729): this is unsound: any extra
// logging by the child process (e.g. due to GODEBUG
// options) will add noise to stderr, causing the
// CombinedOutput to be unparseable as JSON. But we
// can't simply use Output here as some of the tests
// look for substrings of stderr. Rework the test to
// be specific about which output stream to match.
out, err := cmd.CombinedOutput()
exitcode := 0
if exitErr, ok := err.(*exec.ExitError); ok {
exitcode = exitErr.ExitCode()
}
if (exitcode != 0) != test.wantExitError {
want := "zero"
if test.wantExitError {
want = "nonzero"
}
t.Errorf("%s: got exit code %d, want %s", test.args, exitcode, want)
}
matched, err := regexp.Match(test.wantOut, out)
if err != nil {
t.Fatalf("regexp.Match(<<%s>>): %v", test.wantOut, err)
}
if !matched {
t.Errorf("%s: got <<%s>>, want match of regexp <<%s>>", test.args, out, test.wantOut)
}
}
}
|
