1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315
|
// Copyright 2020 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Package unusedvariable defines an analyzer that checks for unused variables.
package unusedvariable
import (
"bytes"
"fmt"
"go/ast"
"go/format"
"go/token"
"go/types"
"regexp"
"strings"
"golang.org/x/tools/go/analysis"
"golang.org/x/tools/go/ast/astutil"
)
const Doc = `check for unused variables and suggest fixes`
var Analyzer = &analysis.Analyzer{
Name: "unusedvariable",
Doc: Doc,
Requires: []*analysis.Analyzer{},
Run: run,
RunDespiteErrors: true, // an unusedvariable diagnostic is a compile error
URL: "https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/unusedvariable",
}
// The suffix for this error message changed in Go 1.20 and Go 1.23.
var unusedVariableRegexp = []*regexp.Regexp{
regexp.MustCompile("^(.*) declared but not used$"),
regexp.MustCompile("^(.*) declared and not used$"), // Go 1.20+
regexp.MustCompile("^declared and not used: (.*)$"), // Go 1.23+
}
func run(pass *analysis.Pass) (interface{}, error) {
for _, typeErr := range pass.TypeErrors {
for _, re := range unusedVariableRegexp {
match := re.FindStringSubmatch(typeErr.Msg)
if len(match) > 0 {
varName := match[1]
// Beginning in Go 1.23, go/types began quoting vars as `v'.
varName = strings.Trim(varName, "'`'")
err := runForError(pass, typeErr, varName)
if err != nil {
return nil, err
}
}
}
}
return nil, nil
}
func runForError(pass *analysis.Pass, err types.Error, name string) error {
var file *ast.File
for _, f := range pass.Files {
if f.Pos() <= err.Pos && err.Pos < f.End() {
file = f
break
}
}
if file == nil {
return nil
}
path, _ := astutil.PathEnclosingInterval(file, err.Pos, err.Pos)
if len(path) < 2 {
return nil
}
ident, ok := path[0].(*ast.Ident)
if !ok || ident.Name != name {
return nil
}
diag := analysis.Diagnostic{
Pos: ident.Pos(),
End: ident.End(),
Message: err.Msg,
}
for i := range path {
switch stmt := path[i].(type) {
case *ast.ValueSpec:
// Find GenDecl to which offending ValueSpec belongs.
if decl, ok := path[i+1].(*ast.GenDecl); ok {
fixes := removeVariableFromSpec(pass, path, stmt, decl, ident)
// fixes may be nil
if len(fixes) > 0 {
diag.SuggestedFixes = fixes
pass.Report(diag)
}
}
case *ast.AssignStmt:
if stmt.Tok != token.DEFINE {
continue
}
containsIdent := false
for _, expr := range stmt.Lhs {
if expr == ident {
containsIdent = true
}
}
if !containsIdent {
continue
}
fixes := removeVariableFromAssignment(path, stmt, ident)
// fixes may be nil
if len(fixes) > 0 {
diag.SuggestedFixes = fixes
pass.Report(diag)
}
}
}
return nil
}
func removeVariableFromSpec(pass *analysis.Pass, path []ast.Node, stmt *ast.ValueSpec, decl *ast.GenDecl, ident *ast.Ident) []analysis.SuggestedFix {
newDecl := new(ast.GenDecl)
*newDecl = *decl
newDecl.Specs = nil
for _, spec := range decl.Specs {
if spec != stmt {
newDecl.Specs = append(newDecl.Specs, spec)
continue
}
newSpec := new(ast.ValueSpec)
*newSpec = *stmt
newSpec.Names = nil
for _, n := range stmt.Names {
if n != ident {
newSpec.Names = append(newSpec.Names, n)
}
}
if len(newSpec.Names) > 0 {
newDecl.Specs = append(newDecl.Specs, newSpec)
}
}
// decl.End() does not include any comments, so if a comment is present we
// need to account for it when we delete the statement
end := decl.End()
if stmt.Comment != nil && stmt.Comment.End() > end {
end = stmt.Comment.End()
}
// There are no other specs left in the declaration, the whole statement can
// be deleted
if len(newDecl.Specs) == 0 {
// Find parent DeclStmt and delete it
for _, node := range path {
if declStmt, ok := node.(*ast.DeclStmt); ok {
edits := deleteStmtFromBlock(path, declStmt)
if len(edits) == 0 {
return nil // can this happen?
}
return []analysis.SuggestedFix{
{
Message: suggestedFixMessage(ident.Name),
TextEdits: edits,
},
}
}
}
}
var b bytes.Buffer
if err := format.Node(&b, pass.Fset, newDecl); err != nil {
return nil
}
return []analysis.SuggestedFix{
{
Message: suggestedFixMessage(ident.Name),
TextEdits: []analysis.TextEdit{
{
Pos: decl.Pos(),
// Avoid adding a new empty line
End: end + 1,
NewText: b.Bytes(),
},
},
},
}
}
func removeVariableFromAssignment(path []ast.Node, stmt *ast.AssignStmt, ident *ast.Ident) []analysis.SuggestedFix {
// The only variable in the assignment is unused
if len(stmt.Lhs) == 1 {
// If LHS has only one expression to be valid it has to have 1 expression
// on RHS
//
// RHS may have side effects, preserve RHS
if exprMayHaveSideEffects(stmt.Rhs[0]) {
// Delete until RHS
return []analysis.SuggestedFix{
{
Message: suggestedFixMessage(ident.Name),
TextEdits: []analysis.TextEdit{
{
Pos: ident.Pos(),
End: stmt.Rhs[0].Pos(),
},
},
},
}
}
// RHS does not have any side effects, delete the whole statement
edits := deleteStmtFromBlock(path, stmt)
if len(edits) == 0 {
return nil // can this happen?
}
return []analysis.SuggestedFix{
{
Message: suggestedFixMessage(ident.Name),
TextEdits: edits,
},
}
}
// Otherwise replace ident with `_`
return []analysis.SuggestedFix{
{
Message: suggestedFixMessage(ident.Name),
TextEdits: []analysis.TextEdit{
{
Pos: ident.Pos(),
End: ident.End(),
NewText: []byte("_"),
},
},
},
}
}
func suggestedFixMessage(name string) string {
return fmt.Sprintf("Remove variable %s", name)
}
func deleteStmtFromBlock(path []ast.Node, stmt ast.Stmt) []analysis.TextEdit {
// Find innermost enclosing BlockStmt.
var block *ast.BlockStmt
for i := range path {
if blockStmt, ok := path[i].(*ast.BlockStmt); ok {
block = blockStmt
break
}
}
nodeIndex := -1
for i, blockStmt := range block.List {
if blockStmt == stmt {
nodeIndex = i
break
}
}
// The statement we need to delete was not found in BlockStmt
if nodeIndex == -1 {
return nil
}
// Delete until the end of the block unless there is another statement after
// the one we are trying to delete
end := block.Rbrace
if nodeIndex < len(block.List)-1 {
end = block.List[nodeIndex+1].Pos()
}
return []analysis.TextEdit{
{
Pos: stmt.Pos(),
End: end,
},
}
}
// exprMayHaveSideEffects reports whether the expression may have side effects
// (because it contains a function call or channel receive). We disregard
// runtime panics as well written programs should not encounter them.
func exprMayHaveSideEffects(expr ast.Expr) bool {
var mayHaveSideEffects bool
ast.Inspect(expr, func(n ast.Node) bool {
switch n := n.(type) {
case *ast.CallExpr: // possible function call
mayHaveSideEffects = true
return false
case *ast.UnaryExpr:
if n.Op == token.ARROW { // channel receive
mayHaveSideEffects = true
return false
}
case *ast.FuncLit:
return false // evaluating what's inside a FuncLit has no effect
}
return true
})
return mayHaveSideEffects
}
|