1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519
|
// Copyright 2019 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package cache
// This file defines routines to convert diagnostics from go list, go
// get, go/packages, parsing, type checking, and analysis into
// golang.Diagnostic form, and suggesting quick fixes.
import (
"context"
"fmt"
"go/parser"
"go/scanner"
"go/token"
"log"
"path/filepath"
"regexp"
"strconv"
"strings"
"golang.org/x/tools/go/packages"
"golang.org/x/tools/gopls/internal/cache/metadata"
"golang.org/x/tools/gopls/internal/cache/parsego"
"golang.org/x/tools/gopls/internal/file"
"golang.org/x/tools/gopls/internal/protocol"
"golang.org/x/tools/gopls/internal/protocol/command"
"golang.org/x/tools/gopls/internal/settings"
"golang.org/x/tools/gopls/internal/util/bug"
"golang.org/x/tools/internal/typesinternal"
)
// goPackagesErrorDiagnostics translates the given go/packages Error into a
// diagnostic, using the provided metadata and filesource.
//
// The slice of diagnostics may be empty.
func goPackagesErrorDiagnostics(ctx context.Context, e packages.Error, mp *metadata.Package, fs file.Source) ([]*Diagnostic, error) {
if diag, err := parseGoListImportCycleError(ctx, e, mp, fs); err != nil {
return nil, err
} else if diag != nil {
return []*Diagnostic{diag}, nil
}
// Parse error location and attempt to convert to protocol form.
loc, err := func() (protocol.Location, error) {
filename, line, col8 := parseGoListError(e, mp.LoadDir)
uri := protocol.URIFromPath(filename)
fh, err := fs.ReadFile(ctx, uri)
if err != nil {
return protocol.Location{}, err
}
content, err := fh.Content()
if err != nil {
return protocol.Location{}, err
}
mapper := protocol.NewMapper(uri, content)
posn, err := mapper.LineCol8Position(line, col8)
if err != nil {
return protocol.Location{}, err
}
return protocol.Location{
URI: uri,
Range: protocol.Range{
Start: posn,
End: posn,
},
}, nil
}()
// TODO(rfindley): in some cases the go command outputs invalid spans, for
// example (from TestGoListErrors):
//
// package a
// import
//
// In this case, the go command will complain about a.go:2:8, which is after
// the trailing newline but still considered to be on the second line, most
// likely because *token.File lacks information about newline termination.
//
// We could do better here by handling that case.
if err != nil {
// Unable to parse a valid position.
// Apply the error to all files to be safe.
var diags []*Diagnostic
for _, uri := range mp.CompiledGoFiles {
diags = append(diags, &Diagnostic{
URI: uri,
Severity: protocol.SeverityError,
Source: ListError,
Message: e.Msg,
})
}
return diags, nil
}
return []*Diagnostic{{
URI: loc.URI,
Range: loc.Range,
Severity: protocol.SeverityError,
Source: ListError,
Message: e.Msg,
}}, nil
}
func parseErrorDiagnostics(pkg *syntaxPackage, errList scanner.ErrorList) ([]*Diagnostic, error) {
// The first parser error is likely the root cause of the problem.
if errList.Len() <= 0 {
return nil, fmt.Errorf("no errors in %v", errList)
}
e := errList[0]
pgf, err := pkg.File(protocol.URIFromPath(e.Pos.Filename))
if err != nil {
return nil, err
}
rng, err := pgf.Mapper.OffsetRange(e.Pos.Offset, e.Pos.Offset)
if err != nil {
return nil, err
}
return []*Diagnostic{{
URI: pgf.URI,
Range: rng,
Severity: protocol.SeverityError,
Source: ParseError,
Message: e.Msg,
}}, nil
}
var importErrorRe = regexp.MustCompile(`could not import ([^\s]+)`)
var unsupportedFeatureRe = regexp.MustCompile(`.*require.* go(\d+\.\d+) or later`)
func goGetQuickFixes(haveModule bool, uri protocol.DocumentURI, pkg string) []SuggestedFix {
// Go get only supports module mode for now.
if !haveModule {
return nil
}
title := fmt.Sprintf("go get package %v", pkg)
cmd, err := command.NewGoGetPackageCommand(title, command.GoGetPackageArgs{
URI: uri,
AddRequire: true,
Pkg: pkg,
})
if err != nil {
bug.Reportf("internal error building 'go get package' fix: %v", err)
return nil
}
return []SuggestedFix{SuggestedFixFromCommand(cmd, protocol.QuickFix)}
}
func editGoDirectiveQuickFix(haveModule bool, uri protocol.DocumentURI, version string) []SuggestedFix {
// Go mod edit only supports module mode.
if !haveModule {
return nil
}
title := fmt.Sprintf("go mod edit -go=%s", version)
cmd, err := command.NewEditGoDirectiveCommand(title, command.EditGoDirectiveArgs{
URI: uri,
Version: version,
})
if err != nil {
bug.Reportf("internal error constructing 'edit go directive' fix: %v", err)
return nil
}
return []SuggestedFix{SuggestedFixFromCommand(cmd, protocol.QuickFix)}
}
// encodeDiagnostics gob-encodes the given diagnostics.
func encodeDiagnostics(srcDiags []*Diagnostic) []byte {
var gobDiags []gobDiagnostic
for _, srcDiag := range srcDiags {
var gobFixes []gobSuggestedFix
for _, srcFix := range srcDiag.SuggestedFixes {
gobFix := gobSuggestedFix{
Message: srcFix.Title,
ActionKind: srcFix.ActionKind,
}
for uri, srcEdits := range srcFix.Edits {
for _, srcEdit := range srcEdits {
gobFix.TextEdits = append(gobFix.TextEdits, gobTextEdit{
Location: protocol.Location{
URI: uri,
Range: srcEdit.Range,
},
NewText: []byte(srcEdit.NewText),
})
}
}
if srcCmd := srcFix.Command; srcCmd != nil {
gobFix.Command = &gobCommand{
Title: srcCmd.Title,
Command: srcCmd.Command,
Arguments: srcCmd.Arguments,
}
}
gobFixes = append(gobFixes, gobFix)
}
var gobRelated []gobRelatedInformation
for _, srcRel := range srcDiag.Related {
gobRel := gobRelatedInformation(srcRel)
gobRelated = append(gobRelated, gobRel)
}
gobDiag := gobDiagnostic{
Location: protocol.Location{
URI: srcDiag.URI,
Range: srcDiag.Range,
},
Severity: srcDiag.Severity,
Code: srcDiag.Code,
CodeHref: srcDiag.CodeHref,
Source: string(srcDiag.Source),
Message: srcDiag.Message,
SuggestedFixes: gobFixes,
Related: gobRelated,
Tags: srcDiag.Tags,
}
gobDiags = append(gobDiags, gobDiag)
}
return diagnosticsCodec.Encode(gobDiags)
}
// decodeDiagnostics decodes the given gob-encoded diagnostics.
func decodeDiagnostics(data []byte) []*Diagnostic {
var gobDiags []gobDiagnostic
diagnosticsCodec.Decode(data, &gobDiags)
var srcDiags []*Diagnostic
for _, gobDiag := range gobDiags {
var srcFixes []SuggestedFix
for _, gobFix := range gobDiag.SuggestedFixes {
srcFix := SuggestedFix{
Title: gobFix.Message,
ActionKind: gobFix.ActionKind,
}
for _, gobEdit := range gobFix.TextEdits {
if srcFix.Edits == nil {
srcFix.Edits = make(map[protocol.DocumentURI][]protocol.TextEdit)
}
srcEdit := protocol.TextEdit{
Range: gobEdit.Location.Range,
NewText: string(gobEdit.NewText),
}
uri := gobEdit.Location.URI
srcFix.Edits[uri] = append(srcFix.Edits[uri], srcEdit)
}
if gobCmd := gobFix.Command; gobCmd != nil {
srcFix.Command = &protocol.Command{
Title: gobCmd.Title,
Command: gobCmd.Command,
Arguments: gobCmd.Arguments,
}
}
srcFixes = append(srcFixes, srcFix)
}
var srcRelated []protocol.DiagnosticRelatedInformation
for _, gobRel := range gobDiag.Related {
srcRel := protocol.DiagnosticRelatedInformation(gobRel)
srcRelated = append(srcRelated, srcRel)
}
srcDiag := &Diagnostic{
URI: gobDiag.Location.URI,
Range: gobDiag.Location.Range,
Severity: gobDiag.Severity,
Code: gobDiag.Code,
CodeHref: gobDiag.CodeHref,
Source: DiagnosticSource(gobDiag.Source),
Message: gobDiag.Message,
Tags: gobDiag.Tags,
Related: srcRelated,
SuggestedFixes: srcFixes,
}
srcDiags = append(srcDiags, srcDiag)
}
return srcDiags
}
// toSourceDiagnostic converts a gobDiagnostic to "source" form.
func toSourceDiagnostic(srcAnalyzer *settings.Analyzer, gobDiag *gobDiagnostic) *Diagnostic {
var related []protocol.DiagnosticRelatedInformation
for _, gobRelated := range gobDiag.Related {
related = append(related, protocol.DiagnosticRelatedInformation(gobRelated))
}
severity := srcAnalyzer.Severity()
if severity == 0 {
severity = protocol.SeverityWarning
}
diag := &Diagnostic{
URI: gobDiag.Location.URI,
Range: gobDiag.Location.Range,
Severity: severity,
Code: gobDiag.Code,
CodeHref: gobDiag.CodeHref,
Source: DiagnosticSource(gobDiag.Source),
Message: gobDiag.Message,
Related: related,
Tags: srcAnalyzer.Tags(),
}
// We cross the set of fixes (whether edit- or command-based)
// with the set of kinds, as a single fix may represent more
// than one kind of action (e.g. refactor, quickfix, fixall),
// each corresponding to a distinct client UI element
// or operation.
kinds := srcAnalyzer.ActionKinds()
if len(kinds) == 0 {
kinds = []protocol.CodeActionKind{protocol.QuickFix}
}
var fixes []SuggestedFix
for _, fix := range gobDiag.SuggestedFixes {
if len(fix.TextEdits) > 0 {
// Accumulate edit-based fixes supplied by the diagnostic itself.
edits := make(map[protocol.DocumentURI][]protocol.TextEdit)
for _, e := range fix.TextEdits {
uri := e.Location.URI
edits[uri] = append(edits[uri], protocol.TextEdit{
Range: e.Location.Range,
NewText: string(e.NewText),
})
}
for _, kind := range kinds {
fixes = append(fixes, SuggestedFix{
Title: fix.Message,
Edits: edits,
ActionKind: kind,
})
}
} else {
// Accumulate command-based fixes, whose edits
// are not provided by the analyzer but are computed on demand
// by logic "adjacent to" the analyzer.
//
// The analysis.Diagnostic.Category is used as the fix name.
cmd, err := command.NewApplyFixCommand(fix.Message, command.ApplyFixArgs{
Fix: diag.Code,
URI: gobDiag.Location.URI,
Range: gobDiag.Location.Range,
})
if err != nil {
// JSON marshalling of these argument values cannot fail.
log.Fatalf("internal error in NewApplyFixCommand: %v", err)
}
for _, kind := range kinds {
fixes = append(fixes, SuggestedFixFromCommand(cmd, kind))
}
// Ensure that the analyzer specifies a category for all its no-edit fixes.
// This is asserted by analysistest.RunWithSuggestedFixes, but there
// may be gaps in test coverage.
if diag.Code == "" || diag.Code == "default" {
bug.Reportf("missing Diagnostic.Code: %#v", *diag)
}
}
}
diag.SuggestedFixes = fixes
// If the fixes only delete code, assume that the diagnostic is reporting dead code.
if onlyDeletions(diag.SuggestedFixes) {
diag.Tags = append(diag.Tags, protocol.Unnecessary)
}
return diag
}
// onlyDeletions returns true if fixes is non-empty and all of the suggested
// fixes are deletions.
func onlyDeletions(fixes []SuggestedFix) bool {
for _, fix := range fixes {
if fix.Command != nil {
return false
}
for _, edits := range fix.Edits {
for _, edit := range edits {
if edit.NewText != "" {
return false
}
if protocol.ComparePosition(edit.Range.Start, edit.Range.End) == 0 {
return false
}
}
}
}
return len(fixes) > 0
}
func typesCodeHref(linkTarget string, code typesinternal.ErrorCode) string {
return BuildLink(linkTarget, "golang.org/x/tools/internal/typesinternal", code.String())
}
// BuildLink constructs a URL with the given target, path, and anchor.
func BuildLink(target, path, anchor string) protocol.URI {
link := fmt.Sprintf("https://%s/%s", target, path)
if anchor == "" {
return link
}
return link + "#" + anchor
}
func parseGoListError(e packages.Error, dir string) (filename string, line, col8 int) {
input := e.Pos
if input == "" {
// No position. Attempt to parse one out of a
// go list error of the form "file:line:col:
// message" by stripping off the message.
input = strings.TrimSpace(e.Msg)
if i := strings.Index(input, ": "); i >= 0 {
input = input[:i]
}
}
filename, line, col8 = splitFileLineCol(input)
if !filepath.IsAbs(filename) {
filename = filepath.Join(dir, filename)
}
return filename, line, col8
}
// splitFileLineCol splits s into "filename:line:col",
// where line and col consist of decimal digits.
func splitFileLineCol(s string) (file string, line, col8 int) {
// Beware that the filename may contain colon on Windows.
// stripColonDigits removes a ":%d" suffix, if any.
stripColonDigits := func(s string) (rest string, num int) {
if i := strings.LastIndex(s, ":"); i >= 0 {
if v, err := strconv.ParseInt(s[i+1:], 10, 32); err == nil {
return s[:i], int(v)
}
}
return s, -1
}
// strip col ":%d"
s, n1 := stripColonDigits(s)
if n1 < 0 {
return s, 1, 1 // "filename"
}
// strip line ":%d"
s, n2 := stripColonDigits(s)
if n2 < 0 {
return s, n1, 1 // "filename:line"
}
return s, n2, n1 // "filename:line:col"
}
// parseGoListImportCycleError attempts to parse the given go/packages error as
// an import cycle, returning a diagnostic if successful.
//
// If the error is not detected as an import cycle error, it returns nil, nil.
func parseGoListImportCycleError(ctx context.Context, e packages.Error, mp *metadata.Package, fs file.Source) (*Diagnostic, error) {
re := regexp.MustCompile(`(.*): import stack: \[(.+)\]`)
matches := re.FindStringSubmatch(strings.TrimSpace(e.Msg))
if len(matches) < 3 {
return nil, nil
}
msg := matches[1]
importList := strings.Split(matches[2], " ")
// Since the error is relative to the current package. The import that is causing
// the import cycle error is the second one in the list.
if len(importList) < 2 {
return nil, nil
}
// Imports have quotation marks around them.
circImp := strconv.Quote(importList[1])
for _, uri := range mp.CompiledGoFiles {
pgf, err := parseGoURI(ctx, fs, uri, parsego.Header)
if err != nil {
return nil, err
}
// Search file imports for the import that is causing the import cycle.
for _, imp := range pgf.File.Imports {
if imp.Path.Value == circImp {
rng, err := pgf.NodeMappedRange(imp)
if err != nil {
return nil, nil
}
return &Diagnostic{
URI: pgf.URI,
Range: rng.Range(),
Severity: protocol.SeverityError,
Source: ListError,
Message: msg,
}, nil
}
}
}
return nil, nil
}
// parseGoURI is a helper to parse the Go file at the given URI from the file
// source fs. The resulting syntax and token.File belong to an ephemeral,
// encapsulated FileSet, so this file stands only on its own: it's not suitable
// to use in a list of file of a package, for example.
//
// It returns an error if the file could not be read.
//
// TODO(rfindley): eliminate this helper.
func parseGoURI(ctx context.Context, fs file.Source, uri protocol.DocumentURI, mode parser.Mode) (*parsego.File, error) {
fh, err := fs.ReadFile(ctx, uri)
if err != nil {
return nil, err
}
return parseGoImpl(ctx, token.NewFileSet(), fh, mode, false)
}
// parseModURI is a helper to parse the Mod file at the given URI from the file
// source fs.
//
// It returns an error if the file could not be read.
func parseModURI(ctx context.Context, fs file.Source, uri protocol.DocumentURI) (*ParsedModule, error) {
fh, err := fs.ReadFile(ctx, uri)
if err != nil {
return nil, err
}
return parseModImpl(ctx, fh)
}
|