1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302
|
// Copyright 2024 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package golang
// This file defines the code action "Extract declarations to new file".
import (
"bytes"
"context"
"errors"
"fmt"
"go/ast"
"go/format"
"go/token"
"go/types"
"os"
"path/filepath"
"strings"
"golang.org/x/tools/gopls/internal/cache"
"golang.org/x/tools/gopls/internal/cache/parsego"
"golang.org/x/tools/gopls/internal/file"
"golang.org/x/tools/gopls/internal/protocol"
"golang.org/x/tools/gopls/internal/util/bug"
"golang.org/x/tools/gopls/internal/util/safetoken"
"golang.org/x/tools/gopls/internal/util/typesutil"
)
// canExtractToNewFile reports whether the code in the given range can be extracted to a new file.
func canExtractToNewFile(pgf *parsego.File, start, end token.Pos) bool {
_, _, _, ok := selectedToplevelDecls(pgf, start, end)
return ok
}
// findImportEdits finds imports specs that needs to be added to the new file
// or deleted from the old file if the range is extracted to a new file.
//
// TODO: handle dot imports.
func findImportEdits(file *ast.File, info *types.Info, start, end token.Pos) (adds, deletes []*ast.ImportSpec, _ error) {
// make a map from a pkgName to its references
pkgNameReferences := make(map[*types.PkgName][]*ast.Ident)
for ident, use := range info.Uses {
if pkgName, ok := use.(*types.PkgName); ok {
pkgNameReferences[pkgName] = append(pkgNameReferences[pkgName], ident)
}
}
// PkgName referenced in the extracted selection must be
// imported in the new file.
// PkgName only referenced in the extracted selection must be
// deleted from the original file.
for _, spec := range file.Imports {
if spec.Name != nil && spec.Name.Name == "." {
// TODO: support dot imports.
return nil, nil, errors.New("\"extract to new file\" does not support files containing dot imports")
}
pkgName, ok := typesutil.ImportedPkgName(info, spec)
if !ok {
continue
}
usedInSelection := false
usedInNonSelection := false
for _, ident := range pkgNameReferences[pkgName] {
if posRangeContains(start, end, ident.Pos(), ident.End()) {
usedInSelection = true
} else {
usedInNonSelection = true
}
}
if usedInSelection {
adds = append(adds, spec)
}
if usedInSelection && !usedInNonSelection {
deletes = append(deletes, spec)
}
}
return adds, deletes, nil
}
// ExtractToNewFile moves selected declarations into a new file.
func ExtractToNewFile(ctx context.Context, snapshot *cache.Snapshot, fh file.Handle, rng protocol.Range) (*protocol.WorkspaceEdit, error) {
errorPrefix := "ExtractToNewFile"
pkg, pgf, err := NarrowestPackageForFile(ctx, snapshot, fh.URI())
if err != nil {
return nil, err
}
start, end, err := pgf.RangePos(rng)
if err != nil {
return nil, fmt.Errorf("%s: %w", errorPrefix, err)
}
start, end, firstSymbol, ok := selectedToplevelDecls(pgf, start, end)
if !ok {
return nil, bug.Errorf("invalid selection")
}
// select trailing empty lines
offset, err := safetoken.Offset(pgf.Tok, end)
if err != nil {
return nil, err
}
rest := pgf.Src[offset:]
end += token.Pos(len(rest) - len(bytes.TrimLeft(rest, " \t\n")))
replaceRange, err := pgf.PosRange(start, end)
if err != nil {
return nil, bug.Errorf("invalid range: %v", err)
}
adds, deletes, err := findImportEdits(pgf.File, pkg.TypesInfo(), start, end)
if err != nil {
return nil, err
}
var importDeletes []protocol.TextEdit
// For unparenthesised declarations like `import "fmt"` we remove
// the whole declaration because simply removing importSpec leaves
// `import \n`, which does not compile.
// For parenthesised declarations like `import ("fmt"\n "log")`
// we only remove the ImportSpec, because removing the whole declaration
// might remove other ImportsSpecs we don't want to touch.
unparenthesizedImports := unparenthesizedImports(pgf)
for _, importSpec := range deletes {
if decl := unparenthesizedImports[importSpec]; decl != nil {
importDeletes = append(importDeletes, removeNode(pgf, decl))
} else {
importDeletes = append(importDeletes, removeNode(pgf, importSpec))
}
}
var buf bytes.Buffer
fmt.Fprintf(&buf, "package %s\n", pgf.File.Name.Name)
if len(adds) > 0 {
buf.WriteString("import (")
for _, importSpec := range adds {
if importSpec.Name != nil {
fmt.Fprintf(&buf, "%s %s\n", importSpec.Name.Name, importSpec.Path.Value)
} else {
fmt.Fprintf(&buf, "%s\n", importSpec.Path.Value)
}
}
buf.WriteString(")\n")
}
newFile, err := chooseNewFile(ctx, snapshot, pgf.URI.Dir().Path(), firstSymbol)
if err != nil {
return nil, fmt.Errorf("%s: %w", errorPrefix, err)
}
fileStart := pgf.Tok.Pos(0) // TODO(adonovan): use go1.20 pgf.File.FileStart
buf.Write(pgf.Src[start-fileStart : end-fileStart])
// TODO: attempt to duplicate the copyright header, if any.
newFileContent, err := format.Source(buf.Bytes())
if err != nil {
return nil, err
}
return protocol.NewWorkspaceEdit(
// edit the original file
protocol.DocumentChangeEdit(fh, append(importDeletes, protocol.TextEdit{Range: replaceRange, NewText: ""})),
// create a new file
protocol.DocumentChangeCreate(newFile.URI()),
// edit the created file
protocol.DocumentChangeEdit(newFile, []protocol.TextEdit{
{Range: protocol.Range{}, NewText: string(newFileContent)},
})), nil
}
// chooseNewFile chooses a new filename in dir, based on the name of the
// first extracted symbol, and if necessary to disambiguate, a numeric suffix.
func chooseNewFile(ctx context.Context, snapshot *cache.Snapshot, dir string, firstSymbol string) (file.Handle, error) {
basename := strings.ToLower(firstSymbol)
newPath := protocol.URIFromPath(filepath.Join(dir, basename+".go"))
for count := 1; count < 5; count++ {
fh, err := snapshot.ReadFile(ctx, newPath)
if err != nil {
return nil, err // canceled
}
if _, err := fh.Content(); errors.Is(err, os.ErrNotExist) {
return fh, nil
}
filename := fmt.Sprintf("%s.%d.go", basename, count)
newPath = protocol.URIFromPath(filepath.Join(dir, filename))
}
return nil, fmt.Errorf("chooseNewFileURI: exceeded retry limit")
}
// selectedToplevelDecls returns the lexical extent of the top-level
// declarations enclosed by [start, end), along with the name of the
// first declaration. The returned boolean reports whether the selection
// should be offered a code action to extract the declarations.
func selectedToplevelDecls(pgf *parsego.File, start, end token.Pos) (token.Pos, token.Pos, string, bool) {
// selection cannot intersect a package declaration
if posRangeIntersects(start, end, pgf.File.Package, pgf.File.Name.End()) {
return 0, 0, "", false
}
firstName := ""
for _, decl := range pgf.File.Decls {
if posRangeIntersects(start, end, decl.Pos(), decl.End()) {
var id *ast.Ident
switch v := decl.(type) {
case *ast.BadDecl:
return 0, 0, "", false
case *ast.FuncDecl:
// if only selecting keyword "func" or function name, extend selection to the
// whole function
if posRangeContains(v.Pos(), v.Name.End(), start, end) {
start, end = v.Pos(), v.End()
}
id = v.Name
case *ast.GenDecl:
// selection cannot intersect an import declaration
if v.Tok == token.IMPORT {
return 0, 0, "", false
}
// if only selecting keyword "type", "const", or "var", extend selection to the
// whole declaration
if v.Tok == token.TYPE && posRangeContains(v.Pos(), v.Pos()+token.Pos(len("type")), start, end) ||
v.Tok == token.CONST && posRangeContains(v.Pos(), v.Pos()+token.Pos(len("const")), start, end) ||
v.Tok == token.VAR && posRangeContains(v.Pos(), v.Pos()+token.Pos(len("var")), start, end) {
start, end = v.Pos(), v.End()
}
if len(v.Specs) > 0 {
switch spec := v.Specs[0].(type) {
case *ast.TypeSpec:
id = spec.Name
case *ast.ValueSpec:
id = spec.Names[0]
}
}
}
// selection cannot partially intersect a node
if !posRangeContains(start, end, decl.Pos(), decl.End()) {
return 0, 0, "", false
}
if id != nil && firstName == "" {
// may be "_"
firstName = id.Name
}
// extends selection to docs comments
var c *ast.CommentGroup
switch decl := decl.(type) {
case *ast.GenDecl:
c = decl.Doc
case *ast.FuncDecl:
c = decl.Doc
}
if c != nil && c.Pos() < start {
start = c.Pos()
}
}
}
for _, comment := range pgf.File.Comments {
if posRangeIntersects(start, end, comment.Pos(), comment.End()) {
if !posRangeContains(start, end, comment.Pos(), comment.End()) {
// selection cannot partially intersect a comment
return 0, 0, "", false
}
}
}
if firstName == "" {
return 0, 0, "", false
}
return start, end, firstName, true
}
// unparenthesizedImports returns a map from each unparenthesized ImportSpec
// to its enclosing declaration (which may need to be deleted too).
func unparenthesizedImports(pgf *parsego.File) map[*ast.ImportSpec]*ast.GenDecl {
decls := make(map[*ast.ImportSpec]*ast.GenDecl)
for _, decl := range pgf.File.Decls {
if decl, ok := decl.(*ast.GenDecl); ok && decl.Tok == token.IMPORT && !decl.Lparen.IsValid() {
decls[decl.Specs[0].(*ast.ImportSpec)] = decl
}
}
return decls
}
// removeNode returns a TextEdit that removes the node.
func removeNode(pgf *parsego.File, node ast.Node) protocol.TextEdit {
rng, err := pgf.NodeRange(node)
if err != nil {
bug.Reportf("removeNode: %v", err)
}
return protocol.TextEdit{Range: rng, NewText: ""}
}
// posRangeIntersects checks if [a, b) and [c, d) intersects, assuming a <= b and c <= d.
func posRangeIntersects(a, b, c, d token.Pos) bool {
return !(b <= c || d <= a)
}
// posRangeContains checks if [a, b) contains [c, d), assuming a <= b and c <= d.
func posRangeContains(a, b, c, d token.Pos) bool {
return a <= c && d <= b
}
|