1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300
|
// Copyright 2018 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package server
import (
"context"
"fmt"
"sort"
"strings"
"golang.org/x/tools/gopls/internal/cache"
"golang.org/x/tools/gopls/internal/file"
"golang.org/x/tools/gopls/internal/golang"
"golang.org/x/tools/gopls/internal/mod"
"golang.org/x/tools/gopls/internal/protocol"
"golang.org/x/tools/gopls/internal/protocol/command"
"golang.org/x/tools/gopls/internal/settings"
"golang.org/x/tools/gopls/internal/util/slices"
"golang.org/x/tools/internal/event"
)
func (s *server) CodeAction(ctx context.Context, params *protocol.CodeActionParams) ([]protocol.CodeAction, error) {
ctx, done := event.Start(ctx, "lsp.Server.codeAction")
defer done()
fh, snapshot, release, err := s.fileOf(ctx, params.TextDocument.URI)
if err != nil {
return nil, err
}
defer release()
uri := fh.URI()
// Determine the supported actions for this file kind.
kind := snapshot.FileKind(fh)
supportedCodeActions, ok := snapshot.Options().SupportedCodeActions[kind]
if !ok {
return nil, fmt.Errorf("no supported code actions for %v file kind", kind)
}
if len(supportedCodeActions) == 0 {
return nil, nil // not an error if there are none supported
}
// The Only field of the context specifies which code actions the client wants.
// If Only is empty, assume that the client wants all of the non-explicit code actions.
want := supportedCodeActions
if len(params.Context.Only) > 0 {
want = make(map[protocol.CodeActionKind]bool)
// Explicit Code Actions are opt-in and shouldn't be
// returned to the client unless requested using Only.
//
// This mechanim exists to avoid a distracting
// lightbulb (code action) on each Test function.
// These actions are unwanted in VS Code because it
// has Test Explorer, and in other editors because
// the UX of executeCommand is unsatisfactory for tests:
// it doesn't show the complete streaming output.
// See https://github.com/joaotavora/eglot/discussions/1402
// for a better solution.
explicit := map[protocol.CodeActionKind]bool{
settings.GoTest: true,
}
for _, only := range params.Context.Only {
for k, v := range supportedCodeActions {
if only == k || strings.HasPrefix(string(k), string(only)+".") {
want[k] = want[k] || v
}
}
want[only] = want[only] || explicit[only]
}
}
if len(want) == 0 {
return nil, fmt.Errorf("no supported code action to execute for %s, wanted %v", uri, params.Context.Only)
}
switch kind {
case file.Mod:
var actions []protocol.CodeAction
fixes, err := s.codeActionsMatchingDiagnostics(ctx, fh.URI(), snapshot, params.Context.Diagnostics, want)
if err != nil {
return nil, err
}
// Group vulnerability fixes by their range, and select only the most
// appropriate upgrades.
//
// TODO(rfindley): can this instead be accomplished on the diagnosis side,
// so that code action handling remains uniform?
vulnFixes := make(map[protocol.Range][]protocol.CodeAction)
searchFixes:
for _, fix := range fixes {
for _, diag := range fix.Diagnostics {
if diag.Source == string(cache.Govulncheck) || diag.Source == string(cache.Vulncheck) {
vulnFixes[diag.Range] = append(vulnFixes[diag.Range], fix)
continue searchFixes
}
}
actions = append(actions, fix)
}
for _, fixes := range vulnFixes {
fixes = mod.SelectUpgradeCodeActions(fixes)
actions = append(actions, fixes...)
}
return actions, nil
case file.Go:
// diagnostic-bundled code actions
//
// The diagnostics already have a UI presence (e.g. squiggly underline);
// the associated action may additionally show (in VS Code) as a lightbulb.
// Note s.codeActionsMatchingDiagnostics returns only fixes
// detected during the analysis phase. golang.CodeActions computes
// extra changes that can address some diagnostics.
actions, err := s.codeActionsMatchingDiagnostics(ctx, uri, snapshot, params.Context.Diagnostics, want)
if err != nil {
return nil, err
}
// computed code actions (may include quickfixes from diagnostics)
trigger := protocol.CodeActionUnknownTrigger
if k := params.Context.TriggerKind; k != nil { // (some clients omit it)
trigger = *k
}
moreActions, err := golang.CodeActions(ctx, snapshot, fh, params.Range, params.Context.Diagnostics, want, trigger)
if err != nil {
return nil, err
}
actions = append(actions, moreActions...)
// Don't suggest fixes for generated files, since they are generally
// not useful and some editors may apply them automatically on save.
// (Unfortunately there's no reliable way to distinguish fixes from
// queries, so we must list all kinds of queries here.)
if golang.IsGenerated(ctx, snapshot, uri) {
actions = slices.DeleteFunc(actions, func(a protocol.CodeAction) bool {
switch a.Kind {
case settings.GoTest,
settings.GoDoc,
settings.GoFreeSymbols,
settings.GoAssembly,
settings.GoplsDocFeatures:
return false // read-only query
}
return true // potential write operation
})
}
return actions, nil
default:
// Unsupported file kind for a code action.
return nil, nil
}
}
// ResolveCodeAction resolves missing Edit information (that is, computes the
// details of the necessary patch) in the given code action using the provided
// Data field of the CodeAction, which should contain the raw json of a protocol.Command.
//
// This should be called by the client before applying code actions, when the
// client has code action resolve support.
//
// This feature allows capable clients to preview and selectively apply the diff
// instead of applying the whole thing unconditionally through workspace/applyEdit.
func (s *server) ResolveCodeAction(ctx context.Context, ca *protocol.CodeAction) (*protocol.CodeAction, error) {
ctx, done := event.Start(ctx, "lsp.Server.resolveCodeAction")
defer done()
// Only resolve the code action if there is Data provided.
var cmd protocol.Command
if ca.Data != nil {
if err := protocol.UnmarshalJSON(*ca.Data, &cmd); err != nil {
return nil, err
}
}
if cmd.Command != "" {
params := &protocol.ExecuteCommandParams{
Command: cmd.Command,
Arguments: cmd.Arguments,
}
handler := &commandHandler{
s: s,
params: params,
}
edit, err := command.Dispatch(ctx, params, handler)
if err != nil {
return nil, err
}
var ok bool
if ca.Edit, ok = edit.(*protocol.WorkspaceEdit); !ok {
return nil, fmt.Errorf("unable to resolve code action %q", ca.Title)
}
}
return ca, nil
}
// codeActionsMatchingDiagnostics creates code actions for the
// provided diagnostics, by unmarshalling actions bundled in the
// protocol.Diagnostic.Data field or, if there were none, by creating
// actions from edits associated with a matching Diagnostic from the
// set of stored diagnostics for this file.
func (s *server) codeActionsMatchingDiagnostics(ctx context.Context, uri protocol.DocumentURI, snapshot *cache.Snapshot, pds []protocol.Diagnostic, want map[protocol.CodeActionKind]bool) ([]protocol.CodeAction, error) {
var actions []protocol.CodeAction
var unbundled []protocol.Diagnostic // diagnostics without bundled code actions in their Data field
for _, pd := range pds {
bundled := cache.BundledLazyFixes(pd)
if len(bundled) > 0 {
for _, fix := range bundled {
if want[fix.Kind] {
actions = append(actions, fix)
}
}
} else {
// No bundled actions: keep searching for a match.
unbundled = append(unbundled, pd)
}
}
for _, pd := range unbundled {
for _, sd := range s.findMatchingDiagnostics(uri, pd) {
diagActions, err := codeActionsForDiagnostic(ctx, snapshot, sd, &pd, want)
if err != nil {
return nil, err
}
actions = append(actions, diagActions...)
}
}
return actions, nil
}
func codeActionsForDiagnostic(ctx context.Context, snapshot *cache.Snapshot, sd *cache.Diagnostic, pd *protocol.Diagnostic, want map[protocol.CodeActionKind]bool) ([]protocol.CodeAction, error) {
var actions []protocol.CodeAction
for _, fix := range sd.SuggestedFixes {
if !want[fix.ActionKind] {
continue
}
var changes []protocol.DocumentChange
for uri, edits := range fix.Edits {
fh, err := snapshot.ReadFile(ctx, uri)
if err != nil {
return nil, err
}
change := protocol.DocumentChangeEdit(fh, edits)
changes = append(changes, change)
}
actions = append(actions, protocol.CodeAction{
Title: fix.Title,
Kind: fix.ActionKind,
Edit: protocol.NewWorkspaceEdit(changes...),
Command: fix.Command,
Diagnostics: []protocol.Diagnostic{*pd},
})
}
return actions, nil
}
func (s *server) findMatchingDiagnostics(uri protocol.DocumentURI, pd protocol.Diagnostic) []*cache.Diagnostic {
s.diagnosticsMu.Lock()
defer s.diagnosticsMu.Unlock()
var sds []*cache.Diagnostic
for _, viewDiags := range s.diagnostics[uri].byView {
for _, sd := range viewDiags.diagnostics {
sameDiagnostic := (pd.Message == strings.TrimSpace(sd.Message) && // extra space may have been trimmed when converting to protocol.Diagnostic
protocol.CompareRange(pd.Range, sd.Range) == 0 &&
pd.Source == string(sd.Source))
if sameDiagnostic {
sds = append(sds, sd)
}
}
}
return sds
}
func (s *server) getSupportedCodeActions() []protocol.CodeActionKind {
allCodeActionKinds := make(map[protocol.CodeActionKind]struct{})
for _, kinds := range s.Options().SupportedCodeActions {
for kind := range kinds {
allCodeActionKinds[kind] = struct{}{}
}
}
var result []protocol.CodeActionKind
for kind := range allCodeActionKinds {
result = append(result, kind)
}
sort.Slice(result, func(i, j int) bool {
return result[i] < result[j]
})
return result
}
type unit = struct{}
|