1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
|
// Copyright 2020 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package order
import (
"math/rand"
"sort"
"testing"
"github.com/google/go-cmp/cmp"
"google.golang.org/protobuf/reflect/protoreflect"
)
type fieldDesc struct {
index int
name protoreflect.FullName
number protoreflect.FieldNumber
extension bool
oneofIndex int // non-zero means within oneof; negative means synthetic
protoreflect.FieldDescriptor
}
func (d fieldDesc) Index() int { return d.index }
func (d fieldDesc) Name() protoreflect.Name { return d.name.Name() }
func (d fieldDesc) FullName() protoreflect.FullName { return d.name }
func (d fieldDesc) Number() protoreflect.FieldNumber { return d.number }
func (d fieldDesc) IsExtension() bool { return d.extension }
func (d fieldDesc) ContainingOneof() protoreflect.OneofDescriptor {
switch {
case d.oneofIndex < 0:
return oneofDesc{index: -d.oneofIndex, synthetic: true}
case d.oneofIndex > 0:
return oneofDesc{index: +d.oneofIndex, synthetic: false}
default:
return nil
}
}
type oneofDesc struct {
index int
synthetic bool
protoreflect.OneofDescriptor
}
func (d oneofDesc) Index() int { return d.index }
func (d oneofDesc) IsSynthetic() bool { return d.synthetic }
func TestFieldOrder(t *testing.T) {
tests := []struct {
label string
order FieldOrder
fields []fieldDesc
}{{
label: "LegacyFieldOrder",
order: LegacyFieldOrder,
fields: []fieldDesc{
// Extension fields sorted first by field number.
{number: 2, extension: true},
{number: 4, extension: true},
{number: 100, extension: true},
{number: 120, extension: true},
// Non-extension fields that are not within a oneof
// sorted next by field number.
{number: 1},
{number: 5, oneofIndex: -10}, // synthetic oneof
{number: 10},
{number: 11, oneofIndex: -9}, // synthetic oneof
{number: 12},
// Non-synthetic oneofs sorted last by index.
{number: 13, oneofIndex: 4},
{number: 3, oneofIndex: 5},
{number: 9, oneofIndex: 5},
{number: 7, oneofIndex: 8},
},
}, {
label: "NumberFieldOrder",
order: NumberFieldOrder,
fields: []fieldDesc{
{number: 1, index: 5, name: "c"},
{number: 2, index: 2, name: "b"},
{number: 3, index: 3, name: "d"},
{number: 5, index: 1, name: "a"},
{number: 7, index: 7, name: "e"},
},
}, {
label: "IndexNameFieldOrder",
order: IndexNameFieldOrder,
fields: []fieldDesc{
// Non-extension fields sorted first by index.
{index: 0, number: 5, name: "c"},
{index: 2, number: 2, name: "a"},
{index: 4, number: 4, name: "b"},
{index: 7, number: 6, name: "d"},
// Extension fields sorted last by full name.
{index: 3, number: 1, name: "d.a", extension: true},
{index: 5, number: 3, name: "e", extension: true},
{index: 1, number: 7, name: "g", extension: true},
},
}}
for _, tt := range tests {
t.Run(tt.label, func(t *testing.T) {
want := tt.fields
got := append([]fieldDesc(nil), want...)
for i, j := range rand.Perm(len(got)) {
got[i], got[j] = got[j], got[i]
}
sort.Slice(got, func(i, j int) bool {
return tt.order(got[i], got[j])
})
if diff := cmp.Diff(want, got,
cmp.Comparer(func(x, y fieldDesc) bool { return x == y }),
); diff != "" {
t.Errorf("order mismatch (-want +got):\n%s", diff)
}
})
}
}
func TestKeyOrder(t *testing.T) {
tests := []struct {
label string
order KeyOrder
keys []any
}{{
label: "GenericKeyOrder",
order: GenericKeyOrder,
keys: []any{false, true},
}, {
label: "GenericKeyOrder",
order: GenericKeyOrder,
keys: []any{int32(-100), int32(-99), int32(-10), int32(-9), int32(-1), int32(0), int32(+1), int32(+9), int32(+10), int32(+99), int32(+100)},
}, {
label: "GenericKeyOrder",
order: GenericKeyOrder,
keys: []any{int64(-100), int64(-99), int64(-10), int64(-9), int64(-1), int64(0), int64(+1), int64(+9), int64(+10), int64(+99), int64(+100)},
}, {
label: "GenericKeyOrder",
order: GenericKeyOrder,
keys: []any{uint32(0), uint32(1), uint32(9), uint32(10), uint32(99), uint32(100)},
}, {
label: "GenericKeyOrder",
order: GenericKeyOrder,
keys: []any{uint64(0), uint64(1), uint64(9), uint64(10), uint64(99), uint64(100)},
}, {
label: "GenericKeyOrder",
order: GenericKeyOrder,
keys: []any{"", "a", "aa", "ab", "ba", "bb", "\u0080", "\u0080\u0081", "\u0082\u0080"},
}}
for _, tt := range tests {
t.Run(tt.label, func(t *testing.T) {
var got, want []protoreflect.MapKey
for _, v := range tt.keys {
want = append(want, protoreflect.ValueOf(v).MapKey())
}
got = append(got, want...)
for i, j := range rand.Perm(len(got)) {
got[i], got[j] = got[j], got[i]
}
sort.Slice(got, func(i, j int) bool {
return tt.order(got[i], got[j])
})
if diff := cmp.Diff(want, got, cmp.Transformer("", protoreflect.MapKey.Interface)); diff != "" {
t.Errorf("order mismatch (-want +got):\n%s", diff)
}
})
}
}
|
