File: feature_support_checker_test.go

package info (click to toggle)
golang-k8s-apiserver 0.32.7-3
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid
  • size: 11,356 kB
  • sloc: sh: 236; makefile: 5
file content (269 lines) | stat: -rw-r--r-- 8,525 bytes parent folder | download | duplicates (2)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
/*
Copyright 2024 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package feature

import (
	"context"
	"fmt"
	"testing"

	"github.com/stretchr/testify/assert"
	clientv3 "go.etcd.io/etcd/client/v3"
	"k8s.io/apiserver/pkg/storage"
)

type mockEndpointVersion struct {
	Endpoint string
	Version  string
	Error    error
}

// MockEtcdClient is a mock implementation of the EtcdClientInterface interface.
type MockEtcdClient struct {
	EndpointVersion []mockEndpointVersion
}

func (m MockEtcdClient) getEndpoints() []string {
	var endpoints []string
	for _, ev := range m.EndpointVersion {
		endpoints = append(endpoints, ev.Endpoint)
	}
	return endpoints
}

func (m MockEtcdClient) getVersion(endpoint string) (string, error) {
	for _, ev := range m.EndpointVersion {
		if ev.Endpoint == endpoint {
			return ev.Version, ev.Error
		}
	}
	// Never should happen, unless tests having a problem.
	return "", fmt.Errorf("No version found")
}

func (m *MockEtcdClient) Endpoints() []string {
	return m.getEndpoints()
}

// Status returns a mock status response.
func (m *MockEtcdClient) Status(ctx context.Context, endpoint string) (*clientv3.StatusResponse, error) {
	version, err := m.getVersion(endpoint)
	if err != nil {
		return nil, err
	}
	// Return a mock status response
	return &clientv3.StatusResponse{
		Version: version,
	}, nil
}

func TestSupports(t *testing.T) {
	tests := []struct {
		testName       string
		featureName    string
		expectedResult bool
	}{
		{
			testName:    "Disabled - with unknown feature",
			featureName: "some unknown feature",
		},
		{
			testName:    "Disabled - with empty feature",
			featureName: "",
		},
		{
			testName:       "Disabled - default",
			featureName:    storage.RequestWatchProgress,
			expectedResult: false,
		},
	}

	for _, tt := range tests {
		t.Run(tt.testName, func(t *testing.T) {
			var testFeatureSupportChecker FeatureSupportChecker = newDefaultFeatureSupportChecker()

			supported := testFeatureSupportChecker.Supports(tt.featureName)

			assert.Equal(t, tt.expectedResult, supported)
		})
	}
}

func TestSupportsRequestWatchProgress(t *testing.T) {
	type testCase struct {
		endpointsVersion []mockEndpointVersion
		expectedResult   bool
		expectedError    error
	}
	tests := []struct {
		testName string
		rounds   []testCase
	}{
		{
			testName: "Disabled - default disabled",
			rounds:   []testCase{{expectedResult: false}},
		},
		{
			testName: "Enabled - supported versions bound",
			rounds: []testCase{
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.4.31", Endpoint: "localhost:2390"}},
					expectedResult: true,
				},
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.5.13", Endpoint: "localhost:2391"}},
					expectedResult: true,
				},
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.6.0", Endpoint: "localhost:2392"}},
					expectedResult: true}},
		},
		{
			testName: "Disabled - supported versions bound, 3.4.30",
			rounds: []testCase{
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.4.30", Endpoint: "localhost:2390"}},
					expectedResult: false}},
		},
		{
			testName: "Disabled - supported versions bound, 3.5.0",
			rounds: []testCase{
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.5.0", Endpoint: "localhost:2390"}},
					expectedResult: false}},
		},
		{
			testName: "Disabled - supported versions bound, 3.5.12",
			rounds: []testCase{
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.5.12", Endpoint: "localhost:2390"}},
					expectedResult: false}},
		},
		{
			testName: "Disabled - disables if called with one client doesn't support it",
			rounds: []testCase{
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.5.13", Endpoint: "localhost:2390"},
					{Version: "3.5.10", Endpoint: "localhost:2391"}},
					expectedResult: false}},
		},
		{
			testName: "Disabled - disables if called with all client doesn't support it",
			rounds: []testCase{
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.5.9", Endpoint: "localhost:2390"},
					{Version: "3.5.10", Endpoint: "localhost:2391"}},
					expectedResult: false}},
		},
		{
			testName: "Enabled - if provided client has at least one endpoint that supports it and no client that doesn't",
			rounds: []testCase{
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.4.31", Endpoint: "localhost:2390"},
					{Version: "3.5.13", Endpoint: "localhost:2391"},
					{Version: "3.5.14", Endpoint: "localhost:2392"},
					{Version: "3.6.0", Endpoint: "localhost:2393"}},
					expectedResult: true}},
		},
		{
			testName: "Disabled - cannot be re-enabled",
			rounds: []testCase{
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.4.0", Endpoint: "localhost:2390"},
					{Version: "3.4.1", Endpoint: "localhost:2391"}},
					expectedResult: false},
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.6.0", Endpoint: "localhost:2392"}},
					expectedResult: false}},
		},
		{
			testName: "Enabled - one client supports it and later disabled it with second client",
			rounds: []testCase{
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.6.0", Endpoint: "localhost:2390"},
					{Version: "3.5.14", Endpoint: "localhost:2391"}},
					expectedResult: true},
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.4.0", Endpoint: "localhost:2392"}},
					expectedResult: false}},
		},
		{
			testName: "Disabled - malformed version would disable the supported cluster and can not be re-enabled again",
			rounds: []testCase{
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.6.0", Endpoint: "localhost:2390"}},
					expectedResult: true,
				},
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.4.--aaa", Endpoint: "localhost:2392"}},
					expectedResult: false},
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.5.13", Endpoint: "localhost:2393"}},
					expectedResult: false}},
		},
		{
			testName: "Enabled - error on first client, enabled success on second client",
			rounds: []testCase{
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.6.0", Endpoint: "localhost:2390", Error: fmt.Errorf("some error")}},
					expectedResult: false,
					expectedError:  fmt.Errorf("failed checking etcd version, endpoint: %q: %w", "localhost:2390", fmt.Errorf("some error")),
				},
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.5.14", Endpoint: "localhost:2391"}},
					expectedResult: true}},
		},
		{
			testName: "Disabled - enabled success on first client, error on second client, disabled success on third client",
			rounds: []testCase{
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.6.0", Endpoint: "localhost:2390"}},
					expectedResult: true,
				},
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.6.0", Endpoint: "localhost:2391", Error: fmt.Errorf("some error")}},
					expectedResult: true,
					expectedError:  fmt.Errorf("failed checking etcd version, endpoint: %q: %w", "localhost:2391", fmt.Errorf("some error")),
				},
				{endpointsVersion: []mockEndpointVersion{
					{Version: "3.5.10", Endpoint: "localhost:2392"}},
					expectedResult: false}},
		},
		{
			testName: "Disabled - client doesn't have any endpoints",
			rounds:   []testCase{{endpointsVersion: []mockEndpointVersion{}, expectedResult: false}},
		},
	}
	for _, tt := range tests {
		t.Run(tt.testName, func(t *testing.T) {
			var testFeatureSupportChecker = newDefaultFeatureSupportChecker()
			for _, round := range tt.rounds {
				// Mock Etcd client
				mockClient := &MockEtcdClient{EndpointVersion: round.endpointsVersion}
				ctx := context.Background()

				for _, ep := range mockClient.Endpoints() {
					err := testFeatureSupportChecker.clientSupportsRequestWatchProgress(ctx, mockClient, ep)
					assert.Equal(t, round.expectedError, err)
				}

				supported := testFeatureSupportChecker.Supports(storage.RequestWatchProgress)
				assert.Equal(t, round.expectedResult, supported)
			}
		})
	}
}