1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522
|
/*
Copyright 2024 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package server
import (
"context"
"errors"
"fmt"
"io"
"net/http"
"net/http/httptest"
"strings"
"testing"
"time"
"k8s.io/apimachinery/pkg/util/wait"
"k8s.io/apiserver/pkg/endpoints/request"
)
func TestRequestTimeoutBehavior(t *testing.T) {
type setup struct {
name string
clientTimeout time.Duration
serverReqTimeout time.Duration
handlerWritesBeforeTimeout bool
handlerFlushesBeforeTimeout bool
waiter waiter
}
type expectation struct {
clientErr verifier
clientStatusCodeExpected int
clientRespBodyReadErr verifier
handlerWriteErr verifier
}
tests := []struct {
setup setup
expectations map[string]expectation
}{
// scenario:
// a) timeout filter enabled: Yes
// b) client specifies timeout in the request URI: No
// c) the handler writes to the ResponseWriter object before request times out: No
// d) the handler flushes the ResponseWriter object before request times out: No
// observation:
// the timeout filter detects that the context of the request has exceeded its
// deadline, since the ResponseWriter object has not been written to yet,
// the following takes place:
// - it marks the ResponseWriter object as timeout=true, so any further
// attempt to write to it will yield an 'http: Handler timeout' error
// - it sends 504 status code to the client
// expectation (same behavior for both http/1x and http/2.0):
// client:
// - client receives a '504 GatewayTimeout' status code
// - reading the Body of the Response object yields an error
// server:
// - Write to the ResponseWriter yields an 'http: Handler timeout'
// error immediately.
{
setup: setup{
name: "timeout occurs before the handler writes to or flushes the ResponseWriter",
clientTimeout: 0, // b
handlerWritesBeforeTimeout: false, // c
handlerFlushesBeforeTimeout: false, // d
serverReqTimeout: time.Second,
},
expectations: map[string]expectation{
"HTTP/2.0": {
clientErr: wantNoError{},
clientStatusCodeExpected: http.StatusGatewayTimeout,
clientRespBodyReadErr: wantNoError{},
handlerWriteErr: wantError{http.ErrHandlerTimeout},
},
"HTTP/1.1": {
clientErr: wantNoError{},
clientStatusCodeExpected: http.StatusGatewayTimeout,
clientRespBodyReadErr: wantNoError{},
handlerWriteErr: wantError{http.ErrHandlerTimeout},
},
},
},
// scenario:
// a) timeout filter enabled: Yes
// b) client specifies timeout in the request URI: No
// c) the handler writes to the ResponseWriter object before request times out: Yes
// d) the handler flushes the ResponseWriter object before request times out: No
// observation:
// the timeout filter detects that the context of the request has exceeded its
// deadline, since the ResponseWriter object has already been written to,
// the following takes place:
// - it marks the ResponseWriter object as timeout=true, so any further attempt
// to write to it will yield an 'http: Handler timeout' error
// - it can't send '504 GatewayTimeout' to the client since the ResponseWriter
// object has already been written to, so it panics with 'net/http: abort Handler' error
{
setup: setup{
name: "timeout occurs after the handler writes to the ResponseWriter",
clientTimeout: 0, // b
handlerWritesBeforeTimeout: true, // c
handlerFlushesBeforeTimeout: false, // d
serverReqTimeout: time.Second,
},
expectations: map[string]expectation{
// expectation:
// - client: receives a stream reset error, no 'Response' from the server
// - server: Write to the ResponseWriter yields an 'http: Handler timeout' error
"HTTP/2.0": {
clientErr: wantContains{"stream error: stream ID 1; INTERNAL_ERROR; received from peer"},
clientStatusCodeExpected: 0,
clientRespBodyReadErr: wantNoError{},
handlerWriteErr: wantError{http.ErrHandlerTimeout},
},
// expectation:
// - client: receives an 'io.EOF' error, no 'Response' from the server
// - server: Write to the ResponseWriter yields an 'http: Handler timeout' error
"HTTP/1.1": {
clientErr: wantError{io.EOF},
clientStatusCodeExpected: 0,
clientRespBodyReadErr: wantNoError{},
handlerWriteErr: wantError{http.ErrHandlerTimeout},
},
},
},
// scenario:
// a) timeout filter enabled: Yes
// b) client specifies timeout in the request URI: No
// c) the handler writes to the ResponseWriter object before request times out: Yes
// d) the handler flushes the ResponseWriter object before request times out: Yes
// observation:
// the timeout filter detects that the context of the request has exceeded its
// deadline, since the ResponseWriter object has already been written to,
// the following takes place:
// - it marks the ResponseWriter object as timeout=true, so any further attempt
// to write to it will yield an 'http: Handler timeout' error
// - it can't send '504 GatewayTimeout' to the client since the ResponseWriter
// object has already been written to, so it panics with 'net/http: abort Handler' error
{
setup: setup{
name: "timeout occurs after the handler writes to and flushes the ResponseWriter",
clientTimeout: 0, // b
handlerWritesBeforeTimeout: true, // c
handlerFlushesBeforeTimeout: true, // d
serverReqTimeout: time.Second,
},
expectations: map[string]expectation{
// expectation:
// - client: since the ResponseWriter has been flushed the client
// receives a response from the server, but reading the response body
// is expected to yield a stream reset error.
// - server: Write to the ResponseWriter yields an 'http: Handler timeout' error
"HTTP/2.0": {
clientErr: wantNoError{},
clientStatusCodeExpected: 200,
clientRespBodyReadErr: wantContains{"stream error: stream ID 1; INTERNAL_ERROR; received from peer"},
handlerWriteErr: wantError{http.ErrHandlerTimeout},
},
// expectation:
// - client: since the ResponseWriter has been flushed the client
// receives a response from the server, but reading the response body
// will yield an 'unexpected EOF' error.
// - server: Write to the ResponseWriter yields an 'http: Handler timeout' error
"HTTP/1.1": {
clientErr: wantNoError{},
clientStatusCodeExpected: 200,
clientRespBodyReadErr: wantError{io.ErrUnexpectedEOF},
handlerWriteErr: wantError{http.ErrHandlerTimeout},
},
},
},
// scenario:
// a) timeout filter enabled: Yes
// b) client specifies timeout in the request URI: Yes
// c) the handler writes to the ResponseWriter object before request times out: Yes
// d) the handler flushes the ResponseWriter object before request times out: No
// observation:
// the timeout filter detects that the context of the request has exceeded its
// deadline, and the the following takes place:
// - it marks the ResponseWriter object as timeout=true, so any further attempt
// to write to it will yield an 'http: Handler timeout' error
// - it can't send '504 GatewayTimeout' to the client since the ResponseWriter
// object has already been written to, so it panics with 'net/http: abort Handler' error
// at the same time, the net/http client also detects that the context of the
// client-side request has exceeded its deadline, and so it aborts with a
// 'context deadline exceeded' error.
// NOTE: although the client is most likely to receive the context deadline error
// first due to the roundtrip time added to the arrival of the error from
// the server, nevertheless it could cause flakes in CI due to overload, so we
// need to check for either error to be flake free.
{
setup: setup{
name: "client specifies a timeout",
clientTimeout: time.Second, // b
handlerWritesBeforeTimeout: true, // c
handlerFlushesBeforeTimeout: false, // d
serverReqTimeout: wait.ForeverTestTimeout * 2, // this should not be in effect
// twice the request timeout so it can withstand flakes in CI
waiter: &waitWithDuration{after: 2 * time.Second},
},
expectations: map[string]expectation{
// expectation:
// - client: receives either a context.DeadlineExceeded error from its transport
// or it receives the error from the server
// - server: Write to the ResponseWriter will yields an 'http: Handler timeout'
"HTTP/2.0": {
clientErr: wantEitherOr{
err: context.DeadlineExceeded,
contains: "stream error: stream ID 1; INTERNAL_ERROR; received from peer",
},
clientStatusCodeExpected: 0,
clientRespBodyReadErr: wantNoError{},
handlerWriteErr: wantError{http.ErrHandlerTimeout},
},
// expectation:
// - client: receives either a context.DeadlineExceeded error from its
// transport, or it receives the error from the server
// - server: Write to the ResponseWriter will yields an 'http: Handler timeout'
"HTTP/1.1": {
clientErr: wantEitherOr{
err: context.DeadlineExceeded,
contains: "EOF",
},
clientStatusCodeExpected: 0,
clientRespBodyReadErr: wantNoError{},
handlerWriteErr: wantError{http.ErrHandlerTimeout},
},
},
},
}
for _, test := range tests {
for _, proto := range []string{"HTTP/1.1", "HTTP/2.0"} { // every test is run for both http/1x and http/2.0
t.Run(fmt.Sprintf("%s/%s", test.setup.name, proto), func(t *testing.T) {
setup := test.setup
want, ok := test.expectations[proto]
if !ok {
t.Fatalf("wrong test setup - no expectation for %s", proto)
}
fakeAudit := &fakeAudit{}
config, _ := setUp(t)
config.AuditPolicyRuleEvaluator = fakeAudit
config.AuditBackend = fakeAudit
// setup server run option --request-timeout
config.RequestTimeout = setup.serverReqTimeout
s, err := config.Complete(nil).New("test", NewEmptyDelegate())
if err != nil {
t.Fatalf("Error in setting up a GenericAPIServer object: %v", err)
}
// using this, the handler blocks until the timeout occurs
waiter := setup.waiter
if waiter == nil {
waiter = &waitWithChannelClose{after: make(chan time.Time)}
}
// this is the timeout we expect the context of a request
// on the server to have.
// - if the client does not specify a timeout parameter in
// the request URI then it should default to --request-timeout
// - otherwise, it should be the timeout specified by the client
reqCtxTimeoutWant := config.RequestTimeout
if setup.clientTimeout > 0 {
reqCtxTimeoutWant = setup.clientTimeout
}
handlerDoneCh := make(chan struct{})
handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
defer close(handlerDoneCh)
ctx := r.Context()
if r.Proto != proto {
t.Errorf("expected protocol: %q, but got: %q", proto, r.Proto)
return
}
// TODO: we don't support `FlushError` yet
flusher, ok := w.(http.Flusher)
if !ok {
t.Errorf("expected ResponseWriter object to implement FlushError")
return
}
// make sure that we have the right request
// - it must be a non long-running request
// - it must have a received-at timestamp so we
// can calculate the request deadline accurately.
// - the context of the request must have the
// expected deadline
reqInfo, ok := request.RequestInfoFrom(ctx)
if !ok {
t.Errorf("expected the request context to have a RequestInfo associated")
return
}
if config.LongRunningFunc(r, reqInfo) {
t.Errorf("wrong test setup, wanted a non long-running request, but got: %#v", reqInfo)
return
}
receivedAt, ok := request.ReceivedTimestampFrom(ctx)
if !ok {
t.Errorf("expected the request context to have a received-at timestamp")
return
}
deadline, ok := ctx.Deadline()
if !ok {
t.Errorf("expected the request context to have a deadline")
return
}
if want, got := reqCtxTimeoutWant, deadline.Sub(receivedAt); want != got {
t.Errorf("expected the request context to have a deadline of: %s, but got: %s", want, got)
return
}
// does the handler write to or flush the
// ResponseWriter object before timeout occurs?
if setup.handlerWritesBeforeTimeout {
if _, err := w.Write([]byte("hello")); err != nil {
t.Errorf("unexpected error from Write: %v", err)
return
}
}
if setup.handlerFlushesBeforeTimeout {
flusher.Flush()
}
// wait for the request context deadline to elapse
<-waiter.wait()
// write to the ResponseWriter object after timeout happens
_, err := w.Write([]byte("a"))
want.handlerWriteErr.verify(t, err)
// flush the ResponseWriter object after timeout happens
// http.Flusher does not return an error
flusher.Flush()
})
s.Handler.NonGoRestfulMux.Handle("/ping", handler)
server := httptest.NewUnstartedServer(s.Handler)
defer server.Close()
if proto == "HTTP/2.0" {
server.EnableHTTP2 = true
}
server.StartTLS()
func() {
defer waiter.close()
client := server.Client()
url := fmt.Sprintf("%s/ping", server.URL)
// if the user has specified a timeout then add
// it to the request URI
if setup.clientTimeout > 0 {
url = fmt.Sprintf("%s?timeout=%s", url, setup.clientTimeout)
}
// if the client has specified a timeout then we
// must wire the request context with the same
// deadline, this is how client-go behaves today.
ctx := context.Background()
if setup.clientTimeout > 0 {
var cancel context.CancelFunc
ctx, cancel = context.WithTimeout(ctx, setup.clientTimeout)
defer cancel()
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
if err != nil {
t.Errorf("failed to create a new http request - %v", err)
return
}
resp, err := client.Do(req)
want.clientErr.verify(t, err)
// do we expect a valid http status code?
switch {
case want.clientStatusCodeExpected > 0:
if resp == nil {
t.Errorf("expected a response from the server: %v", err)
return
}
if resp.StatusCode != want.clientStatusCodeExpected {
t.Errorf("expected a status code: %d, but got: %#v", want.clientStatusCodeExpected, resp)
}
// read off the body of the response, and verify what we expect
_, err = io.ReadAll(resp.Body)
want.clientRespBodyReadErr.verify(t, err)
if err := resp.Body.Close(); err != nil {
t.Errorf("unexpected error while closing the Body of the Response: %v", err)
}
default:
if resp != nil {
t.Errorf("did not expect a Response from the server, but got: %#v", resp)
}
return
}
}()
select {
case <-handlerDoneCh:
case <-time.After(wait.ForeverTestTimeout):
t.Errorf("expected the request handler to have terminated")
}
})
}
}
}
type verifier interface {
verify(t *testing.T, got error)
}
type wantNoError struct{}
func (v wantNoError) verify(t *testing.T, got error) {
t.Helper()
if got != nil {
t.Errorf("unexpected error: %v", got)
}
}
type wantContains struct {
contains string
}
func (v wantContains) verify(t *testing.T, got error) {
t.Helper()
switch {
case got != nil:
if !strings.Contains(got.Error(), v.contains) {
t.Errorf("expected the error to contain: %q, but got: %v", v.contains, got)
}
default:
t.Errorf("expected an error that contains %q, but got none", v.contains)
}
}
type wantError struct {
err error
}
func (v wantError) verify(t *testing.T, got error) {
t.Helper()
switch {
case got != nil:
if !errors.Is(got, v.err) {
t.Errorf("expected error: %v, but got: %v", v.err, got)
}
default:
t.Errorf("expected an error %v, but got none", v.err)
}
}
type wantEitherOr struct {
err error
contains string
}
func (v wantEitherOr) verify(t *testing.T, got error) {
t.Helper()
switch {
case got != nil:
if !(errors.Is(got, v.err) || strings.Contains(got.Error(), v.contains)) {
t.Errorf("expected the error to contain: %q or be: %v, but got: %v", v.contains, v.err, got)
}
default:
t.Errorf("expected an error to contain: %q or be: %v, but got none", v.contains, v.err)
}
}
type waiter interface {
wait() <-chan time.Time
close()
}
type waitWithDuration struct {
after time.Duration
}
func (w waitWithDuration) wait() <-chan time.Time { return time.After(w.after) }
func (w waitWithDuration) close() {}
type waitWithChannelClose struct {
after chan time.Time
}
func (w waitWithChannelClose) wait() <-chan time.Time {
// for http/2, we do the following:
// a) let the handler block indefinitely
// b) this forces the write timeout to occur on the server side
// c) the http2 client receives a stream reset error immediately
// after the write timeout occurs.
// d) the client then closes the channel by calling close
// e) the handler unblocks and terminates
return w.after
}
func (w waitWithChannelClose) close() { close(w.after) }
|