1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556
|
/*
Copyright 2019 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package metrics
import (
"strings"
"sync"
"testing"
"github.com/blang/semver/v4"
"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/testutil"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
apimachineryversion "k8s.io/apimachinery/pkg/version"
)
var (
v115 = semver.MustParse("1.15.0")
alphaCounter = NewCounter(
&CounterOpts{
Namespace: "some_namespace",
Name: "test_counter_name",
Subsystem: "subsystem",
StabilityLevel: ALPHA,
Help: "counter help",
},
)
alphaDeprecatedCounter = NewCounter(
&CounterOpts{
Namespace: "some_namespace",
Name: "test_alpha_dep_counter",
Subsystem: "subsystem",
StabilityLevel: ALPHA,
Help: "counter help",
DeprecatedVersion: "1.15.0",
},
)
alphaHiddenCounter = NewCounter(
&CounterOpts{
Namespace: "some_namespace",
Name: "test_alpha_hidden_counter",
Subsystem: "subsystem",
StabilityLevel: ALPHA,
Help: "counter help",
DeprecatedVersion: "1.14.0",
},
)
)
func TestShouldHide(t *testing.T) {
currentVersion := parseVersion(apimachineryversion.Info{
Major: "1",
Minor: "17",
GitVersion: "v1.17.1-alpha-1.12345",
})
var tests = []struct {
desc string
deprecatedVersion string
shouldHide bool
}{
{
desc: "current minor release should not be hidden",
deprecatedVersion: "1.17.0",
shouldHide: false,
},
{
desc: "older minor release should be hidden",
deprecatedVersion: "1.16.0",
shouldHide: true,
},
}
for _, test := range tests {
tc := test
t.Run(tc.desc, func(t *testing.T) {
result := shouldHide(¤tVersion, parseSemver(tc.deprecatedVersion))
assert.Equalf(t, tc.shouldHide, result, "expected should hide %v, but got %v", tc.shouldHide, result)
})
}
}
func TestRegister(t *testing.T) {
var tests = []struct {
desc string
metrics []*Counter
expectedErrors []error
expectedIsCreatedValues []bool
expectedIsDeprecated []bool
expectedIsHidden []bool
}{
{
desc: "test alpha metric",
metrics: []*Counter{alphaCounter},
expectedErrors: []error{nil},
expectedIsCreatedValues: []bool{true},
expectedIsDeprecated: []bool{false},
expectedIsHidden: []bool{false},
},
{
desc: "test registering same metric multiple times",
metrics: []*Counter{alphaCounter, alphaCounter},
expectedErrors: []error{nil, prometheus.AlreadyRegisteredError{}},
expectedIsCreatedValues: []bool{true, true},
expectedIsDeprecated: []bool{false, false},
expectedIsHidden: []bool{false, false},
},
{
desc: "test alpha deprecated metric",
metrics: []*Counter{alphaDeprecatedCounter},
expectedErrors: []error{nil},
expectedIsCreatedValues: []bool{true},
expectedIsDeprecated: []bool{true},
expectedIsHidden: []bool{false},
},
{
desc: "test alpha hidden metric",
metrics: []*Counter{alphaHiddenCounter},
expectedErrors: []error{nil},
expectedIsCreatedValues: []bool{false},
expectedIsDeprecated: []bool{true},
expectedIsHidden: []bool{true},
},
}
for _, test := range tests {
t.Run(test.desc, func(t *testing.T) {
registry := newKubeRegistry(apimachineryversion.Info{
Major: "1",
Minor: "15",
GitVersion: "v1.15.0-alpha-1.12345",
})
for i, m := range test.metrics {
err := registry.Register(m)
if err != nil && err.Error() != test.expectedErrors[i].Error() {
t.Errorf("Got unexpected error %v, wanted %v", err, test.expectedErrors[i])
}
if m.IsCreated() != test.expectedIsCreatedValues[i] {
t.Errorf("Got isCreated == %v, wanted isCreated to be %v", m.IsCreated(), test.expectedIsCreatedValues[i])
}
if m.IsDeprecated() != test.expectedIsDeprecated[i] {
t.Errorf("Got IsDeprecated == %v, wanted IsDeprecated to be %v", m.IsDeprecated(), test.expectedIsDeprecated[i])
}
if m.IsHidden() != test.expectedIsHidden[i] {
t.Errorf("Got IsHidden == %v, wanted IsHidden to be %v", m.IsHidden(), test.expectedIsDeprecated[i])
}
}
})
}
}
func TestMustRegister(t *testing.T) {
var tests = []struct {
desc string
metrics []*Counter
registryVersion *semver.Version
expectedPanics []bool
}{
{
desc: "test alpha metric",
metrics: []*Counter{alphaCounter},
registryVersion: &v115,
expectedPanics: []bool{false},
},
{
desc: "test registering same metric multiple times",
metrics: []*Counter{alphaCounter, alphaCounter},
registryVersion: &v115,
expectedPanics: []bool{false, true},
},
{
desc: "test alpha deprecated metric",
metrics: []*Counter{alphaDeprecatedCounter},
registryVersion: &v115,
expectedPanics: []bool{false},
},
{
desc: "test must registering same deprecated metric",
metrics: []*Counter{alphaDeprecatedCounter, alphaDeprecatedCounter},
registryVersion: &v115,
expectedPanics: []bool{false, true},
},
{
desc: "test alpha hidden metric",
metrics: []*Counter{alphaHiddenCounter},
registryVersion: &v115,
expectedPanics: []bool{false},
},
}
for _, test := range tests {
t.Run(test.desc, func(t *testing.T) {
registry := newKubeRegistry(apimachineryversion.Info{
Major: "1",
Minor: "15",
GitVersion: "v1.15.0-alpha-1.12345",
})
for i, m := range test.metrics {
if test.expectedPanics[i] {
assert.Panics(t,
func() { registry.MustRegister(m) },
"Did not panic even though we expected it.")
} else {
registry.MustRegister(m)
}
}
})
}
}
func TestShowHiddenMetric(t *testing.T) {
registry := newKubeRegistry(apimachineryversion.Info{
Major: "1",
Minor: "15",
GitVersion: "v1.15.0-alpha-1.12345",
})
expectedMetricCount := 0
registry.MustRegister(alphaHiddenCounter)
ms, err := registry.Gather()
require.NoError(t, err, "Gather failed %v", err)
assert.Lenf(t, ms, expectedMetricCount, "Got %v metrics, Want: %v metrics", len(ms), expectedMetricCount)
showHidden.Store(true)
defer showHidden.Store(false)
registry.MustRegister(NewCounter(
&CounterOpts{
Namespace: "some_namespace",
Name: "test_alpha_show_hidden_counter",
Subsystem: "subsystem",
StabilityLevel: ALPHA,
Help: "counter help",
DeprecatedVersion: "1.14.0",
},
))
expectedMetricCount = 1
ms, err = registry.Gather()
require.NoError(t, err, "Gather failed %v", err)
assert.Lenf(t, ms, expectedMetricCount, "Got %v metrics, Want: %v metrics", len(ms), expectedMetricCount)
}
func TestValidateShowHiddenMetricsVersion(t *testing.T) {
currentVersion := parseVersion(apimachineryversion.Info{
Major: "1",
Minor: "17",
GitVersion: "v1.17.1-alpha-1.12345",
})
var tests = []struct {
desc string
targetVersion string
expectedError bool
}{
{
desc: "invalid version is not allowed",
targetVersion: "1.invalid",
expectedError: true,
},
{
desc: "patch version is not allowed",
targetVersion: "1.16.0",
expectedError: true,
},
{
desc: "old version is not allowed",
targetVersion: "1.15",
expectedError: true,
},
{
desc: "new version is not allowed",
targetVersion: "1.17",
expectedError: true,
},
{
desc: "valid version is allowed",
targetVersion: "1.16",
expectedError: false,
},
}
for _, test := range tests {
tc := test
t.Run(tc.desc, func(t *testing.T) {
err := validateShowHiddenMetricsVersion(currentVersion, tc.targetVersion)
if tc.expectedError {
assert.Errorf(t, err, "Failed to test: %s", tc.desc)
} else {
assert.NoErrorf(t, err, "Failed to test: %s", tc.desc)
}
})
}
}
func TestEnableHiddenMetrics(t *testing.T) {
currentVersion := apimachineryversion.Info{
Major: "1",
Minor: "17",
GitVersion: "v1.17.1-alpha-1.12345",
}
var tests = []struct {
name string
fqName string
counter *Counter
mustRegister bool
expectedMetric string
}{
{
name: "hide by register",
fqName: "hidden_metric_register",
counter: NewCounter(&CounterOpts{
Name: "hidden_metric_register",
Help: "counter help",
StabilityLevel: STABLE,
DeprecatedVersion: "1.16.0",
}),
mustRegister: false,
expectedMetric: `
# HELP hidden_metric_register [STABLE] (Deprecated since 1.16.0) counter help
# TYPE hidden_metric_register counter
hidden_metric_register 1
`,
},
{
name: "hide by must register",
fqName: "hidden_metric_must_register",
counter: NewCounter(&CounterOpts{
Name: "hidden_metric_must_register",
Help: "counter help",
StabilityLevel: STABLE,
DeprecatedVersion: "1.16.0",
}),
mustRegister: true,
expectedMetric: `
# HELP hidden_metric_must_register [STABLE] (Deprecated since 1.16.0) counter help
# TYPE hidden_metric_must_register counter
hidden_metric_must_register 1
`,
},
}
for _, test := range tests {
tc := test
t.Run(tc.name, func(t *testing.T) {
registry := newKubeRegistry(currentVersion)
if tc.mustRegister {
registry.MustRegister(tc.counter)
} else {
_ = registry.Register(tc.counter)
}
tc.counter.Inc() // no-ops, because counter hasn't been initialized
if err := testutil.GatherAndCompare(registry, strings.NewReader(""), tc.fqName); err != nil {
t.Fatal(err)
}
SetShowHidden()
defer func() {
showHiddenOnce = *new(sync.Once)
showHidden.Store(false)
}()
tc.counter.Inc()
if err := testutil.GatherAndCompare(registry, strings.NewReader(tc.expectedMetric), tc.fqName); err != nil {
t.Fatal(err)
}
})
}
}
func TestEnableHiddenStableCollector(t *testing.T) {
var currentVersion = apimachineryversion.Info{
Major: "1",
Minor: "17",
GitVersion: "v1.17.0-alpha-1.12345",
}
var normal = NewDesc("test_enable_hidden_custom_metric_normal", "this is a normal metric", []string{"name"}, nil, STABLE, "")
var hiddenA = NewDesc("test_enable_hidden_custom_metric_hidden_a", "this is the hidden metric A", []string{"name"}, nil, STABLE, "1.16.0")
var hiddenB = NewDesc("test_enable_hidden_custom_metric_hidden_b", "this is the hidden metric B", []string{"name"}, nil, STABLE, "1.16.0")
var tests = []struct {
name string
descriptors []*Desc
metricNames []string
expectMetricsBeforeEnable string
expectMetricsAfterEnable string
}{
{
name: "all hidden",
descriptors: []*Desc{hiddenA, hiddenB},
metricNames: []string{"test_enable_hidden_custom_metric_hidden_a",
"test_enable_hidden_custom_metric_hidden_b"},
expectMetricsBeforeEnable: "",
expectMetricsAfterEnable: `
# HELP test_enable_hidden_custom_metric_hidden_a [STABLE] (Deprecated since 1.16.0) this is the hidden metric A
# TYPE test_enable_hidden_custom_metric_hidden_a gauge
test_enable_hidden_custom_metric_hidden_a{name="value"} 1
# HELP test_enable_hidden_custom_metric_hidden_b [STABLE] (Deprecated since 1.16.0) this is the hidden metric B
# TYPE test_enable_hidden_custom_metric_hidden_b gauge
test_enable_hidden_custom_metric_hidden_b{name="value"} 1
`,
},
{
name: "partial hidden",
descriptors: []*Desc{normal, hiddenA, hiddenB},
metricNames: []string{"test_enable_hidden_custom_metric_normal",
"test_enable_hidden_custom_metric_hidden_a",
"test_enable_hidden_custom_metric_hidden_b"},
expectMetricsBeforeEnable: `
# HELP test_enable_hidden_custom_metric_normal [STABLE] this is a normal metric
# TYPE test_enable_hidden_custom_metric_normal gauge
test_enable_hidden_custom_metric_normal{name="value"} 1
`,
expectMetricsAfterEnable: `
# HELP test_enable_hidden_custom_metric_normal [STABLE] this is a normal metric
# TYPE test_enable_hidden_custom_metric_normal gauge
test_enable_hidden_custom_metric_normal{name="value"} 1
# HELP test_enable_hidden_custom_metric_hidden_a [STABLE] (Deprecated since 1.16.0) this is the hidden metric A
# TYPE test_enable_hidden_custom_metric_hidden_a gauge
test_enable_hidden_custom_metric_hidden_a{name="value"} 1
# HELP test_enable_hidden_custom_metric_hidden_b [STABLE] (Deprecated since 1.16.0) this is the hidden metric B
# TYPE test_enable_hidden_custom_metric_hidden_b gauge
test_enable_hidden_custom_metric_hidden_b{name="value"} 1
`,
},
}
for _, test := range tests {
tc := test
t.Run(tc.name, func(t *testing.T) {
registry := newKubeRegistry(currentVersion)
customCollector := newTestCustomCollector(tc.descriptors...)
registry.CustomMustRegister(customCollector)
if err := testutil.GatherAndCompare(registry, strings.NewReader(tc.expectMetricsBeforeEnable), tc.metricNames...); err != nil {
t.Fatalf("before enable test failed: %v", err)
}
SetShowHidden()
defer func() {
showHiddenOnce = *new(sync.Once)
showHidden.Store(false)
}()
if err := testutil.GatherAndCompare(registry, strings.NewReader(tc.expectMetricsAfterEnable), tc.metricNames...); err != nil {
t.Fatalf("after enable test failed: %v", err)
}
// refresh descriptors so as to share with cases.
for _, d := range tc.descriptors {
d.ClearState()
}
})
}
}
func TestRegistryReset(t *testing.T) {
currentVersion := apimachineryversion.Info{
Major: "1",
Minor: "17",
GitVersion: "v1.17.1-alpha-1.12345",
}
registry := newKubeRegistry(currentVersion)
resettableMetric := NewCounterVec(&CounterOpts{
Name: "reset_metric",
Help: "this metric can be reset",
}, []string{"label"})
// gauges cannot be reset
nonResettableMetric := NewGauge(&GaugeOpts{
Name: "not_reset_metric",
Help: "this metric cannot be reset",
})
registry.MustRegister(resettableMetric)
registry.MustRegister(nonResettableMetric)
resettableMetric.WithLabelValues("one").Inc()
resettableMetric.WithLabelValues("two").Inc()
resettableMetric.WithLabelValues("two").Inc()
nonResettableMetric.Inc()
nonResettableOutput := `
# HELP not_reset_metric [ALPHA] this metric cannot be reset
# TYPE not_reset_metric gauge
not_reset_metric 1
`
resettableOutput := `
# HELP reset_metric [ALPHA] this metric can be reset
# TYPE reset_metric counter
reset_metric{label="one"} 1
reset_metric{label="two"} 2
`
if err := testutil.GatherAndCompare(registry, strings.NewReader(nonResettableOutput+resettableOutput), "reset_metric", "not_reset_metric"); err != nil {
t.Fatal(err)
}
registry.Reset()
if err := testutil.GatherAndCompare(registry, strings.NewReader(nonResettableOutput), "reset_metric", "not_reset_metric"); err != nil {
t.Fatal(err)
}
}
func TestDisabledMetrics(t *testing.T) {
o := NewOptions()
o.DisabledMetrics = []string{"should_be_disabled"}
o.Apply()
currentVersion := apimachineryversion.Info{
Major: "1",
Minor: "17",
GitVersion: "v1.17.1-alpha-1.12345",
}
registry := newKubeRegistry(currentVersion)
disabledMetric := NewCounterVec(&CounterOpts{
Name: "should_be_disabled",
Help: "this metric should be disabled",
}, []string{"label"})
// gauges cannot be reset
enabledMetric := NewGauge(&GaugeOpts{
Name: "should_be_enabled",
Help: "this metric should not be disabled",
})
registry.MustRegister(disabledMetric)
registry.MustRegister(enabledMetric)
disabledMetric.WithLabelValues("one").Inc()
disabledMetric.WithLabelValues("two").Inc()
disabledMetric.WithLabelValues("two").Inc()
enabledMetric.Inc()
enabledMetricOutput := `
# HELP should_be_enabled [ALPHA] this metric should not be disabled
# TYPE should_be_enabled gauge
should_be_enabled 1
`
if err := testutil.GatherAndCompare(registry, strings.NewReader(enabledMetricOutput), "should_be_disabled", "should_be_enabled"); err != nil {
t.Fatal(err)
}
}
|