1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966
|
package topology
import (
"context"
"errors"
"net"
"sync"
"sync/atomic"
"testing"
"time"
"github.com/stretchr/testify/assert"
"go.mongodb.org/mongo-driver/mongo/address"
"go.mongodb.org/mongo-driver/x/mongo/driver/operation"
)
func TestPool(t *testing.T) {
t.Run("newPool", func(t *testing.T) {
t.Parallel()
t.Run("should be connected", func(t *testing.T) {
t.Parallel()
p := newPool(poolConfig{})
err := p.connect()
noerr(t, err)
assert.Equalf(t, connected, p.connected, "expected new pool to be connected")
err = p.disconnect(context.Background())
noerr(t, err)
})
})
t.Run("closeConnection", func(t *testing.T) {
t.Parallel()
t.Run("can't close connection from different pool", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 1, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
p1 := newPool(poolConfig{
Address: address.Address(addr.String()),
})
err := p1.connect()
noerr(t, err)
c, err := p1.checkOut(context.Background())
noerr(t, err)
p2 := newPool(poolConfig{})
err = p2.connect()
noerr(t, err)
err = p2.closeConnection(c)
assert.Equalf(t, ErrWrongPool, err, "expected ErrWrongPool error")
err = p1.disconnect(context.Background())
noerr(t, err)
err = p2.disconnect(context.Background())
noerr(t, err)
})
})
t.Run("disconnect", func(t *testing.T) {
t.Parallel()
t.Run("cannot disconnect multiple times without connect", func(t *testing.T) {
t.Parallel()
p := newPool(poolConfig{})
err := p.connect()
noerr(t, err)
err = p.disconnect(context.Background())
noerr(t, err)
for i := 0; i < 5; i++ {
err = p.disconnect(context.Background())
assert.Equalf(
t,
ErrPoolDisconnected,
err,
"disconnecting an already disconnected pool should return ErrPoolDisconnected")
}
})
t.Run("closes idle connections", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 3, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
d := newdialer(&net.Dialer{})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
}, WithDialer(func(Dialer) Dialer { return d }))
err := p.connect()
noerr(t, err)
conns := make([]*connection, 3)
for i := range conns {
conns[i], err = p.checkOut(context.Background())
noerr(t, err)
}
for i := range conns {
err = p.checkIn(conns[i])
noerr(t, err)
}
assert.Equalf(t, 3, d.lenopened(), "should have opened 3 connections")
assert.Equalf(t, 0, d.lenclosed(), "should have closed 0 connections")
assert.Equalf(t, 3, p.availableConnectionCount(), "should have 3 available connections")
assert.Equalf(t, 3, p.totalConnectionCount(), "should have 3 total connections")
err = p.disconnect(context.Background())
noerr(t, err)
assertConnectionsClosed(t, d, 3)
assert.Equalf(t, 0, p.availableConnectionCount(), "should have 0 available connections")
assert.Equalf(t, 0, p.availableConnectionCount(), "should have 0 total connections")
})
t.Run("closes all open connections", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 3, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
d := newdialer(&net.Dialer{})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
}, WithDialer(func(Dialer) Dialer { return d }))
err := p.connect()
noerr(t, err)
conns := make([]*connection, 3)
for i := range conns {
conns[i], err = p.checkOut(context.Background())
noerr(t, err)
}
for i := 0; i < 2; i++ {
err = p.checkIn(conns[i])
noerr(t, err)
}
assert.Equalf(t, 3, d.lenopened(), "should have opened 3 connections")
assert.Equalf(t, 0, d.lenclosed(), "should have closed 0 connections")
assert.Equalf(t, 2, p.availableConnectionCount(), "should have 2 available connections")
assert.Equalf(t, 3, p.totalConnectionCount(), "should have 3 total connections")
err = p.disconnect(context.Background())
noerr(t, err)
assertConnectionsClosed(t, d, 3)
assert.Equalf(t, 0, p.availableConnectionCount(), "should have 0 available connections")
assert.Equalf(t, 0, p.totalConnectionCount(), "should have 0 total connections")
})
t.Run("no race if connections are also connecting", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 3, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
})
err := p.connect()
noerr(t, err)
_, err = p.checkOut(context.Background())
noerr(t, err)
disconnected := make(chan struct{})
started := make(chan struct{})
go func() {
close(started)
for {
select {
case <-disconnected:
return
default:
c, _ := p.checkOut(context.Background())
_ = p.checkIn(c)
time.Sleep(time.Millisecond)
}
}
}()
// Wait for the background goroutine to start running before trying to disconnect the
// connection pool.
<-started
_, err = p.checkOut(context.Background())
noerr(t, err)
err = p.disconnect(context.Background())
noerr(t, err)
close(disconnected)
})
t.Run("shuts down gracefully if Context has a deadline", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 3, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
})
err := p.connect()
noerr(t, err)
// Check out 2 connections from the pool and add them to a conns slice.
conns := make([]*connection, 2)
for i := 0; i < 2; i++ {
c, err := p.checkOut(context.Background())
noerr(t, err)
conns[i] = c
}
// Check out a 3rd connection from the pool and immediately check it back in so there is
// a mixture of in-use and idle connections.
c, err := p.checkOut(context.Background())
noerr(t, err)
err = p.checkIn(c)
noerr(t, err)
// Start a goroutine that waits for the pool to start disconnecting, then checks in the
// 2 in-use connections. Assert that both connections are still connected during
// graceful shutdown before they are checked in.
go func() {
for atomic.LoadInt64(&p.connected) == connected {
time.Sleep(time.Millisecond)
}
for _, c := range conns {
assert.Equalf(t, connected, c.connected, "expected conn to still be connected")
err := p.checkIn(c)
noerr(t, err)
}
}()
// Disconnect the pool with a 1-hour graceful shutdown timeout. Expect that the call to
// disconnect() returns when all of the connections are checked in. If disconnect()
// doesn't return when all of the connections are checked in, the test will time out.
ctx, cancel := context.WithTimeout(context.Background(), 1*time.Hour)
defer cancel()
err = p.disconnect(ctx)
noerr(t, err)
})
t.Run("closing a Connection does not cause an error after pool is disconnected", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 3, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
})
err := p.connect()
noerr(t, err)
c, err := p.checkOut(context.Background())
noerr(t, err)
err = p.disconnect(context.Background())
noerr(t, err)
c1 := &Connection{connection: c}
err = c1.Close()
noerr(t, err)
})
})
t.Run("connect", func(t *testing.T) {
t.Parallel()
t.Run("can reconnect a disconnected pool", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 6, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
})
err := p.connect()
noerr(t, err)
for i := 0; i < 3; i++ {
_, err := p.checkOut(context.Background())
noerr(t, err)
}
assert.Equalf(t, 0, p.availableConnectionCount(), "should have 0 available connections")
assert.Equalf(t, 3, p.totalConnectionCount(), "should have 3 total connections")
err = p.disconnect(context.Background())
noerr(t, err)
assert.Equalf(t, 0, p.availableConnectionCount(), "should have 0 available connections")
assert.Equalf(t, 0, p.totalConnectionCount(), "should have 0 total connections")
err = p.connect()
noerr(t, err)
for i := 0; i < 3; i++ {
_, err := p.checkOut(context.Background())
noerr(t, err)
}
assert.Equalf(t, 0, p.availableConnectionCount(), "should have 0 available connections")
assert.Equalf(t, 3, p.totalConnectionCount(), "should have 3 total connections")
err = p.disconnect(context.Background())
noerr(t, err)
})
t.Run("cannot connect multiple times without disconnect", func(t *testing.T) {
t.Parallel()
p := newPool(poolConfig{})
err := p.connect()
noerr(t, err)
for i := 0; i < 5; i++ {
err := p.connect()
assert.Equalf(
t,
ErrPoolConnected,
err,
"connecting an already connected pool should return ErrPoolConnected")
}
err = p.disconnect(context.Background())
noerr(t, err)
})
t.Run("can disconnect and reconnect multiple times", func(t *testing.T) {
t.Parallel()
p := newPool(poolConfig{})
for i := 0; i < 100; i++ {
err := p.connect()
noerr(t, err)
err = p.disconnect(context.Background())
noerr(t, err)
}
})
})
t.Run("checkOut", func(t *testing.T) {
t.Parallel()
t.Run("return error when attempting to create new connection", func(t *testing.T) {
t.Parallel()
dialErr := errors.New("create new connection error")
p := newPool(poolConfig{}, WithDialer(func(Dialer) Dialer {
return DialerFunc(func(context.Context, string, string) (net.Conn, error) {
return nil, dialErr
})
}))
err := p.connect()
noerr(t, err)
_, err = p.checkOut(context.Background())
var want error = ConnectionError{Wrapped: dialErr, init: true}
assert.Equalf(t, want, err, "should return error from calling checkOut()")
assert.Equalf(t, 0, p.totalConnectionCount(), "pool should have 0 total connections")
err = p.disconnect(context.Background())
noerr(t, err)
})
t.Run("closes perished connections", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 2, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
d := newdialer(&net.Dialer{})
p := newPool(
poolConfig{
Address: address.Address(addr.String()),
MaxIdleTime: time.Millisecond,
},
WithDialer(func(Dialer) Dialer { return d }),
)
err := p.connect()
noerr(t, err)
// Check out a connection and assert that the idle timeout is properly set then check it
// back into the pool.
c1, err := p.checkOut(context.Background())
noerr(t, err)
assert.Equalf(t, 1, d.lenopened(), "should have opened 1 connection")
assert.Equalf(t, 1, p.totalConnectionCount(), "pool should have 1 total connection")
assert.Equalf(t, time.Millisecond, c1.idleTimeout, "connection should have a 1ms idle timeout")
err = p.checkIn(c1)
noerr(t, err)
// Sleep for more than the 1ms idle timeout and then try to check out a connection.
// Expect that the previously checked-out connection is closed because it's idle and a
// new connection is created.
time.Sleep(50 * time.Millisecond)
c2, err := p.checkOut(context.Background())
noerr(t, err)
assert.NotEqualf(t, c1, c2, "expected a new connection on 2nd check out after idle timeout expires")
assert.Equalf(t, 2, d.lenopened(), "should have opened 2 connections")
assert.Equalf(t, 1, p.totalConnectionCount(), "pool should have 1 total connection")
err = p.disconnect(context.Background())
noerr(t, err)
})
t.Run("recycles connections", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 1, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
d := newdialer(&net.Dialer{})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
}, WithDialer(func(Dialer) Dialer { return d }))
err := p.connect()
noerr(t, err)
for i := 0; i < 100; i++ {
c, err := p.checkOut(context.Background())
noerr(t, err)
err = p.checkIn(c)
noerr(t, err)
}
assert.Equalf(t, 1, d.lenopened(), "should have opened 1 connection")
})
t.Run("cannot checkOut from disconnected pool", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 3, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
})
err := p.connect()
noerr(t, err)
err = p.disconnect(context.Background())
noerr(t, err)
_, err = p.checkOut(context.Background())
assert.Equalf(
t,
ErrPoolDisconnected,
err,
"expected an error from checkOut() from a disconnected pool")
})
t.Run("handshaker i/o fails", func(t *testing.T) {
t.Parallel()
p := newPool(
poolConfig{},
WithHandshaker(func(Handshaker) Handshaker {
return operation.NewHello()
}),
WithDialer(func(Dialer) Dialer {
return DialerFunc(func(context.Context, string, string) (net.Conn, error) {
return &writeFailConn{&net.TCPConn{}}, nil
})
}),
)
err := p.connect()
noerr(t, err)
_, err = p.checkOut(context.Background())
assert.IsTypef(t, ConnectionError{}, err, "expected a ConnectionError")
if err, ok := err.(ConnectionError); ok {
assert.Containsf(
t,
err.Unwrap().Error(),
"unable to write wire message to network: Write error",
"expected error to contain string")
}
assert.Equalf(t, 0, p.totalConnectionCount(), "pool should have 0 total connections")
err = p.disconnect(context.Background())
noerr(t, err)
})
// Test that if a checkOut() times out, it returns a WaitQueueTimeout error that wraps a
// context.DeadlineExceeded error.
t.Run("wait queue timeout error", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 1, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
MaxPoolSize: 1,
})
err := p.connect()
noerr(t, err)
// check out first connection.
_, err = p.checkOut(context.Background())
noerr(t, err)
// Set a short timeout and check out again.
ctx, cancel := context.WithTimeout(context.Background(), 100*time.Millisecond)
defer cancel()
_, err = p.checkOut(ctx)
assert.NotNilf(t, err, "expected a WaitQueueTimeout error")
// Assert that error received is WaitQueueTimeoutError with context deadline exceeded.
assert.IsTypef(t, WaitQueueTimeoutError{}, err, "expected a WaitQueueTimeoutError")
if err, ok := err.(WaitQueueTimeoutError); ok {
assert.Equalf(t, context.DeadlineExceeded, err.Unwrap(), "expected wrapped error to be a context.Timeout")
}
err = p.disconnect(context.Background())
noerr(t, err)
})
// Test that an indefinitely blocked checkOut() doesn't cause the wait queue to overflow
// if there are many other checkOut() calls that time out. This tests a scenario where a
// wantConnQueue may grow unbounded while a checkOut() is blocked, even if all subsequent
// checkOut() calls time out (due to the behavior of wantConnQueue.cleanFront()).
t.Run("wait queue doesn't overflow", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 1, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
MaxPoolSize: 1,
})
err := p.connect()
noerr(t, err)
// Check out the 1 connection that the pool will create.
c, err := p.checkOut(context.Background())
noerr(t, err)
// Start a goroutine that tries to check out another connection with no timeout. Expect
// this goroutine to block (wait in the wait queue) until the checked-out connection is
// checked-in. Assert that there is no error once checkOut() finally does return.
var wg sync.WaitGroup
wg.Add(1)
go func() {
defer wg.Done()
_, err := p.checkOut(context.Background())
noerr(t, err)
}()
// Run lots of check-out attempts with a low timeout and assert that each one fails with
// a WaitQueueTimeout error. Expect no other errors or panics.
for i := 0; i < 50000; i++ {
ctx, cancel := context.WithTimeout(context.Background(), 1*time.Microsecond)
_, err := p.checkOut(ctx)
cancel()
assert.NotNilf(t, err, "expected a WaitQueueTimeout error")
assert.IsTypef(t, WaitQueueTimeoutError{}, err, "expected a WaitQueueTimeoutError")
}
// Check-in the connection we checked out earlier and wait for the checkOut() goroutine
// to resume.
err = p.checkIn(c)
noerr(t, err)
wg.Wait()
})
// Test that checkOut() on a full connection pool creates and returns a new connection
// immediately as soon as the pool is no longer full.
t.Run("should return a new connection as soon as the pool isn't full", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 3, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
d := newdialer(&net.Dialer{})
p := newPool(
poolConfig{
Address: address.Address(addr.String()),
MaxPoolSize: 2,
},
WithDialer(func(Dialer) Dialer { return d }),
)
err := p.connect()
noerr(t, err)
// Check out two connections (MaxPoolSize) so that subsequent checkOut() calls should
// block until a connection is checked back in or removed from the pool.
c, err := p.checkOut(context.Background())
noerr(t, err)
_, err = p.checkOut(context.Background())
noerr(t, err)
assert.Equalf(t, 2, d.lenopened(), "should have opened 2 connection")
assert.Equalf(t, 2, p.totalConnectionCount(), "pool should have 2 total connection")
assert.Equalf(t, 0, p.availableConnectionCount(), "pool should have 0 idle connection")
// Run a checkOut() with timeout and expect it to time out because the pool is at
// MaxPoolSize and no connections are checked in or removed from the pool.
ctx, cancel := context.WithTimeout(context.Background(), 1*time.Millisecond)
defer cancel()
_, err = p.checkOut(ctx)
assert.Equalf(
t,
context.DeadlineExceeded,
err.(WaitQueueTimeoutError).Wrapped,
"expected wrapped error to be a context.DeadlineExceeded")
// Start a goroutine that closes one of the checked-out conections and checks it in.
// Expect that the checked-in connection is closed and allows blocked checkOut() to
// complete. Assert that the time between checking in the closed connection and when the
// checkOut() completes is within 50ms.
var start time.Time
go func() {
c.close()
start = time.Now()
err := p.checkIn(c)
noerr(t, err)
}()
_, err = p.checkOut(context.Background())
noerr(t, err)
assert.WithinDurationf(
t,
time.Now(),
start,
50*time.Millisecond,
"expected checkOut to complete within 50ms of checking in a closed connection")
assert.Equalf(t, 1, d.lenclosed(), "should have closed 1 connection")
assert.Equalf(t, 3, d.lenopened(), "should have opened 3 connection")
assert.Equalf(t, 2, p.totalConnectionCount(), "pool should have 2 total connection")
assert.Equalf(t, 0, p.availableConnectionCount(), "pool should have 0 idle connection")
err = p.disconnect(context.Background())
noerr(t, err)
})
})
t.Run("checkIn", func(t *testing.T) {
t.Parallel()
t.Run("cannot return same connection to pool twice", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 1, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
})
err := p.connect()
noerr(t, err)
c, err := p.checkOut(context.Background())
noerr(t, err)
assert.Equalf(t, 0, p.availableConnectionCount(), "should be no idle connections in pool")
assert.Equalf(t, 1, p.totalConnectionCount(), "should be 1 total connection in pool")
err = p.checkIn(c)
noerr(t, err)
err = p.checkIn(c)
assert.NotNilf(t, err, "expected an error trying to return the same conn to the pool twice")
assert.Equalf(t, 1, p.availableConnectionCount(), "should have returned 1 idle connection to the pool")
assert.Equalf(t, 1, p.totalConnectionCount(), "should have 1 total connection in pool")
err = p.disconnect(context.Background())
noerr(t, err)
})
t.Run("closes connections if the pool is closed", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 1, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
d := newdialer(&net.Dialer{})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
}, WithDialer(func(Dialer) Dialer { return d }))
err := p.connect()
noerr(t, err)
c, err := p.checkOut(context.Background())
noerr(t, err)
assert.Equalf(t, 0, d.lenclosed(), "should have closed 0 connections")
assert.Equalf(t, 0, p.availableConnectionCount(), "should have 0 idle connections in pool")
assert.Equalf(t, 1, p.totalConnectionCount(), "should have 1 total connection in pool")
err = p.disconnect(context.Background())
noerr(t, err)
err = p.checkIn(c)
noerr(t, err)
assert.Equalf(t, 1, d.lenclosed(), "should have closed 1 connection")
assert.Equalf(t, 0, p.availableConnectionCount(), "should have 0 idle connections in pool")
assert.Equalf(t, 0, p.totalConnectionCount(), "should have 0 total connection in pool")
})
t.Run("can't checkIn a connection from different pool", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 1, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
p1 := newPool(poolConfig{
Address: address.Address(addr.String()),
})
err := p1.connect()
noerr(t, err)
c, err := p1.checkOut(context.Background())
noerr(t, err)
p2 := newPool(poolConfig{})
err = p2.connect()
noerr(t, err)
err = p2.checkIn(c)
assert.Equalf(t, ErrWrongPool, err, "expected ErrWrongPool error")
err = p1.disconnect(context.Background())
noerr(t, err)
err = p2.disconnect(context.Background())
noerr(t, err)
})
})
t.Run("maintain", func(t *testing.T) {
t.Parallel()
t.Run("creates MinPoolSize connections shortly after calling connect()", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 3, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
d := newdialer(&net.Dialer{})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
MinPoolSize: 3,
}, WithDialer(func(Dialer) Dialer { return d }))
err := p.connect()
noerr(t, err)
assertConnectionsOpened(t, d, 3)
assert.Equalf(t, 3, p.availableConnectionCount(), "should be 3 idle connections in pool")
assert.Equalf(t, 3, p.totalConnectionCount(), "should be 3 total connection in pool")
err = p.disconnect(context.Background())
noerr(t, err)
})
t.Run("when MinPoolSize > MaxPoolSize should not exceed MaxPoolSize connections", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 20, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
d := newdialer(&net.Dialer{})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
MinPoolSize: 20,
MaxPoolSize: 2,
}, WithDialer(func(Dialer) Dialer { return d }))
err := p.connect()
noerr(t, err)
assertConnectionsOpened(t, d, 2)
assert.Equalf(t, 2, p.availableConnectionCount(), "should be 2 idle connections in pool")
assert.Equalf(t, 2, p.totalConnectionCount(), "should be 2 total connection in pool")
err = p.disconnect(context.Background())
noerr(t, err)
})
t.Run("removes perished connections", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 5, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
d := newdialer(&net.Dialer{})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
}, WithDialer(func(Dialer) Dialer { return d }))
// Set the pool's maintain interval to 10ms so that it allows the test to run quickly.
p.maintainInterval = 10 * time.Millisecond
err := p.connect()
noerr(t, err)
// Check out and check in 3 connections. Assert that there are 3 total and 3 idle
// connections in the pool.
conns := make([]*connection, 3)
for i := range conns {
conns[i], err = p.checkOut(context.Background())
noerr(t, err)
}
for _, c := range conns {
err = p.checkIn(c)
noerr(t, err)
}
assert.Equalf(t, 3, d.lenopened(), "should have opened 3 connections")
assert.Equalf(t, 3, p.availableConnectionCount(), "should be 3 idle connections in pool")
assert.Equalf(t, 3, p.totalConnectionCount(), "should be 3 total connection in pool")
// Manually make two of the connections in the idle connections stack perished due to
// passing the connection's idle deadline. Assert that maintain() closes the two
// perished connections and removes them from the pool.
p.idleMu.Lock()
for i := 0; i < 2; i++ {
p.idleConns[i].idleTimeout = time.Millisecond
p.idleConns[i].idleDeadline.Store(time.Now().Add(-1 * time.Hour))
}
p.idleMu.Unlock()
assertConnectionsClosed(t, d, 2)
assert.Equalf(t, 1, p.availableConnectionCount(), "should be 1 idle connections in pool")
assert.Equalf(t, 1, p.totalConnectionCount(), "should be 1 total connection in pool")
err = p.disconnect(context.Background())
noerr(t, err)
})
t.Run("removes perished connections and replaces them to maintain MinPoolSize", func(t *testing.T) {
t.Parallel()
cleanup := make(chan struct{})
defer close(cleanup)
addr := bootstrapConnections(t, 5, func(nc net.Conn) {
<-cleanup
_ = nc.Close()
})
d := newdialer(&net.Dialer{})
p := newPool(poolConfig{
Address: address.Address(addr.String()),
MinPoolSize: 3,
}, WithDialer(func(Dialer) Dialer { return d }))
// Set the pool's maintain interval to 10ms so that it allows the test to run quickly.
p.maintainInterval = 10 * time.Millisecond
err := p.connect()
noerr(t, err)
assertConnectionsOpened(t, d, 3)
assert.Equalf(t, 3, p.availableConnectionCount(), "should be 3 idle connections in pool")
assert.Equalf(t, 3, p.totalConnectionCount(), "should be 3 total connection in pool")
p.idleMu.Lock()
for i := 0; i < 2; i++ {
p.idleConns[i].idleTimeout = time.Millisecond
p.idleConns[i].idleDeadline.Store(time.Now().Add(-1 * time.Hour))
}
p.idleMu.Unlock()
assertConnectionsClosed(t, d, 2)
assertConnectionsOpened(t, d, 5)
assert.Equalf(t, 3, p.availableConnectionCount(), "should be 3 idle connections in pool")
assert.Equalf(t, 3, p.totalConnectionCount(), "should be 3 total connection in pool")
err = p.disconnect(context.Background())
noerr(t, err)
})
})
}
func assertConnectionsClosed(t *testing.T, dialer *dialer, count int) {
t.Helper()
start := time.Now()
for {
if dialer.lenclosed() == count {
return
}
if time.Since(start) > 3*time.Second {
t.Errorf(
"Waited for 3 seconds for %d connections to be closed, but got %d",
count,
dialer.lenclosed())
return
}
time.Sleep(100 * time.Millisecond)
}
}
func assertConnectionsOpened(t *testing.T, dialer *dialer, count int) {
t.Helper()
start := time.Now()
for {
if dialer.lenopened() == count {
return
}
if time.Since(start) > 3*time.Second {
t.Errorf(
"Waited for 3 seconds for %d connections to be opened, but got %d",
count,
dialer.lenopened())
return
}
time.Sleep(100 * time.Millisecond)
}
}
|